projects / git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: d64bb06) | patch
builtin_diff(): read $GIT_DIFF_OPTS closer to use
authorJeff King <peff@peff.net>
Fri, 11 Jan 2019 22:17:22 +0000 (17:17 -0500)
committerJunio C Hamano <gitster@pobox.com>
Sat, 12 Jan 2019 02:48:59 +0000 (18:48 -0800)
commit0da0e9268b4825cafb27bb0e07b43fae30bb33da
treee4b9660b93279f25f2d70351e940f0b5a80bb995tree | snapshot
parentd64bb065c0279e523db5270bbcf0ddda74fa9c8fcommit | diff
builtin_diff(): read $GIT_DIFF_OPTS closer to use

The value returned by getenv() is not guaranteed to remain valid across
other environment function calls. But in between our call and using the
value, we run fill_textconv(), which may do quite a bit of work,
including spawning sub-processes.

We can make this safer by calling getenv() right before we actually look
at its value.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
diff.c diff | blob | blame | history
Unnamed repository; edit this file 'description' to name the repository.