fsck: don't put a void*-shaped peg in a char*-shaped hole
authorMichael Haggerty <mhagger@alum.mit.edu>
Sat, 25 May 2013 09:08:11 +0000 (11:08 +0200)
committerJunio C Hamano <gitster@pobox.com>
Tue, 28 May 2013 16:25:01 +0000 (09:25 -0700)
commit16aa3bfc9b9dc587d02f29d8e54810480cf955e4
tree2d78148a37b435ee6a6b5795d70777e6498d708c
parent1506510c170d23b8f769757dc81904f334c40281
fsck: don't put a void*-shaped peg in a char*-shaped hole

The source of this nonsense was

    04d3975937 fsck: reduce stack footprint

, which wedged a pointer to parent into the object_array_entry's name
field.  The parent pointer was passed to traverse_one_object(), even
though that function *didn't use it*.

The useless code has been deleted over time.  Commit

    a1cdc25172 fsck: drop unused parameter from traverse_one_object()

removed the parent pointer from traverse_one_object()'s
signature. Commit

    c0aa335c95 Remove unused variables

removed the code that read the parent pointer back out of the name
field.

This commit takes the last step: don't write the parent pointer into
the name field in the first place.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/fsck.c