pkt-line: do not issue flush packets in write_packetized_*()
authorJohannes Schindelin <johannes.schindelin@gmx.de>
Mon, 15 Mar 2021 21:08:19 +0000 (21:08 +0000)
committerJunio C Hamano <gitster@pobox.com>
Mon, 15 Mar 2021 21:32:50 +0000 (14:32 -0700)
commit3a63c6a48c0588a237b3133fe785d6e734dedbb5
tree34a9c24d2755dcad66d779f4b792e8f021203c6b
parent7455e05e4e750451eb3c33359a2bc9050156750c
pkt-line: do not issue flush packets in write_packetized_*()

Remove the `packet_flush_gently()` call in `write_packetized_from_buf() and
`write_packetized_from_fd()` and require the caller to call it if desired.
Rename both functions to `write_packetized_from_*_no_flush()` to prevent
later merge accidents.

`write_packetized_from_buf()` currently only has one caller:
`apply_multi_file_filter()` in `convert.c`.  It always wants a flush packet
to be written after writing the payload.

However, we are about to introduce a caller that wants to write many
packets before a final flush packet, so let's make the caller responsible
for emitting the flush packet.

Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
convert.c
pkt-line.c
pkt-line.h