vcs-svn: simplify cleanup in apply_one_window
authorDavid Barr <davidbarr@google.com>
Thu, 31 May 2012 14:41:26 +0000 (00:41 +1000)
committerJonathan Nieder <jrnieder@gmail.com>
Fri, 6 Jul 2012 04:26:52 +0000 (23:26 -0500)
commit4a1613194af218afb99be0e14af449e86852d06e
tree62d97f9ad6046361f81eeb99ca8ad072367858e9
parent4a5de8dd79879d737e172a5d7e4196c6bf99e57d
vcs-svn: simplify cleanup in apply_one_window

Currently the cleanup code looks like this:

free resources
return 0;
 error_out:
free resources
return -1;

Avoid duplicating the "free resources" part by keeping the return
value in a variable and sharing code between the success and
exceptional case:

ret = 0;
 out:
free resources
return ret;

Noticed in the svn-dump-fast-export project, where using the error()
macro in void context produces a warning.

Signed-off-by: David Barr <davidbarr@google.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
vcs-svn/svndiff.c