builtin/commit.c: switch to strbuf, instead of snprintf()
authorElia Pinto <gitter.spiros@gmail.com>
Tue, 31 Jan 2017 13:45:35 +0000 (13:45 +0000)
committerJunio C Hamano <gitster@pobox.com>
Tue, 31 Jan 2017 18:09:00 +0000 (10:09 -0800)
commit4a5281917b2b84affa9942c991419115088aec0e
tree201277e7d106ba5e8283fb81715f46924f72d997
parent8d7aa4ba6a00b3ff69261e88b4842c0df5662125
builtin/commit.c: switch to strbuf, instead of snprintf()

Switch to dynamic allocation with strbuf, so we can avoid dealing
with magic numbers in the code and reduce the cognitive burden from
the programmers.  The original code is correct, but programmers no
longer have to count bytes needed for static allocation to know that.

As a side effect of this change, we also reduce the snprintf()
calls, that may silently truncate results if the programmer is not
careful.

Helped-by: René Scharfe <l.s.r@web.de>
Helped-by: Junio C Hamano <gitster@pobox.com>
Helped-by: Jeff King <peff@peff.net>
Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/commit.c