t9819: don't use test_must_fail with p4
authorDenton Liu <liu.denton@gmail.com>
Mon, 20 Apr 2020 08:54:45 +0000 (04:54 -0400)
committerJunio C Hamano <gitster@pobox.com>
Mon, 20 Apr 2020 20:30:55 +0000 (13:30 -0700)
commit546f352638fd4fd7e517e8c6e74e229825e9afab
tree8cac81a81595ffb052de04801a1b347a0d2ad9fc
parentbf1218106835fb06f8862c6727dd4453e9ea5fd9
t9819: don't use test_must_fail with p4

We were using `test_must_fail p4` to test that the p4 command failed as
expected. However, test_must_fail() is used to ensure that commands fail
in an expected way, not due to something like a segv. Since we are not
in the business of verifying the sanity of the external world, replace
`test_must_fail p4` with `! p4` and assume that the `p4` command does
not die unexpectedly.

Signed-off-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/t9819-git-p4-case-folding.sh