ls-remote: do not send ref prefixes for patterns
authorJeff King <peff@peff.net>
Wed, 31 Oct 2018 04:24:05 +0000 (00:24 -0400)
committerJunio C Hamano <gitster@pobox.com>
Wed, 31 Oct 2018 04:40:09 +0000 (13:40 +0900)
commit631f0f8c4b3cf86df13534be40b8df56c2fc6dda
tree99d1dd012fb27759960586475fa3013ff6023f5c
parent268fbcd172cdb306e8a3e7143cc16677c963d6cd
ls-remote: do not send ref prefixes for patterns

Since b4be74105f (ls-remote: pass ref prefixes when requesting a
remote's refs, 2018-03-15), "ls-remote foo" will pass "refs/heads/foo",
"refs/tags/foo", etc to the transport code in an attempt to let the
other side reduce the size of its advertisement.

Unfortunately this is not correct, as ls-remote patterns do not follow
the usual ref lookup rules, and are in fact tail-matched. So we could
find "refs/heads/foo" or "refs/heads/a/much/deeper/foo" or even
"refs/another/hierarchy/foo".

Since we can't pass a prefix and there's not yet a v2 extension for
matching wildcards, we must disable this feature to keep the same
behavior as v1.

Reported-by: Jon Simons <jon@jonsimons.org>
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/ls-remote.c
t/t5512-ls-remote.sh