branch: restrict @-expansions when deleting
authorJeff King <peff@peff.net>
Thu, 2 Mar 2017 08:23:10 +0000 (03:23 -0500)
committerJunio C Hamano <gitster@pobox.com>
Thu, 2 Mar 2017 19:05:04 +0000 (11:05 -0800)
commit6b145e016aaf512d0026cbd2c78fa28476f043b4
tree2035c956b7db744d0bf874458c1c39b9d5d7c4ad
parenta356e8e2a724012c8120bfa69133b6118b1565f4
branch: restrict @-expansions when deleting

We use strbuf_branchname() to expand the branch name from
the command line, so you can delete the branch given by
@{-1}, for example.  However, we allow other nonsense like
"@", and we do not respect our "-r" flag (so we may end up
deleting an oddly-named local ref instead of a remote one).

We can fix this by passing the appropriate "allowed" flag to
strbuf_branchname().

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/branch.c
t/t3204-branch-name-interpretation.sh