t2028: fix minor error and issues in newly-added "worktree move" tests
authorEric Sunshine <sunshine@sunshineco.com>
Sun, 4 Mar 2018 05:26:47 +0000 (00:26 -0500)
committerJunio C Hamano <gitster@pobox.com>
Tue, 6 Mar 2018 22:35:42 +0000 (14:35 -0800)
commit7f19def0fc254829839495f7fb44a7d99b161d3d
tree16af5374bf916960456ab7b3c2a84448f6c3e567
parentee6763af0a3b97225803c6c908a29de40336cf38
t2028: fix minor error and issues in newly-added "worktree move" tests

Recently-added "git worktree move" tests include a minor error and a few
small issues. Specifically:

 * checking non-existence of wrong file ("source" instead of
   "destination")

 * unneeded redirect (">empty")

 * unused variable ("toplevel")

 * restoring a worktree location by means of a separate test somewhat
   distant from the test which moved it rather than using
   test_when_finished() to restore it in a self-contained fashion

 * having git command on the left-hand-side of a pipe ("git foo | grep")

Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
Acked-by: Duy Nguyen <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/t2028-worktree-move.sh