bisect--helper: finish porting `bisect_start()` to C
authorPranit Bauva <pranit.bauva@gmail.com>
Thu, 15 Oct 2020 13:38:32 +0000 (15:38 +0200)
committerJunio C Hamano <gitster@pobox.com>
Fri, 16 Oct 2020 19:24:20 +0000 (12:24 -0700)
commit88ad372fc02c119a4e44ae71c93b6fab9d998512
tree88e3046d14266c748b80d505ae2473909c129c63
parent517ecb3161daa4503f7638489fd44177b3659913
bisect--helper: finish porting `bisect_start()` to C

Add the subcommand to `git bisect--helper` and call it from
git-bisect.sh.

With the conversion of `bisect_auto_next()` from shell to C in a
previous commit, `bisect_start()` can now be fully ported to C.

So let's complete the `--bisect-start` subcommand of
`git bisect--helper` so that it fully implements `bisect_start()`,
and let's use this subcommand in `git-bisect.sh` instead of
`bisect_start()`.

Note that the `eval` in the changed line of `git-bisect.sh` cannot be
dropped: it is necessary because the `rev` and the `tail`
variables may contain multiple, quoted arguments that need to be
passed to `bisect--helper` (without the quotes, naturally).

Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Mentored-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Pranit Bauva <pranit.bauva@gmail.com>
Signed-off-by: Tanushree Tumane <tanushreetumane@gmail.com>
Signed-off-by: Miriam Rubio <mirucam@gmail.com>
Reviewed-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/bisect--helper.c
git-bisect.sh