t3301: modernize style
authorJohan Herland <johan@herland.net>
Wed, 12 Nov 2014 00:40:16 +0000 (01:40 +0100)
committerJunio C Hamano <gitster@pobox.com>
Fri, 14 Nov 2014 21:33:09 +0000 (13:33 -0800)
commit908a3203632a02568df230c0fccf9a2cd8da24e6
treed67a27c86a1ebe5eaaca30441bd4e6bd96ae3fa1
parent8a4acd699536c518c9245714d6175aa39d13eb9d
t3301: modernize style

Make this test script appear somewhat less old-fashioned:

 - Use test helper functions:
    - write_script
    - test_commit
    - test_write_lines
    - test_line_count
    - test_config
    - test_unconfig
    - test_path_is_missing

 - Remove whitespace between redirection operators and their targets.

 - Move preparation of "expect" files into tests.

 - Rename "output" files to "actual".

 - More consistent quoting, especially around commands that might
   expand to nothing.

 - More visibility of important whitespace with ${indent}.

 - Combine pairs of tests that unnecessarily split setup and verification.

Improved-by: Eric Sunshine <sunshine@sunshineco.com>
Improved-by: Junio C Hamano <gitster@pobox.com>
Improved-by: Michael Blume <blume.mike@gmail.com>
Improved-by: Jeff King <peff@peff.net>
Signed-off-by: Johan Herland <johan@herland.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/t3301-notes.sh