avoid shifting signed integers 31 bits
authorJeff King <peff@peff.net>
Tue, 29 Dec 2015 06:35:46 +0000 (01:35 -0500)
committerJunio C Hamano <gitster@pobox.com>
Mon, 4 Jan 2016 17:51:16 +0000 (09:51 -0800)
commit9a93c6686f56086fe5280a85513041bbfebf41d0
tree7e8ceeeb6f3e52f99e94e968145f5cf46d508080
parent1ff88560c8d22bcdb528a6629239d638f927cb96
avoid shifting signed integers 31 bits

We sometimes use 32-bit unsigned integers as bit-fields.
It's fine to access the MSB, because it's unsigned. However,
doing so as "1 << 31" is wrong, because the constant "1" is
a signed int, and we shift into the sign bit, causing
undefined behavior.

We can fix this by using "1U" as the constant.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/receive-pack.c
cache.h
diff.h