graph: reduce duplication in `graph_insert_into_new_columns()`
authorJames Coglan <jcoglan@gmail.com>
Tue, 15 Oct 2019 23:47:50 +0000 (23:47 +0000)
committerJunio C Hamano <gitster@pobox.com>
Wed, 16 Oct 2019 02:11:24 +0000 (11:11 +0900)
commita551fd5efd7b82604c3254e3f7cac08eaaa97ba9
tree526b1ade30d3cc7929bfc66e03c45176ec15c5e3
parent9157a2a032c4c5a154782537b6f1e2f8b7bd7435
graph: reduce duplication in `graph_insert_into_new_columns()`

I will shortly be making some changes to this function and so am trying
to simplify it. It currently contains some duplicated logic; both
branches the function can take assign the commit's column index into
the `mapping` array and increment `mapping_index`.

Here I change the function so that the only conditional behaviour is
that it appends the commit to `new_columns` if it's not present. All
manipulation of `mapping` now happens on a single code path.

Signed-off-by: James Coglan <jcoglan@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
graph.c