rebase: warn if state directory cannot be removed
authorPhillip Wood <phillip.wood@dunelm.org.uk>
Tue, 14 May 2019 18:03:47 +0000 (19:03 +0100)
committerJunio C Hamano <gitster@pobox.com>
Wed, 15 May 2019 01:59:33 +0000 (10:59 +0900)
commitd3fce47d2df868287de1a15d769e78db2c3283a9
treeaaa42dfe8aa82760372b010b91a8f0336174c74d
parent7372eaeb8b47ba96bad08777cd1330561ada8592
rebase: warn if state directory cannot be removed

If rebase --quit cannot remove the state directory then it dies. However
when rebase finishes normally or the user runs rebase --abort any errors
that occur when removing the state directory are ignored. That is fixed
by this commit.

All of the callers of finish_rebase() except the code
that handles --abort are careful to make sure they get a postive return
value, do the same for --abort.

Signed-off-by: Phillip Wood <phillip.wood@dunelm.org.uk>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/rebase.c