verify_signed_buffer: prefer close_tempfile() to close()
authorJeff King <peff@peff.net>
Tue, 5 Sep 2017 12:14:23 +0000 (08:14 -0400)
committerJunio C Hamano <gitster@pobox.com>
Wed, 6 Sep 2017 08:19:52 +0000 (17:19 +0900)
commitd88ef6605120fd75be38376ba147623cf427bf73
tree921faad50f4f5757c10f8d0b6e6ff4359f659b94
parentc0e963b77c6892d40d4ca81a71098aaa6c4eaed3
verify_signed_buffer: prefer close_tempfile() to close()

We do a manual close() on the descriptor provided to us by
mks_tempfile. But this runs contrary to the advice in
tempfile.h, which notes that you should always use
close_tempfile(). Otherwise the descriptor may be reused
without the tempfile object knowing it, and the later call
to delete_tempfile() could close a random descriptor.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
gpg-interface.c