parallel-checkout: avoid dash local bug in tests
authorRené Scharfe <l.s.r@web.de>
Sun, 6 Jun 2021 01:01:57 +0000 (03:01 +0200)
committerJunio C Hamano <gitster@pobox.com>
Sun, 6 Jun 2021 01:40:26 +0000 (10:40 +0900)
commitebee5580ca7e4dba06405713de14507909615966
tree6ab8278bbc876ac71f23e1e66151bbdcab1b108e
parent87094fc2daa9613c2fad454dbb068a8f23ce8de8
parallel-checkout: avoid dash local bug in tests

Dash bug https://bugs.launchpad.net/ubuntu/+source/dash/+bug/139097
lets the shell erroneously perform field splitting on the expansion of a
command substitution during declaration of a local variable.  It causes
the parallel-checkout tests to fail e.g. when running them with
/bin/dash on MacOS 11.4, where they error out like this:

   ./t2080-parallel-checkout-basics.sh: 33: local: 0: bad variable name

That's because the output of wc -l contains leading spaces and the
returned number of lines is treated as another variable to declare, i.e.
as in "local workers= 0".

Work around it by enclosing the command substitution in quotes.

Helped-by: Matheus Tavares Bernardino <matheus.bernardino@usp.br>
Helped-by: SZEDER Gábor <szeder.dev@gmail.com>
Helped-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: René Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/lib-parallel-checkout.sh