start_command: close cmd->err descriptor when fork/spawn fails
authorbert Dvornik <dvornik+git@gmail.com>
Thu, 20 May 2010 18:57:52 +0000 (20:57 +0200)
committerJunio C Hamano <gitster@pobox.com>
Thu, 20 May 2010 23:11:29 +0000 (16:11 -0700)
commitfc012c2810c237dd2299a3fc85b18c2beb60b730
tree41bc04928e0a2ab24f2c28b8f8c2da153de0820e
parent60890cc60ccfc7000791a47f1f3d69fdb8884dd7
start_command: close cmd->err descriptor when fork/spawn fails

Fix the problem where the cmd->err passed into start_command wasn't
being properly closed when certain types of errors occurr.  (Compare
the affected code with the clean shutdown code later in the function.)

On Windows, this problem would be triggered if mingw_spawnvpe()
failed, which would happen if the command to be executed was malformed
(e.g. a text file that didn't start with a #! line).  If cmd->err was
a pipe, the failure to close it could result in a hang while the other
side was waiting (forever) for either input or pipe close, e.g. while
trying to shove the output into the side band.  On msysGit, this
problem was causing a hang in t5516-fetch-push.

[J6t: With a slight adjustment of the test case, the hang is also
observed on Linux.]

Signed-off-by: bert Dvornik <dvornik+git@gmail.com>
Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
run-command.c
t/t5516-fetch-push.sh