git
11 years agoremote-bzr: add support for remote repositories
Felipe Contreras [Sun, 11 Nov 2012 14:19:54 +0000 (15:19 +0100)] 
remote-bzr: add support for remote repositories

Strictly speaking bzr doesn't need any changes to interact with remote
repositories, but it's dead slow.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agoremote-bzr: add support for pushing
Felipe Contreras [Sun, 11 Nov 2012 14:19:53 +0000 (15:19 +0100)] 
remote-bzr: add support for pushing

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agoAdd new remote-bzr transport helper
Felipe Contreras [Sun, 11 Nov 2012 14:19:52 +0000 (15:19 +0100)] 
Add new remote-bzr transport helper

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
12 years agoMerge branch 'tj/maint-doc-commit-sign'
Jeff King [Sun, 4 Nov 2012 13:00:47 +0000 (08:00 -0500)] 
Merge branch 'tj/maint-doc-commit-sign'

* tj/maint-doc-commit-sign:
  Add -S, --gpg-sign option to manpage of "git commit"

12 years agoMerge branch 'pp/maint-doc-pager-config'
Jeff King [Sun, 4 Nov 2012 13:00:37 +0000 (08:00 -0500)] 
Merge branch 'pp/maint-doc-pager-config'

* pp/maint-doc-pager-config:
  Documentation: improve the example of overriding LESS via core.pager

12 years agoMerge branch 'km/maint-doc-git-reset'
Jeff King [Sun, 4 Nov 2012 13:00:33 +0000 (08:00 -0500)] 
Merge branch 'km/maint-doc-git-reset'

* km/maint-doc-git-reset:
  doc: git-reset: make "<mode>" optional

12 years agoMerge branch 'tb/maint-t9200-case-insensitive'
Jeff King [Sun, 4 Nov 2012 13:00:29 +0000 (08:00 -0500)] 
Merge branch 'tb/maint-t9200-case-insensitive'

* tb/maint-t9200-case-insensitive:
  Fix t9200 on case insensitive file systems

12 years agoMerge branch 'rf/maint-mailmap-off-by-one'
Jeff King [Sun, 4 Nov 2012 13:00:23 +0000 (08:00 -0500)] 
Merge branch 'rf/maint-mailmap-off-by-one'

* rf/maint-mailmap-off-by-one:
  mailmap: avoid out-of-bounds memory access

12 years agoMerge branch 'gb/maint-doc-svn-log-window-size'
Jeff King [Sun, 4 Nov 2012 13:00:21 +0000 (08:00 -0500)] 
Merge branch 'gb/maint-doc-svn-log-window-size'

* gb/maint-doc-svn-log-window-size:
  Document git-svn fetch --log-window-size parameter

12 years agoMerge branch 'sz/maint-submodule-reference-arg'
Jeff King [Sun, 4 Nov 2012 13:00:16 +0000 (08:00 -0500)] 
Merge branch 'sz/maint-submodule-reference-arg'

* sz/maint-submodule-reference-arg:
  submodule add: fix handling of --reference=<repo> option

12 years agoMerge branch 'sl/maint-configure-messages'
Jeff King [Sun, 4 Nov 2012 13:00:13 +0000 (08:00 -0500)] 
Merge branch 'sl/maint-configure-messages'

Minor message fixes for the configure script.

* sl/maint-configure-messages:
  configure: fix some output message

12 years agoMerge branch 'po/maint-refs-replace-docs'
Jeff King [Sun, 4 Nov 2012 13:00:11 +0000 (08:00 -0500)] 
Merge branch 'po/maint-refs-replace-docs'

The refs/replace hierarchy was not mentioned in the
repository-layout docs.

* po/maint-refs-replace-docs:
  Doc repository-layout: Show refs/replace

12 years agoMerge branch 'ph/pull-rebase-detached'
Jeff King [Sun, 4 Nov 2012 13:00:06 +0000 (08:00 -0500)] 
Merge branch 'ph/pull-rebase-detached'

Avoids spewing error messages when using "pull --rebase" on a
detached HEAD.

* ph/pull-rebase-detached:
  git-pull: Avoid merge-base on detached head

12 years agoMerge branch 'mm/maint-doc-remote-tracking'
Jeff King [Sun, 4 Nov 2012 12:59:57 +0000 (07:59 -0500)] 
Merge branch 'mm/maint-doc-remote-tracking'

We long ago hyphenated "remote-tracking branch"; this
catches some new instances added since then.

* mm/maint-doc-remote-tracking:
  Documentation: remote tracking branch -> remote-tracking branch

12 years agoAdd -S, --gpg-sign option to manpage of "git commit"
Tom Jones [Sun, 21 Oct 2012 19:46:37 +0000 (20:46 +0100)] 
Add -S, --gpg-sign option to manpage of "git commit"

git commit -S, --gpg-sign was mentioned in the program's help message,
but not in the manpage.

This adds an equivalent entry for the option in the manpage.

Signed-off-by: Tom Jones <tom@oxix.org>
Signed-off-by: Jeff King <peff@peff.net>
12 years agoMerge branch 'rs/branch-del-symref'
Jeff King [Mon, 29 Oct 2012 08:15:04 +0000 (04:15 -0400)] 
Merge branch 'rs/branch-del-symref'

A symbolic ref refs/heads/SYM was not correctly removed with
"git branch -d SYM"; the command removed the ref pointed by
SYM instead.

* rs/branch-del-symref:
  branch: show targets of deleted symrefs, not sha1s
  branch: skip commit checks when deleting symref branches
  branch: delete symref branch, not its target
  branch: factor out delete_branch_config()
  branch: factor out check_branch_commit()

12 years agoMerge branch 'nd/status-long'
Jeff King [Mon, 29 Oct 2012 08:14:57 +0000 (04:14 -0400)] 
Merge branch 'nd/status-long'

Allow an earlier "--short" option on the command line to be
countermanded with the "--long" option for "git status" and "git
commit".

* nd/status-long:
  status: add --long output format option

12 years agoMerge branch 'jk/sh-setup-in-filter-branch'
Jeff King [Mon, 29 Oct 2012 08:13:49 +0000 (04:13 -0400)] 
Merge branch 'jk/sh-setup-in-filter-branch'

Refactoring to avoid code duplication in shell scripts.

* jk/sh-setup-in-filter-branch:
  filter-branch: use git-sh-setup's ident parsing functions
  git-sh-setup: refactor ident-parsing functions

12 years agoMerge branch 'nd/grep-true-path'
Jeff King [Mon, 29 Oct 2012 08:13:16 +0000 (04:13 -0400)] 
Merge branch 'nd/grep-true-path'

"git grep -e pattern <tree>" asked the attribute system to read
"<tree>:.gitattributes" file in the working tree, which was
nonsense.

* nd/grep-true-path:
  grep: stop looking at random places for .gitattributes

12 years agoMerge branch 'jk/maint-http-init-not-in-result-handler'
Jeff King [Mon, 29 Oct 2012 08:13:09 +0000 (04:13 -0400)] 
Merge branch 'jk/maint-http-init-not-in-result-handler'

Further clean-up to the http codepath that picks up results after
cURL library is done with one request slot.

* jk/maint-http-init-not-in-result-handler:
  http: do not set up curl auth after a 401
  remote-curl: do not call run_slot repeatedly

12 years agoMerge branch 'jc/grep-pcre-loose-ends'
Jeff King [Mon, 29 Oct 2012 08:12:15 +0000 (04:12 -0400)] 
Merge branch 'jc/grep-pcre-loose-ends'

"git log -F -E --grep='<ere>'" failed to use the given <ere>
pattern as extended regular expression, and instead looked for the
string literally.  The early part of this series is a fix for it;
the latter part teaches log to respect the grep.* configuration.

* jc/grep-pcre-loose-ends:
  log: honor grep.* configuration
  log --grep: accept --basic-regexp and --perl-regexp
  log --grep: use the same helper to set -E/-F options as "git grep"
  revisions: initialize revs->grep_filter using grep_init()
  grep: move pattern-type bits support to top-level grep.[ch]
  grep: move the configuration parsing logic to grep.[ch]
  builtin/grep.c: make configuration callback more reusable

12 years agoMerge branch 'jl/submodule-add-by-name'
Jeff King [Mon, 29 Oct 2012 08:12:12 +0000 (04:12 -0400)] 
Merge branch 'jl/submodule-add-by-name'

If you remove a submodule, in order to keep the repository so that
"git checkout" to an older commit in the superproject history can
resurrect the submodule, the real repository will stay in $GIT_DIR
of the superproject.  A later "git submodule add $path" to add a
different submodule at the same path will fail.  Diagnose this case
a bit better, and if the user really wants to add an unrelated
submodule at the same path, give the "--name" option to give it a
place in $GIT_DIR of the superproject that does not conflict with
the original submodule.

* jl/submodule-add-by-name:
  submodule add: Fail when .git/modules/<name> already exists unless forced
  Teach "git submodule add" the --name option

12 years agoMerge branch 'jl/submodule-rm'
Jeff King [Mon, 29 Oct 2012 08:12:07 +0000 (04:12 -0400)] 
Merge branch 'jl/submodule-rm'

"git rm submodule" cannot blindly remove a submodule directory as
its working tree may have local changes, and worse yet, it may even
have its repository embedded in it.  Teach it some special cases
where it is safe to remove a submodule, specifically, when there is
no local changes in the submodule working tree, and its repository
is not embedded in its working tree but is elsewhere and uses the
gitfile mechanism to point at it.

* jl/submodule-rm:
  submodule: teach rm to remove submodules unless they contain a git directory

12 years agoDocumentation: improve the example of overriding LESS via core.pager
Patrick Palka [Sun, 28 Oct 2012 20:12:46 +0000 (16:12 -0400)] 
Documentation: improve the example of overriding LESS via core.pager

You can override an option set in the LESS variable by simply prefixing
the command line option with `-+`. This is more robust than the previous
example if the default LESS options are to ever change.

Signed-off-by: Patrick Palka <patrick@parcs.ath.cx>
Signed-off-by: Jeff King <peff@peff.net>
12 years agodoc: git-reset: make "<mode>" optional
Krzysztof Mazur [Sun, 28 Oct 2012 14:13:27 +0000 (15:13 +0100)] 
doc: git-reset: make "<mode>" optional

The git-reset's "<mode>" is an optional argument, however it was
documented as required.

The "<mode>" is documented as one of: --soft, --mixed, --hard, --merge
or --keep, so "<mode>" should be used instead of "--<mode>".

Signed-off-by: Krzysztof Mazur <krzysiek@podlesie.net>
Signed-off-by: Jeff King <peff@peff.net>
12 years agoFix t9200 on case insensitive file systems
Torsten Bögershausen [Fri, 26 Oct 2012 16:18:24 +0000 (18:18 +0200)] 
Fix t9200 on case insensitive file systems

t9200 defines $CVSROOT where cvs should init its repository
$CVSROOT is set to $PWD/cvsroot.
cvs init is supposed to create the repository inside $PWD/cvsroot/CVSROOT

"cvs init" (e.g. version  1.11.23) checks if the last element of the path is
"CVSROOT", and if a directory with e.g. $PWD/cvsroot/CVSROOT already exists.

For such a $CVSROOT cvs refuses to init a repository here:
"Cannot initialize repository under existing CVSROOT:

On a case insenstive file system cvsroot and CVSROOT are the same directories
and t9200 fails.

Solution: use $PWD/tmpcvsroot instead of cvsroot $PWD/cvsroot

Signed-off-by: Torsten Bögershausen <tboegi@web.de>
Signed-off-by: Jeff King <peff@peff.net>
12 years agomailmap: avoid out-of-bounds memory access
Romain Francoise [Sat, 27 Oct 2012 22:49:55 +0000 (00:49 +0200)] 
mailmap: avoid out-of-bounds memory access

AddressSanitizer (http://clang.llvm.org/docs/AddressSanitizer.html)
complains of a one-byte buffer underflow in parse_name_and_email() while
running the test suite. And indeed, if one of the lines in the mailmap
begins with '<', we dereference the address just before the beginning of
the buffer when looking for whitespace to remove, before checking that
we aren't going too far.

So reverse the order of the tests to make sure that we don't read
outside the buffer.

Signed-off-by: Romain Francoise <romain@orebokech.com>
Signed-off-by: Jeff King <peff@peff.net>
12 years agosubmodule add: fix handling of --reference=<repo> option
Stefan Zager [Thu, 25 Oct 2012 04:52:52 +0000 (21:52 -0700)] 
submodule add: fix handling of --reference=<repo> option

Doing a shift here is wrong because there is no extra
argument to consume when "--reference=<repo>" is used (note
the '=' instead of a space).

Signed-off-by: Stefan Zager <szager@google.com>
Signed-off-by: Jeff King <peff@peff.net>
12 years agoDocument git-svn fetch --log-window-size parameter
Gunnlaugur Þór Briem [Tue, 23 Oct 2012 10:33:26 +0000 (10:33 +0000)] 
Document git-svn fetch --log-window-size parameter

The --log-window-size parameter to git-svn fetch is undocumented.

Minimally describe what it does and why the user might change it.

Signed-off-by: Gunnlaugur Þór Briem <gunnlaugur@gmail.com>
Signed-off-by: Jeff King <peff@peff.net>
12 years agoconfigure: fix some output message
Stefano Lattarini [Wed, 24 Oct 2012 15:34:27 +0000 (17:34 +0200)] 
configure: fix some output message

Before this change, output from ./configure could contain
botched wording like this:

    checking Checking for POSIX Threads with '-pthread'... yes

instead of the intended:

    checking for POSIX Threads with '-pthread'... yes

Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
Signed-off-by: Jeff King <peff@peff.net>
12 years agoDoc repository-layout: Show refs/replace
Philip Oakley [Sun, 21 Oct 2012 20:52:37 +0000 (21:52 +0100)] 
Doc repository-layout: Show refs/replace

Signed-off-by: Philip Oakley <philipoakley@iee.org>
Signed-off-by: Jeff King <peff@peff.net>
12 years agoDocumentation: remote tracking branch -> remote-tracking branch
Matthieu Moy [Tue, 23 Oct 2012 11:34:05 +0000 (13:34 +0200)] 
Documentation: remote tracking branch -> remote-tracking branch

This change was already done by 0e615b252f3 (Matthieu Moy, Tue Nov 2
2010, Replace "remote tracking" with "remote-tracking"), but new
instances of remote tracking (without dash) were introduced in the
meantime.

Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
Signed-off-by: Jeff King <peff@peff.net>
12 years agoMerge branch 'jk/strbuf-detach-always-non-null'
Jeff King [Thu, 25 Oct 2012 10:43:03 +0000 (06:43 -0400)] 
Merge branch 'jk/strbuf-detach-always-non-null'

* jk/strbuf-detach-always-non-null:
  strbuf: always return a non-NULL value from strbuf_detach

12 years agoMerge branch 'js/mingw-fflush-errno'
Jeff King [Thu, 25 Oct 2012 10:43:01 +0000 (06:43 -0400)] 
Merge branch 'js/mingw-fflush-errno'

* js/mingw-fflush-errno:
  maybe_flush_or_die: move a too-loose Windows specific error

12 years agoMerge branch 'da/mergetools-p4'
Jeff King [Thu, 25 Oct 2012 10:42:57 +0000 (06:42 -0400)] 
Merge branch 'da/mergetools-p4'

* da/mergetools-p4:
  mergetools/p4merge: Handle "/dev/null"

12 years agoMerge branch 'jc/test-say-color-avoid-echo-escape'
Jeff King [Thu, 25 Oct 2012 10:42:49 +0000 (06:42 -0400)] 
Merge branch 'jc/test-say-color-avoid-echo-escape'

Recent nd/wildmatch series was the first to reveal this ancient bug
in the test scaffolding.

* jc/test-say-color-avoid-echo-escape:
  test-lib: Fix say_color () not to interpret \a\b\c in the message

12 years agoMerge branch 'nd/attr-match-optim'
Jeff King [Thu, 25 Oct 2012 10:42:36 +0000 (06:42 -0400)] 
Merge branch 'nd/attr-match-optim'

Trivial and obvious optimization for finding attributes that match
a given path.

* nd/attr-match-optim:
  attr: avoid searching for basename on every match
  attr: avoid strlen() on every match

12 years agoMerge branch 'jk/peel-ref'
Jeff King [Thu, 25 Oct 2012 10:42:27 +0000 (06:42 -0400)] 
Merge branch 'jk/peel-ref'

Speeds up "git upload-pack" (what is invoked by "git fetch" on the
other side of the connection) by reducing the cost to advertise the
branches and tags that are available in the repository.

* jk/peel-ref:
  upload-pack: use peel_ref for ref advertisements
  peel_ref: check object type before loading
  peel_ref: do not return a null sha1
  peel_ref: use faster deref_tag_noverify

12 years agoMerge branch 'bw/config-lift-variable-name-length-limit'
Jeff King [Thu, 25 Oct 2012 10:42:11 +0000 (06:42 -0400)] 
Merge branch 'bw/config-lift-variable-name-length-limit'

The configuration parser had an unnecessary hardcoded limit on
variable names that was not checked consistently. Lift the limit.

* bw/config-lift-variable-name-length-limit:
  Remove the hard coded length limit on variable names in config files

12 years agoMerge branch 'fa/remote-svn'
Jeff King [Thu, 25 Oct 2012 10:42:01 +0000 (06:42 -0400)] 
Merge branch 'fa/remote-svn'

A GSoC project.

* fa/remote-svn:
  Add a test script for remote-svn
  remote-svn: add marks-file regeneration
  Add a svnrdump-simulator replaying a dump file for testing
  remote-svn: add incremental import
  remote-svn: Activate import/export-marks for fast-import
  Create a note for every imported commit containing svn metadata
  vcs-svn: add fast_export_note to create notes
  Allow reading svn dumps from files via file:// urls
  remote-svn, vcs-svn: Enable fetching to private refs
  When debug==1, start fast-import with "--stats" instead of "--quiet"
  Add documentation for the 'bidi-import' capability of remote-helpers
  Connect fast-import to the remote-helper via pipe, adding 'bidi-import' capability
  Add argv_array_detach and argv_array_free_detached
  Add svndump_init_fd to allow reading dumps from arbitrary FDs
  Add git-remote-testsvn to Makefile
  Implement a remote helper for svn in C

12 years agoMerge branch 'jm/diff-context-config'
Jeff King [Thu, 25 Oct 2012 10:41:57 +0000 (06:41 -0400)] 
Merge branch 'jm/diff-context-config'

Teaches a new configuration variable to "git diff" Porcelain and
its friends.

* jm/diff-context-config:
  t4055: avoid use of sed 'a' command
  diff: diff.context configuration gives default to -U

12 years agoMerge branch 'jk/no-more-pre-exec-callback'
Jeff King [Thu, 25 Oct 2012 10:41:15 +0000 (06:41 -0400)] 
Merge branch 'jk/no-more-pre-exec-callback'

Removes a workaround for buggy version of less older than version
406.

* jk/no-more-pre-exec-callback:
  pager: drop "wait for output to run less" hack

12 years agogit-pull: Avoid merge-base on detached head
Phil Hord [Tue, 23 Oct 2012 20:39:56 +0000 (16:39 -0400)] 
git-pull: Avoid merge-base on detached head

git pull --rebase does some clever tricks to find the base
for $upstream, but it forgets that we may not have any
branch at all.  When this happens, git merge-base reports its
"usage" help in the middle of an otherwise successful
rebase operation, because git-merge is called with one too
few parameters.

Since we do not need the merge-base trick in the case of a
detached HEAD, detect this condition and bypass the clever
trick and the usage noise.

Signed-off-by: Phil Hord <hordp@cisco.com>
Signed-off-by: Jeff King <peff@peff.net>
12 years agoGit 1.8.0 v1.8.0
Junio C Hamano [Sun, 21 Oct 2012 20:56:23 +0000 (13:56 -0700)] 
Git 1.8.0

Signed-off-by: Junio C Hamano <gitster@pobox.com>
12 years agofilter-branch: use git-sh-setup's ident parsing functions
Jeff King [Thu, 18 Oct 2012 10:33:02 +0000 (06:33 -0400)] 
filter-branch: use git-sh-setup's ident parsing functions

This saves us some code, but it also reduces the number of
processes we start for each filtered commit. Since we can
parse both author and committer in the same sed invocation,
we save one process. And since the new interface avoids tr,
we save 4 processes.

It also avoids using "tr", which has had some odd
portability problems reported with from Solaris's xpg6
version.

We also tweak one of the tests in t7003 to double-check that
we are properly exporting the variables (because test-lib.sh
exports GIT_AUTHOR_NAME, it will be automatically exported
in subprograms. We override this to make sure that
filter-branch handles it properly itself).

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
12 years agogit-sh-setup: refactor ident-parsing functions
Jeff King [Thu, 18 Oct 2012 07:25:22 +0000 (03:25 -0400)] 
git-sh-setup: refactor ident-parsing functions

The only ident-parsing function we currently provide is
get_author_ident_from_commit. This is not very
flexible for two reasons:

  1. It takes a commit as an argument, and can't read from
     commit headers saved on disk.

  2. It will only parse authors, not committers.

This patch provides a more flexible interface which will
parse multiple idents from a commit provide on stdin. We can
easily use it as a building block for the current function
to retain compatibility.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
12 years agostatus: add --long output format option
Jeff King [Thu, 18 Oct 2012 14:15:50 +0000 (21:15 +0700)] 
status: add --long output format option

You can currently set the output format to --short or
--porcelain. There is no --long, because we default to it
already. However, you may want to override an alias that
uses "--short" to get back to the default.

This requires a little bit of refactoring, because currently
we use STATUS_FORMAT_LONG internally to mean the same as
"the user did not specify anything". By expanding the enum
to include STATUS_FORMAT_NONE, we can distinguish between
the implicit and explicit cases. This effects these
conditions:

  1. The user has asked for NUL termination. With NONE, we
     currently default to turning on the porcelain mode.
     With an explicit --long, we would in theory use NUL
     termination with the long mode, but it does not support
     it. So we can just complain and die.

  2. When an output format is given to "git commit", we
     default to "--dry-run". This behavior would now kick in
     when "--long" is given, too.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
12 years agobranch: show targets of deleted symrefs, not sha1s
René Scharfe [Thu, 18 Oct 2012 12:08:03 +0000 (14:08 +0200)] 
branch: show targets of deleted symrefs, not sha1s

git branch reports the abbreviated hash of the head commit of
a deleted branch to make it easier for a user to undo the
operation.  For symref branches this doesn't help.  Print the
symref target instead for them.

Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
12 years agobranch: skip commit checks when deleting symref branches
René Scharfe [Thu, 18 Oct 2012 12:07:11 +0000 (14:07 +0200)] 
branch: skip commit checks when deleting symref branches

Before a branch is deleted, we check that it points to a valid
commit.  With -d we also check that the commit is a merged; this
check is not done with -D.

The reason for that is that commits pointed to by branches should
never go missing; if they do then something broke and it's better
to stop instead of adding to the mess.  And a non-merged commit
may contain changes that are worth preserving, so we require the
stronger option -D instead of -d to get rid of them.

If a branch consists of a symref, these concerns don't apply.
Deleting such a branch can't make a commit become unreferenced,
so we don't need to check if it is merged, or even if it is
actually a valid commit.  Skip them in that case.  This allows
us to delete dangling symref branches.

Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
12 years agobranch: delete symref branch, not its target
René Scharfe [Thu, 18 Oct 2012 12:05:17 +0000 (14:05 +0200)] 
branch: delete symref branch, not its target

If a branch that is to be deleted happens to be a symref to another
branch, the current code removes the targeted branch instead of the
one it was called for.

Change this surprising behaviour and delete the symref branch
instead.

Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
12 years agobranch: factor out delete_branch_config()
René Scharfe [Thu, 18 Oct 2012 12:04:08 +0000 (14:04 +0200)] 
branch: factor out delete_branch_config()

Provide a small helper function for deleting branch config sections.

Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
12 years agobranch: factor out check_branch_commit()
René Scharfe [Thu, 18 Oct 2012 12:02:51 +0000 (14:02 +0200)] 
branch: factor out check_branch_commit()

Move the code to perform checks on the tip commit of a branch
to its own function.

Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
12 years agostrbuf: always return a non-NULL value from strbuf_detach
Jeff King [Thu, 18 Oct 2012 10:00:12 +0000 (06:00 -0400)] 
strbuf: always return a non-NULL value from strbuf_detach

The current behavior is to return NULL when strbuf did not
actually allocate a string. This can be quite surprising to
callers, though, who may feed the strbuf from arbitrary data
and expect to always get a valid value.

In most cases, it does not make a difference because calling
any strbuf function will cause an allocation (even if the
function ends up not inserting any data). But if the code is
structured like:

  struct strbuf buf = STRBUF_INIT;
  if (some_condition)
  strbuf_addstr(&buf, some_string);
  return strbuf_detach(&buf, NULL);

then you may or may not return NULL, depending on the
condition. This can cause us to segfault in http-push
(when fed an empty URL) and in http-backend (when an empty
parameter like "foo=bar&&" is in the $QUERY_STRING).

This patch forces strbuf_detach to allocate an empty
NUL-terminated string when it is called on a strbuf that has
not been allocated.

I investigated all call-sites of strbuf_detach. The majority
are either not affected by the change (because they call a
strbuf_* function unconditionally), or can handle the empty
string just as easily as NULL.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
12 years agoMerge tag 'gitgui-0.17.0' of git://repo.or.cz/git-gui
Junio C Hamano [Wed, 17 Oct 2012 22:55:46 +0000 (15:55 -0700)] 
Merge tag 'gitgui-0.17.0' of git://repo.or.cz/git-gui

git-gui 0.17.0

* tag 'gitgui-0.17.0' of git://repo.or.cz/git-gui:
  git-gui 0.17
  git-gui: Don't prepend the prefix if value looks like a full path
  git-gui: Detect full path when parsing arguments
  git-gui: remove .git/CHERRY_PICK_HEAD after committing
  git-gui: Fix a loose/lose mistake
  git-gui: Fix semi-working shortcuts for unstage and revert
  git-gui: de.po: translate "remote" as "extern"
  git-gui: de.po: translate "bare" as "bloß"
  git-gui: de.po: consistently add untranslated hook names within braces
  git-gui: preserve commit messages in utf-8
  git-gui: open console when using --trace on windows
  git-gui: fix a typo in po/ files
  git-gui: Use PWD if it exists on Mac OS X
  git-gui: fix git-gui crash due to uninitialized variable

12 years agogit-gui 0.17 gitgui-0.17.0
Pat Thoyts [Wed, 17 Oct 2012 20:57:29 +0000 (21:57 +0100)] 
git-gui 0.17

Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
12 years agogit-gui: Don't prepend the prefix if value looks like a full path
Andrew Wong [Tue, 2 Oct 2012 16:25:15 +0000 (12:25 -0400)] 
git-gui: Don't prepend the prefix if value looks like a full path

When argument parsing fails to detect a file name, "git-gui" will try to
use the previously detected "head" as the file name. We should avoid
prepending the prefix if "head" looks like a full path.

Signed-off-by: Andrew Wong <andrew.kw.w@gmail.com>
Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
12 years agogit-gui: Detect full path when parsing arguments
Andrew Wong [Tue, 2 Oct 2012 16:25:14 +0000 (12:25 -0400)] 
git-gui: Detect full path when parsing arguments

When running "git-gui blame" from a subfolder (which means prefix is
non-empty), if we pass a full path as argument, the argument parsing
will fail to recognize the argument as a file name, because prefix is
prepended to the argument.

This patch handles that scenario by adding an additional branch that
checks the file name without using the prefix.

Signed-off-by: Andrew Wong <andrew.kw.w@gmail.com>
Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
12 years agoGit 1.8.0-rc3 v1.8.0-rc3
Junio C Hamano [Wed, 17 Oct 2012 17:39:44 +0000 (10:39 -0700)] 
Git 1.8.0-rc3

Signed-off-by: Junio C Hamano <gitster@pobox.com>
12 years agoMerge git://github.com/git-l10n/git-po
Junio C Hamano [Wed, 17 Oct 2012 17:37:40 +0000 (10:37 -0700)] 
Merge git://github.com/git-l10n/git-po

* git://github.com/git-l10n/git-po:
  l10n: vi.po: update from v1.8.0-rc2-4-g42e55
  l10n: Update Swedish translation (1964t0f0u)

12 years agoSync with 1.7.12.4
Junio C Hamano [Wed, 17 Oct 2012 17:37:32 +0000 (10:37 -0700)] 
Sync with 1.7.12.4

12 years agoGit 1.7.12.4 v1.7.12.4
Junio C Hamano [Wed, 17 Oct 2012 17:36:01 +0000 (10:36 -0700)] 
Git 1.7.12.4

Signed-off-by: Junio C Hamano <gitster@pobox.com>
12 years agoMerge branch 'jk/maint-http-half-auth-push' into maint
Junio C Hamano [Wed, 17 Oct 2012 17:29:24 +0000 (10:29 -0700)] 
Merge branch 'jk/maint-http-half-auth-push' into maint

* jk/maint-http-half-auth-push:
  http: fix segfault in handle_curl_result

12 years agoMerge branch 'rr/git-uri-doc' into maint
Junio C Hamano [Wed, 17 Oct 2012 17:28:56 +0000 (10:28 -0700)] 
Merge branch 'rr/git-uri-doc' into maint

* rr/git-uri-doc:
  Git url doc: mark ftp/ftps as read-only and deprecate them

12 years agoMerge branch 'bw/cp-a-is-gnuism' into maint
Junio C Hamano [Wed, 17 Oct 2012 17:28:48 +0000 (10:28 -0700)] 
Merge branch 'bw/cp-a-is-gnuism' into maint

* bw/cp-a-is-gnuism:
  tests: "cp -a" is a GNUism

12 years agoMerge branch 'nd/doc-ignore' into maint
Junio C Hamano [Wed, 17 Oct 2012 17:28:42 +0000 (10:28 -0700)] 
Merge branch 'nd/doc-ignore' into maint

* nd/doc-ignore:
  gitignore.txt: suggestions how to get literal # or ! at the beginning

12 years agoMerge branch 'jc/doc-long-options' into maint
Junio C Hamano [Wed, 17 Oct 2012 17:28:34 +0000 (10:28 -0700)] 
Merge branch 'jc/doc-long-options' into maint

* jc/doc-long-options:
  gitcli: parse-options lets you omit tail of long options

12 years agoMerge branch 'jc/maint-t1450-fsck-order-fix' into maint
Junio C Hamano [Wed, 17 Oct 2012 17:28:19 +0000 (10:28 -0700)] 
Merge branch 'jc/maint-t1450-fsck-order-fix' into maint

* jc/maint-t1450-fsck-order-fix:
  t1450: the order the objects are checked is undefined

12 years agoMerge branch 'rr/test-use-shell-path-not-shell' into maint
Junio C Hamano [Wed, 17 Oct 2012 17:27:28 +0000 (10:27 -0700)] 
Merge branch 'rr/test-use-shell-path-not-shell' into maint

* rr/test-use-shell-path-not-shell:
  test-lib: use $SHELL_PATH, not $SHELL

12 years agoMerge branch 'rr/test-make-sure-we-have-git' into maint
Junio C Hamano [Wed, 17 Oct 2012 17:27:21 +0000 (10:27 -0700)] 
Merge branch 'rr/test-make-sure-we-have-git' into maint

* rr/test-make-sure-we-have-git:
  t/test-lib: make sure Git has already been built

12 years agoMerge branch 'po/maint-docs' into maint
Junio C Hamano [Wed, 17 Oct 2012 17:27:10 +0000 (10:27 -0700)] 
Merge branch 'po/maint-docs' into maint

* po/maint-docs:
  Doc branch: show -vv option and alternative
  Doc clean: add See Also link
  Doc add: link gitignore
  Doc: separate gitignore pattern sources
  Doc: shallow clone deepens _to_ new depth

12 years agoMerge branch 'jc/ll-merge-binary-ours' into maint
Junio C Hamano [Wed, 17 Oct 2012 17:26:51 +0000 (10:26 -0700)] 
Merge branch 'jc/ll-merge-binary-ours' into maint

* jc/ll-merge-binary-ours:
  ll-merge: warn about inability to merge binary files only when we can't
  attr: "binary" attribute should choose built-in "binary" merge driver
  merge: teach -Xours/-Xtheirs to binary ll-merge driver

12 years agoMerge branch 'db/doc-custom-xmlto' into maint
Junio C Hamano [Wed, 17 Oct 2012 17:25:37 +0000 (10:25 -0700)] 
Merge branch 'db/doc-custom-xmlto' into maint

* db/doc-custom-xmlto:
  Documentation/Makefile: Allow custom XMLTO binary

12 years agomaybe_flush_or_die: move a too-loose Windows specific error
Johannes Sixt [Wed, 17 Oct 2012 07:05:51 +0000 (09:05 +0200)] 
maybe_flush_or_die: move a too-loose Windows specific error

 check to compat

Commit b2f5e268 (Windows: Work around an oddity when a pipe with no reader
is written to) introduced a check for EINVAL after fflush() to fight
spurious "Invalid argument" errors on Windows when a pipe was broken. But
this check may hide real errors on systems that do not have the this odd
behavior. Introduce an fflush wrapper in compat/mingw.* so that the treatment
is only applied on Windows.

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
12 years agoMerge branch 'master' of https://github.com/nafmo/git-l10n-sv
Jiang Xin [Wed, 17 Oct 2012 01:38:30 +0000 (09:38 +0800)] 
Merge branch 'master' of https://github.com/nafmo/git-l10n-sv

* 'master' of https://github.com/nafmo/git-l10n-sv:
  l10n: Update Swedish translation (1964t0f0u)

12 years agoMerge branch 'master' of git://github.com/vnwildman/git
Jiang Xin [Wed, 17 Oct 2012 01:37:30 +0000 (09:37 +0800)] 
Merge branch 'master' of git://github.com/vnwildman/git

* 'master' of git://github.com/vnwildman/git:
  l10n: vi.po: update from v1.8.0-rc2-4-g42e55

12 years agol10n: vi.po: update from v1.8.0-rc2-4-g42e55
Tran Ngoc Quan [Wed, 17 Oct 2012 01:15:28 +0000 (08:15 +0700)] 
l10n: vi.po: update from v1.8.0-rc2-4-g42e55

* translate 3 new messages
* review quotes

Signed-off-by: Tran Ngoc Quan <vnwildman@gmail.com>
12 years agoDocumentation/RelNotes: remove "updated up to this revision" markers
Thomas Ackermann [Tue, 16 Oct 2012 17:26:23 +0000 (19:26 +0200)] 
Documentation/RelNotes: remove "updated up to this revision" markers

These were used to keep track of the last commit a release notes
entry was written for, and should have been removed when cutting
the final release.

Signed-off-by: Thomas Ackermann <th.acker@arcor.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
12 years agoUpdate draft release notes to 1.8.0
Junio C Hamano [Tue, 16 Oct 2012 20:27:23 +0000 (13:27 -0700)] 
Update draft release notes to 1.8.0

We are almost there...

Signed-off-by: Junio C Hamano <gitster@pobox.com>
12 years agoMerge branch 'jk/maint-http-half-auth-push'
Junio C Hamano [Tue, 16 Oct 2012 18:44:37 +0000 (11:44 -0700)] 
Merge branch 'jk/maint-http-half-auth-push'

Fixes a regression in maint-1.7.11 (v1.7.11.7), maint (v1.7.12.1)
and master (v1.8.0-rc0).

* jk/maint-http-half-auth-push:
  http: fix segfault in handle_curl_result

12 years agol10n: Update Swedish translation (1964t0f0u)
Peter Krefting [Tue, 16 Oct 2012 07:38:11 +0000 (08:38 +0100)] 
l10n: Update Swedish translation (1964t0f0u)

Signed-off-by: Peter Krefting <peter@softwolves.pp.se>
12 years agol10n: Update git.pot (3 new, 6 removed messages)
Jiang Xin [Tue, 16 Oct 2012 00:39:10 +0000 (08:39 +0800)] 
l10n: Update git.pot (3 new, 6 removed messages)

This po/git.pot update is generated from v1.8.0-rc2-4-g42e55.

Signed-off-by: Jiang Xin <worldhello.net@gmail.com>
12 years agoMerge branch 'master' of git://github.com/vnwildman/git
Jiang Xin [Tue, 16 Oct 2012 00:31:22 +0000 (08:31 +0800)] 
Merge branch 'master' of git://github.com/vnwildman/git

* 'master' of git://github.com/vnwildman/git:
  l10n: vi.po: update translation upto cc76011

12 years agol10n: vi.po: update translation upto cc76011
Tran Ngoc Quan [Mon, 15 Oct 2012 07:35:49 +0000 (14:35 +0700)] 
l10n: vi.po: update translation upto cc76011

* translate all new messages (100%)
* review some others

Signed-off-by: Tran Ngoc Quan <vnwildman@gmail.com>
12 years agoMerge branch 'maint'
Junio C Hamano [Sun, 14 Oct 2012 06:05:54 +0000 (23:05 -0700)] 
Merge branch 'maint'

* maint:
  Fix spelling error in post-receive-email hook

12 years agoFix spelling error in post-receive-email hook
Richard Fearn [Sat, 13 Oct 2012 22:32:50 +0000 (23:32 +0100)] 
Fix spelling error in post-receive-email hook

Signed-off-by: Richard Fearn <richardfearn@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
12 years agoMerge branch 'maint'
Junio C Hamano [Fri, 12 Oct 2012 18:36:06 +0000 (11:36 -0700)] 
Merge branch 'maint'

* maint:
  gitweb.cgi: fix "comitter_tz" typo in feed

12 years agohttp: do not set up curl auth after a 401
Jeff King [Fri, 12 Oct 2012 07:35:59 +0000 (03:35 -0400)] 
http: do not set up curl auth after a 401

When we get an http 401, we prompt for credentials and put
them in our global credential struct. We also feed them to
the curl handle that produced the 401, with the intent that
they will be used on a retry.

When the code was originally introduced in commit 42653c0,
this was a necessary step. However, since dfa1725, we always
feed our global credential into every curl handle when we
initialize the slot with get_active_slot. So every further
request already feeds the credential to curl.

Moreover, accessing the slot here is somewhat dubious. After
the slot has produced a response, we don't actually control
it any more.  If we are using curl_multi, it may even have
been re-initialized to handle a different request.

It just so happens that we will reuse the curl handle within
the slot in such a case, and that because we only keep one
global credential, it will be the one we want.  So the
current code is not buggy, but it is misleading.

By cleaning it up, we can remove the slot argument entirely
from handle_curl_result, making it much more obvious that
slots should not be accessed after they are marked as
finished.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
12 years agoremote-curl: do not call run_slot repeatedly
Jeff King [Fri, 12 Oct 2012 07:35:33 +0000 (03:35 -0400)] 
remote-curl: do not call run_slot repeatedly

Commit b81401c (http: prompt for credentials on failed POST)
taught post_rpc to call run_slot in a loop in order to retry
a request after asking the user for credentials. However,
after a call to run_slot we will have called
finish_active_slot. This means we have released the slot,
and we should no longer look at it.

As it happens, this does not cause any bugs in the current
code, since we know that we are not using curl_multi in this
code path, and therefore nobody will have taken over our
slot in the meantime. However, it is good form to actually
call get_active_slot again. It also future proofs us against
changes in the http code.

We can do this by jumping back to a retry label at the top
of our function. We just need to reorder a few setup lines
that should not be repeated; everything else within the loop
is either idempotent, needs to be repeated, or in a path we
do not follow (e.g., we do not even try when large_request
is set, because we don't know how much data we might have
streamed from our helper program).

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
12 years agohttp: fix segfault in handle_curl_result
Jeff King [Fri, 12 Oct 2012 06:22:49 +0000 (02:22 -0400)] 
http: fix segfault in handle_curl_result

When we create an http active_request_slot, we can set its
"results" pointer back to local storage. The http code will
fill in the details of how the request went, and we can
access those details even after the slot has been cleaned
up.

Commit 8809703 (http: factor out http error code handling)
switched us from accessing our local results struct directly
to accessing it via the "results" pointer of the slot. That
means we're accessing the slot after it has been marked as
finished, defeating the whole purpose of keeping the results
storage separate.

Most of the time this doesn't matter, as finishing the slot
does not actually clean up the pointer. However, when using
curl's multi interface with the dumb-http revision walker,
we might actually start a new request before handing control
back to the original caller. In that case, we may reuse the
slot, zeroing its results pointer, and leading the original
caller to segfault while looking for its results inside the
slot.

Instead, we need to pass a pointer to our local results
storage to the handle_curl_result function, rather than
relying on the pointer in the slot struct. This matches what
the original code did before the refactoring (which did not
use a separate function, and therefore just accessed the
results struct directly).

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
12 years agogitweb.cgi: fix "comitter_tz" typo in feed
Dylan Alex Simon [Thu, 11 Oct 2012 20:40:35 +0000 (16:40 -0400)] 
gitweb.cgi: fix "comitter_tz" typo in feed

gitweb's feeds sometimes contained committer timestamps in the wrong timezone
due to a misspelling.

Signed-off-by: Dylan Simon <dylan@dylex.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
12 years agogrep: stop looking at random places for .gitattributes
Nguyễn Thái Ngọc Duy [Fri, 12 Oct 2012 10:49:38 +0000 (17:49 +0700)] 
grep: stop looking at random places for .gitattributes

grep searches for .gitattributes using "name" field in struct
grep_source but that field is not real on-disk path name. For example,
"grep pattern rev" fills the field with "rev:path", and Git looks for
.gitattributes in the (non-existent but exploitable) path "rev:path"
instead of "path".

This patch passes real paths down to grep_source_load_driver() when:

 - grep on work tree
 - grep on the index
 - grep a commit (or a tag if it points to a commit)

so that these cases look up .gitattributes at proper paths.
.gitattributes lookup is disabled in all other cases.

Initial-work-by: Jeff King <peff@peff.net>
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
12 years agomergetools/p4merge: Handle "/dev/null"
David Aguilar [Thu, 11 Oct 2012 03:22:36 +0000 (20:22 -0700)] 
mergetools/p4merge: Handle "/dev/null"

p4merge does not properly handle the case where "/dev/null"
is passed as a filename.

Work it around by creating a temporary file for this purpose.

Reported-by: Jeremy Morton <admin@game-point.net>
Signed-off-by: David Aguilar <davvid@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

 Needs to be amended with Tested-by when a report comes...

12 years agoGit 1.8.0-rc2 v1.8.0-rc2
Junio C Hamano [Thu, 11 Oct 2012 18:18:56 +0000 (11:18 -0700)] 
Git 1.8.0-rc2

Signed-off-by: Junio C Hamano <gitster@pobox.com>
12 years agotest-lib: Fix say_color () not to interpret \a\b\c in the message
Junio C Hamano [Thu, 11 Oct 2012 17:40:36 +0000 (10:40 -0700)] 
test-lib: Fix say_color () not to interpret \a\b\c in the message

When running with color disabled (e.g. under prove to produce TAP
output), say_color() helper function is defined to use echo to show
the message.  With a message that ends with "\c", echo is allowed to
interpret it as "Do not end the line with LF".

Use printf "%s\n" to emit the message literally.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
12 years agoMerge branch 'rr/git-uri-doc'
Junio C Hamano [Wed, 10 Oct 2012 21:57:26 +0000 (14:57 -0700)] 
Merge branch 'rr/git-uri-doc'

* rr/git-uri-doc:
  Git url doc: mark ftp/ftps as read-only and deprecate them

12 years agoMerge branch 'bw/cp-a-is-gnuism'
Junio C Hamano [Wed, 10 Oct 2012 21:57:09 +0000 (14:57 -0700)] 
Merge branch 'bw/cp-a-is-gnuism'

* bw/cp-a-is-gnuism:
  tests: "cp -a" is a GNUism

12 years agoMerge branch 'nd/doc-ignore'
Junio C Hamano [Wed, 10 Oct 2012 21:57:02 +0000 (14:57 -0700)] 
Merge branch 'nd/doc-ignore'

* nd/doc-ignore:
  gitignore.txt: suggestions how to get literal # or ! at the beginning

12 years agoMerge branch 'jc/doc-long-options'
Junio C Hamano [Wed, 10 Oct 2012 21:56:52 +0000 (14:56 -0700)] 
Merge branch 'jc/doc-long-options'

* jc/doc-long-options:
  gitcli: parse-options lets you omit tail of long options

12 years agoSync with maint
Junio C Hamano [Wed, 10 Oct 2012 21:54:25 +0000 (14:54 -0700)] 
Sync with maint

* maint:
  attr: a note about the order of .gitattributes lookup

12 years agoMerge git://bogomips.org/git-svn
Junio C Hamano [Wed, 10 Oct 2012 20:53:56 +0000 (13:53 -0700)] 
Merge git://bogomips.org/git-svn

* git://bogomips.org/git-svn:
  svn test: escape peg revision separator using empty peg rev
  git svn: work around SVN 1.7 mishandling of svn:special changes