projects / ikiwiki / blame
| Commit | Line | Data |
|---|---|---|
| c42ff91e JH |
1 | The final `</div>` in [`recentchanges.tmpl`][tmpl] gets wrapped in a |
| 2 | `<p>` tag for some reason, resulting in the following invalid XHTML at | |
| 3 | the end of the [[RecentChanges]] page | |
| 4 | ||
| 5 | <p></div></p> | |
| 6 | ||
| 62846712 JH |
7 | > I'll bet this is fixed if you use the markdown 1.2 prerelease, which has |
| 8 | > a much less buggy html parser. (Ah, I see below that was the case.) | |
| 9 | > --[[Joey]] | |
| 10 | ||
| c42ff91e JH |
11 | Also, there is a problem with the `<img>` tags generated by the smiley |
| 12 | plugin which end up wrapped in a `<pre>` tag in the inline diff output. | |
| 13 | `<img>` tags is not allowed within a `<pre>` block. Maybe the smiley | |
| 14 | plugin should be disabled on [[RecentChanges]]? | |
| 15 | ||
| 44824dba | 16 | > See [[Smileys_in_the_block_code]], which is now fixed. --[[Joey]] |
| 62846712 | 17 | |
| c42ff91e JH |
18 | See the [validator output][validate] for more details. |
| 19 | ||
| 20 | [tmpl]: http://git.ikiwiki.info/?p=ikiwiki;a=blob_plain;f=templates/recentchanges.tmpl;hb=HEAD | |
| 21 | [validate]: http://validator.w3.org/check?uri=http://ikiwiki.info/recentchanges/ | |
| 1dae7f0e JH |
22 | |
| 23 | - - - | |
| 24 | ||
| 25 | I'll add this here since it's related. I also noticed that the meta tags for | |
| 26 | redirected pages need to be closed in order to be valid XHTML: | |
| 27 | ||
| 28 | <meta http-equiv="refresh" content="10; URL=../ikiwiki/pagespec/"> | |
| 29 | ||
| 30 | I'm noticing these problems because I'm serving ikiwiki-generated | |
| 31 | content as `application/xhtml+xml` (as opposed to `text/html`) in order | |
| 32 | to include inline MathML. Any invalid XHTML causes Firefox to halt all | |
| 33 | processing and throw an error. —[Jason Blevins](http://jblevins.org/) | |
| 4f6728a6 JH |
34 | |
| 35 | - - - | |
| 36 | ||
| 37 | Here is a simple patch for the refresh problem. I haven't figured out | |
| 38 | what's causing the recentchanges bug yet. | |
| 39 | ||
| 4f6728a6 JH |
40 | --[[JasonBlevins]] |
| 41 | ||
| 62846712 JH |
42 | > Thanks, applied that patch. --[[Joey]] |
| 43 | ||
| 8e2f7ec7 JH |
44 | - - - |
| 45 | ||
| 46 | It turns out that the invalid XHTML on the recent changes page is due to | |
| 47 | a bug in Markdown. I was using the packaged version of markdown in | |
| 48 | Ubuntu (Gutsy and markdown 1.0.1-6). Everything is fine | |
| 49 | after installing the most recent version of Text::Markdown from CPAN. | |
| 50 | ||
| 51 | Note that the above patch for the redirect tag is still applicable and | |
| 52 | the smiley issue remains open. --[[JasonBlevins]] | |
| 53 | ||
| 44824dba JH |
54 | > This bug is [[done]], all issues are fixed. --[[Joey]] |
| 55 | ||
| 9c02d61d | 56 | [[!tag patch]] |