From 701ecfc2bb339d438d1138233e8a9250e580adf1 Mon Sep 17 00:00:00 2001 From: intrigeri Date: Mon, 30 Dec 2013 20:53:36 -0400 Subject: [PATCH] Reply on the cgit URL encoding problem. --- doc/todo/support_linking_to_cgit.mdwn | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/doc/todo/support_linking_to_cgit.mdwn b/doc/todo/support_linking_to_cgit.mdwn index 92c7cb8a6..5c61ff42f 100644 --- a/doc/todo/support_linking_to_cgit.mdwn +++ b/doc/todo/support_linking_to_cgit.mdwn @@ -17,4 +17,16 @@ the substitution of `\[[file]]` in `diffurl` and `historyurl`? > In `91b477c` I made a similar change to how the cvs backend encodes > `diffurl`. Perhaps it applies to all VCS backends? --[[schmonz]] +>> Thanks a lot! I've not looked at it yet, but will try to do so +>> soonish, as this bug is a real problem for Tails when welcoming potential +>> new contributors. +>> +>> Also, note that this does not affect recentchanges only: we have +>> the same problem for URLs generated by the shortcut plugin, e.g. +>> `\[[!tails_gitweb config/chroot_local-includes/usr/local/sbin/unsafe-browser]]` +>> in a page (with the shortcut defined as +>> `\[[!shortcut name=tails_gitweb url="https://git-tails.immerda.ch/tails/plain/%s"]]`) +>> produces URLs with `/` encoded as `%2F`, which fails the same way +>> in combination with cgit. --[[intrigeri]] + [[wishlist]] -- 2.32.0.93.g670b81a890