From 7a070c64fab372cb829261a989eb28fdd30d306e Mon Sep 17 00:00:00 2001 From: "http://www.cse.unsw.edu.au/~willu/" Date: Thu, 24 Jul 2008 21:46:23 -0400 Subject: [PATCH] Add notes about possible security issues with rename - these look to be already covered in the source, but I wanted to make sure they're listed in the docs too. --- doc/todo/Moving_Pages.mdwn | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/doc/todo/Moving_Pages.mdwn b/doc/todo/Moving_Pages.mdwn index 61f2663e0..cf1ce89c6 100644 --- a/doc/todo/Moving_Pages.mdwn +++ b/doc/todo/Moving_Pages.mdwn @@ -205,3 +205,9 @@ Cases to consider: Update: Meh. It's certianly not ideal; if Bob tries to save the page he uploaded the attachment to, he'll get a message about it having been deleted/renamed, and he can try to figure out what to do... :-/ +* I don't know if this is a conflict, but it is an important case to consider; + you need to make sure that there are no security holes. You dont want + someone to be able to rename something to /etc/passwd. + I think it would be enough that you cannot rename to a location outside + of srcdir, you cannot rename to a location that you wouldn't be able + to edit because it is locked, and you cannot rename to an existing page. -- 2.32.0.93.g670b81a890