From 93bda514baad6b5e9dce5b6cce62155ac4ba7d68 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Wed, 4 Apr 2012 12:58:36 -0400 Subject: [PATCH] httpauth: When it's the only auth method, avoid a pointless and confusing signin form, and just right to the httpauthurl. --- IkiWiki/Plugin/httpauth.pm | 14 ++++++++++++++ debian/changelog | 2 ++ 2 files changed, 16 insertions(+) diff --git a/IkiWiki/Plugin/httpauth.pm b/IkiWiki/Plugin/httpauth.pm index cb488449d..76d574b2a 100644 --- a/IkiWiki/Plugin/httpauth.pm +++ b/IkiWiki/Plugin/httpauth.pm @@ -7,6 +7,7 @@ use strict; use IkiWiki 3.00; sub import { + hook(type => "checkconfig", id => "httpauth", call => \&checkconfig); hook(type => "getsetup", id => "httpauth", call => \&getsetup); hook(type => "auth", id => "httpauth", call => \&auth); hook(type => "formbuilder_setup", id => "httpauth", @@ -37,6 +38,19 @@ sub getsetup () { rebuild => 0, }, } + +sub checkconfig () { + if ($config{cgi} && defined $config{cgiauthurl} && + keys %{$IkiWiki::hooks{auth}} < 2) { + # There are no other auth hooks registered, so avoid + # the normal signin form, and jump right to httpauth. + require IkiWiki::CGI; + inject(name => "IkiWiki::cgi_signin", call => sub ($$) { + my $cgi=shift; + redir_cgiauthurl($cgi, $cgi->query_string()); + }); + } +} sub redir_cgiauthurl ($;@) { my $cgi=shift; diff --git a/debian/changelog b/debian/changelog index 23c6dc5e3..dd7a5c309 100644 --- a/debian/changelog +++ b/debian/changelog @@ -12,6 +12,8 @@ ikiwiki (3.20120204) UNRELEASED; urgency=low * meta: Support keywords header. Closes: #664780 Thanks, Martin Michlmayr * passwordauth: Fix url in password recovery email to be absolute. + * httpauth: When it's the only auth method, avoid a pointless and + confusing signin form, and just right to the httpauthurl. -- Joey Hess Wed, 21 Mar 2012 14:33:14 -0400 -- 2.32.0.93.g670b81a890