From af5299677e3a3bdaef75e72f82ccc4600cbd2f66 Mon Sep 17 00:00:00 2001
From: Joey Hess <joey@kodama.kitenet.net>
Date: Fri, 25 Jul 2008 15:53:46 -0400
Subject: [PATCH] comments

---
 doc/todo/color_plugin.mdwn | 23 +++++++++++++++++++++++
 po/ikiwiki.pot             | 10 +++++-----
 2 files changed, 28 insertions(+), 5 deletions(-)

diff --git a/doc/todo/color_plugin.mdwn b/doc/todo/color_plugin.mdwn
index 7b5969f0d..fa460a386 100644
--- a/doc/todo/color_plugin.mdwn
+++ b/doc/todo/color_plugin.mdwn
@@ -45,6 +45,29 @@ What do you think about it? --[[Paweł|ptecza]]
 This is a RC1 of my `color` plugin. It works for me well, but all your
 comments are very welcome. --[[Paweł|ptecza]]
 
+> Sure, I have a couple.
+> 
+> The preprocess function is passed named parameters. The hack you have of
+> hardcoding use of `$_[0]` and `$_[2]` can fail at any time.
+> 
+> `replace_preserved_style` is passed a single parameter, so its prototype
+> should be `($)`, not `(@)`.  Ditt `preserve_style`, it should have
+> `($$)`.
+> 
+> The sanitize hook is always passed `$params{content}`, so there should be
+> no reason to check that it exists. Also, it shouldn't be done in a
+> sanitize hook, since html sanitization could run _after_ that santize
+> hook. It should use a format hook.
+> 
+> The preprocess hook needs to call `IkiWiki::preprocess` on the content
+> passed into it if you want to support nesting other preprocessor
+> directives inside the color directive. See `preprocess_toggleable` in the
+> toggle plugin, for example.
+> 
+> I'm not a big fan of the dummy text `COLORS { ... } SROLOC;TEXT { ... TXET }`
+> The method used by toggle of using two real `<div>`s seems slightly
+> better. --[[Joey]]
+
 	--- /dev/null	2008-07-24 09:38:19.000000000 +0200
 	+++ color.pm	2008-07-25 14:43:15.000000000 +0200
 	@@ -0,0 +1,75 @@
diff --git a/po/ikiwiki.pot b/po/ikiwiki.pot
index 35b3bef51..f5f35bff9 100644
--- a/po/ikiwiki.pot
+++ b/po/ikiwiki.pot
@@ -8,7 +8,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: PACKAGE VERSION\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2008-07-23 18:43-0400\n"
+"POT-Creation-Date: 2008-07-25 15:21-0400\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language-Team: LANGUAGE <LL@li.org>\n"
@@ -558,20 +558,20 @@ msgstr ""
 msgid "rename %s"
 msgstr ""
 
-#: ../IkiWiki/Plugin/rename.pm:169
+#: ../IkiWiki/Plugin/rename.pm:179
 msgid "Only one attachment can be renamed at a time."
 msgstr ""
 
-#: ../IkiWiki/Plugin/rename.pm:172
+#: ../IkiWiki/Plugin/rename.pm:182
 msgid "Please select the attachment to rename."
 msgstr ""
 
-#: ../IkiWiki/Plugin/rename.pm:236
+#: ../IkiWiki/Plugin/rename.pm:246
 #, perl-format
 msgid "rename %s to %s"
 msgstr ""
 
-#: ../IkiWiki/Plugin/rename.pm:263
+#: ../IkiWiki/Plugin/rename.pm:274
 #, perl-format
 msgid "update for rename of %s to %s"
 msgstr ""
-- 
2.32.0.93.g670b81a890