From b216f42e8ea6953456381e041d248b5cf958d8ab Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Wed, 5 Jan 2011 15:34:35 -0400 Subject: [PATCH] goto permalink issue --- ...r_https_in_urls_to_allow_serving_both.mdwn | 26 ++++++++++++------- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/doc/todo/want_to_avoid_ikiwiki_using_http_or_https_in_urls_to_allow_serving_both.mdwn b/doc/todo/want_to_avoid_ikiwiki_using_http_or_https_in_urls_to_allow_serving_both.mdwn index 260aecdbd..dfe41e138 100644 --- a/doc/todo/want_to_avoid_ikiwiki_using_http_or_https_in_urls_to_allow_serving_both.mdwn +++ b/doc/todo/want_to_avoid_ikiwiki_using_http_or_https_in_urls_to_allow_serving_both.mdwn @@ -5,15 +5,23 @@ * CGI pages, with the exception of edit pages, set `` to `$config{url}` -I had to revert using `baseurl(undef)` for that, because it needs -to be a full url. - -Ideally, baseurl would return an absolute url derived from the url -being used to access the cgi, but that needs access to the CGI object, -which it does not currently have. Similarly, `misctemplate` -does not have access to the CGI object, so it cannot use it to -generate a better baseurl. Not sure yet what to do; may have to thread -a cgi parameter through all the calls to misctemplate. --[[Joey]] + I had to revert using `baseurl(undef)` for that, because it needs + to be a full url. + + Ideally, baseurl would return an absolute url derived from the url + being used to access the cgi, but that needs access to the CGI object, + which it does not currently have. Similarly, `misctemplate` + does not have access to the CGI object, so it cannot use it to + generate a better baseurl. Not sure yet what to do; may have to thread + a cgi parameter through all the calls to misctemplate. --[[Joey]] + +* Using `do=goto` to go to a comment or recentchanges item + will redirect to the `$config{url}`-based url, since the + permalinks are made to be absolute urls now. + + Fixing this would seem to involve making meta force permalinks + to absolute urls when fulling out templates, while allowing them + to be left as partial urls internally, for use by goto. --[[Joey]] ## old attempt -- 2.32.0.93.g670b81a890