powerpc/mm: Fix a AB->BA deadlock scenario with nohash MMU context lock
authorBenjamin Herrenschmidt <benh@kernel.crashing.org>
Tue, 2 Jun 2009 18:53:37 +0000 (18:53 +0000)
committerBenjamin Herrenschmidt <benh@kernel.crashing.org>
Tue, 9 Jun 2009 06:43:04 +0000 (16:43 +1000)
commitb46b6942b39e577fe3ef1af928cd927864011247
tree8eea7316ac79fae34ee7fdbccc580fbac1589ff3
parent3035c8634f0538a0c6946e3191bb6c9284b63798
powerpc/mm: Fix a AB->BA deadlock scenario with nohash MMU context lock

The MMU context_lock can be taken from switch_mm() while the
rq->lock is held. The rq->lock can also be taken from interrupts,
thus if we get interrupted in destroy_context() with the context
lock held and that interrupt tries to take the rq->lock, there's
a possible deadlock scenario with another CPU having the rq->lock
and calling switch_mm() which takes our context lock.

The fix is to always ensure interrupts are off when taking our
context lock. The switch_mm() path is already good so this fixes
the destroy_context() path.

While at it, turn the context lock into a new style spinlock.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
arch/powerpc/mm/mmu_context_nohash.c