drivers/atm: introduce missing kfree
authorJulia Lawall <julia@diku.dk>
Mon, 9 Feb 2009 01:00:02 +0000 (17:00 -0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 9 Feb 2009 01:00:02 +0000 (17:00 -0800)
commitbc111d570ba87cff48ec8dfa15a2a598e59c0f4b
treef49f3d065311a6fc3c5759ab1ceb2f05ee17e40c
parent0b492fce3d72d982a7981905f85484a1e1ba7fde
drivers/atm: introduce missing kfree

Error handling code following a kmalloc should free the allocated data.

The semantic match that finds the problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@r exists@
local idexpression x;
statement S;
expression E;
identifier f,l;
position p1,p2;
expression *ptr != NULL;
@@

(
if ((x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...)) == NULL) S
|
x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x == NULL) S
)
<... when != x
     when != if (...) { <+...x...+> }
x->f = E
...>
(
 return \(0\|<+...x...+>\|ptr\);
|
 return@p2 ...;
)

@script:python@
p1 << r.p1;
p2 << r.p2;
@@

print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/atm/solos-pci.c