x64, apic: use generic apic_write() for ack_APIC_irq()
authorSuresh Siddha <suresh.b.siddha@intel.com>
Tue, 22 Jul 2008 14:13:11 +0000 (10:13 -0400)
committerIngo Molnar <mingo@elte.hu>
Tue, 22 Jul 2008 15:29:22 +0000 (17:29 +0200)
commitdf1be4372eae5f104b7fb4991bc4b35f00b11a11
tree8d812a128eaed7c27fdb3a7913b050e35e3d6145
parent1b9b89e7f163336ad84200b66a17284dbf26aced
x64, apic: use generic apic_write() for ack_APIC_irq()

I tested tip/master and found an issue (patch attached)
for x2apic support. This is not because of the recent merges we had, but
because of something(where we still access memory based interface after
enabling x2apic mode) that slipped through my earlier tests.

Probably it is a good idea to unmap the memory mapped interface, once we switch
to x2apic mode. That will catch the issues much earlier. I will
post another patch for this.

ack_APIC_irq() is used at too many generic places (and not just during
irq_chip handling!) to use the native_apic_mem_write(). For ex, this will
break x2apic based systems.

Fix ack_APIC_irq() to use the generic apic_write() even for 64-bit.

Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: suresh.b.siddha@intel.com
Cc: yong.y.wang@linux.intel.com
Signed-off-by: Ingo Molnar <mingo@elte.hu>
include/asm-x86/apic.h