Revert "ipv4: arp announce, arp_proxy and windows ip conflict verification"
authorEric W. Biederman <ebiederm@xmission.com>
Tue, 30 Jun 2009 16:27:17 +0000 (16:27 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 1 Jul 2009 02:47:08 +0000 (19:47 -0700)
commitf8a68e752bc4e39644843403168137663c984524
tree3fb17f72a02319f92bd3ed4d73456bbc7e8ac633
parent59ed6eecff4aa00c5c5d18ffd180acac108d596e
Revert "ipv4: arp announce, arp_proxy and windows ip conflict verification"

This reverts commit 73ce7b01b4496a5fbf9caf63033c874be692333f.

After discovering that we don't listen to gratuitious arps in 2.6.30
I tracked the failure down to this commit.

The patch makes absolutely no sense.  RFC2131 RFC3927 and RFC5227.
are all in agreement that an arp request with sip == 0 should be used
for the probe (to prevent learning) and an arp request with sip == tip
should be used for the gratitous announcement that people can learn
from.

It appears the author of the broken patch got those two cases confused
and modified the code to drop all gratuitous arp traffic.  Ouch!

Cc: stable@kernel.org
Signed-off-by: Eric W. Biederman <ebiederm@aristanetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/arp.c