linux-2.6
15 years agoStaging: add USB serial Quatech driver
Greg Kroah-Hartman [Mon, 23 Mar 2009 23:43:59 +0000 (16:43 -0700)] 
Staging: add USB serial Quatech driver

Add support for all Quatech usb to serial devices.

Based on an original driver from Quatech.

Cleaned up and forward ported by me.

It's a mess, uses it's own tty layer interface, and the coding style is
horrible.

Cc: Tim Gobeli <tgobeli@quatech.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agostaging: document that the wifi staging drivers a bit better
Greg Kroah-Hartman [Sun, 22 Mar 2009 20:44:31 +0000 (21:44 +0100)] 
staging: document that the wifi staging drivers a bit better

The Linux wireless developers don't want to hear anything about the
staging wireless drivers, for a wide range of miopic reasons.

The following patch, based on a patch from Johannes Berg, tries to
document this issue a bit better.

Cc: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: echo cleanup
Alexander Beregalov [Thu, 12 Mar 2009 00:32:45 +0000 (03:32 +0300)] 
Staging: echo cleanup

before:
errors lines of code errors/KLOC
drivers/staging/echo/ 213 1701 125.2

after:
errors lines of code errors/KLOC
drivers/staging/echo/ 8 1685 4.7

Compile tested.

Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: BUG to BUG_ON changes
Stoyan Gaydarov [Tue, 10 Mar 2009 05:10:27 +0000 (00:10 -0500)] 
Staging: BUG to BUG_ON changes

Signed-off-by: Stoyan Gaydarov <stoyboyker@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: remove some pointless conditionals before kfree_skb()
Wei Yongjun [Wed, 25 Feb 2009 10:26:33 +0000 (18:26 +0800)] 
Staging: remove some pointless conditionals before kfree_skb()

Remove some pointless conditionals before kfree_skb().

Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: line6: fix build error, select SND_RAWMIDI
Randy Dunlap [Wed, 18 Mar 2009 17:00:16 +0000 (10:00 -0700)] 
Staging: line6: fix build error, select SND_RAWMIDI

line6 needs to select SND_RAWMIDI, like many other drivers do.

ERROR: "snd_rawmidi_set_ops" [drivers/staging/line6/line6usb.ko] undefined!
ERROR: "snd_rawmidi_new" [drivers/staging/line6/line6usb.ko] undefined!
ERROR: "snd_rawmidi_transmit_peek" [drivers/staging/line6/line6usb.ko] undefined!
ERROR: "snd_rawmidi_transmit_ack" [drivers/staging/line6/line6usb.ko] undefined!
ERROR: "snd_rawmidi_receive" [drivers/staging/line6/line6usb.ko] undefined!

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: line6: fix checkpatch errors in variax.c
Greg Kroah-Hartman [Sat, 28 Feb 2009 06:43:57 +0000 (22:43 -0800)] 
Staging: line6: fix checkpatch errors in variax.c

Lots of warnings also fixed up.

Cc: Markus Grabner <grabner@icg.tugraz.at>
Cc: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: line6: fix checkpatch errors in toneport.c
Greg Kroah-Hartman [Sat, 28 Feb 2009 06:43:45 +0000 (22:43 -0800)] 
Staging: line6: fix checkpatch errors in toneport.c

Lots of warnings also fixed up.

Cc: Markus Grabner <grabner@icg.tugraz.at>
Cc: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: line6: fix checkpatch errors in pcm.c
Greg Kroah-Hartman [Sat, 28 Feb 2009 06:43:30 +0000 (22:43 -0800)] 
Staging: line6: fix checkpatch errors in pcm.c

Lots of warnings also fixed up.

Cc: Markus Grabner <grabner@icg.tugraz.at>
Cc: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: line6: fix checkpatch errors in midibuf.c
Greg Kroah-Hartman [Sat, 28 Feb 2009 06:43:11 +0000 (22:43 -0800)] 
Staging: line6: fix checkpatch errors in midibuf.c

Lots of warnings also fixed up.

Cc: Markus Grabner <grabner@icg.tugraz.at>
Cc: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: line6: fix checkpatch errors in midi.c
Greg Kroah-Hartman [Sat, 28 Feb 2009 06:42:55 +0000 (22:42 -0800)] 
Staging: line6: fix checkpatch errors in midi.c

Lots of warnings also fixed up.

Cc: Markus Grabner <grabner@icg.tugraz.at>
Cc: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: line6: fix checkpatch errors in dumprequest.c
Greg Kroah-Hartman [Sat, 28 Feb 2009 06:42:34 +0000 (22:42 -0800)] 
Staging: line6: fix checkpatch errors in dumprequest.c

Lots of warnings also fixed up.

Cc: Markus Grabner <grabner@icg.tugraz.at>
Cc: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: line6: fix checkpatch errors in driver.c
Greg Kroah-Hartman [Sat, 28 Feb 2009 06:42:18 +0000 (22:42 -0800)] 
Staging: line6: fix checkpatch errors in driver.c

Lots of warnings also fixed up.

Cc: Markus Grabner <grabner@icg.tugraz.at>
Cc: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: line6: fix checkpatch errors in audio.c
Greg Kroah-Hartman [Sat, 28 Feb 2009 06:41:54 +0000 (22:41 -0800)] 
Staging: line6: fix checkpatch errors in audio.c

Lots of warnings also fixed up.

Cc: Markus Grabner <grabner@icg.tugraz.at>
Cc: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: line6: fix checkpatch errors in pod.c
Greg Kroah-Hartman [Sat, 28 Feb 2009 06:41:29 +0000 (22:41 -0800)] 
Staging: line6: fix checkpatch errors in pod.c

2 errors left, but they are minor.
Lots of warnings also fixed up.

Cc: Markus Grabner <grabner@icg.tugraz.at>
Cc: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: line6: fix checkpatch errors in playback.c
Greg Kroah-Hartman [Sat, 28 Feb 2009 06:41:12 +0000 (22:41 -0800)] 
Staging: line6: fix checkpatch errors in playback.c

2 errors left, but they are minor.
Lots of warnings also fixed up.

Cc: Markus Grabner <grabner@icg.tugraz.at>
Cc: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: line6: fix checkpatch errors in control.c
Greg Kroah-Hartman [Sat, 28 Feb 2009 06:40:27 +0000 (22:40 -0800)] 
Staging: line6: fix checkpatch errors in control.c

1 error left, but it's minor.
Lots of warnings also fixed up.

Cc: Markus Grabner <grabner@icg.tugraz.at>
Cc: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: line6: fix checkpatch errors in capture.c
Greg Kroah-Hartman [Sat, 28 Feb 2009 06:39:22 +0000 (22:39 -0800)] 
Staging: line6: fix checkpatch errors in capture.c

2 errors left, but they are minor.
Lots of warnings also fixed up.

Cc: Markus Grabner <grabner@icg.tugraz.at>
Cc: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: line6: coding style cleanups for .h files.
Greg Kroah-Hartman [Sat, 28 Feb 2009 05:09:55 +0000 (21:09 -0800)] 
Staging: line6: coding style cleanups for .h files.

Mostly all line length issues.
Skipped the control.h file as it makes sense to leave it alone.

Cc: Markus Grabner <grabner@icg.tugraz.at>
Cc: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: line6: fix up NULL assignment mistakes
Greg Kroah-Hartman [Sat, 28 Feb 2009 04:49:46 +0000 (20:49 -0800)] 
Staging: line6: fix up NULL assignment mistakes

Should use NULL for a pointer, not 0, otherwise sparse complains.

Cc: Markus Grabner <grabner@icg.tugraz.at>
Cc: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: line6: static function cleanups
Greg Kroah-Hartman [Sat, 28 Feb 2009 04:45:03 +0000 (20:45 -0800)] 
Staging: line6: static function cleanups

This fixes all of the static function warnings that sparse complains
about.

Cc: Markus Grabner <grabner@icg.tugraz.at>
Cc: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: line6: remove KERNEL_VERSION checks
Greg Kroah-Hartman [Sat, 28 Feb 2009 04:32:10 +0000 (20:32 -0800)] 
Staging: line6: remove KERNEL_VERSION checks

As the code is in the kernel tree, it's no longer needed.

Cc: Markus Grabner <grabner@icg.tugraz.at>
Cc: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: line6: remove PT_REGS
Greg Kroah-Hartman [Sat, 28 Feb 2009 04:28:04 +0000 (20:28 -0800)] 
Staging: line6: remove PT_REGS

As the code is in the kernel tree, it's no longer needed.

Cc: Markus Grabner <grabner@icg.tugraz.at>
Cc: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: line6: remove DEVICE_ATTRIBUTE
Greg Kroah-Hartman [Sat, 28 Feb 2009 04:25:43 +0000 (20:25 -0800)] 
Staging: line6: remove DEVICE_ATTRIBUTE

As the code is in the kernel tree, it's no longer needed.

Cc: Markus Grabner <grabner@icg.tugraz.at>
Cc: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: line6: depends on SND
Randy Dunlap [Mon, 2 Mar 2009 17:54:57 +0000 (09:54 -0800)] 
Staging: line6: depends on SND

line6 code has lots of dependencies on ALSA (and build errors),
so express that in Kconfig.

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Markus Grabner <grabner@icg.tugraz.at>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: line6: add to the build
Greg Kroah-Hartman [Sat, 28 Feb 2009 03:50:03 +0000 (19:50 -0800)] 
Staging: line6: add to the build

This adds the line6 driver to the build system.

Cc: Markus Grabner <grabner@icg.tugraz.at>
Cc: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: line6: fix bus_id usage
Greg Kroah-Hartman [Sat, 28 Feb 2009 03:49:00 +0000 (19:49 -0800)] 
Staging: line6: fix bus_id usage

bus_id is now gone in the linux-next tree, so replace it with dev_name()
so the code works properly.

Cc: Markus Grabner <grabner@icg.tugraz.at>
Cc: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: add line6 usb driver
Markus Grabner [Sat, 28 Feb 2009 03:43:04 +0000 (19:43 -0800)] 
Staging: add line6 usb driver

This is an experimental Linux driver for the guitar amp, cab, and
effects modeller PODxt Pro by Line6 (and similar devices), supporting
the following features:

  - Reading/writing individual parameters
  - Reading/writing complete channel, effects setup, and amp setup data
  - Channel switching
  - Virtual MIDI interface
  - Tuner access
  - Playback/capture/mixer device for any  ALSA-compatible PCM audio
    application
  - Signal routing (record clean/processed  guitar signal, re-amping)

Moreover, preliminary support for the Variax Workbench is included.

From: Markus Grabner <grabner@icg.tugraz.at>
Cc: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: add rt3070 wireless driver
Greg Kroah-Hartman [Thu, 26 Feb 2009 00:14:55 +0000 (16:14 -0800)] 
Staging: add rt3070 wireless driver

This is the Ralink RT3070 driver from the company that does horrible
things like reading a config file from /etc.  However, the driver that
is currently under development from the wireless development community
is not working at all yet, so distros and users are using this version
instead (quite common hardware on a lot of netbook machines).

So here is this driver, for now, until the wireless developers get a
"clean" version into the main tree, or until this version is cleaned up
sufficiently to move out of the staging tree.

Ported to the Linux build system, fixed lots of build issues, forward
ported to the current kernel version, and other minor cleanups were all
done by me.

Cc: Linux wireless <linux-wireless@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: heci: add TODO file
Greg Kroah-Hartman [Wed, 25 Feb 2009 21:11:52 +0000 (13:11 -0800)] 
Staging: heci: add TODO file

List some of the remaining issues in the code.

Cc: Anas Nashif <anas.nashif@intel.com>
Cc: Marcin Obara <marcin.obara@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: heci: fix some sparse warnings
Greg Kroah-Hartman [Wed, 25 Feb 2009 21:06:49 +0000 (13:06 -0800)] 
Staging: heci: fix some sparse warnings

This resolves a lot of the more obvious sparse warnings in the code.

There still are some major problems in the ioctl handlers dealing with
user and kernel pointers that this patch does not resolve, that needs to
be addressed still.

Also, the locking seems to be a bit strange in places, which sparse
points out, that too need to be resolved.

Cc: Anas Nashif <anas.nashif@intel.com>
Cc: Marcin Obara <marcin.obara@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: heci: fix checkpatch warnings
Greg Kroah-Hartman [Wed, 25 Feb 2009 20:41:16 +0000 (12:41 -0800)] 
Staging: heci: fix checkpatch warnings

This resolves the outstanding scripts/checkpatch.pl warnings

Cc: Anas Nashif <anas.nashif@intel.com>
Cc: Marcin Obara <marcin.obara@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: heci: remove kcompat.h
Greg Kroah-Hartman [Wed, 25 Feb 2009 20:36:14 +0000 (12:36 -0800)] 
Staging: heci: remove kcompat.h

It's not needed now that we are now in the main kernel tree.

Cc: Anas Nashif <anas.nashif@intel.com>
Cc: Marcin Obara <marcin.obara@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: add heci driver
Marcin Obara [Wed, 25 Feb 2009 20:29:24 +0000 (12:29 -0800)] 
Staging: add heci driver

The Intel Management Engine Interface (aka HECI: Host Embedded
Controller Interface ) enables communication between the host OS and
the Management Engine firmware. MEI is bi-directional, and either the
host or Intel AMT firmware can initiate transactions.

The core hardware architecture of Intel Active Management Technology
(Intel AMT) is resident in firmware. The micro-controller within the
chipset's graphics and memory controller (GMCH) hub houses the
Management Engine (ME) firmware, which implements various services
on behalf of management applications.

Some of the ME subsystems that can be access via MEI driver:

- Intel(R) Quiet System Technology (QST) is implemented as a firmware
subsystem  that  runs in the ME.  Programs that wish to expose the
health monitoring and fan speed control capabilities of Intel(R) QST
will need to use the MEI driver to communicate with the ME sub-system.
- ASF is the "Alert Standard Format" which is an DMTF manageability
standard. It is implemented in the PC's hardware and firmware, and is
managed from a remote console.

Most recent Intel desktop chipsets have one or more of the above ME
services. The MEI driver will make it possible to support the above
features on Linux and provides applications access to the ME and it's
features.

Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Signed-off-by: Marcin Obara <marcin.obara@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: p9auth: clean up #includes
Greg Kroah-Hartman [Wed, 25 Feb 2009 04:37:55 +0000 (20:37 -0800)] 
Staging: p9auth: clean up #includes

Not all of these files needed to be included, clean up the list.

Cc: Ashwin Ganti <ashwin.ganti@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: p9auth: use kzalloc
Greg Kroah-Hartman [Wed, 25 Feb 2009 04:31:39 +0000 (20:31 -0800)] 
Staging: p9auth: use kzalloc

It's nicer than doing kmalloc/memset.

Also check the return value of all allocations, one was previously not
being checked properly.

Cc: Ashwin Ganti <ashwin.ganti@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: p9auth: fix up sparse warnings
Greg Kroah-Hartman [Wed, 25 Feb 2009 04:25:02 +0000 (20:25 -0800)] 
Staging: p9auth: fix up sparse warnings

Everything needs to be static, as sparse complains and you don't want to
polute the global kernel symbol namespace.  So mark everything as such
and move one function around to prevent a forward declaration from being
needed.

Cc: Ashwin Ganti <ashwin.ganti@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: p9auth: fix up codingstyle issues
Greg Kroah-Hartman [Wed, 25 Feb 2009 04:21:55 +0000 (20:21 -0800)] 
Staging: p9auth: fix up codingstyle issues

This fixes up a number of scripts/codingstyle.pl warnings and errors

Cc: Ashwin Ganti <ashwin.ganti@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: p9auth: remove unneeded header file
Greg Kroah-Hartman [Wed, 25 Feb 2009 04:11:39 +0000 (20:11 -0800)] 
Staging: p9auth: remove unneeded header file

The p9auth.h file is not needed, move the stuff into p9auth.c file and
delete it.

Cc: Ashwin Ganti <ashwin.ganti@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: p9auth: fix dependency/build error
Randy Dunlap [Tue, 10 Mar 2009 18:59:36 +0000 (11:59 -0700)] 
Staging: p9auth: fix dependency/build error

Fix p9auth dependency/build failure.  It needs to depend on
CRYPTO.

p9auth.c:(.text+0x107297): undefined reference to `crypto_alloc_base'
p9auth.c:(.text+0x1073d4): undefined reference to `crypto_destroy_tfm'

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Ashwin Ganti <ashwin.ganti@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: p9auth: add to the kernel build
Greg Kroah-Hartman [Wed, 25 Feb 2009 04:08:20 +0000 (20:08 -0800)] 
Staging: p9auth: add to the kernel build

This adds the p9auth code to the kernel build

Cc: Ashwin Ganti <ashwin.ganti@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: p9auth: fix credential logic
Greg Kroah-Hartman [Wed, 25 Feb 2009 04:06:34 +0000 (20:06 -0800)] 
Staging: p9auth: fix credential logic

current->uid is no longer allowed in the 2.6.29 kernel, so use
the proper credential api to be able to alter the uid and euid values.

Note, this now builds properly, hopefully still works properly, would be
good for someone to test it out...

Cc: Ashwin Ganti <ashwin.ganti@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: add p9auth driver
Ashwin Ganti [Wed, 25 Feb 2009 03:48:44 +0000 (19:48 -0800)] 
Staging: add p9auth driver

This is a driver that adds Plan 9 style capability device
implementation.

From: Ashwin Ganti <ashwin.ganti@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: epl: remove pointless highres timer check
Greg Kroah-Hartman [Mon, 23 Mar 2009 20:42:58 +0000 (13:42 -0700)] 
Staging: epl: remove pointless highres timer check

The code only gets built if this option is enabled, so don't
check for it in the code again.

Cc: Daniel Krueger <daniel.krueger@systec-electronic.com>
Cc: Ronald Sieber <Ronald.Sieber@systec-electronic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: epl: don't check for devfs
Greg Kroah-Hartman [Mon, 23 Mar 2009 20:41:23 +0000 (13:41 -0700)] 
Staging: epl: don't check for devfs

devfs is long dead and burried, don't check for it, as it doesn't make
any sense to do so.

Cc: Daniel Krueger <daniel.krueger@systec-electronic.com>
Cc: Ronald Sieber <Ronald.Sieber@systec-electronic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: epl: fix up epl/kernel/*.h files
Greg Kroah-Hartman [Mon, 23 Mar 2009 20:39:35 +0000 (13:39 -0700)] 
Staging: epl: fix up epl/kernel/*.h files

Only include a file if it's needed.

Also remove some unused comments from the boilerplate text.

And delete some empty .h files

Cc: Daniel Krueger <daniel.krueger@systec-electronic.com>
Cc: Ronald Sieber <Ronald.Sieber@systec-electronic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: epl: fix up epl/user/*.h files
Greg Kroah-Hartman [Mon, 23 Mar 2009 20:38:43 +0000 (13:38 -0700)] 
Staging: epl: fix up epl/user/*.h files

Only include a file if it's needed.

Also remove some unused comments from the boilerplate text.

Cc: Daniel Krueger <daniel.krueger@systec-electronic.com>
Cc: Ronald Sieber <Ronald.Sieber@systec-electronic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: epl: remove EPLDLLEXPORT
Greg Kroah-Hartman [Mon, 23 Mar 2009 20:26:29 +0000 (13:26 -0700)] 
Staging: epl: remove EPLDLLEXPORT

This isn't a DLL, so we don't need this :)

Cc: Daniel Krueger <daniel.krueger@systec-electronic.com>
Cc: Ronald Sieber <Ronald.Sieber@systec-electronic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: epl: fix sparse warning in proc_fs.c
Greg Kroah-Hartman [Mon, 23 Mar 2009 20:12:00 +0000 (13:12 -0700)] 
Staging: epl: fix sparse warning in proc_fs.c

proc_fs.c needs to include proc_fs.h

Cc: Daniel Krueger <daniel.krueger@systec-electronic.com>
Cc: Ronald Sieber <Ronald.Sieber@systec-electronic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: epl: remove kernel version checks
Greg Kroah-Hartman [Mon, 23 Mar 2009 20:07:51 +0000 (13:07 -0700)] 
Staging: epl: remove kernel version checks

They are no longer needed now that we are in the kernel.

Cc: Daniel Krueger <daniel.krueger@systec-electronic.com>
Cc: Ronald Sieber <Ronald.Sieber@systec-electronic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: epl: clean up demo_main.c
Greg Kroah-Hartman [Mon, 23 Mar 2009 20:05:08 +0000 (13:05 -0700)] 
Staging: epl: clean up demo_main.c

Fix some static symbols and drop the kernel version checks.

Also comment out the init and exit functions, as they don't get used
anymore.

Cc: Daniel Krueger <daniel.krueger@systec-electronic.com>
Cc: Ronald Sieber <Ronald.Sieber@systec-electronic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: epl: fix up some non-ANSI functions
Greg Kroah-Hartman [Mon, 23 Mar 2009 20:01:08 +0000 (13:01 -0700)] 
Staging: epl: fix up some non-ANSI functions

() isn't valid, you need to put (void).

Cc: Daniel Krueger <daniel.krueger@systec-electronic.com>
Cc: Ronald Sieber <Ronald.Sieber@systec-electronic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: epl: remove WORD
Greg Kroah-Hartman [Mon, 23 Mar 2009 19:57:39 +0000 (12:57 -0700)] 
Staging: epl: remove WORD

It's u16 in kernelspace, not WORD.

Cc: Daniel Krueger <daniel.krueger@systec-electronic.com>
Cc: Ronald Sieber <Ronald.Sieber@systec-electronic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: epl: remove DWORD
Greg Kroah-Hartman [Mon, 23 Mar 2009 19:51:37 +0000 (12:51 -0700)] 
Staging: epl: remove DWORD

It's u32 in kernelspace, not DWORD.

Cc: Daniel Krueger <daniel.krueger@systec-electronic.com>
Cc: Ronald Sieber <Ronald.Sieber@systec-electronic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: epl: remove QWORD
Greg Kroah-Hartman [Mon, 23 Mar 2009 19:43:05 +0000 (12:43 -0700)] 
Staging: epl: remove QWORD

It's u64 in kernelspace, not QWORD.

Cc: Daniel Krueger <daniel.krueger@systec-electronic.com>
Cc: Ronald Sieber <Ronald.Sieber@systec-electronic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: epl: remove BYTE
Greg Kroah-Hartman [Mon, 23 Mar 2009 19:36:38 +0000 (12:36 -0700)] 
Staging: epl: remove BYTE

It's u8 in kernelspace, not BYTE.

Cc: Daniel Krueger <daniel.krueger@systec-electronic.com>
Cc: Ronald Sieber <Ronald.Sieber@systec-electronic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: epl: delete EdrvFec5282.h
Greg Kroah-Hartman [Mon, 23 Mar 2009 19:30:36 +0000 (12:30 -0700)] 
Staging: epl: delete EdrvFec5282.h

No one is using it.

Cc: Daniel Krueger <daniel.krueger@systec-electronic.com>
Cc: Ronald Sieber <Ronald.Sieber@systec-electronic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: epl: remove CONST
Greg Kroah-Hartman [Mon, 23 Mar 2009 19:24:46 +0000 (12:24 -0700)] 
Staging: epl: remove CONST

Just make it const

Cc: Daniel Krueger <daniel.krueger@systec-electronic.com>
Cc: Ronald Sieber <Ronald.Sieber@systec-electronic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: epl: remove some unused types
Greg Kroah-Hartman [Mon, 23 Mar 2009 19:21:08 +0000 (12:21 -0700)] 
Staging: epl: remove some unused types

SHORT, USHORT, INT, UINT, LONG, and ULONG aren't used, so delete them.

Cc: Daniel Krueger <daniel.krueger@systec-electronic.com>
Cc: Ronald Sieber <Ronald.Sieber@systec-electronic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: epl: remove compiler warning from SharedBuff.c
Greg Kroah-Hartman [Mon, 23 Mar 2009 19:12:46 +0000 (12:12 -0700)] 
Staging: epl: remove compiler warning from SharedBuff.c

Yeah, it's a buffer, but this sure can't hurt as it's not easy to unwind
where it's coming from.

Cc: Daniel Krueger <daniel.krueger@systec-electronic.com>
Cc: Ronald Sieber <Ronald.Sieber@systec-electronic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: epl: remove REENTRANT
Greg Kroah-Hartman [Mon, 23 Mar 2009 19:10:47 +0000 (12:10 -0700)] 
Staging: epl: remove REENTRANT

It's not used and is not needed.

Cc: Daniel Krueger <daniel.krueger@systec-electronic.com>
Cc: Ronald Sieber <Ronald.Sieber@systec-electronic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: epl: remove MEM
Greg Kroah-Hartman [Mon, 23 Mar 2009 19:09:26 +0000 (12:09 -0700)] 
Staging: epl: remove MEM

It's not used and is not needed.

Cc: Daniel Krueger <daniel.krueger@systec-electronic.com>
Cc: Ronald Sieber <Ronald.Sieber@systec-electronic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: epl: remove ROM
Greg Kroah-Hartman [Mon, 23 Mar 2009 18:48:19 +0000 (11:48 -0700)] 
Staging: epl: remove ROM

It's not used and is not needed.

Cc: Daniel Krueger <daniel.krueger@systec-electronic.com>
Cc: Ronald Sieber <Ronald.Sieber@systec-electronic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: epl: remove FAR
Greg Kroah-Hartman [Mon, 23 Mar 2009 18:44:31 +0000 (11:44 -0700)] 
Staging: epl: remove FAR

It's not used and is not needed.

Cc: Daniel Krueger <daniel.krueger@systec-electronic.com>
Cc: Ronald Sieber <Ronald.Sieber@systec-electronic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: epl: remove NEAR
Greg Kroah-Hartman [Mon, 23 Mar 2009 18:39:15 +0000 (11:39 -0700)] 
Staging: epl: remove NEAR

It wasn't used and isn't needed.

Cc: Daniel Krueger <daniel.krueger@systec-electronic.com>
Cc: Ronald Sieber <Ronald.Sieber@systec-electronic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: epl: remove GENERIC
Greg Kroah-Hartman [Mon, 23 Mar 2009 18:37:22 +0000 (11:37 -0700)] 
Staging: epl: remove GENERIC

It wasn't used and isn't needed.

Cc: Daniel Krueger <daniel.krueger@systec-electronic.com>
Cc: Ronald Sieber <Ronald.Sieber@systec-electronic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: epl: remove EplObjDef.h
Greg Kroah-Hartman [Mon, 23 Mar 2009 18:34:49 +0000 (11:34 -0700)] 
Staging: epl: remove EplObjDef.h

No one was using it, so delete it.

Cc: Daniel Krueger <daniel.krueger@systec-electronic.com>
Cc: Ronald Sieber <Ronald.Sieber@systec-electronic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: epl: unwind rest of _LINUX_ #ifdefs
Greg Kroah-Hartman [Mon, 23 Mar 2009 18:33:12 +0000 (11:33 -0700)] 
Staging: epl: unwind rest of _LINUX_ #ifdefs

All the non-Linux #defines are now resolved, so remove
the board/system type defines as they are not needed anymore.

Cc: Daniel Krueger <daniel.krueger@systec-electronic.com>
Cc: Ronald Sieber <Ronald.Sieber@systec-electronic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: epl: remove __KERNEL__ checks
Greg Kroah-Hartman [Mon, 23 Mar 2009 18:19:28 +0000 (11:19 -0700)] 
Staging: epl: remove __KERNEL__ checks

We are in the kernel, so these checks are pointless.

Cc: Daniel Krueger <daniel.krueger@systec-electronic.com>
Cc: Ronald Sieber <Ronald.Sieber@systec-electronic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: epl: remove INLINE mess
Greg Kroah-Hartman [Mon, 23 Mar 2009 18:14:48 +0000 (11:14 -0700)] 
Staging: epl: remove INLINE mess

extern inline isn't the nicest and it doesn't really make sense.
So unwind all the INLINE defines and includes, if speed is _really_ an
issue later stuff can be put back in a sane manner.

Cc: Daniel Krueger <daniel.krueger@systec-electronic.com>
Cc: Ronald Sieber <Ronald.Sieber@systec-electronic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: epl: remove _WIN_32_ and _NO_OS_ defines
Greg Kroah-Hartman [Mon, 23 Mar 2009 17:54:14 +0000 (10:54 -0700)] 
Staging: epl: remove _WIN_32_ and _NO_OS_ defines

They are not used.

Also remove the code that was looking for them.

Cc: Daniel Krueger <daniel.krueger@systec-electronic.com>
Cc: Ronald Sieber <Ronald.Sieber@systec-electronic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: epl: remove PUBLIC definition
Greg Kroah-Hartman [Mon, 23 Mar 2009 17:45:12 +0000 (10:45 -0700)] 
Staging: epl: remove PUBLIC definition

It doesn't make sense here, so delete it.

Cc: Daniel Krueger <daniel.krueger@systec-electronic.com>
Cc: Ronald Sieber <Ronald.Sieber@systec-electronic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: epl: remove NULL from global.h
Greg Kroah-Hartman [Mon, 23 Mar 2009 16:33:20 +0000 (09:33 -0700)] 
Staging: epl: remove NULL from global.h

Don't define something that is already defined in the kernel.

Cc: Daniel Krueger <daniel.krueger@systec-electronic.com>
Cc: Ronald Sieber <Ronald.Sieber@systec-electronic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: epl: remove complier macros from global.h
Greg Kroah-Hartman [Mon, 23 Mar 2009 16:31:01 +0000 (09:31 -0700)] 
Staging: epl: remove complier macros from global.h

As we are only building within the Linux kernel, remove all of the
different system types from global.h, they are not needed at all.

First step of many to clean up the code to match the kernel coding
style rules.

Cc: Daniel Krueger <daniel.krueger@systec-electronic.com>
Cc: Ronald Sieber <Ronald.Sieber@systec-electronic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: epl: remove unneeded files
Greg Kroah-Hartman [Mon, 23 Mar 2009 16:12:08 +0000 (09:12 -0700)] 
Staging: epl: remove unneeded files

There were 3 .c files that was not used in the drivers/staging/epl/
directory.  This patch removes these unused files.

Cc: Daniel Krueger <daniel.krueger@systec-electronic.com>
Cc: Ronald Sieber <Ronald.Sieber@systec-electronic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: comedi: fix 64bit build errors
Greg Kroah-Hartman [Sat, 21 Mar 2009 04:34:38 +0000 (21:34 -0700)] 
Staging: comedi: fix 64bit build errors

This patch fixes the 64bit build errors in the comedi code.

Reported-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Alessio Igor Bogani <abogani@texware.it>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: comedi: Remove CHAR, *PCHAR, and *PCSTR typedefs in addi-data
Bill Pemberton [Thu, 19 Mar 2009 22:00:52 +0000 (18:00 -0400)] 
Staging: comedi: Remove CHAR, *PCHAR, and *PCSTR typedefs in addi-data

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: comedi: Remove use of VOID typedef in addi-data
Bill Pemberton [Thu, 19 Mar 2009 22:00:47 +0000 (18:00 -0400)] 
Staging: comedi: Remove use of VOID typedef in addi-data

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: comedi: Remove me4000_info_t typedef
Bill Pemberton [Thu, 19 Mar 2009 22:00:42 +0000 (18:00 -0400)] 
Staging: comedi: Remove me4000_info_t typedef

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: comedi: Remove me4000_cnt_context_t typedef
Bill Pemberton [Thu, 19 Mar 2009 22:00:37 +0000 (18:00 -0400)] 
Staging: comedi: Remove me4000_cnt_context_t typedef

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: comedi: Remove me4000_dio_context_t typedef
Bill Pemberton [Thu, 19 Mar 2009 22:00:31 +0000 (18:00 -0400)] 
Staging: comedi: Remove me4000_dio_context_t typedef

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: comedi: Remove me4000_ai_context_t typedef
Bill Pemberton [Thu, 19 Mar 2009 22:00:26 +0000 (18:00 -0400)] 
Staging: comedi: Remove me4000_ai_context_t typedef

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: comedi: Remove me4000_ao_context_t typedef
Bill Pemberton [Thu, 19 Mar 2009 22:00:21 +0000 (18:00 -0400)] 
Staging: comedi: Remove me4000_ao_context_t typedef

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: comedi: Remove me4000_board_t typedef
Bill Pemberton [Thu, 19 Mar 2009 22:00:16 +0000 (18:00 -0400)] 
Staging: comedi: Remove me4000_board_t typedef

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: comedi: Remove me4000_cnt_info_t typedef
Bill Pemberton [Thu, 19 Mar 2009 22:00:10 +0000 (18:00 -0400)] 
Staging: comedi: Remove me4000_cnt_info_t typedef

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: comedi: Remove me4000_dio_info_t typedef
Bill Pemberton [Thu, 19 Mar 2009 22:00:05 +0000 (18:00 -0400)] 
Staging: comedi: Remove me4000_dio_info_t typedef

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: comedi: Remove me4000_ai_info_t typedef
Bill Pemberton [Thu, 19 Mar 2009 22:00:00 +0000 (18:00 -0400)] 
Staging: comedi: Remove me4000_ai_info_t typedef

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: comedi: Remove me4000_ao_info_t typedef
Bill Pemberton [Thu, 19 Mar 2009 21:59:55 +0000 (17:59 -0400)] 
Staging: comedi: Remove me4000_ao_info_t typedef

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: comedi: Remove das08_board typedef
Bill Pemberton [Thu, 19 Mar 2009 21:59:49 +0000 (17:59 -0400)] 
Staging: comedi: Remove das08_board typedef

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: comedi: Remove nidio96_private typedef
Bill Pemberton [Thu, 19 Mar 2009 21:59:44 +0000 (17:59 -0400)] 
Staging: comedi: Remove nidio96_private typedef

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: comedi: ni_daq_700.c: Remove local_info_t typedef
Bill Pemberton [Thu, 19 Mar 2009 21:59:39 +0000 (17:59 -0400)] 
Staging: comedi: ni_daq_700.c: Remove local_info_t typedef

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: comedi: Remove dio700_board typedef
Bill Pemberton [Thu, 19 Mar 2009 21:59:34 +0000 (17:59 -0400)] 
Staging: comedi: Remove dio700_board typedef

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: comedi: Remove atmio16d_private typedef
Bill Pemberton [Thu, 19 Mar 2009 21:59:28 +0000 (17:59 -0400)] 
Staging: comedi: Remove atmio16d_private typedef

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: comedi: Remove atao_board typedef
Bill Pemberton [Thu, 19 Mar 2009 21:59:23 +0000 (17:59 -0400)] 
Staging: comedi: Remove atao_board typedef

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: comedi: Remove a2150_board typedef
Bill Pemberton [Thu, 19 Mar 2009 21:59:18 +0000 (17:59 -0400)] 
Staging: comedi: Remove a2150_board typedef

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: comedi: Remove ni_670x_board typedef
Bill Pemberton [Thu, 19 Mar 2009 21:59:12 +0000 (17:59 -0400)] 
Staging: comedi: Remove ni_670x_board typedef

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: comedi: Remove ni_660x_private typedef
Bill Pemberton [Thu, 19 Mar 2009 21:59:07 +0000 (17:59 -0400)] 
Staging: comedi: Remove ni_660x_private typedef

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: comedi: Remove ni_660x_board typedef
Bill Pemberton [Thu, 19 Mar 2009 21:59:02 +0000 (17:59 -0400)] 
Staging: comedi: Remove ni_660x_board typedef

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: comedi: Remove NI_660x_Register typedef
Bill Pemberton [Thu, 19 Mar 2009 21:58:57 +0000 (17:58 -0400)] 
Staging: comedi: Remove NI_660x_Register typedef

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
15 years agoStaging: comedi: Remove ni_65xx_subdevice_private typedef
Bill Pemberton [Thu, 19 Mar 2009 21:58:51 +0000 (17:58 -0400)] 
Staging: comedi: Remove ni_65xx_subdevice_private typedef

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>