wine
15 years agocomctl32/tests: Tests for LVM_GETCOLUMNORDERARRAY: it actually uses HDM_GETORDERARRAY.
Nikolay Sivov [Fri, 24 Apr 2009 10:51:43 +0000 (14:51 +0400)] 
comctl32/tests: Tests for LVM_GETCOLUMNORDERARRAY: it actually uses HDM_GETORDERARRAY.

15 years agofonts: Add Kazakhstan's symbols into tahoma.
Konstantin Kondratyuk [Fri, 24 Apr 2009 11:10:32 +0000 (15:10 +0400)] 
fonts: Add Kazakhstan's symbols into tahoma.

15 years agogdiplus/tests: Fix a test failure on Win98.
Paul Vriens [Fri, 24 Apr 2009 12:43:48 +0000 (14:43 +0200)] 
gdiplus/tests: Fix a test failure on Win98.

15 years agosetupapi/tests: Fix a test failure on Win98.
Paul Vriens [Fri, 24 Apr 2009 09:56:10 +0000 (11:56 +0200)] 
setupapi/tests: Fix a test failure on Win98.

15 years agoshell32/tests: Fix a test failure on Win98.
Paul Vriens [Fri, 24 Apr 2009 07:29:12 +0000 (09:29 +0200)] 
shell32/tests: Fix a test failure on Win98.

15 years agoshell32/tests: Fix some test failures on Win9x and NT4.
Paul Vriens [Fri, 24 Apr 2009 07:07:23 +0000 (09:07 +0200)] 
shell32/tests: Fix some test failures on Win9x and NT4.

15 years agoole32/tests: Improve the traces in the test.
Huw Davies [Fri, 24 Apr 2009 11:33:25 +0000 (12:33 +0100)] 
ole32/tests: Improve the traces in the test.

15 years agowinex11.drv: Print clipboard formats in hex.
Huw Davies [Fri, 24 Apr 2009 11:24:52 +0000 (12:24 +0100)] 
winex11.drv: Print clipboard formats in hex.

15 years agoole32: Fix a couple of comments.
Huw Davies [Fri, 24 Apr 2009 11:15:47 +0000 (12:15 +0100)] 
ole32: Fix a couple of comments.

15 years agoole32: Expose the marshalled data on the clipboard rather than as a window prop so...
Huw Davies [Fri, 24 Apr 2009 11:02:48 +0000 (12:02 +0100)] 
ole32: Expose the marshalled data on the clipboard rather than as a window prop so that other processes can actually read it.

15 years agouser32/tests: Don't try to unpack or free invalid handles.
Alexandre Julliard [Fri, 24 Apr 2009 11:38:58 +0000 (13:38 +0200)] 
user32/tests: Don't try to unpack or free invalid handles.

15 years agouser32: Fix the DDE service formatting for 64-bit.
Alexandre Julliard [Fri, 24 Apr 2009 10:48:44 +0000 (12:48 +0200)] 
user32: Fix the DDE service formatting for 64-bit.

15 years agoinclude: Fix the DDE structures for 64-bit.
Alexandre Julliard [Fri, 24 Apr 2009 11:40:39 +0000 (13:40 +0200)] 
include: Fix the DDE structures for 64-bit.

15 years agoinclude: Fix the SYSTEM_CACHE_INFORMATION structure for Win64.
Alexandre Julliard [Fri, 24 Apr 2009 10:31:03 +0000 (12:31 +0200)] 
include: Fix the SYSTEM_CACHE_INFORMATION structure for Win64.

15 years agouser32/tests: Fix a couple of dimension checks on W2k3 and Vista.
Alexandre Julliard [Fri, 24 Apr 2009 10:18:02 +0000 (12:18 +0200)] 
user32/tests: Fix a couple of dimension checks on W2k3 and Vista.

15 years agoadvapi32/tests: Fix a couple of test failures on Vista.
Alexandre Julliard [Fri, 24 Apr 2009 10:17:31 +0000 (12:17 +0200)] 
advapi32/tests: Fix a couple of test failures on Vista.

15 years agogdiplus/tests: Fix test failures on Win98 by using A-functions.
Paul Vriens [Thu, 23 Apr 2009 19:29:22 +0000 (21:29 +0200)] 
gdiplus/tests: Fix test failures on Win98 by using A-functions.

15 years agogdiplus: Convert lfFaceName from W to A, not the other way around.
Paul Vriens [Thu, 23 Apr 2009 19:24:54 +0000 (21:24 +0200)] 
gdiplus: Convert lfFaceName from W to A, not the other way around.

15 years agogdiplus: Return the correct result in GdipCreateFontFromLogfontA.
Paul Vriens [Thu, 23 Apr 2009 19:20:11 +0000 (21:20 +0200)] 
gdiplus: Return the correct result in GdipCreateFontFromLogfontA.

15 years agoinclude: Add missing GdipGetLogFontA definition.
Paul Vriens [Thu, 23 Apr 2009 19:14:45 +0000 (21:14 +0200)] 
include: Add missing GdipGetLogFontA definition.

15 years agowined3d: Use shader_sm1_read_opcode() in shader_get_registers_used().
Henri Verbeet [Fri, 24 Apr 2009 07:17:58 +0000 (09:17 +0200)] 
wined3d: Use shader_sm1_read_opcode() in shader_get_registers_used().

15 years agowined3d: Add a function to read an opcode from SM1-3 bytecode.
Henri Verbeet [Fri, 24 Apr 2009 07:17:58 +0000 (09:17 +0200)] 
wined3d: Add a function to read an opcode from SM1-3 bytecode.

15 years agowined3d: The first shader token should be the version token.
Henri Verbeet [Fri, 24 Apr 2009 07:17:58 +0000 (09:17 +0200)] 
wined3d: The first shader token should be the version token.

15 years agowined3d: Use a more reasonable limit for the number of mipmap levels.
Henri Verbeet [Fri, 24 Apr 2009 07:17:58 +0000 (09:17 +0200)] 
wined3d: Use a more reasonable limit for the number of mipmap levels.

256 is quite ridiculous, considering the dimensions are only UINTs. Perhaps
these arrays should be dynamically allocated in the first place though.

15 years agowined3d: Handle the opcode specific control shift in the frontend rather than the...
Henri Verbeet [Fri, 24 Apr 2009 07:17:58 +0000 (09:17 +0200)] 
wined3d: Handle the opcode specific control shift in the frontend rather than the backend.

15 years agorichedit: Null terminate streamed out rich text.
Dylan Smith [Fri, 24 Apr 2009 07:25:46 +0000 (03:25 -0400)] 
richedit: Null terminate streamed out rich text.

15 years agocrypt32: Fix a test failure on Windows 98.
Juan Lang [Thu, 23 Apr 2009 16:41:43 +0000 (09:41 -0700)] 
crypt32: Fix a test failure on Windows 98.

15 years agoole32: Rename a macro to prevent a conflict on NetBSD.
Austin English [Thu, 23 Apr 2009 16:17:49 +0000 (11:17 -0500)] 
ole32: Rename a macro to prevent a conflict on NetBSD.

15 years agomsctf/tests: Use ITfInputProcessorProfiles::GetCurrentLanguage to get gLangid.
Aric Stewart [Thu, 23 Apr 2009 21:35:25 +0000 (16:35 -0500)] 
msctf/tests: Use ITfInputProcessorProfiles::GetCurrentLanguage to get gLangid.

15 years agoole32: CoGetTreatAsClass should return S_FALSE if it cannot even find the key for...
Aric Stewart [Thu, 23 Apr 2009 15:19:33 +0000 (10:19 -0500)] 
ole32: CoGetTreatAsClass should return S_FALSE if it cannot even find the key for the requested CLSID.

15 years agowined3d: SetDepthStencilSurface is always called when AutoDepthStencil is enabled.
David Adam [Thu, 23 Apr 2009 06:33:21 +0000 (08:33 +0200)] 
wined3d: SetDepthStencilSurface is always called when AutoDepthStencil is enabled.

15 years agowinedbg: Correct slight typo in winedbg dialog.
Ken Sharp [Fri, 24 Apr 2009 00:39:42 +0000 (01:39 +0100)] 
winedbg: Correct slight typo in winedbg dialog.

15 years agocomctl32: Repaint comboex control upon WM_SETREDRAW, like other common controls do.
Alexandre Julliard [Thu, 23 Apr 2009 18:15:22 +0000 (20:15 +0200)] 
comctl32: Repaint comboex control upon WM_SETREDRAW, like other common controls do.

15 years agoshell32/tests: Fix a test failure on Win95 and NT4.
Paul Vriens [Thu, 23 Apr 2009 14:21:46 +0000 (16:21 +0200)] 
shell32/tests: Fix a test failure on Win95 and NT4.

15 years agogdi32/tests: Fix a test failure on NT4.
Paul Vriens [Thu, 23 Apr 2009 14:07:25 +0000 (16:07 +0200)] 
gdi32/tests: Fix a test failure on NT4.

15 years agowined3d: Avoid using an implicit value to set fogcoord to 0.0.
Francois Gouget [Thu, 23 Apr 2009 14:03:12 +0000 (16:03 +0200)] 
wined3d: Avoid using an implicit value to set fogcoord to 0.0.

15 years agoole32: Rewrite OleQueryCreateFromData so it compares clipboard format ids rather...
Huw Davies [Thu, 23 Apr 2009 10:52:22 +0000 (11:52 +0100)] 
ole32: Rewrite OleQueryCreateFromData so it compares clipboard format ids rather than strings and be sure to free the enumerator.

15 years agoole32: Register a few more clipboard formats and make them have global scope.
Huw Davies [Thu, 23 Apr 2009 14:04:56 +0000 (15:04 +0100)] 
ole32: Register a few more clipboard formats and make them have global scope.

15 years agoole32: Add a stub for OleCreateFromDataEx.
Huw Davies [Thu, 23 Apr 2009 13:09:15 +0000 (14:09 +0100)] 
ole32: Add a stub for OleCreateFromDataEx.

15 years agomsctf/tests: Test framework for ITfKeyEventSink.
Aric Stewart [Wed, 22 Apr 2009 17:37:57 +0000 (12:37 -0500)] 
msctf/tests: Test framework for ITfKeyEventSink.

15 years agomsctf/tests: Test ITfKeystrokeMgr::IsPreservedKey.
Aric Stewart [Wed, 22 Apr 2009 17:37:55 +0000 (12:37 -0500)] 
msctf/tests: Test ITfKeystrokeMgr::IsPreservedKey.

15 years agomsctf/tests: Test ITfKeystrokeMgr::UnpreserveKey and ITfKeystrokeMgr::PreserveKey.
Aric Stewart [Wed, 22 Apr 2009 17:37:53 +0000 (12:37 -0500)] 
msctf/tests: Test ITfKeystrokeMgr::UnpreserveKey and ITfKeystrokeMgr::PreserveKey.

15 years agomsctf/tests: Framework for testing ITfKeystrokeMgr.
Aric Stewart [Wed, 22 Apr 2009 17:37:51 +0000 (12:37 -0500)] 
msctf/tests: Framework for testing ITfKeystrokeMgr.

15 years agomsctf: Define the TF_MOD_* Constants.
Aric Stewart [Wed, 22 Apr 2009 17:37:47 +0000 (12:37 -0500)] 
msctf: Define the TF_MOD_* Constants.

15 years agomsctf: Define ITfKeyEventSink.
Aric Stewart [Wed, 22 Apr 2009 17:37:45 +0000 (12:37 -0500)] 
msctf: Define ITfKeyEventSink.

15 years agomsctf: Add ITfKeystrokeMgr framework to ThreadMgr.
Aric Stewart [Wed, 22 Apr 2009 17:37:43 +0000 (12:37 -0500)] 
msctf: Add ITfKeystrokeMgr framework to ThreadMgr.

15 years agoshell32/tests: Fix some test failures on NT4.
Paul Vriens [Wed, 22 Apr 2009 15:07:45 +0000 (17:07 +0200)] 
shell32/tests: Fix some test failures on NT4.

15 years agokernel32: Improve GetVolumePathName stub.
Hans Leidekker [Wed, 22 Apr 2009 10:47:06 +0000 (12:47 +0200)] 
kernel32: Improve GetVolumePathName stub.

15 years agomsctf: Make use of generated cookies in sinks to allow 64 bit compatibility.
Aric Stewart [Wed, 22 Apr 2009 16:14:19 +0000 (11:14 -0500)] 
msctf: Make use of generated cookies in sinks to allow 64 bit compatibility.

15 years agowinemaker: Remove unused function.
André Hentschel [Wed, 22 Apr 2009 16:37:00 +0000 (18:37 +0200)] 
winemaker: Remove unused function.

15 years agocomctl32/tests: Existing items aren't resorted after LVS_SORTASCENDING added.
Nikolay Sivov [Thu, 23 Apr 2009 12:10:49 +0000 (16:10 +0400)] 
comctl32/tests: Existing items aren't resorted after LVS_SORTASCENDING added.

15 years agoinclude: Add defines for 32-bit dbghelp functions on 64-bit.
Alexandre Julliard [Thu, 23 Apr 2009 12:24:45 +0000 (14:24 +0200)] 
include: Add defines for 32-bit dbghelp functions on 64-bit.

15 years agomsi/tests: Fix package test when run on a different drive than C:\.
Nicolas Le Cam [Tue, 21 Apr 2009 00:38:23 +0000 (02:38 +0200)] 
msi/tests: Fix package test when run on a different drive than C:\.

15 years agomsi: Fix ACTION_AppSearchDr on empty path.
Nicolas Le Cam [Tue, 21 Apr 2009 00:11:23 +0000 (02:11 +0200)] 
msi: Fix ACTION_AppSearchDr on empty path.

15 years agomsi/tests: Add empty dir test for the DrLocator part of the AppSearch action.
Nicolas Le Cam [Tue, 21 Apr 2009 00:09:24 +0000 (02:09 +0200)] 
msi/tests: Add empty dir test for the DrLocator part of the AppSearch action.

15 years agomsi: Enfore use of GetFileAttributes return value.
Nicolas Le Cam [Tue, 21 Apr 2009 00:08:31 +0000 (02:08 +0200)] 
msi: Enfore use of GetFileAttributes return value.

15 years agoole32/tests: For win9x and winme the size of the data on the clipboard may be larger...
Huw Davies [Thu, 23 Apr 2009 09:52:16 +0000 (10:52 +0100)] 
ole32/tests: For win9x and winme the size of the data on the clipboard may be larger than expected.

15 years agocomctl32/tests: Remove tests failing on most platforms.
Nikolay Sivov [Thu, 23 Apr 2009 07:51:41 +0000 (11:51 +0400)] 
comctl32/tests: Remove tests failing on most platforms.

15 years agowined3d: Get rid of the shared_handle parameter.
Henri Verbeet [Thu, 23 Apr 2009 07:24:27 +0000 (09:24 +0200)] 
wined3d: Get rid of the shared_handle parameter.

I don't expect us to support this in the near future, and right now it's just
dead code.

15 years agowined3d: Downgrade an ERR to a WARN.
Henri Verbeet [Thu, 23 Apr 2009 07:24:26 +0000 (09:24 +0200)] 
wined3d: Downgrade an ERR to a WARN.

15 years agowined3d: Move frontend specfic constants to baseshader.c.
Henri Verbeet [Thu, 23 Apr 2009 07:24:26 +0000 (09:24 +0200)] 
wined3d: Move frontend specfic constants to baseshader.c.

15 years agowined3d: Move some frontend specfic code to baseshader.c.
Henri Verbeet [Thu, 23 Apr 2009 07:24:26 +0000 (09:24 +0200)] 
wined3d: Move some frontend specfic code to baseshader.c.

15 years agowined3d: Handle the destination modifier shift in the frontend rather than the backend.
Henri Verbeet [Thu, 23 Apr 2009 07:24:26 +0000 (09:24 +0200)] 
wined3d: Handle the destination modifier shift in the frontend rather than the backend.

15 years agocmd: Updated Polish translations.
Łukasz Wojniłowicz [Wed, 22 Apr 2009 07:12:53 +0000 (09:12 +0200)] 
cmd: Updated Polish translations.

15 years agokernel32: Added Polish translations.
Łukasz Wojniłowicz [Tue, 21 Apr 2009 20:41:54 +0000 (22:41 +0200)] 
kernel32: Added Polish translations.

15 years agocomdlg32: Fix a crash in LookIn combo box WM_COMMAND message handler.
Rein Klazes [Thu, 23 Apr 2009 06:25:13 +0000 (08:25 +0200)] 
comdlg32: Fix a crash in LookIn combo box WM_COMMAND message handler.

15 years agomciqtz32: Stop the device only after param and device checks are done.
Christian Costa [Wed, 22 Apr 2009 22:04:04 +0000 (00:04 +0200)] 
mciqtz32: Stop the device only after param and device checks are done.

15 years agomciqtz32: Make sure the device is valid before starting the play.
Christian Costa [Wed, 22 Apr 2009 22:03:58 +0000 (00:03 +0200)] 
mciqtz32: Make sure the device is valid before starting the play.

15 years agomciqtz32: Move MCIQTZ_mciGetOpenDev at the top and always use it.
Christian Costa [Wed, 22 Apr 2009 22:03:52 +0000 (00:03 +0200)] 
mciqtz32: Move MCIQTZ_mciGetOpenDev at the top and always use it.

15 years agomshtml: Fix the size passed to MultiByteToWideChar.
Colin Finck [Wed, 22 Apr 2009 19:31:48 +0000 (21:31 +0200)] 
mshtml: Fix the size passed to MultiByteToWideChar.

15 years agowinex11.drv: Don't give focus to a minimized window upon take focus.
Alexandre Julliard [Thu, 23 Apr 2009 10:41:57 +0000 (12:41 +0200)] 
winex11.drv: Don't give focus to a minimized window upon take focus.

15 years agoimagehlp: Forward some more 64-bit functions to dbghelp.
Alexandre Julliard [Thu, 23 Apr 2009 10:41:42 +0000 (12:41 +0200)] 
imagehlp: Forward some more 64-bit functions to dbghelp.

15 years agodbghelp: Add a few more 64-bit symbol functions.
Alexandre Julliard [Thu, 23 Apr 2009 10:41:29 +0000 (12:41 +0200)] 
dbghelp: Add a few more 64-bit symbol functions.

15 years agoole32/tests: Rename variable to avoid a conflict on some systems.
Huw Davies [Wed, 22 Apr 2009 14:48:21 +0000 (15:48 +0100)] 
ole32/tests: Rename variable to avoid a conflict on some systems.

15 years agoole32: Improve the TRACEs by printing the fmtetc contents.
Huw Davies [Wed, 22 Apr 2009 14:26:04 +0000 (15:26 +0100)] 
ole32: Improve the TRACEs by printing the fmtetc contents.

15 years agocomctl32/toolbar: Fix trace info for TOOLBAR_InternalInsertButtonsT.
Giuseppe Bilotta [Wed, 22 Apr 2009 11:31:09 +0000 (13:31 +0200)] 
comctl32/toolbar: Fix trace info for TOOLBAR_InternalInsertButtonsT.

15 years agowinedbg: Add a crash dialog for --auto mode.
Mikołaj Zalewski [Sun, 21 Dec 2008 21:28:32 +0000 (22:28 +0100)] 
winedbg: Add a crash dialog for --auto mode.

15 years agokernel32: Make sure the string is properly terminated in QueryFullProcessImageNameW.
Alexandre Julliard [Wed, 22 Apr 2009 14:54:16 +0000 (16:54 +0200)] 
kernel32: Make sure the string is properly terminated in QueryFullProcessImageNameW.

15 years agoinclude: Bring in6_addr into line with the MS definition.
Jeff Latimer [Wed, 22 Apr 2009 13:09:14 +0000 (23:09 +1000)] 
include: Bring in6_addr into line with the MS definition.

15 years agows2_32/tests: Avoid sizeof in traces.
Alexandre Julliard [Wed, 22 Apr 2009 13:25:50 +0000 (15:25 +0200)] 
ws2_32/tests: Avoid sizeof in traces.

15 years agojscript: Avoid size_t in printf width specifier.
Alexandre Julliard [Wed, 22 Apr 2009 13:25:35 +0000 (15:25 +0200)] 
jscript: Avoid size_t in printf width specifier.

15 years agoole32/tests: Add some tests to exercise the enumerator.
Huw Davies [Wed, 22 Apr 2009 10:45:36 +0000 (11:45 +0100)] 
ole32/tests: Add some tests to exercise the enumerator.

15 years agoole32/tests: win9x and winme don't enumerate duplicated cfFormats.
Huw Davies [Wed, 22 Apr 2009 09:47:28 +0000 (10:47 +0100)] 
ole32/tests: win9x and winme don't enumerate duplicated cfFormats.

15 years agoole32/tests: win64 sets the lsb of the final DWORD in the ole private data header.
Huw Davies [Wed, 22 Apr 2009 09:34:04 +0000 (10:34 +0100)] 
ole32/tests: win64 sets the lsb of the final DWORD in the ole private data header.

15 years agoole32/tests: win9x and winme don't have CF_UNICODETEXT.
Huw Davies [Wed, 22 Apr 2009 09:25:59 +0000 (10:25 +0100)] 
ole32/tests: win9x and winme don't have CF_UNICODETEXT.

15 years agoole32/tests: win9x, winme and nt4 ignore the target device.
Huw Davies [Tue, 21 Apr 2009 15:50:58 +0000 (16:50 +0100)] 
ole32/tests: win9x, winme and nt4 ignore the target device.

15 years agoole32/tests: OleGetClipboard doesn't return the same object under win9x, winme and...
Huw Davies [Tue, 21 Apr 2009 15:47:28 +0000 (16:47 +0100)] 
ole32/tests: OleGetClipboard doesn't return the same object under win9x, winme and nt4.

15 years agowinemaker: Parse include dirs from vcproj file.
André Hentschel [Tue, 21 Apr 2009 18:32:52 +0000 (20:32 +0200)] 
winemaker: Parse include dirs from vcproj file.

15 years agowinemaker: Fix wrong place for case-check.
André Hentschel [Tue, 21 Apr 2009 18:32:41 +0000 (20:32 +0200)] 
winemaker: Fix wrong place for case-check.

15 years agowinemaker: Fix whitespace handling for libs.
André Hentschel [Tue, 21 Apr 2009 18:32:34 +0000 (20:32 +0200)] 
winemaker: Fix whitespace handling for libs.

15 years agoconfigure: Remove checks for headers that are no longer used.
Alexandre Julliard [Wed, 22 Apr 2009 12:41:49 +0000 (14:41 +0200)] 
configure: Remove checks for headers that are no longer used.

15 years agocomctl32/listview: Partial fix for LVM_GETSUBITEMRECT for item == -1.
Nikolay Sivov [Wed, 22 Apr 2009 17:51:02 +0000 (13:51 -0400)] 
comctl32/listview: Partial fix for LVM_GETSUBITEMRECT for item == -1.

15 years agocomctl32/listview: Additional tests for LVM_GETSUBITEMRECT.
Nikolay Sivov [Wed, 22 Apr 2009 17:05:56 +0000 (13:05 -0400)] 
comctl32/listview: Additional tests for LVM_GETSUBITEMRECT.

15 years agowined3d: Handle the source modifier shift in the frontend rather than the backend.
Henri Verbeet [Wed, 22 Apr 2009 08:48:34 +0000 (10:48 +0200)] 
wined3d: Handle the source modifier shift in the frontend rather than the backend.

15 years agowined3d: Handle the swizzle shift in the frontend rather than the backend.
Henri Verbeet [Wed, 22 Apr 2009 08:48:34 +0000 (10:48 +0200)] 
wined3d: Handle the swizzle shift in the frontend rather than the backend.

15 years agowined3d: Get rid of the WINED3DVS_* swizzle constants.
Henri Verbeet [Wed, 22 Apr 2009 08:48:34 +0000 (10:48 +0200)] 
wined3d: Get rid of the WINED3DVS_* swizzle constants.

They're redundant.

15 years agowined3d: Get rid of the token field from struct wined3d_shader_src_param.
Henri Verbeet [Wed, 22 Apr 2009 08:48:33 +0000 (10:48 +0200)] 
wined3d: Get rid of the token field from struct wined3d_shader_src_param.

15 years agowined3d: Pass a struct wined3d_shader_src_param to shader_arb_get_swizzle().
Henri Verbeet [Wed, 22 Apr 2009 08:48:33 +0000 (10:48 +0200)] 
wined3d: Pass a struct wined3d_shader_src_param to shader_arb_get_swizzle().

15 years agouser32/tests: Don't use the long type.
Michael Stefaniuc [Wed, 22 Apr 2009 08:25:30 +0000 (10:25 +0200)] 
user32/tests: Don't use the long type.

15 years agoamstream/tests: Handle directdraw not being created (Coverity 920).
Marcus Meissner [Wed, 22 Apr 2009 08:22:05 +0000 (10:22 +0200)] 
amstream/tests: Handle directdraw not being created (Coverity 920).