wine
22 years agoImplemented GetDateFormatW.
Steve Lustbader [Thu, 3 Oct 2002 22:57:55 +0000 (22:57 +0000)] 
Implemented GetDateFormatW.

22 years agoAdded UuidCreateNil, UuidEqual and UuidIsNil.
Ove Kaaven [Thu, 3 Oct 2002 22:51:49 +0000 (22:51 +0000)] 
Added UuidCreateNil, UuidEqual and UuidIsNil.

22 years agoAdded process_id_t and thread_it_t types to the server interface
Alexandre Julliard [Thu, 3 Oct 2002 19:54:57 +0000 (19:54 +0000)] 
Added process_id_t and thread_it_t types to the server interface
instead of using void*, and removed a number of type casts.

22 years agoMoved CreateBrushIndirect16 and CreateDIBPatternBrush16 to gdi16.c.
Alexandre Julliard [Thu, 3 Oct 2002 19:48:59 +0000 (19:48 +0000)] 
Moved CreateBrushIndirect16 and CreateDIBPatternBrush16 to gdi16.c.

22 years agoRemoved LPxxx handle types that don't exist under Windows.
Alexandre Julliard [Thu, 3 Oct 2002 19:46:27 +0000 (19:46 +0000)] 
Removed LPxxx handle types that don't exist under Windows.

22 years agoRemoved error message that confuses users.
Alexandre Julliard [Thu, 3 Oct 2002 19:43:10 +0000 (19:43 +0000)] 
Removed error message that confuses users.

22 years agoBuild tests with -DSTRICT.
Alexandre Julliard [Thu, 3 Oct 2002 19:42:45 +0000 (19:42 +0000)] 
Build tests with -DSTRICT.

22 years ago- Reorganize DrawItem.
Dimitrie O. Paun [Wed, 2 Oct 2002 23:53:04 +0000 (23:53 +0000)] 
- Reorganize DrawItem.
- Unify text attribute selection between Draw{Sub,}Item.
- Usual cleanups, and simplifications.

22 years agoAdded support for multiple object namespaces, and a bunch functions
Alexandre Julliard [Wed, 2 Oct 2002 23:49:30 +0000 (23:49 +0000)] 
Added support for multiple object namespaces, and a bunch functions
for managing linked lists.

22 years agoFixed GDI heap selector handling broken by previous change.
Alexandre Julliard [Wed, 2 Oct 2002 23:47:14 +0000 (23:47 +0000)] 
Fixed GDI heap selector handling broken by previous change.

22 years agoUse the new Subclassing API.
György 'Nog' Jeney [Wed, 2 Oct 2002 23:46:20 +0000 (23:46 +0000)] 
Use the new Subclassing API.

22 years agoFancy/optimized EnsureVisible method that eliminates flicker.
Dimitrie O. Paun [Wed, 2 Oct 2002 23:45:50 +0000 (23:45 +0000)] 
Fancy/optimized EnsureVisible method that eliminates flicker.
Minor cleanups.

22 years agoImplemented {G|S}etWindowSubClass, DefSubclassProc,
György 'Nog' Jeney [Wed, 2 Oct 2002 20:01:01 +0000 (20:01 +0000)] 
Implemented {G|S}etWindowSubClass, DefSubclassProc,
RemoveWindowSubclass.

22 years ago- Fix the subitem drawing code.
Dimitrie O. Paun [Wed, 2 Oct 2002 19:59:55 +0000 (19:59 +0000)] 
- Fix the subitem drawing code.
- A lot faster drawing in report mode.
- A great deal of cleanup, and simplifications.

22 years agoAdded some more autogenerated tests.
Patrik Stridvall [Wed, 2 Oct 2002 19:58:27 +0000 (19:58 +0000)] 
Added some more autogenerated tests.

22 years ago- Minor improvements.
Patrik Stridvall [Wed, 2 Oct 2002 19:54:14 +0000 (19:54 +0000)] 
- Minor improvements.
- Added tests for GDI and USER.

22 years agoAdded a couple of defines.
György 'Nog' Jeney [Wed, 2 Oct 2002 19:46:45 +0000 (19:46 +0000)] 
Added a couple of defines.

22 years agoFix Validate{Rect,Rgn} prototypes.
Dimitrie O. Paun [Wed, 2 Oct 2002 19:45:48 +0000 (19:45 +0000)] 
Fix Validate{Rect,Rgn} prototypes.

22 years agoPreliminary support for dumping NE binaries.
Alexandre Julliard [Wed, 2 Oct 2002 18:50:09 +0000 (18:50 +0000)] 
Preliminary support for dumping NE binaries.

22 years ago- Fix the state icon handling.
Dimitrie O. Paun [Wed, 2 Oct 2002 18:38:11 +0000 (18:38 +0000)] 
- Fix the state icon handling.
- Fix handling of new image lists.
- Small cleanups.

22 years agoexcept_handler3: Set correct %ebp when calling exception filter.
Alexandre Julliard [Wed, 2 Oct 2002 18:34:58 +0000 (18:34 +0000)] 
except_handler3: Set correct %ebp when calling exception filter.

22 years agoEnable anti-aliasing for all font sizes.
Alexandre Julliard [Wed, 2 Oct 2002 18:33:53 +0000 (18:33 +0000)] 
Enable anti-aliasing for all font sizes.

22 years agoCreateDC: handle (nil, <string>, ...) gracefully if no driver found.
Greg Turner [Wed, 2 Oct 2002 18:33:21 +0000 (18:33 +0000)] 
CreateDC: handle (nil, <string>, ...) gracefully if no driver found.

22 years ago- Rework the {Insert,Delete}Column functions.
Dimitrie O. Paun [Wed, 2 Oct 2002 18:32:08 +0000 (18:32 +0000)] 
- Rework the {Insert,Delete}Column functions.
- Drawing optimizations when adding/removing columns.
- More cleanups, and simplifications.

22 years agoMake sure things still work if 16-bit dlls cannot be loaded.
Alexandre Julliard [Wed, 2 Oct 2002 02:36:20 +0000 (02:36 +0000)] 
Make sure things still work if 16-bit dlls cannot be loaded.

22 years agoAdded --disable-win16 configure option.
Alexandre Julliard [Wed, 2 Oct 2002 02:34:09 +0000 (02:34 +0000)] 
Added --disable-win16 configure option.

22 years agoFixed warnings.
Alexandre Julliard [Wed, 2 Oct 2002 01:34:17 +0000 (01:34 +0000)] 
Fixed warnings.

22 years agoAdded EUC-JP encoding as codepage 20932 (with the help of Aric
Alexandre Julliard [Wed, 2 Oct 2002 01:29:22 +0000 (01:29 +0000)] 
Added EUC-JP encoding as codepage 20932 (with the help of Aric
Stewart).

22 years agoFixed some issues found by winapi_check.
Patrik Stridvall [Wed, 2 Oct 2002 01:24:27 +0000 (01:24 +0000)] 
Fixed some issues found by winapi_check.

22 years ago- API file update.
Patrik Stridvall [Wed, 2 Oct 2002 01:23:55 +0000 (01:23 +0000)] 
- API file update.
- Minor bug fixes.

22 years agoAdded some more useful macros.
Patrik Stridvall [Wed, 2 Oct 2002 01:23:33 +0000 (01:23 +0000)] 
Added some more useful macros.

22 years agoMoved X flags and libraries out of Make.rules into the makefiles that
Alexandre Julliard [Tue, 1 Oct 2002 18:16:19 +0000 (18:16 +0000)] 
Moved X flags and libraries out of Make.rules into the makefiles that
need them.

22 years agoUse correct 16-bit resources to avoid warnings.
Alexandre Julliard [Tue, 1 Oct 2002 18:14:04 +0000 (18:14 +0000)] 
Use correct 16-bit resources to avoid warnings.

22 years agoUpdate documentation of how to invoke winedbg.
Francois Gouget [Tue, 1 Oct 2002 18:13:09 +0000 (18:13 +0000)] 
Update documentation of how to invoke winedbg.

22 years agoAdded new autogenerated test for data structure packing.
Patrik Stridvall [Tue, 1 Oct 2002 18:11:47 +0000 (18:11 +0000)] 
Added new autogenerated test for data structure packing.

22 years ago- Added a new tool winapi_test for generating tests.
Patrik Stridvall [Tue, 1 Oct 2002 18:10:54 +0000 (18:10 +0000)] 
- Added a new tool winapi_test for generating tests.
- Added a data structure packing test to winapi_test.
- Reorganized and optimized a few things.

22 years agoAdded a GNU C implementation of some of the DECLSPEC_ macros and used
Patrik Stridvall [Tue, 1 Oct 2002 18:07:37 +0000 (18:07 +0000)] 
Added a GNU C implementation of some of the DECLSPEC_ macros and used
them wherever possible.

22 years ago- Fix LIST mode, broken by previous changes.
Dimitrie O. Paun [Tue, 1 Oct 2002 18:06:15 +0000 (18:06 +0000)] 
- Fix LIST mode, broken by previous changes.
- Implement GetItemRect in terms of GetItemMeasurements.
- Improvements in debug traces.
- Many bug fixes, compelete implementation for GetItemMeasurements.
- Lots of code cleanups, simplifications.
- Documentation updates.

22 years agoPathIsExe: corrected and added executable types.
Jeff Smith [Mon, 30 Sep 2002 19:01:20 +0000 (19:01 +0000)] 
PathIsExe: corrected and added executable types.

22 years ago- The TTM_ message needed to be in correct order.
Guy L. Albertelli [Mon, 30 Sep 2002 18:52:52 +0000 (18:52 +0000)] 
- The TTM_ message needed to be in correct order.
- Added TTM_GETBUBBLESIZE.

22 years agoPrevent crash when listview trace logging is on.
Paul Rupe [Mon, 30 Sep 2002 18:52:33 +0000 (18:52 +0000)] 
Prevent crash when listview trace logging is on.

22 years agoImplement SwapTextureHandles method.
Christian Costa [Mon, 30 Sep 2002 18:52:06 +0000 (18:52 +0000)] 
Implement SwapTextureHandles method.

22 years agoDefine SNDMSG.
György 'Nog' Jeney [Mon, 30 Sep 2002 18:51:33 +0000 (18:51 +0000)] 
Define SNDMSG.

22 years agoAttempt at handling 'k' and 'B' symbols.
Greg Turner [Sun, 29 Sep 2002 18:35:31 +0000 (18:35 +0000)] 
Attempt at handling 'k' and 'B' symbols.

22 years ago- Eliminate extra background fills.
Guy Albertelli [Sun, 29 Sep 2002 18:34:51 +0000 (18:34 +0000)] 
- Eliminate extra background fills.
- Eliminate bogus error messages.

22 years agoFixed a couple of bugs in the debugger startup.
Alexandre Julliard [Sun, 29 Sep 2002 18:21:06 +0000 (18:21 +0000)] 
Fixed a couple of bugs in the debugger startup.

22 years agoDon't build d3d8 if we don't have OpenGL support.
Alexandre Julliard [Sun, 29 Sep 2002 18:07:25 +0000 (18:07 +0000)] 
Don't build d3d8 if we don't have OpenGL support.

22 years agoAdded check for OpenGL.
Alexandre Julliard [Sun, 29 Sep 2002 18:05:32 +0000 (18:05 +0000)] 
Added check for OpenGL.

22 years agoAdded {G|S}etWindowLongPtr.
György 'Nog' Jeney [Sun, 29 Sep 2002 18:04:55 +0000 (18:04 +0000)] 
Added {G|S}etWindowLongPtr.

22 years agoInitial implementation of custom control header.
György 'Nog' Jeney [Sun, 29 Sep 2002 18:04:15 +0000 (18:04 +0000)] 
Initial implementation of custom control header.

22 years agoUse correct check to see if xserver supports xvidmode.
Jukka Heinonen [Sun, 29 Sep 2002 18:02:40 +0000 (18:02 +0000)] 
Use correct check to see if xserver supports xvidmode.

22 years ago- Cache GWL_STYLE, to avoid fetching in virtually every function.
Dimitrie O. Paun [Sun, 29 Sep 2002 18:02:21 +0000 (18:02 +0000)] 
- Cache GWL_STYLE, to avoid fetching in virtually every function.
- Separate GetOrigin from GetAllMeasures as it is item independent,
  and rename function to reflect the change.
- Small cleanups.

22 years agoFix for soundcards that can't do 8-bit audio, only 16-bit (also
Ove Kaaven [Sun, 29 Sep 2002 18:01:33 +0000 (18:01 +0000)] 
Fix for soundcards that can't do 8-bit audio, only 16-bit (also
checked for soundcards that can't do stereo while I was at it).

22 years agoexecute: Activate the viewport passed as parameter when executing
Christian Costa [Sun, 29 Sep 2002 18:01:13 +0000 (18:01 +0000)] 
execute: Activate the viewport passed as parameter when executing
buffer.

22 years agoImplement IDirect3DViewport2_DeleteLight.
Christian Costa [Sun, 29 Sep 2002 18:00:43 +0000 (18:00 +0000)] 
Implement IDirect3DViewport2_DeleteLight.

22 years agoFunctions sscanf and swscanf now expect strings to be terminated with
Jukka Heinonen [Sun, 29 Sep 2002 18:00:23 +0000 (18:00 +0000)] 
Functions sscanf and swscanf now expect strings to be terminated with
null (0) instead of EOF (-1).

22 years agoMinor typo fix.
Bill Medland [Sun, 29 Sep 2002 17:59:58 +0000 (17:59 +0000)] 
Minor typo fix.

22 years agoRemove item from the list, if we fail to initialize it at insert
Dimitrie O. Paun [Fri, 27 Sep 2002 22:47:00 +0000 (22:47 +0000)] 
Remove item from the list, if we fail to initialize it at insert
time.

22 years agoInitial D3D8 implementation.
Jason Edmeades [Fri, 27 Sep 2002 22:46:16 +0000 (22:46 +0000)] 
Initial D3D8 implementation.

22 years agoFixed nameless union/struct declaration.
Alexandre Julliard [Fri, 27 Sep 2002 22:45:20 +0000 (22:45 +0000)] 
Fixed nameless union/struct declaration.

22 years agoExpanded the "Linux Libraries as Dlls" winelib section and brought it
Bill Medland [Fri, 27 Sep 2002 22:07:40 +0000 (22:07 +0000)] 
Expanded the "Linux Libraries as Dlls" winelib section and brought it
up to date.

22 years agoUpdated the wrapper code to match the new naming executable and
Francois Gouget [Fri, 27 Sep 2002 22:06:56 +0000 (22:06 +0000)] 
Updated the wrapper code to match the new naming executable and
library conventions.
Executables don't need spec files.
Removed unused code.

22 years agoAdded stubs for HttpEndRequestA/W, InternetReadFileExA/W,
Chris Morgan [Fri, 27 Sep 2002 22:05:23 +0000 (22:05 +0000)] 
Added stubs for HttpEndRequestA/W, InternetReadFileExA/W,
SetUrlCacheEntryGroup, CreateUrlCacheGroup, DeleteUrlCacheGroup.

22 years agoMoved some 16-bit functions from windows/cursoricon.c to
Michael Stefaniuc [Fri, 27 Sep 2002 22:04:54 +0000 (22:04 +0000)] 
Moved some 16-bit functions from windows/cursoricon.c to
dlls/user/user16.c.

22 years agoCheck for an empty string in DOSFS_FindNextEx to avoid an unnecessary
György 'Nog' Jeney [Fri, 27 Sep 2002 22:03:44 +0000 (22:03 +0000)] 
Check for an empty string in DOSFS_FindNextEx to avoid an unnecessary
failure.

22 years ago- Fix crashes in debug mode.
Dimitrie O. Paun [Fri, 27 Sep 2002 22:02:16 +0000 (22:02 +0000)] 
- Fix crashes in debug mode.
- Fix some focus rectangle problems.
- Better debugging output.
- More cleanups.

22 years agoRemove wrong and useless transformation of z projected coordinates.
Christian Costa [Fri, 27 Sep 2002 22:01:28 +0000 (22:01 +0000)] 
Remove wrong and useless transformation of z projected coordinates.
Add normals world transformation.

22 years agoFix devices creation broken code. Now, the display and the drawable
Christian Costa [Fri, 27 Sep 2002 22:01:12 +0000 (22:01 +0000)] 
Fix devices creation broken code. Now, the display and the drawable
are retrieve through GDI escape sequences and stored in the private
data. Add desallocation of the device private data.

22 years agoSplit the 16-bit funcitons into a seperate file.
György 'Nog' Jeney [Fri, 27 Sep 2002 22:00:41 +0000 (22:00 +0000)] 
Split the 16-bit funcitons into a seperate file.

22 years agoFixed X11 error code mismatch and removed debugging output.
Alexandre Julliard [Thu, 26 Sep 2002 03:23:13 +0000 (03:23 +0000)] 
Fixed X11 error code mismatch and removed debugging output.

22 years ago- fixed up some semantic misunderstandings using the helpful advice of
Greg Turner [Thu, 26 Sep 2002 03:21:54 +0000 (03:21 +0000)] 
- fixed up some semantic misunderstandings using the helpful advice of
  Rein Klazes
- added SO_SNDTIMEO support
- added ifdef's for consistency with rest of socket.c

22 years agoBring the naming of libraries and executable up to current standards.
Francois Gouget [Thu, 26 Sep 2002 03:20:59 +0000 (03:20 +0000)] 
Bring the naming of libraries and executable up to current standards.
Install dlls and executables in dlldir.
It is no longer necessary to import ntdll.dll.

22 years agoAdded desallocation of the viewport private data.
Christian Costa [Thu, 26 Sep 2002 03:20:35 +0000 (03:20 +0000)] 
Added desallocation of the viewport private data.

22 years agoAdded allocation/desallocation of the light private data.
Christian Costa [Thu, 26 Sep 2002 03:20:23 +0000 (03:20 +0000)] 
Added allocation/desallocation of the light private data.

22 years agoEnable creation of our OpenGL Direct3D device from a surface used as
Christian Costa [Thu, 26 Sep 2002 03:20:07 +0000 (03:20 +0000)] 
Enable creation of our OpenGL Direct3D device from a surface used as
rendering target.
Enable creation of a texture from a surface.

22 years agoMoved ts_xlib.c into x11drv and removed libwine_tsx11.
Alexandre Julliard [Wed, 25 Sep 2002 03:29:55 +0000 (03:29 +0000)] 
Moved ts_xlib.c into x11drv and removed libwine_tsx11.

22 years agoAdded missing WIN_ReleasePtr (spotted by Dmitry Timoshkov).
Alexandre Julliard [Wed, 25 Sep 2002 03:25:43 +0000 (03:25 +0000)] 
Added missing WIN_ReleasePtr (spotted by Dmitry Timoshkov).

22 years ago- Stop passing hwnd around when we're passing EDITSTATE.
Dimitrie O. Paun [Wed, 25 Sep 2002 03:24:53 +0000 (03:24 +0000)] 
- Stop passing hwnd around when we're passing EDITSTATE.
- Merge the non-obsolete bits of EDIT.TODO into edit.c.
- Some cleanups, and simplifications.

22 years ago- Initialize memory to prevent crashes when -debugmsg +listview is on.
Paul Rupe [Wed, 25 Sep 2002 03:20:01 +0000 (03:20 +0000)] 
- Initialize memory to prevent crashes when -debugmsg +listview is on.
- Fix various array bounds related errors.

22 years agoResize dynamic pointer array more carefully when adding new entries.
Paul Rupe [Wed, 25 Sep 2002 03:19:24 +0000 (03:19 +0000)] 
Resize dynamic pointer array more carefully when adding new entries.

22 years agoAdded support for POINT, WIREFRAME and SOLID fill modes.
Christian Costa [Wed, 25 Sep 2002 03:18:38 +0000 (03:18 +0000)] 
Added support for POINT, WIREFRAME and SOLID fill modes.

22 years agoIDirect3DTexture2Impl_Load: when the surface is not allocated and no
Christian Costa [Wed, 25 Sep 2002 03:18:17 +0000 (03:18 +0000)] 
IDirect3DTexture2Impl_Load: when the surface is not allocated and no
location are specified, set it to video memory.

22 years agoImport wine_tsx11_lock/unlock directly from x11drv in opengl32 and
Alexandre Julliard [Wed, 25 Sep 2002 00:29:56 +0000 (00:29 +0000)] 
Import wine_tsx11_lock/unlock directly from x11drv in opengl32 and
ddraw, so that they don't need to link with libwine_tsx11.
Removed header wine_gl.h.

22 years agoFixed a number of bugs in the handling of window parent and owner and
Alexandre Julliard [Wed, 25 Sep 2002 00:21:56 +0000 (00:21 +0000)] 
Fixed a number of bugs in the handling of window parent and owner and
added a regression test (based on the work of Bill Medland).

22 years agoBy default, we should use our own dlls.
Dimitrie O. Paun [Wed, 25 Sep 2002 00:16:52 +0000 (00:16 +0000)] 
By default, we should use our own dlls.

22 years agoAccept time_t argument in WS_setsockopt/WS_SO_RCVTIMEO; translate to
Greg Turner [Wed, 25 Sep 2002 00:15:43 +0000 (00:15 +0000)] 
Accept time_t argument in WS_setsockopt/WS_SO_RCVTIMEO; translate to
struct timeval for edification of setsockopt.

22 years agoRemoved some more TSX11 functions and files.
Alexandre Julliard [Tue, 24 Sep 2002 18:36:51 +0000 (18:36 +0000)] 
Removed some more TSX11 functions and files.

22 years agoFixed some issues found by winapi_check.
Patrik Stridvall [Tue, 24 Sep 2002 18:29:39 +0000 (18:29 +0000)] 
Fixed some issues found by winapi_check.

22 years ago- Don't add standard headers for the dll separation hacks.
Patrik Stridvall [Tue, 24 Sep 2002 18:27:47 +0000 (18:27 +0000)] 
- Don't add standard headers for the dll separation hacks.
- API files update.

22 years ago- Localize origin, location, and rectangle computation.
Guy L. Albertelli [Tue, 24 Sep 2002 18:27:21 +0000 (18:27 +0000)] 
- Localize origin, location, and rectangle computation.
- Support state icons in LVS_ICON style.
- Draw only items that are in the clip box.
- Draw non-selected items first then the selected ones because large
  icons may overlap each other.
- Correct invalidation rectangles for items.
- Correct drawing of large icons.
- Eliminate divide by zero cases in scrolling.
- Invalidate selected items prior to setting window losing focus.

22 years agoSmall cleanups, updated documentation.
Dimitrie O. Paun [Tue, 24 Sep 2002 18:26:42 +0000 (18:26 +0000)] 
Small cleanups, updated documentation.

22 years agoFixed #endif.
Alexandre Julliard [Tue, 24 Sep 2002 03:59:08 +0000 (03:59 +0000)] 
Fixed #endif.

22 years agoRemoved a bunch of no longer used TSX wrappers.
Alexandre Julliard [Tue, 24 Sep 2002 03:17:31 +0000 (03:17 +0000)] 
Removed a bunch of no longer used TSX wrappers.

22 years agoFixed some issues found by winapi_check.
Patrik Stridvall [Tue, 24 Sep 2002 03:09:50 +0000 (03:09 +0000)] 
Fixed some issues found by winapi_check.

22 years agoConvert HKEY to a void*.
Michael Stefaniuc [Tue, 24 Sep 2002 03:09:12 +0000 (03:09 +0000)] 
Convert HKEY to a void*.

22 years ago- Added support for %struct16 (used by CLSID).
Patrik Stridvall [Tue, 24 Sep 2002 03:07:38 +0000 (03:07 +0000)] 
- Added support for %struct16 (used by CLSID).
- API files update.

22 years agoAdded new "GlobalRegistryDir" option.
Raul Dias [Tue, 24 Sep 2002 03:07:17 +0000 (03:07 +0000)] 
Added new "GlobalRegistryDir" option.

22 years agoRemoved the #undef of WS_DEFINE_SELECT so that select is in fact
Patrick J. McNerthney [Tue, 24 Sep 2002 03:05:59 +0000 (03:05 +0000)] 
Removed the #undef of WS_DEFINE_SELECT so that select is in fact
defined.
Fixed if statement in __WS_FD_SET2 which used a = where a == is
needed, in additition the if did not have its outer set of
parenthesis.
Removed parentheses around type to be cast in __WS_FD_SET macro.
Removed WS macro usage from within other macros because the WS macro
is undefined when these macros are expanded.
Added WINAPI attributee to select definition.

22 years agoAdded casts to all macros to avoid compiler warnings.
Patrick J. McNerthney [Tue, 24 Sep 2002 03:04:45 +0000 (03:04 +0000)] 
Added casts to all macros to avoid compiler warnings.

22 years agoRemove some more superfluous ZeroMemory calls, small cleanups.
Dimitrie O. Paun [Mon, 23 Sep 2002 20:59:42 +0000 (20:59 +0000)] 
Remove some more superfluous ZeroMemory calls, small cleanups.