wine
22 years agoTry to use read instead of mmap for files on removable media, so that
Alexandre Julliard [Wed, 24 Oct 2001 00:30:23 +0000 (00:30 +0000)] 
Try to use read instead of mmap for files on removable media, so that
we don't need to keep the mapping handle open.

22 years agoSave a disk file's drive type in the server object.
Ove Kaaven [Wed, 24 Oct 2001 00:23:25 +0000 (00:23 +0000)] 
Save a disk file's drive type in the server object.

22 years agoCosmetic fixes.
Alexandre Julliard [Tue, 23 Oct 2001 20:35:44 +0000 (20:35 +0000)] 
Cosmetic fixes.

22 years agoAdded stubs for msdmo.dll, qcap.dll and devenum.dll.
Hidenori Takeshima [Tue, 23 Oct 2001 20:35:23 +0000 (20:35 +0000)] 
Added stubs for msdmo.dll, qcap.dll and devenum.dll.

22 years agoImplement GetFontData.
Huw D M Davies [Tue, 23 Oct 2001 20:06:32 +0000 (20:06 +0000)] 
Implement GetFontData.

22 years agoImplemented OleCreatePropertyFrame and
Hidenori Takeshima [Tue, 23 Oct 2001 19:59:24 +0000 (19:59 +0000)] 
Implemented OleCreatePropertyFrame and
OleCreatePropertyFrameIndirect.

22 years agoMoved/added some console definitions.
Eric Pouech [Tue, 23 Oct 2001 19:58:17 +0000 (19:58 +0000)] 
Moved/added some console definitions.

22 years agoRevert 16bit win95 version back to original value. Fixes InstallShield
Marcus Meissner [Tue, 23 Oct 2001 19:55:11 +0000 (19:55 +0000)] 
Revert 16bit win95 version back to original value. Fixes InstallShield
installer version check.

22 years agoExtTextOutW with symbol fonts works with chars in the ranges
Huw D M Davies [Tue, 23 Oct 2001 19:54:27 +0000 (19:54 +0000)] 
ExtTextOutW with symbol fonts works with chars in the ranges
0x0000 -- 0x00ff and 0xf000 -- 0xf0ff and not, for example, with
chars in the Unicode Greek range.

22 years agoBetter failure messages for CoCreateInstance.
Huw D M Davies [Tue, 23 Oct 2001 19:52:08 +0000 (19:52 +0000)] 
Better failure messages for CoCreateInstance.

22 years agoFixed window handle check in GetDCEx.
Alexandre Julliard [Tue, 23 Oct 2001 00:29:25 +0000 (00:29 +0000)] 
Fixed window handle check in GetDCEx.

22 years agoA couple of optimizations.
Alexandre Julliard [Tue, 23 Oct 2001 00:26:10 +0000 (00:26 +0000)] 
A couple of optimizations.

22 years agoExpand environment variables in "Debugger" setting.
Francois Gouget [Tue, 23 Oct 2001 00:25:46 +0000 (00:25 +0000)] 
Expand environment variables in "Debugger" setting.
Replace fixed-size buffers with dynamic ones.

22 years agoFixed the behavior for SHGetFileInfo when the SHGFI_USEFILEATTRIBUTES
Aric Stewart [Tue, 23 Oct 2001 00:25:15 +0000 (00:25 +0000)] 
Fixed the behavior for SHGetFileInfo when the SHGFI_USEFILEATTRIBUTES
flag is set. Corrects the given type and icon.

22 years agoStore in the server all the window information accessible with
Alexandre Julliard [Mon, 22 Oct 2001 19:08:33 +0000 (19:08 +0000)] 
Store in the server all the window information accessible with
Get/SetWindowLong.

22 years agoSpelling, grammar and a bit of comment formatting fixes.
Francois Gouget [Mon, 22 Oct 2001 19:04:32 +0000 (19:04 +0000)] 
Spelling, grammar and a bit of comment formatting fixes.

22 years agoFixed some bugs.
Hidenori Takeshima [Mon, 22 Oct 2001 19:03:26 +0000 (19:03 +0000)] 
Fixed some bugs.
Implemented AVI Decompressor.
Started implementing Color Space Converter.
Started implementing seeking.

22 years agoAdded "--auto" option.
Alexandre Julliard [Mon, 22 Oct 2001 19:00:34 +0000 (19:00 +0000)] 
Added "--auto" option.

22 years agoAdd support for environment variables in the printer settings.
Francois Gouget [Mon, 22 Oct 2001 19:00:08 +0000 (19:00 +0000)] 
Add support for environment variables in the printer settings.
Remove the fixed-size buffers.

22 years agoAdded __WINE_USE_MSVCRT.
Francois Gouget [Mon, 22 Oct 2001 18:59:23 +0000 (18:59 +0000)] 
Added __WINE_USE_MSVCRT.

22 years agoImplemented the wcstoul function.
David Elliott [Mon, 22 Oct 2001 18:58:21 +0000 (18:58 +0000)] 
Implemented the wcstoul function.

22 years agoCosmetics.
Andreas Mohr [Sun, 21 Oct 2001 15:18:15 +0000 (15:18 +0000)] 
Cosmetics.

22 years ago- Add stubs for _25, _33, _35
Guy L. Albertelli [Sun, 21 Oct 2001 15:17:16 +0000 (15:17 +0000)] 
- Add stubs for _25, _33, _35
- Add/correct code for: _15, _29, _30, _31, _151, _152, _153, _154,
  _158.

22 years ago- Implement HUSKEY design.
Guy L. Albertelli [Sun, 21 Oct 2001 15:09:36 +0000 (15:09 +0000)] 
- Implement HUSKEY design.
- Implement functions: SHRegOpenUSKey{A|W}, SHRegCloseUSKey,
  SHRegGetUSValue{A|W}, SHRegQueryInfoUSKey{A|W}

22 years ago- Implement UrlCanonicalizeW, UrlEscapeW, UrlUnescapeW.
Guy L. Albertelli [Sun, 21 Oct 2001 15:08:01 +0000 (15:08 +0000)] 
- Implement UrlCanonicalizeW, UrlEscapeW, UrlUnescapeW.
- Stub UrlGetLocation{A|W}.

22 years agoAvoid crashing on non-initialized debug info.
Alexandre Julliard [Sun, 21 Oct 2001 15:04:04 +0000 (15:04 +0000)] 
Avoid crashing on non-initialized debug info.

22 years agoFixed a typo.
Hidenori Takeshima [Sun, 21 Oct 2001 15:02:59 +0000 (15:02 +0000)] 
Fixed a typo.

22 years agoImplemented GetCharacterPlacementW.
Guy L. Albertelli [Sun, 21 Oct 2001 15:02:34 +0000 (15:02 +0000)] 
Implemented GetCharacterPlacementW.

22 years agoXFree86 4.1 gamma ramp support.
Andrew Lewycky [Sun, 21 Oct 2001 15:02:01 +0000 (15:02 +0000)] 
XFree86 4.1 gamma ramp support.

22 years agoFixed a typo.
Ove Kaaven [Sun, 21 Oct 2001 15:01:43 +0000 (15:01 +0000)] 
Fixed a typo.

22 years agoReturn TRUE on success in COMM_BuildOldCommDCB.
Mike McCormack [Sun, 21 Oct 2001 15:01:20 +0000 (15:01 +0000)] 
Return TRUE on success in COMM_BuildOldCommDCB.
DCB16.BaudRate > 57600 means 115200.
OpenComm16 should use overlapped I/O.

22 years agoChanged X11 mouse driver to use SendInput, and removed WINE_MOUSEEVENT
Alexandre Julliard [Thu, 18 Oct 2001 21:38:59 +0000 (21:38 +0000)] 
Changed X11 mouse driver to use SendInput, and removed WINE_MOUSEEVENT
hack. Moved mouse.c to dlls/x11drv.
Added KeymapNotify event handler, and fixed handling with multiple
alt/shift/control keys.
Removed dinput functions from USER driver.

22 years agoAdded a few XBUTTON defines.
Alexandre Julliard [Thu, 18 Oct 2001 21:34:17 +0000 (21:34 +0000)] 
Added a few XBUTTON defines.

22 years agoUse WIN_ReleasePtr not WIN_ReleaseWndPtr with WIN_GetPtr.
Mike McCormack [Thu, 18 Oct 2001 21:33:03 +0000 (21:33 +0000)] 
Use WIN_ReleasePtr not WIN_ReleaseWndPtr with WIN_GetPtr.

22 years agoMake dinput a properly separated dll.
Alexandre Julliard [Thu, 18 Oct 2001 21:31:14 +0000 (21:31 +0000)] 
Make dinput a properly separated dll.

22 years agoUse WH_MOUSE_LL hook instead of redirecting the mouse event handler.
Alexandre Julliard [Thu, 18 Oct 2001 21:30:46 +0000 (21:30 +0000)] 
Use WH_MOUSE_LL hook instead of redirecting the mouse event handler.

22 years agoFixed GetDeviceState and GetDeviceData to use only exported APIs.
Alexandre Julliard [Thu, 18 Oct 2001 21:30:06 +0000 (21:30 +0000)] 
Fixed GetDeviceState and GetDeviceData to use only exported APIs.

22 years agoFix tons of color conversion bugs.
Francois Gouget [Wed, 17 Oct 2001 19:41:54 +0000 (19:41 +0000)] 
Fix tons of color conversion bugs.
Reorganize things more rationally and so that more code is shared.

22 years agoFixed mouse_event bug - cursor was moved before new position was
Andriy Palamarchuk [Wed, 17 Oct 2001 19:39:55 +0000 (19:39 +0000)] 
Fixed mouse_event bug - cursor was moved before new position was
calculated.

22 years agoRelay tracing would crash if it came upon a function call with an
Johan Gill [Wed, 17 Oct 2001 19:39:22 +0000 (19:39 +0000)] 
Relay tracing would crash if it came upon a function call with an
invalid pointer as a parameter.

22 years agoReleasing a mouse button now clears an entry in table
Jukka Heinonen [Wed, 17 Oct 2001 19:36:31 +0000 (19:36 +0000)] 
Releasing a mouse button now clears an entry in table
InputKeyStateTable instead of AsyncKeyStateTable.

22 years agoOnly modify the ancestor if you find it.
Bill Medland [Wed, 17 Oct 2001 19:35:36 +0000 (19:35 +0000)] 
Only modify the ancestor if you find it.

22 years agoAdded support for low-level mouse and keyboard hooks.
Alexandre Julliard [Wed, 17 Oct 2001 17:50:02 +0000 (17:50 +0000)] 
Added support for low-level mouse and keyboard hooks.
Misc keyboard handling cleanups.

22 years agoMake sure that GetMessagePos and GetMessageTime return sane values
Alexandre Julliard [Wed, 17 Oct 2001 17:48:49 +0000 (17:48 +0000)] 
Make sure that GetMessagePos and GetMessageTime return sane values
for all messages.

22 years agoWhen a surface becomes primary surface, mark the whole surface damaged.
Jukka Heinonen [Wed, 17 Oct 2001 17:45:53 +0000 (17:45 +0000)] 
When a surface becomes primary surface, mark the whole surface damaged.

22 years agoUse the same color conversion algorithm as the DIB code (and Windows),
Francois Gouget [Wed, 17 Oct 2001 17:45:33 +0000 (17:45 +0000)] 
Use the same color conversion algorithm as the DIB code (and Windows),
i.e. shifts, not MulDivs.
Fix the grayscale formula.

22 years agoSeparate code to overlapped timeouts into FILE_GetTimeout.
Mike McCormack [Wed, 17 Oct 2001 17:45:11 +0000 (17:45 +0000)] 
Separate code to overlapped timeouts into FILE_GetTimeout.

22 years agoAdded internal Wine messages to perform SetWindowPos, ShowWindow and
Alexandre Julliard [Tue, 16 Oct 2001 21:58:58 +0000 (21:58 +0000)] 
Added internal Wine messages to perform SetWindowPos, ShowWindow and
SetParent in the correct thread.
Replace QUEUE_IsExitingQueue by USER_IsExitingThread.
Store window rectangles in the server.
Prevent DestroyWindow on windows not belonging to the current thread.

22 years agoAdded requests to store window rectangles in the server.
Alexandre Julliard [Tue, 16 Oct 2001 21:55:37 +0000 (21:55 +0000)] 
Added requests to store window rectangles in the server.

22 years agoMoved scrollbar tracking code to scroll.c.
Alexandre Julliard [Tue, 16 Oct 2001 21:52:26 +0000 (21:52 +0000)] 
Moved scrollbar tracking code to scroll.c.
Avoid unnecessary coordinates conversion in NC_HandleSysCommand.

22 years agoMisc doc updates.
Gerard Patel [Tue, 16 Oct 2001 21:47:51 +0000 (21:47 +0000)] 
Misc doc updates.

22 years agoRegistry entries for stdole32.tlb.
Ove Kaaven [Tue, 16 Oct 2001 21:47:22 +0000 (21:47 +0000)] 
Registry entries for stdole32.tlb.

22 years ago- eliminate different segmentation faults.
Guy L. Albertelli [Tue, 16 Oct 2001 21:46:58 +0000 (21:46 +0000)] 
- eliminate different segmentation faults.
- when attempting to open a dll, append ".dll" to find it (was
  stripped previously).
- identify named exports so that the ordinal number is "@" in .spec
  file.
- setup output dll name prior to creating ordinal symbols.
- don't overlay the named exports with the ordinal exports.
- correct test for last symbol.
- fix generated install script to match current make files.

22 years agoFix the case where child=0 (last child) in MDI_ChildActivate.
Gerard Patel [Mon, 15 Oct 2001 18:00:09 +0000 (18:00 +0000)] 
Fix the case where child=0 (last child) in MDI_ChildActivate.

22 years agoRenamed WIN_GetWndPtr into WIN_GetPtr and added corresponding
Alexandre Julliard [Mon, 15 Oct 2001 17:56:45 +0000 (17:56 +0000)] 
Renamed WIN_GetWndPtr into WIN_GetPtr and added corresponding
WIN_ReleasePtr. Started using it instead of WIN_FindWndPtr where we
don't need to access windows of other processes.

22 years agoAdded some missing GUIDs.
Hidenori Takeshima [Mon, 15 Oct 2001 17:51:15 +0000 (17:51 +0000)] 
Added some missing GUIDs.

22 years agoThe _IOXXX macros conflict with system headers on Solaris. Prefix
Francois Gouget [Mon, 15 Oct 2001 17:50:55 +0000 (17:50 +0000)] 
The _IOXXX macros conflict with system headers on Solaris. Prefix
them.

22 years agoInternalExtractIcon16 forgot to close file handle.
Kai Morich [Mon, 15 Oct 2001 17:50:21 +0000 (17:50 +0000)] 
InternalExtractIcon16 forgot to close file handle.

22 years agoAdd INVALID_ATOM and MAXINTATOM to winbase.h.
Francois Gouget [Mon, 15 Oct 2001 17:49:23 +0000 (17:49 +0000)] 
Add INVALID_ATOM and MAXINTATOM to winbase.h.
Replace MIN_STR_ATOM with MAXINTATOM.

22 years agoWhen including 'wine/port.h', include it first.
Francois Gouget [Sun, 14 Oct 2001 16:25:47 +0000 (16:25 +0000)] 
When including 'wine/port.h', include it first.
Remove redundant 'config.h' includes.

22 years agoWhen including config.h, include it first.
Francois Gouget [Sun, 14 Oct 2001 16:18:52 +0000 (16:18 +0000)] 
When including config.h, include it first.

22 years agoAdded some RPC definitions.
Ove Kaaven [Sun, 14 Oct 2001 16:15:37 +0000 (16:15 +0000)] 
Added some RPC definitions.

22 years agoDon't print NULL strings (crashes on Solaris).
Francois Gouget [Sun, 14 Oct 2001 16:15:05 +0000 (16:15 +0000)] 
Don't print NULL strings (crashes on Solaris).
Small code maintainability tweak in ShellExecuteExA.
Two typo fixes in winmm.

22 years agoStarted implementing AVI splitter.
Hidenori Takeshima [Sun, 14 Oct 2001 16:13:14 +0000 (16:13 +0000)] 
Started implementing AVI splitter.
Implemented AsyncSource.
Merged some C sources.
Fixed some bugs.

22 years agoAdded MPEG1WAVEFORMAT and MPEGLAYER3WAVEFORMAT.
Hidenori Takeshima [Sun, 14 Oct 2001 16:10:02 +0000 (16:10 +0000)] 
Added MPEG1WAVEFORMAT and MPEGLAYER3WAVEFORMAT.

22 years agoPass security attributes for DOSFS creation.
Eric Pouech [Sun, 14 Oct 2001 16:08:45 +0000 (16:08 +0000)] 
Pass security attributes for DOSFS creation.

22 years agoFixed bugs with propget methods with input arguments.
Ove Kaaven [Sun, 14 Oct 2001 16:07:49 +0000 (16:07 +0000)] 
Fixed bugs with propget methods with input arguments.
Improved variant debug dumps.

22 years agoFixed bugs in safe arrays.
Ove Kaaven [Sun, 14 Oct 2001 16:07:36 +0000 (16:07 +0000)] 
Fixed bugs in safe arrays.
- enlarging a safe array didn't clear the new entries
- element access only validated the first dimension
- the validation always failed when the array contained 1 element

22 years agoFix a UINT16 redefinition problem.
Ove Kaaven [Sun, 14 Oct 2001 16:07:23 +0000 (16:07 +0000)] 
Fix a UINT16 redefinition problem.

22 years agoRecognize the Solaris dlopen equivalent of "cannot open".
Francois Gouget [Sun, 14 Oct 2001 16:06:54 +0000 (16:06 +0000)] 
Recognize the Solaris dlopen equivalent of "cannot open".

22 years agoFix handling of empty lists in install and uninstall targets.
Francois Gouget [Sun, 14 Oct 2001 16:06:18 +0000 (16:06 +0000)] 
Fix handling of empty lists in install and uninstall targets.
Install the executables .so libraries in $bindir (not $libdir!).

22 years agoStore window properties in the server. Moved property.c to dlls/user.
Alexandre Julliard [Fri, 12 Oct 2001 19:10:26 +0000 (19:10 +0000)] 
Store window properties in the server. Moved property.c to dlls/user.

22 years agoAdded atom_t type for atoms to make sure we use the same type
Alexandre Julliard [Fri, 12 Oct 2001 18:45:29 +0000 (18:45 +0000)] 
Added atom_t type for atoms to make sure we use the same type
everywhere. Handle MIN_STR_ATOM offset in the server.

22 years agoMoved MAKEINTATOM to winbase.h and added Unicode version.
Alexandre Julliard [Fri, 12 Oct 2001 18:43:27 +0000 (18:43 +0000)] 
Moved MAKEINTATOM to winbase.h and added Unicode version.

22 years agoHandle bad pointer arguments to LoadImageA() (and functions
Marcus Meissner [Fri, 12 Oct 2001 18:42:17 +0000 (18:42 +0000)] 
Handle bad pointer arguments to LoadImageA() (and functions
callingLoadImageA) with an exception handler.

22 years agoWorkaround X11 BadWindow error if no parent window is found.
Dominik Strasser [Fri, 12 Oct 2001 18:41:50 +0000 (18:41 +0000)] 
Workaround X11 BadWindow error if no parent window is found.

22 years agoFix the Wine tools search path.
Francois Gouget [Fri, 12 Oct 2001 18:41:26 +0000 (18:41 +0000)] 
Fix the Wine tools search path.
Add /usr/local/lib to the default ntdll search path.

22 years agoRemoved the cleanup_window_queue request.
Alexandre Julliard [Thu, 11 Oct 2001 20:50:10 +0000 (20:50 +0000)] 
Removed the cleanup_window_queue request.

22 years agoRemoved next and child fields in the window structure and use
Alexandre Julliard [Thu, 11 Oct 2001 20:49:40 +0000 (20:49 +0000)] 
Removed next and child fields in the window structure and use
WIN_ListChildren instead.

22 years agoAdded some missing GUIDs.
Hidenori Takeshima [Thu, 11 Oct 2001 20:47:55 +0000 (20:47 +0000)] 
Added some missing GUIDs.

22 years agoFix the .spec.c rule.
Francois Gouget [Thu, 11 Oct 2001 20:47:26 +0000 (20:47 +0000)] 
Fix the .spec.c rule.

22 years agoStore window parent as an HWND instead of a pointer.
Alexandre Julliard [Wed, 10 Oct 2001 20:28:17 +0000 (20:28 +0000)] 
Store window parent as an HWND instead of a pointer.

22 years agoDo overlapped reads if and only if the file was opened with
Mike McCormack [Wed, 10 Oct 2001 20:26:58 +0000 (20:26 +0000)] 
Do overlapped reads if and only if the file was opened with
FILE_FLAG_OVERLAPPED.

22 years agoAllocate the array and strings in one lump (bug found by Malte
Francois Gouget [Wed, 10 Oct 2001 20:25:59 +0000 (20:25 +0000)] 
Allocate the array and strings in one lump (bug found by Malte
Starostik).
Same thing for the lpCmdline="" case.
There is no NULL pointer at the end of the argv list.

22 years agoGetTextCharsetInfo should return the charset that the driver is
Huw D M Davies [Wed, 10 Oct 2001 20:25:04 +0000 (20:25 +0000)] 
GetTextCharsetInfo should return the charset that the driver is
actually using, rather than that specified in the LOGFONT.

22 years agoInclude information about XFree86 Windows server.
Andriy Palamarchuk [Wed, 10 Oct 2001 20:22:35 +0000 (20:22 +0000)] 
Include information about XFree86 Windows server.

22 years agoMove the RT_XXX macros to winuser.h.
Francois Gouget [Wed, 10 Oct 2001 02:51:24 +0000 (02:51 +0000)] 
Move the RT_XXX macros to winuser.h.
winuser.h: Add support for NOGDI.
winuser.h: Modify to allow compilation without wingdi.h.

22 years agoAdded names of the "missing" paths for SHGetSpecialFolderPathA.
Chris Green [Wed, 10 Oct 2001 02:48:29 +0000 (02:48 +0000)] 
Added names of the "missing" paths for SHGetSpecialFolderPathA.

22 years agoFixed locking of class list.
Alexandre Julliard [Tue, 9 Oct 2001 23:27:17 +0000 (23:27 +0000)] 
Fixed locking of class list.
Print ERR when accessing classes of other processes.

22 years agoStore window class atom in the server.
Alexandre Julliard [Tue, 9 Oct 2001 23:26:40 +0000 (23:26 +0000)] 
Store window class atom in the server.
Keep unlinked windows on a separate list.
Implemented inter-process FindWindow().

22 years agoRemove non windows macros.
Francois Gouget [Tue, 9 Oct 2001 23:25:20 +0000 (23:25 +0000)] 
Remove non windows macros.

22 years agoSilence the pthread_kill_other_threads_np FIXME.
Alexandre Julliard [Tue, 9 Oct 2001 21:59:16 +0000 (21:59 +0000)] 
Silence the pthread_kill_other_threads_np FIXME.

22 years agoFix MapViewOfFile to always return a 64K-aligned address.
Alexandre Julliard [Tue, 9 Oct 2001 21:50:44 +0000 (21:50 +0000)] 
Fix MapViewOfFile to always return a 64K-aligned address.
Avoid converting pointers to UINT.

22 years agoAPI files update.
Patrik Stridvall [Tue, 9 Oct 2001 21:49:07 +0000 (21:49 +0000)] 
API files update.

22 years agoFixed issue found by winapi_check.
Patrik Stridvall [Tue, 9 Oct 2001 21:48:39 +0000 (21:48 +0000)] 
Fixed issue found by winapi_check.

22 years agoAdded new include file ws2spi.h for adding needed types.
Patrik Stridvall [Tue, 9 Oct 2001 21:48:22 +0000 (21:48 +0000)] 
Added new include file ws2spi.h for adding needed types.

22 years agoFixed parameters of SetupOpenInfFileA.
Stefan Leichter [Tue, 9 Oct 2001 21:47:11 +0000 (21:47 +0000)] 
Fixed parameters of SetupOpenInfFileA.

22 years agoMoved MsgWaitForMultipleObjects call on RDW_UPDATENOW out of the
Alexandre Julliard [Mon, 8 Oct 2001 22:32:05 +0000 (22:32 +0000)] 
Moved MsgWaitForMultipleObjects call on RDW_UPDATENOW out of the
RDW_Paint recursion.

22 years agoAdd support for NOCOLOR.
Francois Gouget [Mon, 8 Oct 2001 22:31:16 +0000 (22:31 +0000)] 
Add support for NOCOLOR.

22 years agoMove WINDEBUGINFO from winbase.h to winbase16.h and rename to
Francois Gouget [Mon, 8 Oct 2001 22:30:34 +0000 (22:30 +0000)] 
Move WINDEBUGINFO from winbase.h to winbase16.h and rename to
WINDEBUGINFO16.
Move the related macros to version.c and ifdef them out (kept for
documentation only, they are not used).