wine
22 years agoMoved network.c to 16-bit sources.
Alexandre Julliard [Wed, 23 Oct 2002 20:22:53 +0000 (20:22 +0000)] 
Moved network.c to 16-bit sources.

22 years agoDon't use wine/unicode.h in the header files, include it directly
Patrik Stridvall [Wed, 23 Oct 2002 20:20:59 +0000 (20:20 +0000)] 
Don't use wine/unicode.h in the header files, include it directly
where needed instead.

22 years agoAvoid redefinition warning.
Alexandre Julliard [Wed, 23 Oct 2002 20:19:48 +0000 (20:19 +0000)] 
Avoid redefinition warning.

22 years agoAdd needed casts for a "no warnings" compile of comctl32.
Michael Stefaniuc [Wed, 23 Oct 2002 20:19:22 +0000 (20:19 +0000)] 
Add needed casts for a "no warnings" compile of comctl32.

22 years agoFix for platforms not supporting DOS mode.
Patrik Stridvall [Wed, 23 Oct 2002 20:16:36 +0000 (20:16 +0000)] 
Fix for platforms not supporting DOS mode.

22 years agoAdd pragma to eliminate MS C warnings.
Patrik Stridvall [Wed, 23 Oct 2002 20:16:23 +0000 (20:16 +0000)] 
Add pragma to eliminate MS C warnings.

22 years ago- Added proper parsing of the Makefile.in's to find the tests.
Patrik Stridvall [Wed, 23 Oct 2002 20:16:12 +0000 (20:16 +0000)] 
- Added proper parsing of the Makefile.in's to find the tests.
- Added support for optionally using the Microsoft headers instead of
  the Wine headers.

22 years agoImplemented NLS in progman.
Sylvain Petreolle [Wed, 23 Oct 2002 20:15:48 +0000 (20:15 +0000)] 
Implemented NLS in progman.

22 years agoStore thread id instead of queue handle in timer structure.
Alexandre Julliard [Wed, 23 Oct 2002 18:56:34 +0000 (18:56 +0000)] 
Store thread id instead of queue handle in timer structure.

22 years agoImplemented GetWindowTask16 on top of GetWindowThreadProcessId.
Alexandre Julliard [Wed, 23 Oct 2002 18:56:02 +0000 (18:56 +0000)] 
Implemented GetWindowTask16 on top of GetWindowThreadProcessId.
Removed no longer used hmemTaskQ field in WND structure.

22 years agoFixed mismatches between the Wine headers and the Microsoft headers.
Patrik Stridvall [Wed, 23 Oct 2002 18:50:10 +0000 (18:50 +0000)] 
Fixed mismatches between the Wine headers and the Microsoft headers.

22 years agoAdded dialog for AVISaveOptions.
Michael Günnewig [Wed, 23 Oct 2002 18:47:51 +0000 (18:47 +0000)] 
Added dialog for AVISaveOptions.

22 years agoImplemented AVIBuildFilterW and AVISaveOptions.
Michael Günnewig [Wed, 23 Oct 2002 18:47:39 +0000 (18:47 +0000)] 
Implemented AVIBuildFilterW and AVISaveOptions.

22 years agoFixed bug that prevented ICCompressorChoose from working.
Michael Günnewig [Wed, 23 Oct 2002 18:47:20 +0000 (18:47 +0000)] 
Fixed bug that prevented ICCompressorChoose from working.

22 years agoMessageBoxIndirectW: call FindResourceEx with arguments in the right
Rein Klazes [Wed, 23 Oct 2002 18:45:46 +0000 (18:45 +0000)] 
MessageBoxIndirectW: call FindResourceEx with arguments in the right
order.

22 years agoUpdated the generated tests.
Patrik Stridvall [Wed, 23 Oct 2002 18:45:15 +0000 (18:45 +0000)] 
Updated the generated tests.

22 years agoMinor modifications and improvements.
Patrik Stridvall [Wed, 23 Oct 2002 18:44:46 +0000 (18:44 +0000)] 
Minor modifications and improvements.

22 years agoDo not break quoted strings in Control_DoLaunch.
Stefan Leichter [Wed, 23 Oct 2002 18:44:13 +0000 (18:44 +0000)] 
Do not break quoted strings in Control_DoLaunch.

22 years agoCollect all bugs, missing features, etc in the header doc.
Christian Neumair [Wed, 23 Oct 2002 18:43:32 +0000 (18:43 +0000)] 
Collect all bugs, missing features, etc in the header doc.

22 years agoMoved 16 bit digital structs to include/wine/mmsystem16.h.
Eric Pouech [Wed, 23 Oct 2002 18:43:00 +0000 (18:43 +0000)] 
Moved 16 bit digital structs to include/wine/mmsystem16.h.

22 years agoCompile the winspool dll with STRICT defined.
Michael Stefaniuc [Tue, 22 Oct 2002 00:47:33 +0000 (00:47 +0000)] 
Compile the winspool dll with STRICT defined.

22 years agoCompile the tapi32 dll with STRICT defined.
Michael Stefaniuc [Tue, 22 Oct 2002 00:47:08 +0000 (00:47 +0000)] 
Compile the tapi32 dll with STRICT defined.

22 years agoCompile the psapi dll with STRICT defined.
Michael Stefaniuc [Tue, 22 Oct 2002 00:46:46 +0000 (00:46 +0000)] 
Compile the psapi dll with STRICT defined.

22 years agoCompile the msacm dll with STRICT defined.
Michael Stefaniuc [Tue, 22 Oct 2002 00:46:23 +0000 (00:46 +0000)] 
Compile the msacm dll with STRICT defined.

22 years agoCompile the mpr dll with STRICT defined.
Michael Stefaniuc [Tue, 22 Oct 2002 00:45:56 +0000 (00:45 +0000)] 
Compile the mpr dll with STRICT defined.

22 years agoCompile the imagehlp dll with STRICT defined.
Michael Stefaniuc [Tue, 22 Oct 2002 00:45:27 +0000 (00:45 +0000)] 
Compile the imagehlp dll with STRICT defined.

22 years agoCompile the imm32 dll with STRICT defined.
Michael Stefaniuc [Tue, 22 Oct 2002 00:45:02 +0000 (00:45 +0000)] 
Compile the imm32 dll with STRICT defined.

22 years agoAvoid reference to glibc internal __libc_fork function.
Alexandre Julliard [Tue, 22 Oct 2002 00:44:24 +0000 (00:44 +0000)] 
Avoid reference to glibc internal __libc_fork function.

22 years agoRestore setting of caption "Error".
Dmitry Timoshkov [Tue, 22 Oct 2002 00:42:53 +0000 (00:42 +0000)] 
Restore setting of caption "Error".

22 years agoBeginnings of Stencil support.
Jason Edmeades [Tue, 22 Oct 2002 00:42:11 +0000 (00:42 +0000)] 
Beginnings of Stencil support.

22 years agoBring header's height more inline with native's.
Dimitrie O. Paun [Tue, 22 Oct 2002 00:41:45 +0000 (00:41 +0000)] 
Bring header's height more inline with native's.

22 years ago- Use Ove-style macros for NdrConformantStringMarshall definition.
Greg Turner [Tue, 22 Oct 2002 00:41:17 +0000 (00:41 +0000)] 
- Use Ove-style macros for NdrConformantStringMarshall definition.
- Move NdrConformantStringMarshall to new ndr_marshall.c.
- Stubs for NdrConformantStringBufferSize,
  NdrConformantStringMemorySize, and NdrConformantStringUnmarshall.

22 years ago- ClientCall2 still deserves a FIXME.
Greg Turner [Tue, 22 Oct 2002 00:40:01 +0000 (00:40 +0000)] 
- ClientCall2 still deserves a FIXME.
- Complete bindings with NULL endpoints.
- Implement RpcServerUseProtseqA, RpcServerUseProtseqW.

22 years agoFixed the WINE_NO_STRICT #ifdefs to do the right thing if STRICT is
Alexandre Julliard [Mon, 21 Oct 2002 23:43:04 +0000 (23:43 +0000)] 
Fixed the WINE_NO_STRICT #ifdefs to do the right thing if STRICT is
defined (spotted by Michael Stefaniuc).

22 years agoFix return types of NdrConformantStringMarshall, NdrGetBuffer, and
Greg Turner [Mon, 21 Oct 2002 23:42:01 +0000 (23:42 +0000)] 
Fix return types of NdrConformantStringMarshall, NdrGetBuffer, and
NdrSendReceive.

22 years agoStubs for RpcServerUseProtseqA, RpcServerUseProtseqW.
Greg Turner [Mon, 21 Oct 2002 23:41:35 +0000 (23:41 +0000)] 
Stubs for RpcServerUseProtseqA, RpcServerUseProtseqW.

22 years agoNew AVI streamhandlers for audio and video streams.
Michael Günnewig [Mon, 21 Oct 2002 23:41:01 +0000 (23:41 +0000)] 
New AVI streamhandlers for audio and video streams.

22 years ago- Fixed usage of handler instead of type in AVIMakeCompressedStream.
Michael Günnewig [Mon, 21 Oct 2002 23:40:38 +0000 (23:40 +0000)] 
- Fixed usage of handler instead of type in AVIMakeCompressedStream.
- Implemented AVIBuildFilterA.
- Started to implement AVIBuildFilterW.

22 years ago- Fixed many bugs which prevents writing.
Michael Günnewig [Mon, 21 Oct 2002 23:40:09 +0000 (23:40 +0000)] 
- Fixed many bugs which prevents writing.
- Fixed segfault while parsing invalid index.
- Keep parsing of index even if streamheader says it's empty
- Fixed bug in AVIFILE_SaveIndex when stream is empty.
- Fixed bug in AVIFILE_WriteBlock, when chunk is not of even size.

22 years agoAdded macros for AVIFileClose and AVIStreamClose.
Michael Günnewig [Mon, 21 Oct 2002 23:39:20 +0000 (23:39 +0000)] 
Added macros for AVIFileClose and AVIStreamClose.

22 years agoDPAs can't have more than 0x8000 elements (fixed with lots of help
Dimitrie O. Paun [Mon, 21 Oct 2002 19:54:06 +0000 (19:54 +0000)] 
DPAs can't have more than 0x8000 elements (fixed with lots of help
from Carlos <clozano@andago.com).

22 years agoNo need to increment item size, it's already adjusted by DPA_SetPtr
Dimitrie O. Paun [Mon, 21 Oct 2002 19:49:44 +0000 (19:49 +0000)] 
No need to increment item size, it's already adjusted by DPA_SetPtr
(found, and fixed by Carlos <clozano@andago.com>).

22 years agoDo not rely on HeapReAlloc to allocate a NULL pointer.
Dimitrie O. Paun [Mon, 21 Oct 2002 19:49:12 +0000 (19:49 +0000)] 
Do not rely on HeapReAlloc to allocate a NULL pointer.

22 years agoRewrite DPA_InsertPtr in terms on DPA_SetPtr, so that it's simpler,
Dimitrie O. Paun [Mon, 21 Oct 2002 19:48:37 +0000 (19:48 +0000)] 
Rewrite DPA_InsertPtr in terms on DPA_SetPtr, so that  it's simpler,
cleaner, and more correct.
It now expands the array to accomodate larger than current size
indexes.

22 years agoDo not send uninitialized lParams on notification msgs (found by Rein
Dimitrie O. Paun [Mon, 21 Oct 2002 19:46:46 +0000 (19:46 +0000)] 
Do not send uninitialized lParams on notification msgs (found by Rein
Klazes <rklazes@xs4all.nl>).

22 years agoComplete rewrite of the rcView implementation.
Dimitrie O. Paun [Mon, 21 Oct 2002 19:46:08 +0000 (19:46 +0000)] 
Complete rewrite of the rcView implementation.
Lots of bugs fixed in rcView computation.
Assorted cleanups, and simplifications.

22 years agoSplit ranges_destroy in ranges_clear, and ranges_destroy.
Dimitrie O. Paun [Mon, 21 Oct 2002 19:45:29 +0000 (19:45 +0000)] 
Split ranges_destroy in ranges_clear, and ranges_destroy.
Rewrite DeleteAllItems, for cleaner, faster, more correct code.

22 years agoUpdated header documentation to the latest, and greatest.
Dimitrie O. Paun [Mon, 21 Oct 2002 19:44:51 +0000 (19:44 +0000)] 
Updated header documentation to the latest, and greatest.

22 years agoOptimize invalidation on insert.
Dimitrie O. Paun [Mon, 21 Oct 2002 19:44:18 +0000 (19:44 +0000)] 
Optimize invalidation on insert.
Share the invalidation code between {Delete,Insert}Item.

22 years agoRewrite DeleteItemT: cleaner, a lot faster.
Dimitrie O. Paun [Mon, 21 Oct 2002 19:43:37 +0000 (19:43 +0000)] 
Rewrite DeleteItemT: cleaner, a lot faster.
Number of bug were fixed.
The minimum possible is redrawn.

22 years agoImplement most of LVM_ARRANGE.
Dimitrie O. Paun [Mon, 21 Oct 2002 19:43:03 +0000 (19:43 +0000)] 
Implement most of LVM_ARRANGE.
Make use of it, where it was appropriate.
Use infoPtr->dwStyle directly, in most places.
Assorted cleanups.

22 years agoProper (type wise) return types.
Dimitrie O. Paun [Mon, 21 Oct 2002 19:42:30 +0000 (19:42 +0000)] 
Proper (type wise) return types.

22 years agoReorganize header notifications.
Dimitrie O. Paun [Mon, 21 Oct 2002 19:41:56 +0000 (19:41 +0000)] 
Reorganize header notifications.
Support notifications that don't have embedded size info.
Invalidate columns on format change (if needed).
Assorted cleanups.

22 years agoCrash on internal NULL pointers, don't test all over the place.
Dimitrie O. Paun [Mon, 21 Oct 2002 19:41:00 +0000 (19:41 +0000)] 
Crash on internal NULL pointers, don't test all over the place.

22 years agoWhen removing focus, no need to go through all elements.
Dimitrie O. Paun [Mon, 21 Oct 2002 19:40:26 +0000 (19:40 +0000)] 
When removing focus, no need to go through all elements.

22 years agoFix colors for selected items in full row select mode.
Dimitrie O. Paun [Mon, 21 Oct 2002 19:39:45 +0000 (19:39 +0000)] 
Fix colors for selected items in full row select mode.
Fix bug caused by use of uninitialized state.

22 years agoFix computation of subitem box, when invalidating it.
Dimitrie O. Paun [Mon, 21 Oct 2002 19:34:38 +0000 (19:34 +0000)] 
Fix computation of subitem box, when invalidating it.

22 years agoAssert on inconsistent range list states.
Dimitrie O. Paun [Mon, 21 Oct 2002 19:33:59 +0000 (19:33 +0000)] 
Assert on inconsistent range list states.
Various code cleanups, few potential bugs fixed.

22 years agoDo not grow the item list to arbritary index: if requested index is
Dimitrie O. Paun [Mon, 21 Oct 2002 19:33:14 +0000 (19:33 +0000)] 
Do not grow the item list to arbritary index: if requested index is
larger than current count, just append.
Miscellaneous cleanups.

22 years agoSetColumnWidth rewrite: simpler, cleaner code. Bugs squashed.
Dimitrie O. Paun [Mon, 21 Oct 2002 19:32:38 +0000 (19:32 +0000)] 
SetColumnWidth rewrite: simpler, cleaner code. Bugs squashed.

22 years agoHandle generic column width changes.
Dimitrie O. Paun [Mon, 21 Oct 2002 19:32:07 +0000 (19:32 +0000)] 
Handle generic column width changes.
Fix bug in SetColumnT which rendered it unusable.
Column code cleanup.

22 years agoAssert on internal invariants, rather than fail gracefully.
Dimitrie O. Paun [Mon, 21 Oct 2002 19:31:34 +0000 (19:31 +0000)] 
Assert on internal invariants, rather than fail gracefully.

22 years agoMore docs compliant alignment handling for subitems.
Dimitrie O. Paun [Mon, 21 Oct 2002 19:31:01 +0000 (19:31 +0000)] 
More docs compliant alignment handling for subitems.

22 years agoRun regedit even if not installed.
Vincent Béron [Mon, 21 Oct 2002 19:19:54 +0000 (19:19 +0000)] 
Run regedit even if not installed.

22 years agoNo longer using explicit values for resource identification.
Eric Pouech [Mon, 21 Oct 2002 19:18:42 +0000 (19:18 +0000)] 
No longer using explicit values for resource identification.

22 years agoFix notification from header, on item changed.
Dimitrie O. Paun [Mon, 21 Oct 2002 18:22:51 +0000 (18:22 +0000)] 
Fix notification from header, on item changed.
Small indentation fixes.

22 years agoSet the return value of the PD_PAGENUMS flag.
Duane Clark [Mon, 21 Oct 2002 18:22:31 +0000 (18:22 +0000)] 
Set the return value of the PD_PAGENUMS flag.

22 years agoImplement printing in notepad.
Duane Clark [Mon, 21 Oct 2002 18:22:15 +0000 (18:22 +0000)] 
Implement printing in notepad.

22 years agoAdd the basic support for volume textures / volumes (3d textures).
Jason Edmeades [Mon, 21 Oct 2002 18:21:59 +0000 (18:21 +0000)] 
Add the basic support for volume textures / volumes (3d textures).

22 years agoKeep on moving 16 bit code out of winmm, now only using linear
Eric Pouech [Mon, 21 Oct 2002 18:21:26 +0000 (18:21 +0000)] 
Keep on moving 16 bit code out of winmm, now only using linear
addresses for buffers.

22 years agoImplemented a few more macros for button manipulation
Eric Pouech [Mon, 21 Oct 2002 18:20:23 +0000 (18:20 +0000)] 
Implemented a few more macros for button manipulation
(enable/disable/changing macro).

22 years agoImproved a bit link handling (a few more link types loaded from file
Eric Pouech [Mon, 21 Oct 2002 18:20:05 +0000 (18:20 +0000)] 
Improved a bit link handling (a few more link types loaded from file
and support for link to a macro).

22 years agoActually use language identifier.
Dmitry Timoshkov [Mon, 21 Oct 2002 18:19:29 +0000 (18:19 +0000)] 
Actually use language identifier.

22 years agoCorrect the behavior for disabled toolbar buttons.
Duane Clark [Mon, 21 Oct 2002 18:19:02 +0000 (18:19 +0000)] 
Correct the behavior for disabled toolbar buttons.

22 years agoDo not create a range list for an empty range.
Dimitrie O. Paun [Sat, 19 Oct 2002 19:26:17 +0000 (19:26 +0000)] 
Do not create a range list for an empty range.

22 years agoStore the entire format bitmap in the column info.
Dimitrie O. Paun [Sat, 19 Oct 2002 19:25:41 +0000 (19:25 +0000)] 
Store the entire format bitmap in the column info.
Rewrite GetColumnT to take advantage of that.
Related cleanups, and simplifications.

22 years agoColumn zero has the image enabled always, irrespective of format.
Dimitrie O. Paun [Sat, 19 Oct 2002 19:25:01 +0000 (19:25 +0000)] 
Column zero has the image enabled always, irrespective of format.

22 years agoUnify {Insert,Set}ColumnT as much as possible.
Dimitrie O. Paun [Sat, 19 Oct 2002 19:24:24 +0000 (19:24 +0000)] 
Unify {Insert,Set}ColumnT as much as possible.
Fix a bunch of problems in SetColumnT.

22 years agoFix function header documentation.
Dimitrie O. Paun [Sat, 19 Oct 2002 19:23:31 +0000 (19:23 +0000)] 
Fix function header documentation.

22 years agoBetter report mode.
Dimitrie O. Paun [Sat, 19 Oct 2002 19:20:35 +0000 (19:20 +0000)] 
Better report mode.
Use the new column information to simplify, and speed up the code.
Enable support for images in subitems (in LVS_REPORT mode).

22 years agoConvert MessageBox family functions to unicode.
Dmitry Timoshkov [Sat, 19 Oct 2002 19:18:19 +0000 (19:18 +0000)] 
Convert MessageBox family functions to unicode.

22 years agoPatch cruft removal.
Greg Turner [Sat, 19 Oct 2002 19:17:37 +0000 (19:17 +0000)] 
Patch cruft removal.

22 years agoSuper-crude implementation for NdrClientCall2.
Greg Turner [Sat, 19 Oct 2002 19:17:19 +0000 (19:17 +0000)] 
Super-crude implementation for NdrClientCall2.
Specs and headers for NdrClientInitializeNew,
NdrConformantStringMarshall, NdrGetBuffer, NdrFreeBuffer, and
NdrSendReceive.

22 years agoFix up RpcMgmtWaitServerListen to be less incorrect.
Greg Turner [Sat, 19 Oct 2002 19:14:45 +0000 (19:14 +0000)] 
Fix up RpcMgmtWaitServerListen to be less incorrect.

22 years agoSome MIDL constants and structures (should eventually move to rpcndr.h
Greg Turner [Sat, 19 Oct 2002 19:14:25 +0000 (19:14 +0000)] 
Some MIDL constants and structures (should eventually move to rpcndr.h
I think).
Stubs for NdrClientInitializeNew, NdrConformantStringMarshall,
NdrGetBuffer, NdrFreeBuffer, and NdrSendReceive (not in specfile yet).

22 years agoGet/SetFastQueue16 should use HQUEUE16 handles.
Alexandre Julliard [Sat, 19 Oct 2002 17:20:44 +0000 (17:20 +0000)] 
Get/SetFastQueue16 should use HQUEUE16 handles.

22 years agoRemoved DECLARE_OLD_HANDLE. Fixed a few remaining warnings.
Alexandre Julliard [Sat, 19 Oct 2002 17:20:02 +0000 (17:20 +0000)] 
Removed DECLARE_OLD_HANDLE. Fixed a few remaining warnings.

22 years agodemangle_datatype: delete superflous free().
Uwe Bonnes [Sat, 19 Oct 2002 17:16:29 +0000 (17:16 +0000)] 
demangle_datatype: delete superflous free().

22 years agoAdd 3D support at the User driver level.
Lionel Ulmer [Sat, 19 Oct 2002 17:16:00 +0000 (17:16 +0000)] 
Add 3D support at the User driver level.

22 years agoFixed IWebBrowser::Navigate() parameter type.
Malte Starostik [Sat, 19 Oct 2002 17:15:39 +0000 (17:15 +0000)] 
Fixed IWebBrowser::Navigate() parameter type.
Added IWebBrowserApp and related typedefs.

22 years agoCorrected the alignment of unicode message table strings in wmc, and
Martin Fuchs [Sat, 19 Oct 2002 17:15:00 +0000 (17:15 +0000)] 
Corrected the alignment of unicode message table strings in wmc, and
switched to unicode for message strings, so that FormatMessage() now
works.

22 years agoConverted the server to -DSTRICT.
Alexandre Julliard [Sat, 19 Oct 2002 01:00:59 +0000 (01:00 +0000)] 
Converted the server to -DSTRICT.

22 years agoAdd documentation on how to modify what --debugmsg +relay reports.
Bill Medland [Sat, 19 Oct 2002 01:00:04 +0000 (01:00 +0000)] 
Add documentation on how to modify what --debugmsg +relay reports.

22 years agoWhen deleting an item, remove selection, don't add it!
Dimitrie O. Paun [Sat, 19 Oct 2002 00:59:34 +0000 (00:59 +0000)] 
When deleting an item, remove selection, don't add it!

22 years agoChanged the USER_HEAP_* macros to use HANDLEs instead of HANDLE16s.
Alexandre Julliard [Sat, 19 Oct 2002 00:55:34 +0000 (00:55 +0000)] 
Changed the USER_HEAP_* macros to use HANDLEs instead of HANDLE16s.

22 years agoSilence some warnings due to casts between pointer and integers of
Michael Stefaniuc [Sat, 19 Oct 2002 00:52:55 +0000 (00:52 +0000)] 
Silence some warnings due to casts between pointer and integers of
different size.

22 years agoFix warnings when converting between an ATOM and a HSZ.
Michael Stefaniuc [Sat, 19 Oct 2002 00:51:00 +0000 (00:51 +0000)] 
Fix warnings when converting between an ATOM and a HSZ.

22 years agoMore traces to help us make sense of the output.
Dimitrie O. Paun [Sat, 19 Oct 2002 00:21:02 +0000 (00:21 +0000)] 
More traces to help us make sense of the output.
Faster, cleaner ranges_{add,del}.

22 years agoFix ranges insertion bug (specify DPAS_SORTED when searching).
Dimitrie O. Paun [Sat, 19 Oct 2002 00:20:21 +0000 (00:20 +0000)] 
Fix ranges insertion bug (specify DPAS_SORTED when searching).
Add a lot of assert-ed consistency checks.
Add bunch of trace messages.

22 years agoInspect style bits independently on style change.
Dimitrie O. Paun [Sat, 19 Oct 2002 00:19:28 +0000 (00:19 +0000)] 
Inspect style bits independently on style change.