Andrew Talbot [Sat, 7 Feb 2009 19:38:54 +0000 (19:38 +0000)]
riched20: Remove unused functions.
Francois Gouget [Sat, 7 Feb 2009 19:18:40 +0000 (20:18 +0100)]
user32: LookupIconIdFromDirectory16() is unused so remove it.
Francois Gouget [Sat, 7 Feb 2009 15:04:49 +0000 (16:04 +0100)]
uxtheme: UXINI_ResetINI() is unused so remove it.
Francois Gouget [Sat, 7 Feb 2009 15:11:07 +0000 (16:11 +0100)]
d3dx9_36: The d3dx debug channel is unused so remove it.
Francois Gouget [Sat, 7 Feb 2009 15:10:33 +0000 (16:10 +0100)]
progman: Make DIALOG_Symbol() static.
Francois Gouget [Sat, 7 Feb 2009 15:09:34 +0000 (16:09 +0100)]
taskmgr: Make some functions static.
Francois Gouget [Sat, 7 Feb 2009 15:09:28 +0000 (16:09 +0100)]
shell32: HCR_GetDefaultIconFromGUIDW() is unused so remove it.
Francois Gouget [Sat, 7 Feb 2009 15:09:05 +0000 (16:09 +0100)]
shell32: Get rid of TRASH_ELEMENT and TRASH_DisposeElement().
The latter was unused while the former did not seem very useful.
Francois Gouget [Sat, 7 Feb 2009 15:08:22 +0000 (16:08 +0100)]
shell32: Remove some unused functions in clipboard.c.
Francois Gouget [Sat, 7 Feb 2009 15:07:37 +0000 (16:07 +0100)]
winealsa.drv: ALSA_PeekRingMessage() is not used anymore so remove it.
Francois Gouget [Sat, 7 Feb 2009 15:06:11 +0000 (16:06 +0100)]
urlmon: Make create_http_protocol() static.
Francois Gouget [Sat, 7 Feb 2009 15:06:02 +0000 (16:06 +0100)]
user32: Make EditWndProcW() static, fix its documentation.
Francois Gouget [Sat, 7 Feb 2009 15:05:33 +0000 (16:05 +0100)]
user32: Reorder some functions to avoid forward declarations in edit.c.
Francois Gouget [Sat, 7 Feb 2009 15:05:22 +0000 (16:05 +0100)]
user32: Remove unneeded forward declarations in edit.c.
Francois Gouget [Sat, 7 Feb 2009 15:04:23 +0000 (16:04 +0100)]
notepad: Make the Lithuanian resources SUBLANG_NEUTRAL.
Dylan Smith [Sat, 7 Feb 2009 18:21:29 +0000 (13:21 -0500)]
richedit: Removed ME_StrRelPos, ME_StrRelPos2, & ME_PosToVPos functions.
These functions were just being used for addition, so it was simpler to
remove the functions and modify the places it was used.
The ME_StrRelPos2 and ME_PosToVPos were just simple wrappers around
ME_StrRelPos, and ME_PosToVPos wasn't being used.
Dylan Smith [Sat, 7 Feb 2009 18:21:23 +0000 (13:21 -0500)]
richedit: Got rid of ME_GetCharFwd and ME_GetCharBack.
These two functions were being used for simple operations, to get the
first or last character when pre-computing flags for splitting runs.
The call to ME_GetCharBack wasn't even giving the correct result, it
would always return -1 since it is being called with nPos of 0.
This patch simplifies the code by removing the functions and getting the
characters directly from the string.
Dylan Smith [Sat, 7 Feb 2009 18:21:17 +0000 (13:21 -0500)]
richedit: Removed ME_StrLen and ME_StrVLen field access functions.
These functions were probably previously needed because of some wierd
special handling of backspace characters, but currently there is no
reason why the nLen field can't be accessed directly.
Having to functions that just access the string length field just causes
slightly more effort for someone to look at the code, because they need
to enter the function to find out what it actually is doing.
Dylan Smith [Sat, 7 Feb 2009 18:21:10 +0000 (13:21 -0500)]
richedit: Got rid of useless function ME_VPosToPos.
The function was just returning the second parameter. It had some
commented out code that indicated that previously backslashes weren't
included in the length. Native wordpad doesn't handle backspaces in a
special way, so this must have been an internal representation that
complicated finding the position of characters.
Dylan Smith [Sat, 7 Feb 2009 18:21:03 +0000 (13:21 -0500)]
richedit: Removed some conditions that are always taken.
ME_GetCursorCoordinates had two conditions that were always taken. The
first condition was if(pCursor->pRun->type == diRun) was following an
assertion making the exact same check. The next one, if(row), should
always be taken, otherwise the richedit controls are in a corrupt state,
therefore an assertion is more appropriate.
Dylan Smith [Sat, 7 Feb 2009 18:20:55 +0000 (13:20 -0500)]
richedit: Avoid duplication in make string functions using ME_MakeStringB.
I found that ME_MakeStringB was previously unused, and that the other
ME_MakeString functions repeated code that was already in ME_MakeStringB.
Making ME_MakeStringB static and using it to avoid duplicate code seemed
like a better idea than removing the function.
Dylan Smith [Sat, 7 Feb 2009 18:20:46 +0000 (13:20 -0500)]
richedit: Prevent string trunction due to NULL characters.
Dylan Smith [Sat, 7 Feb 2009 18:20:38 +0000 (13:20 -0500)]
richedit: Simplified ME_UpdateSelectionLinkAttribute.
Dylan Smith [Sat, 7 Feb 2009 18:20:31 +0000 (13:20 -0500)]
richedit: Directly get start and end of text on Ctrl-Home or Ctrl-End.
Previously it found the start or end by traversing the linked lists of
run, rows, paragraphs, and cells from the current position of the
cursors. Clearly it is better to get the start or end directly to make
it a constant time operation.
Dylan Smith [Sat, 7 Feb 2009 18:20:23 +0000 (13:20 -0500)]
richedit: Wrap even when message says not to repaint.
Wrapping is needed to be done even when repainting isn't done since
later messages expect line breaks to reflect the current text. Some
message can specify not to paint the sceen, but this should prevent
wrapping from being done.
Alexandre Julliard [Mon, 9 Feb 2009 11:57:39 +0000 (12:57 +0100)]
include: Moved VWIN32 ioctl definitions out of winioctl.h.
Alexandre Julliard [Mon, 9 Feb 2009 12:04:55 +0000 (13:04 +0100)]
setupapi: Don't use 'interface' as variable name, since it can be defined to a keyword.
Alexandre Julliard [Mon, 9 Feb 2009 12:03:59 +0000 (13:03 +0100)]
jscript: Rename the GetObjectW variable to avoid conflict with the function of the same name.
Alexandre Julliard [Mon, 9 Feb 2009 12:03:35 +0000 (13:03 +0100)]
rsaenh: Rename the HANDLETABLE structure to avoid conflicts with wingdi.h.
Alexandre Julliard [Mon, 9 Feb 2009 11:41:45 +0000 (12:41 +0100)]
include: Undefine a few Unicode macros that conflict with interface functions.
Andrew Talbot [Sat, 7 Feb 2009 14:32:54 +0000 (14:32 +0000)]
qcap: Remove an unused function.
Andrew Talbot [Sat, 7 Feb 2009 14:32:50 +0000 (14:32 +0000)]
cabinet: Declare a function static.
Juan Lang [Fri, 6 Feb 2009 23:28:55 +0000 (15:28 -0800)]
rpcrt4: Don't abort reading from a pipe if a single read is short.
Juan Lang [Fri, 6 Feb 2009 20:35:52 +0000 (12:35 -0800)]
cryptui: Delete the private keys if requested when they're successfully exported.
Juan Lang [Fri, 6 Feb 2009 20:17:45 +0000 (12:17 -0800)]
cryptui: Save private key in temporary store when exporting it.
Juan Lang [Fri, 6 Feb 2009 20:05:30 +0000 (12:05 -0800)]
cryptui: Ensure a certificate's private key is exportable before allowing it to be selected for export.
Juan Lang [Sun, 1 Feb 2009 22:31:37 +0000 (14:31 -0800)]
cryptui: Correct return value of the user cancels the export wizard.
Juan Lang [Sun, 1 Feb 2009 22:27:59 +0000 (14:27 -0800)]
cryptui: Implement exporting to a PFX file.
Juan Lang [Sun, 1 Feb 2009 21:23:04 +0000 (13:23 -0800)]
cryptui: Skip password page when moving backward through the export wizard if it wasn't shown in the first place.
Juan Lang [Sun, 1 Feb 2009 20:54:09 +0000 (12:54 -0800)]
cryptui: Validate password in export wizard.
Juan Lang [Sun, 1 Feb 2009 19:38:52 +0000 (11:38 -0800)]
cryptui: Only show password page if the private key is to be exported.
Juan Lang [Sun, 1 Feb 2009 19:34:21 +0000 (11:34 -0800)]
cryptui: Add a password page to the export wizard.
Juan Lang [Sun, 1 Feb 2009 19:14:31 +0000 (11:14 -0800)]
cryptui: Enable/disable PFX choice based on whether the private key is to be exported.
Juan Lang [Sun, 1 Feb 2009 19:06:44 +0000 (11:06 -0800)]
cryptui: Set default export format based on whether the private key is to be exported.
Juan Lang [Sun, 1 Feb 2009 18:34:05 +0000 (10:34 -0800)]
cryptui: Make a copy of export info in CryptUIWizExport.
Juan Lang [Sun, 1 Feb 2009 18:28:07 +0000 (10:28 -0800)]
cryptui: Prompt whether to export the private key from CryptUIWizExport.
Michael Stefaniuc [Fri, 6 Feb 2009 22:47:52 +0000 (23:47 +0100)]
include: Change two DWORD to DWORD_PTR in vfw.h to match the DDK.
Michael Stefaniuc [Fri, 6 Feb 2009 22:46:59 +0000 (23:46 +0100)]
riched20: Fix some Win64 compiler warnings.
- A HWND can be safely marshaled over a LONG as its payload is not
a pointer but a user handle.
- Use GetWindowLongPtr instead of GetWindowLong to retrieve a pointer.
Michael Stefaniuc [Fri, 6 Feb 2009 20:48:36 +0000 (21:48 +0100)]
spoolss: Add missing LeaveCriticalSection on error path (Smatch).
Aric Stewart [Fri, 6 Feb 2009 20:02:21 +0000 (14:02 -0600)]
msctf: Hook up ITfContextOwnerCompositionSink if present.
Juan Lang [Fri, 6 Feb 2009 17:43:33 +0000 (09:43 -0800)]
crypt32: Fix a regression in chain tests.
Relaxing the tests on older versions of Windows caused a couple tests
to fail on more recent ones, which was unintended.
Artem Reznikov [Fri, 6 Feb 2009 13:58:24 +0000 (14:58 +0100)]
avifil32: Ukranian translation.
Alexandre Julliard [Fri, 6 Feb 2009 22:20:27 +0000 (23:20 +0100)]
winepath: Fixed the wmain() definition.
Alexandre Julliard [Fri, 6 Feb 2009 22:20:01 +0000 (23:20 +0100)]
programs: Don't make apps Unicode if they don't use the command line.
Alexandre Julliard [Fri, 6 Feb 2009 21:31:56 +0000 (22:31 +0100)]
winmm: Disable system thread if poll() support is missing.
Alexandre Julliard [Fri, 6 Feb 2009 19:35:56 +0000 (20:35 +0100)]
winegcc: Don't pass the as/ld/nm commands to winebuild.
winebuild should be able to find them on its own.
Alexandre Julliard [Fri, 6 Feb 2009 19:31:59 +0000 (20:31 +0100)]
makefiles: Pass the target flags to winegcc.
Aurimas Fischer [Thu, 5 Feb 2009 21:16:53 +0000 (23:16 +0200)]
notepad: Add Lithuanian translation.
Alistair Leslie-Hughes [Wed, 4 Feb 2009 05:01:05 +0000 (16:01 +1100)]
mshtml: Implement IHTMLStyle_get_backgroundColor.
Alistair Leslie-Hughes [Wed, 4 Feb 2009 05:32:31 +0000 (16:32 +1100)]
mshtml: Implement IHTMLStyle_put_fontWeight.
Detlef Riekenberg [Fri, 6 Feb 2009 08:35:13 +0000 (09:35 +0100)]
spoolss: Move routing functions to a seperate file.
Jeremy White [Thu, 5 Feb 2009 22:23:29 +0000 (16:23 -0600)]
sane.ds: More completely implement ICAP_XFERMECH, with helper functions.
Alexandre Julliard [Fri, 6 Feb 2009 13:38:45 +0000 (14:38 +0100)]
widl: Print all NdrFcShort parameters as shorts to avoid warnings for negative values.
Alexandre Julliard [Fri, 6 Feb 2009 13:31:29 +0000 (14:31 +0100)]
widl: Add printf format attribute on all printf-like functions and fix resulting warnings.
Alexandre Julliard [Fri, 6 Feb 2009 13:30:38 +0000 (14:30 +0100)]
widl: Replace unsigned long and size_t by unsigned int where appropriate.
Alexandre Julliard [Fri, 6 Feb 2009 13:03:54 +0000 (14:03 +0100)]
widl: Add a dummy reference to the filter function to avoid a warning.
Alexandre Julliard [Fri, 6 Feb 2009 13:03:29 +0000 (14:03 +0100)]
widl: Avoid using GetExceptionCode outside of an exception handler.
David Adam [Fri, 6 Feb 2009 10:42:01 +0000 (11:42 +0100)]
d3dx8: Implement D3DXComputeBoundingBox.
David Adam [Thu, 5 Feb 2009 18:06:03 +0000 (19:06 +0100)]
d3dx8: Implement D3DXComputeBoundingSphere.
Luis C. Busquets Pérez [Thu, 5 Feb 2009 18:00:32 +0000 (19:00 +0100)]
d3dx8: Add tests for D3DXGetFVFVertexSize.
David Adam [Thu, 5 Feb 2009 17:56:47 +0000 (18:56 +0100)]
d3dx8: Implement D3DXGetFVFVertexSize.
David Adam [Thu, 5 Feb 2009 17:55:31 +0000 (18:55 +0100)]
d3dx8: Change the debug channel into the generic d3dx.
David Adam [Thu, 5 Feb 2009 17:53:09 +0000 (18:53 +0100)]
d3dx8: Remove useless includes.
David Adam [Fri, 6 Feb 2009 11:04:37 +0000 (12:04 +0100)]
d3dx8: Move some functions into core.c to match the header file layout.
Alexandre Julliard [Fri, 6 Feb 2009 12:56:09 +0000 (13:56 +0100)]
Fix position of CDECL qualifier for functions that return pointers.
Michael Stefaniuc [Fri, 6 Feb 2009 09:38:02 +0000 (10:38 +0100)]
comctl32/tests: Remove superfluous pointer casts.
Dylan Smith [Fri, 6 Feb 2009 06:10:06 +0000 (01:10 -0500)]
richedit: Avoided searching for adjacent paragraphs through runs.
When finding an adjacent paragraph, the next_para and prev_para pointers
should be used because they are direct pointers, a constant time
operation. Instead I found some places in the code that searched through
the general linked list to get to an adjacent paragraph, which is a linear
time operation, depending on the number of rows and runs in between
paragraphs.
Dylan Smith [Fri, 6 Feb 2009 06:10:00 +0000 (01:10 -0500)]
richedit: Removed incorrect FIXME comment.
The fixme comment is suggesting wrapping a paragraph within a function
that is for moving the selection cursor up or down a line when the up
or down keys are pressed. The contents fo paragraph aren't being
changed, so there is no need to wrap the paragraph.
Dylan Smith [Fri, 6 Feb 2009 06:09:56 +0000 (01:09 -0500)]
richedit: Add paragraph field to wrap context to avoid searching for it.
More case of searching for the paragraph through the linked list when
is was already previously available. Since each wrap context is used
for wrapping each paragraph, I decided to add the reference to the
paragarph in the structure.
Dylan Smith [Fri, 6 Feb 2009 06:09:51 +0000 (01:09 -0500)]
richedit: Accept paragraph as parameter for ME_CharOfsFromRunOfs.
Rather than get the paragraph from the run, the function allows the
caller to provide the paragraph, since it is already available. This
reduces unnecessary traversals of lists that take longer as more runs
and rows are in the paragraph.
Dylan Smith [Fri, 6 Feb 2009 06:09:47 +0000 (01:09 -0500)]
richedit: Get the paragraph with ME_RunOfsFromCharOfs.
The ME_RunOfsFromCharOfs function finds the paragraph before finding the
run and offset within the run, so the function may as well be able to
return this paragraph to the caller. Many callers to the function
instead find the paragraph from the run, which ends up unnecessarily
traversing a linked list of runs within the paragraph.
Dylan Smith [Fri, 6 Feb 2009 06:09:43 +0000 (01:09 -0500)]
richedit: Properly destroy context in two places.
Whenever ME_InitContext is called, ME_DestroyContext should be used to
clean it up. This way the context can be extended easily by modifying
those two functions. Instead, these two places of code just released
the DC, without using ME_DestroyContext, so the created brush for the
margin was not deleted.
Dylan Smith [Fri, 6 Feb 2009 06:09:36 +0000 (01:09 -0500)]
richedit: Removed unnecessary calls to ME_WrapMarkedParagraphs.
These calls to ME_WrapMarkedParagraphs never do anything, and don't make
sense to be called in these places. These places are for ME_MoveCaret,
and ME_ArrowHome, which both don't involve any text being modified, and
all (direct and indirect) calls to these functions are done after the
text has already been wrapped.
Dylan Smith [Fri, 6 Feb 2009 06:09:30 +0000 (01:09 -0500)]
richedit: Simplified the character length delete protection.
The value for nMaxChars can be found easier by using ME_GetTextLength.
Juan Lang [Thu, 5 Feb 2009 18:12:55 +0000 (10:12 -0800)]
crypt32: Fix some test failures on older versions of Windows.
Aric Stewart [Thu, 5 Feb 2009 20:17:50 +0000 (14:17 -0600)]
msctf: Define ITfContextOwnerCompositionSink. This is implemented by a tsf aware application.
Aric Stewart [Thu, 5 Feb 2009 20:17:41 +0000 (14:17 -0600)]
msctf: When a Context is created connect to the ITextStoreACP if provided and create and advise our ITextStoreACPSink.
Aric Stewart [Thu, 5 Feb 2009 20:17:32 +0000 (14:17 -0600)]
msctf: Define ITextStoreACP.
Aric Stewart [Thu, 5 Feb 2009 20:17:26 +0000 (14:17 -0600)]
msctf: Add stub ITextStoreACPSink.
Jacek Caban [Thu, 5 Feb 2009 20:18:16 +0000 (21:18 +0100)]
mshtml: Remove document observer before releasing nsdoc.
Jacek Caban [Thu, 5 Feb 2009 20:17:58 +0000 (21:17 +0100)]
mshtml: Wine Gecko 0.9.1 release.
Paul Vriens [Fri, 6 Feb 2009 10:20:00 +0000 (11:20 +0100)]
fusion/tests: Fix some tests failures on .NET 1.1 (and Win98).
Paul Vriens [Fri, 6 Feb 2009 07:31:48 +0000 (08:31 +0100)]
fusion/tests: Fix a test failure on Win64.
Paul Vriens [Fri, 6 Feb 2009 07:27:08 +0000 (08:27 +0100)]
fusion/tests: Fix some test failures on systems with .NET 1.1.
Paul Vriens [Fri, 6 Feb 2009 07:11:49 +0000 (08:11 +0100)]
fusion/tests: Run tests correctly on Win98.
Michael Stefaniuc [Fri, 6 Feb 2009 00:12:14 +0000 (01:12 +0100)]
winejack.drv: The dwParam1/dwParam2 function arguments are DWORD_PTR.
Michael Stefaniuc [Fri, 6 Feb 2009 00:11:18 +0000 (01:11 +0100)]
winmm: SendDriverMessage takes LPARAM as 3rd and 4th argument.
Andre Wisplinghoff [Thu, 5 Feb 2009 23:19:57 +0000 (00:19 +0100)]
comdlg32: Update German and French translation.
Ken Thomases [Thu, 5 Feb 2009 21:49:04 +0000 (15:49 -0600)]
winecoreaudio.drv: Add support for waveOutBreakLoop/WODM_BREAKLOOP.
Marcus Meissner [Thu, 5 Feb 2009 21:03:59 +0000 (22:03 +0100)]
mshtml: Fixed size passed to MultiByteToWideChar.