2 #include "object-store.h"
12 #include "sha1-array.h"
18 #define FOREACH_MSG_ID(FUNC) \
20 FUNC(NUL_IN_HEADER, FATAL) \
21 FUNC(UNTERMINATED_HEADER, FATAL) \
23 FUNC(BAD_DATE, ERROR) \
24 FUNC(BAD_DATE_OVERFLOW, ERROR) \
25 FUNC(BAD_EMAIL, ERROR) \
26 FUNC(BAD_NAME, ERROR) \
27 FUNC(BAD_OBJECT_SHA1, ERROR) \
28 FUNC(BAD_PARENT_SHA1, ERROR) \
29 FUNC(BAD_TAG_OBJECT, ERROR) \
30 FUNC(BAD_TIMEZONE, ERROR) \
31 FUNC(BAD_TREE, ERROR) \
32 FUNC(BAD_TREE_SHA1, ERROR) \
33 FUNC(BAD_TYPE, ERROR) \
34 FUNC(DUPLICATE_ENTRIES, ERROR) \
35 FUNC(MISSING_AUTHOR, ERROR) \
36 FUNC(MISSING_COMMITTER, ERROR) \
37 FUNC(MISSING_EMAIL, ERROR) \
38 FUNC(MISSING_GRAFT, ERROR) \
39 FUNC(MISSING_NAME_BEFORE_EMAIL, ERROR) \
40 FUNC(MISSING_OBJECT, ERROR) \
41 FUNC(MISSING_PARENT, ERROR) \
42 FUNC(MISSING_SPACE_BEFORE_DATE, ERROR) \
43 FUNC(MISSING_SPACE_BEFORE_EMAIL, ERROR) \
44 FUNC(MISSING_TAG, ERROR) \
45 FUNC(MISSING_TAG_ENTRY, ERROR) \
46 FUNC(MISSING_TAG_OBJECT, ERROR) \
47 FUNC(MISSING_TREE, ERROR) \
48 FUNC(MISSING_TYPE, ERROR) \
49 FUNC(MISSING_TYPE_ENTRY, ERROR) \
50 FUNC(MULTIPLE_AUTHORS, ERROR) \
51 FUNC(TAG_OBJECT_NOT_TAG, ERROR) \
52 FUNC(TREE_NOT_SORTED, ERROR) \
53 FUNC(UNKNOWN_TYPE, ERROR) \
54 FUNC(ZERO_PADDED_DATE, ERROR) \
56 FUNC(BAD_FILEMODE, WARN) \
57 FUNC(EMPTY_NAME, WARN) \
58 FUNC(FULL_PATHNAME, WARN) \
60 FUNC(HAS_DOTDOT, WARN) \
61 FUNC(HAS_DOTGIT, WARN) \
62 FUNC(NULL_SHA1, WARN) \
63 FUNC(ZERO_PADDED_FILEMODE, WARN) \
64 FUNC(NUL_IN_COMMIT, WARN) \
65 /* infos (reported as warnings, but ignored by default) */ \
66 FUNC(BAD_TAG_NAME, INFO) \
67 FUNC(MISSING_TAGGER_ENTRY, INFO)
69 #define MSG_ID(id, msg_type) FSCK_MSG_##id,
71 FOREACH_MSG_ID(MSG_ID)
77 #define MSG_ID(id, msg_type) { STR(id), NULL, FSCK_##msg_type },
79 const char *id_string;
80 const char *downcased;
82 } msg_id_info[FSCK_MSG_MAX + 1] = {
83 FOREACH_MSG_ID(MSG_ID)
88 static int parse_msg_id(const char *text)
92 if (!msg_id_info[0].downcased) {
93 /* convert id_string to lower case, without underscores. */
94 for (i = 0; i < FSCK_MSG_MAX; i++) {
95 const char *p = msg_id_info[i].id_string;
97 char *q = xmalloc(len);
99 msg_id_info[i].downcased = q;
104 *(q)++ = tolower(*(p)++);
109 for (i = 0; i < FSCK_MSG_MAX; i++)
110 if (!strcmp(text, msg_id_info[i].downcased))
116 static int fsck_msg_type(enum fsck_msg_id msg_id,
117 struct fsck_options *options)
121 assert(msg_id >= 0 && msg_id < FSCK_MSG_MAX);
123 if (options->msg_type)
124 msg_type = options->msg_type[msg_id];
126 msg_type = msg_id_info[msg_id].msg_type;
127 if (options->strict && msg_type == FSCK_WARN)
128 msg_type = FSCK_ERROR;
134 static void init_skiplist(struct fsck_options *options, const char *path)
136 static struct oid_array skiplist = OID_ARRAY_INIT;
138 char buffer[GIT_MAX_HEXSZ + 1];
139 struct object_id oid;
141 if (options->skiplist)
142 sorted = options->skiplist->sorted;
145 options->skiplist = &skiplist;
148 fd = open(path, O_RDONLY);
150 die("Could not open skip list: %s", path);
153 int result = read_in_full(fd, buffer, sizeof(buffer));
155 die_errno("Could not read '%s'", path);
158 if (parse_oid_hex(buffer, &oid, &p) || *p != '\n')
159 die("Invalid SHA-1: %s", buffer);
160 oid_array_append(&skiplist, &oid);
161 if (sorted && skiplist.nr > 1 &&
162 oidcmp(&skiplist.oid[skiplist.nr - 2],
172 static int parse_msg_type(const char *str)
174 if (!strcmp(str, "error"))
176 else if (!strcmp(str, "warn"))
178 else if (!strcmp(str, "ignore"))
181 die("Unknown fsck message type: '%s'", str);
184 int is_valid_msg_type(const char *msg_id, const char *msg_type)
186 if (parse_msg_id(msg_id) < 0)
188 parse_msg_type(msg_type);
192 void fsck_set_msg_type(struct fsck_options *options,
193 const char *msg_id, const char *msg_type)
195 int id = parse_msg_id(msg_id), type;
198 die("Unhandled message id: %s", msg_id);
199 type = parse_msg_type(msg_type);
201 if (type != FSCK_ERROR && msg_id_info[id].msg_type == FSCK_FATAL)
202 die("Cannot demote %s to %s", msg_id, msg_type);
204 if (!options->msg_type) {
207 ALLOC_ARRAY(msg_type, FSCK_MSG_MAX);
208 for (i = 0; i < FSCK_MSG_MAX; i++)
209 msg_type[i] = fsck_msg_type(i, options);
210 options->msg_type = msg_type;
213 options->msg_type[id] = type;
216 void fsck_set_msg_types(struct fsck_options *options, const char *values)
218 char *buf = xstrdup(values), *to_free = buf;
222 int len = strcspn(buf, " ,|"), equal;
232 equal < len && buf[equal] != '=' && buf[equal] != ':';
234 buf[equal] = tolower(buf[equal]);
237 if (!strcmp(buf, "skiplist")) {
239 die("skiplist requires a path");
240 init_skiplist(options, buf + equal + 1);
246 die("Missing '=': '%s'", buf);
248 fsck_set_msg_type(options, buf, buf + equal + 1);
254 static void append_msg_id(struct strbuf *sb, const char *msg_id)
257 char c = *(msg_id)++;
262 strbuf_addch(sb, tolower(c));
265 strbuf_addch(sb, *(msg_id)++);
269 strbuf_addstr(sb, ": ");
272 __attribute__((format (printf, 4, 5)))
273 static int report(struct fsck_options *options, struct object *object,
274 enum fsck_msg_id id, const char *fmt, ...)
277 struct strbuf sb = STRBUF_INIT;
278 int msg_type = fsck_msg_type(id, options), result;
280 if (msg_type == FSCK_IGNORE)
283 if (options->skiplist && object &&
284 oid_array_lookup(options->skiplist, &object->oid) >= 0)
287 if (msg_type == FSCK_FATAL)
288 msg_type = FSCK_ERROR;
289 else if (msg_type == FSCK_INFO)
290 msg_type = FSCK_WARN;
292 append_msg_id(&sb, msg_id_info[id].id_string);
295 strbuf_vaddf(&sb, fmt, ap);
296 result = options->error_func(options, object, msg_type, sb.buf);
303 static char *get_object_name(struct fsck_options *options, struct object *obj)
305 if (!options->object_names)
307 return lookup_decoration(options->object_names, obj);
310 static void put_object_name(struct fsck_options *options, struct object *obj,
311 const char *fmt, ...)
314 struct strbuf buf = STRBUF_INIT;
317 if (!options->object_names)
319 existing = lookup_decoration(options->object_names, obj);
323 strbuf_vaddf(&buf, fmt, ap);
324 add_decoration(options->object_names, obj, strbuf_detach(&buf, NULL));
328 static const char *describe_object(struct fsck_options *o, struct object *obj)
330 static struct strbuf buf = STRBUF_INIT;
334 strbuf_addstr(&buf, oid_to_hex(&obj->oid));
335 if (o->object_names && (name = lookup_decoration(o->object_names, obj)))
336 strbuf_addf(&buf, " (%s)", name);
341 static int fsck_walk_tree(struct tree *tree, void *data, struct fsck_options *options)
343 struct tree_desc desc;
344 struct name_entry entry;
348 if (parse_tree(tree))
351 name = get_object_name(options, &tree->object);
352 if (init_tree_desc_gently(&desc, tree->buffer, tree->size))
354 while (tree_entry_gently(&desc, &entry)) {
358 if (S_ISGITLINK(entry.mode))
361 if (S_ISDIR(entry.mode)) {
362 obj = (struct object *)lookup_tree(entry.oid);
364 put_object_name(options, obj, "%s%s/", name,
366 result = options->walk(obj, OBJ_TREE, data, options);
368 else if (S_ISREG(entry.mode) || S_ISLNK(entry.mode)) {
369 obj = (struct object *)lookup_blob(entry.oid);
371 put_object_name(options, obj, "%s%s", name,
373 result = options->walk(obj, OBJ_BLOB, data, options);
376 result = error("in tree %s: entry %s has bad mode %.6o",
377 describe_object(options, &tree->object), entry.path, entry.mode);
387 static int fsck_walk_commit(struct commit *commit, void *data, struct fsck_options *options)
389 int counter = 0, generation = 0, name_prefix_len = 0;
390 struct commit_list *parents;
395 if (parse_commit(commit))
398 name = get_object_name(options, &commit->object);
400 put_object_name(options, &commit->tree->object, "%s:", name);
402 result = options->walk((struct object *)commit->tree, OBJ_TREE, data, options);
407 parents = commit->parents;
408 if (name && parents) {
409 int len = strlen(name), power;
411 if (len && name[len - 1] == '^') {
413 name_prefix_len = len - 1;
415 else { /* parse ~<generation> suffix */
416 for (generation = 0, power = 1;
417 len && isdigit(name[len - 1]);
419 generation += power * (name[--len] - '0');
420 if (power > 1 && len && name[len - 1] == '~')
421 name_prefix_len = len - 1;
427 struct object *obj = &parents->item->object;
430 put_object_name(options, obj, "%s^%d",
432 else if (generation > 0)
433 put_object_name(options, obj, "%.*s~%d",
434 name_prefix_len, name, generation + 1);
436 put_object_name(options, obj, "%s^", name);
438 result = options->walk((struct object *)parents->item, OBJ_COMMIT, data, options);
443 parents = parents->next;
448 static int fsck_walk_tag(struct tag *tag, void *data, struct fsck_options *options)
450 char *name = get_object_name(options, &tag->object);
455 put_object_name(options, tag->tagged, "%s", name);
456 return options->walk(tag->tagged, OBJ_ANY, data, options);
459 int fsck_walk(struct object *obj, void *data, struct fsck_options *options)
464 if (obj->type == OBJ_NONE)
465 parse_object(&obj->oid);
471 return fsck_walk_tree((struct tree *)obj, data, options);
473 return fsck_walk_commit((struct commit *)obj, data, options);
475 return fsck_walk_tag((struct tag *)obj, data, options);
477 error("Unknown object type for %s", describe_object(options, obj));
483 * The entries in a tree are ordered in the _path_ order,
484 * which means that a directory entry is ordered by adding
485 * a slash to the end of it.
487 * So a directory called "a" is ordered _after_ a file
488 * called "a.c", because "a/" sorts after "a.c".
490 #define TREE_UNORDERED (-1)
491 #define TREE_HAS_DUPS (-2)
493 static int verify_ordered(unsigned mode1, const char *name1, unsigned mode2, const char *name2)
495 int len1 = strlen(name1);
496 int len2 = strlen(name2);
497 int len = len1 < len2 ? len1 : len2;
498 unsigned char c1, c2;
501 cmp = memcmp(name1, name2, len);
505 return TREE_UNORDERED;
508 * Ok, the first <len> characters are the same.
509 * Now we need to order the next one, but turn
510 * a '\0' into a '/' for a directory entry.
516 * git-write-tree used to write out a nonsense tree that has
517 * entries with the same name, one blob and one tree. Make
518 * sure we do not have duplicate entries.
520 return TREE_HAS_DUPS;
521 if (!c1 && S_ISDIR(mode1))
523 if (!c2 && S_ISDIR(mode2))
525 return c1 < c2 ? 0 : TREE_UNORDERED;
528 static int fsck_tree(struct tree *item, struct fsck_options *options)
531 int has_null_sha1 = 0;
532 int has_full_path = 0;
533 int has_empty_name = 0;
537 int has_zero_pad = 0;
538 int has_bad_modes = 0;
539 int has_dup_entries = 0;
540 int not_properly_sorted = 0;
541 struct tree_desc desc;
545 if (init_tree_desc_gently(&desc, item->buffer, item->size)) {
546 retval += report(options, &item->object, FSCK_MSG_BAD_TREE, "cannot be parsed as a tree");
556 const struct object_id *oid;
558 oid = tree_entry_extract(&desc, &name, &mode);
560 has_null_sha1 |= is_null_oid(oid);
561 has_full_path |= !!strchr(name, '/');
562 has_empty_name |= !*name;
563 has_dot |= !strcmp(name, ".");
564 has_dotdot |= !strcmp(name, "..");
565 has_dotgit |= (!strcmp(name, ".git") ||
566 is_hfs_dotgit(name) ||
567 is_ntfs_dotgit(name));
568 has_zero_pad |= *(char *)desc.buffer == '0';
569 if (update_tree_entry_gently(&desc)) {
570 retval += report(options, &item->object, FSCK_MSG_BAD_TREE, "cannot be parsed as a tree");
585 * This is nonstandard, but we had a few of these
586 * early on when we honored the full set of mode
590 if (!options->strict)
598 switch (verify_ordered(o_mode, o_name, mode, name)) {
600 not_properly_sorted = 1;
615 retval += report(options, &item->object, FSCK_MSG_NULL_SHA1, "contains entries pointing to null sha1");
617 retval += report(options, &item->object, FSCK_MSG_FULL_PATHNAME, "contains full pathnames");
619 retval += report(options, &item->object, FSCK_MSG_EMPTY_NAME, "contains empty pathname");
621 retval += report(options, &item->object, FSCK_MSG_HAS_DOT, "contains '.'");
623 retval += report(options, &item->object, FSCK_MSG_HAS_DOTDOT, "contains '..'");
625 retval += report(options, &item->object, FSCK_MSG_HAS_DOTGIT, "contains '.git'");
627 retval += report(options, &item->object, FSCK_MSG_ZERO_PADDED_FILEMODE, "contains zero-padded file modes");
629 retval += report(options, &item->object, FSCK_MSG_BAD_FILEMODE, "contains bad file modes");
631 retval += report(options, &item->object, FSCK_MSG_DUPLICATE_ENTRIES, "contains duplicate file entries");
632 if (not_properly_sorted)
633 retval += report(options, &item->object, FSCK_MSG_TREE_NOT_SORTED, "not properly sorted");
637 static int verify_headers(const void *data, unsigned long size,
638 struct object *obj, struct fsck_options *options)
640 const char *buffer = (const char *)data;
643 for (i = 0; i < size; i++) {
646 return report(options, obj,
647 FSCK_MSG_NUL_IN_HEADER,
648 "unterminated header: NUL at offset %ld", i);
650 if (i + 1 < size && buffer[i + 1] == '\n')
656 * We did not find double-LF that separates the header
657 * and the body. Not having a body is not a crime but
658 * we do want to see the terminating LF for the last header
661 if (size && buffer[size - 1] == '\n')
664 return report(options, obj,
665 FSCK_MSG_UNTERMINATED_HEADER, "unterminated header");
668 static int fsck_ident(const char **ident, struct object *obj, struct fsck_options *options)
670 const char *p = *ident;
673 *ident = strchrnul(*ident, '\n');
678 return report(options, obj, FSCK_MSG_MISSING_NAME_BEFORE_EMAIL, "invalid author/committer line - missing space before email");
679 p += strcspn(p, "<>\n");
681 return report(options, obj, FSCK_MSG_BAD_NAME, "invalid author/committer line - bad name");
683 return report(options, obj, FSCK_MSG_MISSING_EMAIL, "invalid author/committer line - missing email");
685 return report(options, obj, FSCK_MSG_MISSING_SPACE_BEFORE_EMAIL, "invalid author/committer line - missing space before email");
687 p += strcspn(p, "<>\n");
689 return report(options, obj, FSCK_MSG_BAD_EMAIL, "invalid author/committer line - bad email");
692 return report(options, obj, FSCK_MSG_MISSING_SPACE_BEFORE_DATE, "invalid author/committer line - missing space before date");
694 if (*p == '0' && p[1] != ' ')
695 return report(options, obj, FSCK_MSG_ZERO_PADDED_DATE, "invalid author/committer line - zero-padded date");
696 if (date_overflows(parse_timestamp(p, &end, 10)))
697 return report(options, obj, FSCK_MSG_BAD_DATE_OVERFLOW, "invalid author/committer line - date causes integer overflow");
698 if ((end == p || *end != ' '))
699 return report(options, obj, FSCK_MSG_BAD_DATE, "invalid author/committer line - bad date");
701 if ((*p != '+' && *p != '-') ||
707 return report(options, obj, FSCK_MSG_BAD_TIMEZONE, "invalid author/committer line - bad time zone");
712 static int fsck_commit_buffer(struct commit *commit, const char *buffer,
713 unsigned long size, struct fsck_options *options)
715 unsigned char tree_sha1[20], sha1[20];
716 struct commit_graft *graft;
717 unsigned parent_count, parent_line_count = 0, author_count;
719 const char *buffer_begin = buffer;
721 if (verify_headers(buffer, size, &commit->object, options))
724 if (!skip_prefix(buffer, "tree ", &buffer))
725 return report(options, &commit->object, FSCK_MSG_MISSING_TREE, "invalid format - expected 'tree' line");
726 if (get_sha1_hex(buffer, tree_sha1) || buffer[40] != '\n') {
727 err = report(options, &commit->object, FSCK_MSG_BAD_TREE_SHA1, "invalid 'tree' line format - bad sha1");
732 while (skip_prefix(buffer, "parent ", &buffer)) {
733 if (get_sha1_hex(buffer, sha1) || buffer[40] != '\n') {
734 err = report(options, &commit->object, FSCK_MSG_BAD_PARENT_SHA1, "invalid 'parent' line format - bad sha1");
741 graft = lookup_commit_graft(the_repository, &commit->object.oid);
742 parent_count = commit_list_count(commit->parents);
744 if (graft->nr_parent == -1 && !parent_count)
745 ; /* shallow commit */
746 else if (graft->nr_parent != parent_count) {
747 err = report(options, &commit->object, FSCK_MSG_MISSING_GRAFT, "graft objects missing");
752 if (parent_count != parent_line_count) {
753 err = report(options, &commit->object, FSCK_MSG_MISSING_PARENT, "parent objects missing");
759 while (skip_prefix(buffer, "author ", &buffer)) {
761 err = fsck_ident(&buffer, &commit->object, options);
765 if (author_count < 1)
766 err = report(options, &commit->object, FSCK_MSG_MISSING_AUTHOR, "invalid format - expected 'author' line");
767 else if (author_count > 1)
768 err = report(options, &commit->object, FSCK_MSG_MULTIPLE_AUTHORS, "invalid format - multiple 'author' lines");
771 if (!skip_prefix(buffer, "committer ", &buffer))
772 return report(options, &commit->object, FSCK_MSG_MISSING_COMMITTER, "invalid format - expected 'committer' line");
773 err = fsck_ident(&buffer, &commit->object, options);
777 err = report(options, &commit->object, FSCK_MSG_BAD_TREE, "could not load commit's tree %s", sha1_to_hex(tree_sha1));
781 if (memchr(buffer_begin, '\0', size)) {
782 err = report(options, &commit->object, FSCK_MSG_NUL_IN_COMMIT,
783 "NUL byte in the commit object body");
790 static int fsck_commit(struct commit *commit, const char *data,
791 unsigned long size, struct fsck_options *options)
793 const char *buffer = data ? data : get_commit_buffer(commit, &size);
794 int ret = fsck_commit_buffer(commit, buffer, size, options);
796 unuse_commit_buffer(commit, buffer);
800 static int fsck_tag_buffer(struct tag *tag, const char *data,
801 unsigned long size, struct fsck_options *options)
803 unsigned char sha1[20];
806 char *to_free = NULL, *eol;
807 struct strbuf sb = STRBUF_INIT;
812 enum object_type type;
815 read_object_file(&tag->object.oid, &type, &size);
817 return report(options, &tag->object,
818 FSCK_MSG_MISSING_TAG_OBJECT,
819 "cannot read tag object");
821 if (type != OBJ_TAG) {
822 ret = report(options, &tag->object,
823 FSCK_MSG_TAG_OBJECT_NOT_TAG,
824 "expected tag got %s",
830 ret = verify_headers(buffer, size, &tag->object, options);
834 if (!skip_prefix(buffer, "object ", &buffer)) {
835 ret = report(options, &tag->object, FSCK_MSG_MISSING_OBJECT, "invalid format - expected 'object' line");
838 if (get_sha1_hex(buffer, sha1) || buffer[40] != '\n') {
839 ret = report(options, &tag->object, FSCK_MSG_BAD_OBJECT_SHA1, "invalid 'object' line format - bad sha1");
845 if (!skip_prefix(buffer, "type ", &buffer)) {
846 ret = report(options, &tag->object, FSCK_MSG_MISSING_TYPE_ENTRY, "invalid format - expected 'type' line");
849 eol = strchr(buffer, '\n');
851 ret = report(options, &tag->object, FSCK_MSG_MISSING_TYPE, "invalid format - unexpected end after 'type' line");
854 if (type_from_string_gently(buffer, eol - buffer, 1) < 0)
855 ret = report(options, &tag->object, FSCK_MSG_BAD_TYPE, "invalid 'type' value");
860 if (!skip_prefix(buffer, "tag ", &buffer)) {
861 ret = report(options, &tag->object, FSCK_MSG_MISSING_TAG_ENTRY, "invalid format - expected 'tag' line");
864 eol = strchr(buffer, '\n');
866 ret = report(options, &tag->object, FSCK_MSG_MISSING_TAG, "invalid format - unexpected end after 'type' line");
869 strbuf_addf(&sb, "refs/tags/%.*s", (int)(eol - buffer), buffer);
870 if (check_refname_format(sb.buf, 0)) {
871 ret = report(options, &tag->object, FSCK_MSG_BAD_TAG_NAME,
872 "invalid 'tag' name: %.*s",
873 (int)(eol - buffer), buffer);
879 if (!skip_prefix(buffer, "tagger ", &buffer)) {
880 /* early tags do not contain 'tagger' lines; warn only */
881 ret = report(options, &tag->object, FSCK_MSG_MISSING_TAGGER_ENTRY, "invalid format - expected 'tagger' line");
886 ret = fsck_ident(&buffer, &tag->object, options);
894 static int fsck_tag(struct tag *tag, const char *data,
895 unsigned long size, struct fsck_options *options)
897 struct object *tagged = tag->tagged;
900 return report(options, &tag->object, FSCK_MSG_BAD_TAG_OBJECT, "could not load tagged object");
902 return fsck_tag_buffer(tag, data, size, options);
905 int fsck_object(struct object *obj, void *data, unsigned long size,
906 struct fsck_options *options)
909 return report(options, obj, FSCK_MSG_BAD_OBJECT_SHA1, "no valid object to fsck");
911 if (obj->type == OBJ_BLOB)
913 if (obj->type == OBJ_TREE)
914 return fsck_tree((struct tree *) obj, options);
915 if (obj->type == OBJ_COMMIT)
916 return fsck_commit((struct commit *) obj, (const char *) data,
918 if (obj->type == OBJ_TAG)
919 return fsck_tag((struct tag *) obj, (const char *) data,
922 return report(options, obj, FSCK_MSG_UNKNOWN_TYPE, "unknown type '%d' (internal fsck error)",
926 int fsck_error_function(struct fsck_options *o,
927 struct object *obj, int msg_type, const char *message)
929 if (msg_type == FSCK_WARN) {
930 warning("object %s: %s", describe_object(o, obj), message);
933 error("object %s: %s", describe_object(o, obj), message);