11 #include "sha1-array.h"
17 #define FOREACH_MSG_ID(FUNC) \
19 FUNC(NUL_IN_HEADER, FATAL) \
20 FUNC(UNTERMINATED_HEADER, FATAL) \
22 FUNC(BAD_DATE, ERROR) \
23 FUNC(BAD_DATE_OVERFLOW, ERROR) \
24 FUNC(BAD_EMAIL, ERROR) \
25 FUNC(BAD_NAME, ERROR) \
26 FUNC(BAD_OBJECT_SHA1, ERROR) \
27 FUNC(BAD_PARENT_SHA1, ERROR) \
28 FUNC(BAD_TAG_OBJECT, ERROR) \
29 FUNC(BAD_TIMEZONE, ERROR) \
30 FUNC(BAD_TREE, ERROR) \
31 FUNC(BAD_TREE_SHA1, ERROR) \
32 FUNC(BAD_TYPE, ERROR) \
33 FUNC(DUPLICATE_ENTRIES, ERROR) \
34 FUNC(MISSING_AUTHOR, ERROR) \
35 FUNC(MISSING_COMMITTER, ERROR) \
36 FUNC(MISSING_EMAIL, ERROR) \
37 FUNC(MISSING_GRAFT, ERROR) \
38 FUNC(MISSING_NAME_BEFORE_EMAIL, ERROR) \
39 FUNC(MISSING_OBJECT, ERROR) \
40 FUNC(MISSING_PARENT, ERROR) \
41 FUNC(MISSING_SPACE_BEFORE_DATE, ERROR) \
42 FUNC(MISSING_SPACE_BEFORE_EMAIL, ERROR) \
43 FUNC(MISSING_TAG, ERROR) \
44 FUNC(MISSING_TAG_ENTRY, ERROR) \
45 FUNC(MISSING_TAG_OBJECT, ERROR) \
46 FUNC(MISSING_TREE, ERROR) \
47 FUNC(MISSING_TYPE, ERROR) \
48 FUNC(MISSING_TYPE_ENTRY, ERROR) \
49 FUNC(MULTIPLE_AUTHORS, ERROR) \
50 FUNC(TAG_OBJECT_NOT_TAG, ERROR) \
51 FUNC(TREE_NOT_SORTED, ERROR) \
52 FUNC(UNKNOWN_TYPE, ERROR) \
53 FUNC(ZERO_PADDED_DATE, ERROR) \
55 FUNC(BAD_FILEMODE, WARN) \
56 FUNC(EMPTY_NAME, WARN) \
57 FUNC(FULL_PATHNAME, WARN) \
59 FUNC(HAS_DOTDOT, WARN) \
60 FUNC(HAS_DOTGIT, WARN) \
61 FUNC(NULL_SHA1, WARN) \
62 FUNC(ZERO_PADDED_FILEMODE, WARN) \
63 FUNC(NUL_IN_COMMIT, WARN) \
64 /* infos (reported as warnings, but ignored by default) */ \
65 FUNC(BAD_TAG_NAME, INFO) \
66 FUNC(MISSING_TAGGER_ENTRY, INFO)
68 #define MSG_ID(id, msg_type) FSCK_MSG_##id,
70 FOREACH_MSG_ID(MSG_ID)
76 #define MSG_ID(id, msg_type) { STR(id), NULL, FSCK_##msg_type },
78 const char *id_string;
79 const char *downcased;
81 } msg_id_info[FSCK_MSG_MAX + 1] = {
82 FOREACH_MSG_ID(MSG_ID)
87 static int parse_msg_id(const char *text)
91 if (!msg_id_info[0].downcased) {
92 /* convert id_string to lower case, without underscores. */
93 for (i = 0; i < FSCK_MSG_MAX; i++) {
94 const char *p = msg_id_info[i].id_string;
96 char *q = xmalloc(len);
98 msg_id_info[i].downcased = q;
103 *(q)++ = tolower(*(p)++);
108 for (i = 0; i < FSCK_MSG_MAX; i++)
109 if (!strcmp(text, msg_id_info[i].downcased))
115 static int fsck_msg_type(enum fsck_msg_id msg_id,
116 struct fsck_options *options)
120 assert(msg_id >= 0 && msg_id < FSCK_MSG_MAX);
122 if (options->msg_type)
123 msg_type = options->msg_type[msg_id];
125 msg_type = msg_id_info[msg_id].msg_type;
126 if (options->strict && msg_type == FSCK_WARN)
127 msg_type = FSCK_ERROR;
133 static void init_skiplist(struct fsck_options *options, const char *path)
135 static struct oid_array skiplist = OID_ARRAY_INIT;
137 char buffer[GIT_MAX_HEXSZ + 1];
138 struct object_id oid;
140 if (options->skiplist)
141 sorted = options->skiplist->sorted;
144 options->skiplist = &skiplist;
147 fd = open(path, O_RDONLY);
149 die("Could not open skip list: %s", path);
152 int result = read_in_full(fd, buffer, sizeof(buffer));
154 die_errno("Could not read '%s'", path);
157 if (parse_oid_hex(buffer, &oid, &p) || *p != '\n')
158 die("Invalid SHA-1: %s", buffer);
159 oid_array_append(&skiplist, &oid);
160 if (sorted && skiplist.nr > 1 &&
161 oidcmp(&skiplist.oid[skiplist.nr - 2],
171 static int parse_msg_type(const char *str)
173 if (!strcmp(str, "error"))
175 else if (!strcmp(str, "warn"))
177 else if (!strcmp(str, "ignore"))
180 die("Unknown fsck message type: '%s'", str);
183 int is_valid_msg_type(const char *msg_id, const char *msg_type)
185 if (parse_msg_id(msg_id) < 0)
187 parse_msg_type(msg_type);
191 void fsck_set_msg_type(struct fsck_options *options,
192 const char *msg_id, const char *msg_type)
194 int id = parse_msg_id(msg_id), type;
197 die("Unhandled message id: %s", msg_id);
198 type = parse_msg_type(msg_type);
200 if (type != FSCK_ERROR && msg_id_info[id].msg_type == FSCK_FATAL)
201 die("Cannot demote %s to %s", msg_id, msg_type);
203 if (!options->msg_type) {
206 ALLOC_ARRAY(msg_type, FSCK_MSG_MAX);
207 for (i = 0; i < FSCK_MSG_MAX; i++)
208 msg_type[i] = fsck_msg_type(i, options);
209 options->msg_type = msg_type;
212 options->msg_type[id] = type;
215 void fsck_set_msg_types(struct fsck_options *options, const char *values)
217 char *buf = xstrdup(values), *to_free = buf;
221 int len = strcspn(buf, " ,|"), equal;
231 equal < len && buf[equal] != '=' && buf[equal] != ':';
233 buf[equal] = tolower(buf[equal]);
236 if (!strcmp(buf, "skiplist")) {
238 die("skiplist requires a path");
239 init_skiplist(options, buf + equal + 1);
245 die("Missing '=': '%s'", buf);
247 fsck_set_msg_type(options, buf, buf + equal + 1);
253 static void append_msg_id(struct strbuf *sb, const char *msg_id)
256 char c = *(msg_id)++;
261 strbuf_addch(sb, tolower(c));
264 strbuf_addch(sb, *(msg_id)++);
268 strbuf_addstr(sb, ": ");
271 __attribute__((format (printf, 4, 5)))
272 static int report(struct fsck_options *options, struct object *object,
273 enum fsck_msg_id id, const char *fmt, ...)
276 struct strbuf sb = STRBUF_INIT;
277 int msg_type = fsck_msg_type(id, options), result;
279 if (msg_type == FSCK_IGNORE)
282 if (options->skiplist && object &&
283 oid_array_lookup(options->skiplist, &object->oid) >= 0)
286 if (msg_type == FSCK_FATAL)
287 msg_type = FSCK_ERROR;
288 else if (msg_type == FSCK_INFO)
289 msg_type = FSCK_WARN;
291 append_msg_id(&sb, msg_id_info[id].id_string);
294 strbuf_vaddf(&sb, fmt, ap);
295 result = options->error_func(options, object, msg_type, sb.buf);
302 static char *get_object_name(struct fsck_options *options, struct object *obj)
304 if (!options->object_names)
306 return lookup_decoration(options->object_names, obj);
309 static void put_object_name(struct fsck_options *options, struct object *obj,
310 const char *fmt, ...)
313 struct strbuf buf = STRBUF_INIT;
316 if (!options->object_names)
318 existing = lookup_decoration(options->object_names, obj);
322 strbuf_vaddf(&buf, fmt, ap);
323 add_decoration(options->object_names, obj, strbuf_detach(&buf, NULL));
327 static const char *describe_object(struct fsck_options *o, struct object *obj)
329 static struct strbuf buf = STRBUF_INIT;
333 strbuf_addstr(&buf, oid_to_hex(&obj->oid));
334 if (o->object_names && (name = lookup_decoration(o->object_names, obj)))
335 strbuf_addf(&buf, " (%s)", name);
340 static int fsck_walk_tree(struct tree *tree, void *data, struct fsck_options *options)
342 struct tree_desc desc;
343 struct name_entry entry;
347 if (parse_tree(tree))
350 name = get_object_name(options, &tree->object);
351 if (init_tree_desc_gently(&desc, tree->buffer, tree->size))
353 while (tree_entry_gently(&desc, &entry)) {
357 if (S_ISGITLINK(entry.mode))
360 if (S_ISDIR(entry.mode)) {
361 obj = (struct object *)lookup_tree(entry.oid);
363 put_object_name(options, obj, "%s%s/", name,
365 result = options->walk(obj, OBJ_TREE, data, options);
367 else if (S_ISREG(entry.mode) || S_ISLNK(entry.mode)) {
368 obj = (struct object *)lookup_blob(entry.oid);
370 put_object_name(options, obj, "%s%s", name,
372 result = options->walk(obj, OBJ_BLOB, data, options);
375 result = error("in tree %s: entry %s has bad mode %.6o",
376 describe_object(options, &tree->object), entry.path, entry.mode);
386 static int fsck_walk_commit(struct commit *commit, void *data, struct fsck_options *options)
388 int counter = 0, generation = 0, name_prefix_len = 0;
389 struct commit_list *parents;
394 if (parse_commit(commit))
397 name = get_object_name(options, &commit->object);
399 put_object_name(options, &get_commit_tree(commit)->object,
402 result = options->walk((struct object *)get_commit_tree(commit),
403 OBJ_TREE, data, options);
408 parents = commit->parents;
409 if (name && parents) {
410 int len = strlen(name), power;
412 if (len && name[len - 1] == '^') {
414 name_prefix_len = len - 1;
416 else { /* parse ~<generation> suffix */
417 for (generation = 0, power = 1;
418 len && isdigit(name[len - 1]);
420 generation += power * (name[--len] - '0');
421 if (power > 1 && len && name[len - 1] == '~')
422 name_prefix_len = len - 1;
428 struct object *obj = &parents->item->object;
431 put_object_name(options, obj, "%s^%d",
433 else if (generation > 0)
434 put_object_name(options, obj, "%.*s~%d",
435 name_prefix_len, name, generation + 1);
437 put_object_name(options, obj, "%s^", name);
439 result = options->walk((struct object *)parents->item, OBJ_COMMIT, data, options);
444 parents = parents->next;
449 static int fsck_walk_tag(struct tag *tag, void *data, struct fsck_options *options)
451 char *name = get_object_name(options, &tag->object);
456 put_object_name(options, tag->tagged, "%s", name);
457 return options->walk(tag->tagged, OBJ_ANY, data, options);
460 int fsck_walk(struct object *obj, void *data, struct fsck_options *options)
465 if (obj->type == OBJ_NONE)
466 parse_object(&obj->oid);
472 return fsck_walk_tree((struct tree *)obj, data, options);
474 return fsck_walk_commit((struct commit *)obj, data, options);
476 return fsck_walk_tag((struct tag *)obj, data, options);
478 error("Unknown object type for %s", describe_object(options, obj));
484 * The entries in a tree are ordered in the _path_ order,
485 * which means that a directory entry is ordered by adding
486 * a slash to the end of it.
488 * So a directory called "a" is ordered _after_ a file
489 * called "a.c", because "a/" sorts after "a.c".
491 #define TREE_UNORDERED (-1)
492 #define TREE_HAS_DUPS (-2)
494 static int verify_ordered(unsigned mode1, const char *name1, unsigned mode2, const char *name2)
496 int len1 = strlen(name1);
497 int len2 = strlen(name2);
498 int len = len1 < len2 ? len1 : len2;
499 unsigned char c1, c2;
502 cmp = memcmp(name1, name2, len);
506 return TREE_UNORDERED;
509 * Ok, the first <len> characters are the same.
510 * Now we need to order the next one, but turn
511 * a '\0' into a '/' for a directory entry.
517 * git-write-tree used to write out a nonsense tree that has
518 * entries with the same name, one blob and one tree. Make
519 * sure we do not have duplicate entries.
521 return TREE_HAS_DUPS;
522 if (!c1 && S_ISDIR(mode1))
524 if (!c2 && S_ISDIR(mode2))
526 return c1 < c2 ? 0 : TREE_UNORDERED;
529 static int fsck_tree(struct tree *item, struct fsck_options *options)
532 int has_null_sha1 = 0;
533 int has_full_path = 0;
534 int has_empty_name = 0;
538 int has_zero_pad = 0;
539 int has_bad_modes = 0;
540 int has_dup_entries = 0;
541 int not_properly_sorted = 0;
542 struct tree_desc desc;
546 if (init_tree_desc_gently(&desc, item->buffer, item->size)) {
547 retval += report(options, &item->object, FSCK_MSG_BAD_TREE, "cannot be parsed as a tree");
557 const struct object_id *oid;
559 oid = tree_entry_extract(&desc, &name, &mode);
561 has_null_sha1 |= is_null_oid(oid);
562 has_full_path |= !!strchr(name, '/');
563 has_empty_name |= !*name;
564 has_dot |= !strcmp(name, ".");
565 has_dotdot |= !strcmp(name, "..");
566 has_dotgit |= (!strcmp(name, ".git") ||
567 is_hfs_dotgit(name) ||
568 is_ntfs_dotgit(name));
569 has_zero_pad |= *(char *)desc.buffer == '0';
570 if (update_tree_entry_gently(&desc)) {
571 retval += report(options, &item->object, FSCK_MSG_BAD_TREE, "cannot be parsed as a tree");
586 * This is nonstandard, but we had a few of these
587 * early on when we honored the full set of mode
591 if (!options->strict)
599 switch (verify_ordered(o_mode, o_name, mode, name)) {
601 not_properly_sorted = 1;
616 retval += report(options, &item->object, FSCK_MSG_NULL_SHA1, "contains entries pointing to null sha1");
618 retval += report(options, &item->object, FSCK_MSG_FULL_PATHNAME, "contains full pathnames");
620 retval += report(options, &item->object, FSCK_MSG_EMPTY_NAME, "contains empty pathname");
622 retval += report(options, &item->object, FSCK_MSG_HAS_DOT, "contains '.'");
624 retval += report(options, &item->object, FSCK_MSG_HAS_DOTDOT, "contains '..'");
626 retval += report(options, &item->object, FSCK_MSG_HAS_DOTGIT, "contains '.git'");
628 retval += report(options, &item->object, FSCK_MSG_ZERO_PADDED_FILEMODE, "contains zero-padded file modes");
630 retval += report(options, &item->object, FSCK_MSG_BAD_FILEMODE, "contains bad file modes");
632 retval += report(options, &item->object, FSCK_MSG_DUPLICATE_ENTRIES, "contains duplicate file entries");
633 if (not_properly_sorted)
634 retval += report(options, &item->object, FSCK_MSG_TREE_NOT_SORTED, "not properly sorted");
638 static int verify_headers(const void *data, unsigned long size,
639 struct object *obj, struct fsck_options *options)
641 const char *buffer = (const char *)data;
644 for (i = 0; i < size; i++) {
647 return report(options, obj,
648 FSCK_MSG_NUL_IN_HEADER,
649 "unterminated header: NUL at offset %ld", i);
651 if (i + 1 < size && buffer[i + 1] == '\n')
657 * We did not find double-LF that separates the header
658 * and the body. Not having a body is not a crime but
659 * we do want to see the terminating LF for the last header
662 if (size && buffer[size - 1] == '\n')
665 return report(options, obj,
666 FSCK_MSG_UNTERMINATED_HEADER, "unterminated header");
669 static int fsck_ident(const char **ident, struct object *obj, struct fsck_options *options)
671 const char *p = *ident;
674 *ident = strchrnul(*ident, '\n');
679 return report(options, obj, FSCK_MSG_MISSING_NAME_BEFORE_EMAIL, "invalid author/committer line - missing space before email");
680 p += strcspn(p, "<>\n");
682 return report(options, obj, FSCK_MSG_BAD_NAME, "invalid author/committer line - bad name");
684 return report(options, obj, FSCK_MSG_MISSING_EMAIL, "invalid author/committer line - missing email");
686 return report(options, obj, FSCK_MSG_MISSING_SPACE_BEFORE_EMAIL, "invalid author/committer line - missing space before email");
688 p += strcspn(p, "<>\n");
690 return report(options, obj, FSCK_MSG_BAD_EMAIL, "invalid author/committer line - bad email");
693 return report(options, obj, FSCK_MSG_MISSING_SPACE_BEFORE_DATE, "invalid author/committer line - missing space before date");
695 if (*p == '0' && p[1] != ' ')
696 return report(options, obj, FSCK_MSG_ZERO_PADDED_DATE, "invalid author/committer line - zero-padded date");
697 if (date_overflows(parse_timestamp(p, &end, 10)))
698 return report(options, obj, FSCK_MSG_BAD_DATE_OVERFLOW, "invalid author/committer line - date causes integer overflow");
699 if ((end == p || *end != ' '))
700 return report(options, obj, FSCK_MSG_BAD_DATE, "invalid author/committer line - bad date");
702 if ((*p != '+' && *p != '-') ||
708 return report(options, obj, FSCK_MSG_BAD_TIMEZONE, "invalid author/committer line - bad time zone");
713 static int fsck_commit_buffer(struct commit *commit, const char *buffer,
714 unsigned long size, struct fsck_options *options)
716 unsigned char tree_sha1[20], sha1[20];
717 struct commit_graft *graft;
718 unsigned parent_count, parent_line_count = 0, author_count;
720 const char *buffer_begin = buffer;
722 if (verify_headers(buffer, size, &commit->object, options))
725 if (!skip_prefix(buffer, "tree ", &buffer))
726 return report(options, &commit->object, FSCK_MSG_MISSING_TREE, "invalid format - expected 'tree' line");
727 if (get_sha1_hex(buffer, tree_sha1) || buffer[40] != '\n') {
728 err = report(options, &commit->object, FSCK_MSG_BAD_TREE_SHA1, "invalid 'tree' line format - bad sha1");
733 while (skip_prefix(buffer, "parent ", &buffer)) {
734 if (get_sha1_hex(buffer, sha1) || buffer[40] != '\n') {
735 err = report(options, &commit->object, FSCK_MSG_BAD_PARENT_SHA1, "invalid 'parent' line format - bad sha1");
742 graft = lookup_commit_graft(&commit->object.oid);
743 parent_count = commit_list_count(commit->parents);
745 if (graft->nr_parent == -1 && !parent_count)
746 ; /* shallow commit */
747 else if (graft->nr_parent != parent_count) {
748 err = report(options, &commit->object, FSCK_MSG_MISSING_GRAFT, "graft objects missing");
753 if (parent_count != parent_line_count) {
754 err = report(options, &commit->object, FSCK_MSG_MISSING_PARENT, "parent objects missing");
760 while (skip_prefix(buffer, "author ", &buffer)) {
762 err = fsck_ident(&buffer, &commit->object, options);
766 if (author_count < 1)
767 err = report(options, &commit->object, FSCK_MSG_MISSING_AUTHOR, "invalid format - expected 'author' line");
768 else if (author_count > 1)
769 err = report(options, &commit->object, FSCK_MSG_MULTIPLE_AUTHORS, "invalid format - multiple 'author' lines");
772 if (!skip_prefix(buffer, "committer ", &buffer))
773 return report(options, &commit->object, FSCK_MSG_MISSING_COMMITTER, "invalid format - expected 'committer' line");
774 err = fsck_ident(&buffer, &commit->object, options);
777 if (!get_commit_tree(commit)) {
778 err = report(options, &commit->object, FSCK_MSG_BAD_TREE, "could not load commit's tree %s", sha1_to_hex(tree_sha1));
782 if (memchr(buffer_begin, '\0', size)) {
783 err = report(options, &commit->object, FSCK_MSG_NUL_IN_COMMIT,
784 "NUL byte in the commit object body");
791 static int fsck_commit(struct commit *commit, const char *data,
792 unsigned long size, struct fsck_options *options)
794 const char *buffer = data ? data : get_commit_buffer(commit, &size);
795 int ret = fsck_commit_buffer(commit, buffer, size, options);
797 unuse_commit_buffer(commit, buffer);
801 static int fsck_tag_buffer(struct tag *tag, const char *data,
802 unsigned long size, struct fsck_options *options)
804 unsigned char sha1[20];
807 char *to_free = NULL, *eol;
808 struct strbuf sb = STRBUF_INIT;
813 enum object_type type;
816 read_object_file(&tag->object.oid, &type, &size);
818 return report(options, &tag->object,
819 FSCK_MSG_MISSING_TAG_OBJECT,
820 "cannot read tag object");
822 if (type != OBJ_TAG) {
823 ret = report(options, &tag->object,
824 FSCK_MSG_TAG_OBJECT_NOT_TAG,
825 "expected tag got %s",
831 ret = verify_headers(buffer, size, &tag->object, options);
835 if (!skip_prefix(buffer, "object ", &buffer)) {
836 ret = report(options, &tag->object, FSCK_MSG_MISSING_OBJECT, "invalid format - expected 'object' line");
839 if (get_sha1_hex(buffer, sha1) || buffer[40] != '\n') {
840 ret = report(options, &tag->object, FSCK_MSG_BAD_OBJECT_SHA1, "invalid 'object' line format - bad sha1");
846 if (!skip_prefix(buffer, "type ", &buffer)) {
847 ret = report(options, &tag->object, FSCK_MSG_MISSING_TYPE_ENTRY, "invalid format - expected 'type' line");
850 eol = strchr(buffer, '\n');
852 ret = report(options, &tag->object, FSCK_MSG_MISSING_TYPE, "invalid format - unexpected end after 'type' line");
855 if (type_from_string_gently(buffer, eol - buffer, 1) < 0)
856 ret = report(options, &tag->object, FSCK_MSG_BAD_TYPE, "invalid 'type' value");
861 if (!skip_prefix(buffer, "tag ", &buffer)) {
862 ret = report(options, &tag->object, FSCK_MSG_MISSING_TAG_ENTRY, "invalid format - expected 'tag' line");
865 eol = strchr(buffer, '\n');
867 ret = report(options, &tag->object, FSCK_MSG_MISSING_TAG, "invalid format - unexpected end after 'type' line");
870 strbuf_addf(&sb, "refs/tags/%.*s", (int)(eol - buffer), buffer);
871 if (check_refname_format(sb.buf, 0)) {
872 ret = report(options, &tag->object, FSCK_MSG_BAD_TAG_NAME,
873 "invalid 'tag' name: %.*s",
874 (int)(eol - buffer), buffer);
880 if (!skip_prefix(buffer, "tagger ", &buffer)) {
881 /* early tags do not contain 'tagger' lines; warn only */
882 ret = report(options, &tag->object, FSCK_MSG_MISSING_TAGGER_ENTRY, "invalid format - expected 'tagger' line");
887 ret = fsck_ident(&buffer, &tag->object, options);
895 static int fsck_tag(struct tag *tag, const char *data,
896 unsigned long size, struct fsck_options *options)
898 struct object *tagged = tag->tagged;
901 return report(options, &tag->object, FSCK_MSG_BAD_TAG_OBJECT, "could not load tagged object");
903 return fsck_tag_buffer(tag, data, size, options);
906 int fsck_object(struct object *obj, void *data, unsigned long size,
907 struct fsck_options *options)
910 return report(options, obj, FSCK_MSG_BAD_OBJECT_SHA1, "no valid object to fsck");
912 if (obj->type == OBJ_BLOB)
914 if (obj->type == OBJ_TREE)
915 return fsck_tree((struct tree *) obj, options);
916 if (obj->type == OBJ_COMMIT)
917 return fsck_commit((struct commit *) obj, (const char *) data,
919 if (obj->type == OBJ_TAG)
920 return fsck_tag((struct tag *) obj, (const char *) data,
923 return report(options, obj, FSCK_MSG_UNKNOWN_TYPE, "unknown type '%d' (internal fsck error)",
927 int fsck_error_function(struct fsck_options *o,
928 struct object *obj, int msg_type, const char *message)
930 if (msg_type == FSCK_WARN) {
931 warning("object %s: %s", describe_object(o, obj), message);
934 error("object %s: %s", describe_object(o, obj), message);