1 ifeq ($(filter no-error,$(DEVOPTS)),)
2 DEVELOPER_CFLAGS += -Werror
3 SPARSE_FLAGS += -Wsparse-error
5 ifneq ($(filter pedantic,$(DEVOPTS)),)
6 DEVELOPER_CFLAGS += -pedantic
7 # don't warn for each N_ use
8 DEVELOPER_CFLAGS += -DUSE_PARENS_AROUND_GETTEXT_N=0
10 DEVELOPER_CFLAGS += -Wall
11 DEVELOPER_CFLAGS += -Wdeclaration-after-statement
12 DEVELOPER_CFLAGS += -Wformat-security
13 DEVELOPER_CFLAGS += -Wold-style-definition
14 DEVELOPER_CFLAGS += -Woverflow
15 DEVELOPER_CFLAGS += -Wpointer-arith
16 DEVELOPER_CFLAGS += -Wstrict-prototypes
17 DEVELOPER_CFLAGS += -Wunused
18 DEVELOPER_CFLAGS += -Wvla
19 DEVELOPER_CFLAGS += -fno-common
21 ifndef COMPILER_FEATURES
22 COMPILER_FEATURES := $(shell ./detect-compiler $(CC))
25 ifneq ($(filter clang4,$(COMPILER_FEATURES)),)
26 DEVELOPER_CFLAGS += -Wtautological-constant-out-of-range-compare
29 ifneq ($(or $(filter gcc6,$(COMPILER_FEATURES)),$(filter clang4,$(COMPILER_FEATURES))),)
30 DEVELOPER_CFLAGS += -Wextra
31 # if a function is public, there should be a prototype and the right
32 # header file should be included. If not, it should be static.
33 DEVELOPER_CFLAGS += -Wmissing-prototypes
34 ifeq ($(filter extra-all,$(DEVOPTS)),)
35 # These are disabled because we have these all over the place.
36 DEVELOPER_CFLAGS += -Wno-empty-body
37 DEVELOPER_CFLAGS += -Wno-missing-field-initializers
38 DEVELOPER_CFLAGS += -Wno-sign-compare
39 DEVELOPER_CFLAGS += -Wno-unused-parameter
43 # uninitialized warnings on gcc 4.9.2 in xdiff/xdiffi.c and config.c
44 # not worth fixing since newer compilers correctly stop complaining
45 ifneq ($(filter gcc4,$(COMPILER_FEATURES)),)
46 ifeq ($(filter gcc5,$(COMPILER_FEATURES)),)
47 DEVELOPER_CFLAGS += -Wno-uninitialized
51 GIT_TEST_PERL_FATAL_WARNINGS = YesPlease