revision: do not include sibling history in --ancestry-path output
[git] / revision.c
1 #include "cache.h"
2 #include "tag.h"
3 #include "blob.h"
4 #include "tree.h"
5 #include "commit.h"
6 #include "diff.h"
7 #include "refs.h"
8 #include "revision.h"
9 #include "graph.h"
10 #include "grep.h"
11 #include "reflog-walk.h"
12 #include "patch-ids.h"
13 #include "decorate.h"
14 #include "log-tree.h"
15 #include "string-list.h"
16
17 volatile show_early_output_fn_t show_early_output;
18
19 char *path_name(const struct name_path *path, const char *name)
20 {
21         const struct name_path *p;
22         char *n, *m;
23         int nlen = strlen(name);
24         int len = nlen + 1;
25
26         for (p = path; p; p = p->up) {
27                 if (p->elem_len)
28                         len += p->elem_len + 1;
29         }
30         n = xmalloc(len);
31         m = n + len - (nlen + 1);
32         strcpy(m, name);
33         for (p = path; p; p = p->up) {
34                 if (p->elem_len) {
35                         m -= p->elem_len + 1;
36                         memcpy(m, p->elem, p->elem_len);
37                         m[p->elem_len] = '/';
38                 }
39         }
40         return n;
41 }
42
43 void add_object(struct object *obj,
44                 struct object_array *p,
45                 struct name_path *path,
46                 const char *name)
47 {
48         add_object_array(obj, path_name(path, name), p);
49 }
50
51 static void mark_blob_uninteresting(struct blob *blob)
52 {
53         if (!blob)
54                 return;
55         if (blob->object.flags & UNINTERESTING)
56                 return;
57         blob->object.flags |= UNINTERESTING;
58 }
59
60 void mark_tree_uninteresting(struct tree *tree)
61 {
62         struct tree_desc desc;
63         struct name_entry entry;
64         struct object *obj = &tree->object;
65
66         if (!tree)
67                 return;
68         if (obj->flags & UNINTERESTING)
69                 return;
70         obj->flags |= UNINTERESTING;
71         if (!has_sha1_file(obj->sha1))
72                 return;
73         if (parse_tree(tree) < 0)
74                 die("bad tree %s", sha1_to_hex(obj->sha1));
75
76         init_tree_desc(&desc, tree->buffer, tree->size);
77         while (tree_entry(&desc, &entry)) {
78                 switch (object_type(entry.mode)) {
79                 case OBJ_TREE:
80                         mark_tree_uninteresting(lookup_tree(entry.sha1));
81                         break;
82                 case OBJ_BLOB:
83                         mark_blob_uninteresting(lookup_blob(entry.sha1));
84                         break;
85                 default:
86                         /* Subproject commit - not in this repository */
87                         break;
88                 }
89         }
90
91         /*
92          * We don't care about the tree any more
93          * after it has been marked uninteresting.
94          */
95         free(tree->buffer);
96         tree->buffer = NULL;
97 }
98
99 void mark_parents_uninteresting(struct commit *commit)
100 {
101         struct commit_list *parents = commit->parents;
102
103         while (parents) {
104                 struct commit *commit = parents->item;
105                 if (!(commit->object.flags & UNINTERESTING)) {
106                         commit->object.flags |= UNINTERESTING;
107
108                         /*
109                          * Normally we haven't parsed the parent
110                          * yet, so we won't have a parent of a parent
111                          * here. However, it may turn out that we've
112                          * reached this commit some other way (where it
113                          * wasn't uninteresting), in which case we need
114                          * to mark its parents recursively too..
115                          */
116                         if (commit->parents)
117                                 mark_parents_uninteresting(commit);
118                 }
119
120                 /*
121                  * A missing commit is ok iff its parent is marked
122                  * uninteresting.
123                  *
124                  * We just mark such a thing parsed, so that when
125                  * it is popped next time around, we won't be trying
126                  * to parse it and get an error.
127                  */
128                 if (!has_sha1_file(commit->object.sha1))
129                         commit->object.parsed = 1;
130                 parents = parents->next;
131         }
132 }
133
134 static void add_pending_object_with_mode(struct rev_info *revs, struct object *obj, const char *name, unsigned mode)
135 {
136         if (revs->no_walk && (obj->flags & UNINTERESTING))
137                 revs->no_walk = 0;
138         if (revs->reflog_info && obj->type == OBJ_COMMIT) {
139                 struct strbuf buf = STRBUF_INIT;
140                 int len = interpret_branch_name(name, &buf);
141                 int st;
142
143                 if (0 < len && name[len] && buf.len)
144                         strbuf_addstr(&buf, name + len);
145                 st = add_reflog_for_walk(revs->reflog_info,
146                                          (struct commit *)obj,
147                                          buf.buf[0] ? buf.buf: name);
148                 strbuf_release(&buf);
149                 if (st)
150                         return;
151         }
152         add_object_array_with_mode(obj, name, &revs->pending, mode);
153 }
154
155 void add_pending_object(struct rev_info *revs, struct object *obj, const char *name)
156 {
157         add_pending_object_with_mode(revs, obj, name, S_IFINVALID);
158 }
159
160 void add_head_to_pending(struct rev_info *revs)
161 {
162         unsigned char sha1[20];
163         struct object *obj;
164         if (get_sha1("HEAD", sha1))
165                 return;
166         obj = parse_object(sha1);
167         if (!obj)
168                 return;
169         add_pending_object(revs, obj, "HEAD");
170 }
171
172 static struct object *get_reference(struct rev_info *revs, const char *name, const unsigned char *sha1, unsigned int flags)
173 {
174         struct object *object;
175
176         object = parse_object(sha1);
177         if (!object)
178                 die("bad object %s", name);
179         object->flags |= flags;
180         return object;
181 }
182
183 static struct commit *handle_commit(struct rev_info *revs, struct object *object, const char *name)
184 {
185         unsigned long flags = object->flags;
186
187         /*
188          * Tag object? Look what it points to..
189          */
190         while (object->type == OBJ_TAG) {
191                 struct tag *tag = (struct tag *) object;
192                 if (revs->tag_objects && !(flags & UNINTERESTING))
193                         add_pending_object(revs, object, tag->tag);
194                 if (!tag->tagged)
195                         die("bad tag");
196                 object = parse_object(tag->tagged->sha1);
197                 if (!object) {
198                         if (flags & UNINTERESTING)
199                                 return NULL;
200                         die("bad object %s", sha1_to_hex(tag->tagged->sha1));
201                 }
202         }
203
204         /*
205          * Commit object? Just return it, we'll do all the complex
206          * reachability crud.
207          */
208         if (object->type == OBJ_COMMIT) {
209                 struct commit *commit = (struct commit *)object;
210                 if (parse_commit(commit) < 0)
211                         die("unable to parse commit %s", name);
212                 if (flags & UNINTERESTING) {
213                         commit->object.flags |= UNINTERESTING;
214                         mark_parents_uninteresting(commit);
215                         revs->limited = 1;
216                 }
217                 if (revs->show_source && !commit->util)
218                         commit->util = (void *) name;
219                 return commit;
220         }
221
222         /*
223          * Tree object? Either mark it uninteresting, or add it
224          * to the list of objects to look at later..
225          */
226         if (object->type == OBJ_TREE) {
227                 struct tree *tree = (struct tree *)object;
228                 if (!revs->tree_objects)
229                         return NULL;
230                 if (flags & UNINTERESTING) {
231                         mark_tree_uninteresting(tree);
232                         return NULL;
233                 }
234                 add_pending_object(revs, object, "");
235                 return NULL;
236         }
237
238         /*
239          * Blob object? You know the drill by now..
240          */
241         if (object->type == OBJ_BLOB) {
242                 struct blob *blob = (struct blob *)object;
243                 if (!revs->blob_objects)
244                         return NULL;
245                 if (flags & UNINTERESTING) {
246                         mark_blob_uninteresting(blob);
247                         return NULL;
248                 }
249                 add_pending_object(revs, object, "");
250                 return NULL;
251         }
252         die("%s is unknown object", name);
253 }
254
255 static int everybody_uninteresting(struct commit_list *orig)
256 {
257         struct commit_list *list = orig;
258         while (list) {
259                 struct commit *commit = list->item;
260                 list = list->next;
261                 if (commit->object.flags & UNINTERESTING)
262                         continue;
263                 return 0;
264         }
265         return 1;
266 }
267
268 /*
269  * The goal is to get REV_TREE_NEW as the result only if the
270  * diff consists of all '+' (and no other changes), REV_TREE_OLD
271  * if the whole diff is removal of old data, and otherwise
272  * REV_TREE_DIFFERENT (of course if the trees are the same we
273  * want REV_TREE_SAME).
274  * That means that once we get to REV_TREE_DIFFERENT, we do not
275  * have to look any further.
276  */
277 static int tree_difference = REV_TREE_SAME;
278
279 static void file_add_remove(struct diff_options *options,
280                     int addremove, unsigned mode,
281                     const unsigned char *sha1,
282                     const char *fullpath, unsigned dirty_submodule)
283 {
284         int diff = addremove == '+' ? REV_TREE_NEW : REV_TREE_OLD;
285
286         tree_difference |= diff;
287         if (tree_difference == REV_TREE_DIFFERENT)
288                 DIFF_OPT_SET(options, HAS_CHANGES);
289 }
290
291 static void file_change(struct diff_options *options,
292                  unsigned old_mode, unsigned new_mode,
293                  const unsigned char *old_sha1,
294                  const unsigned char *new_sha1,
295                  const char *fullpath,
296                  unsigned old_dirty_submodule, unsigned new_dirty_submodule)
297 {
298         tree_difference = REV_TREE_DIFFERENT;
299         DIFF_OPT_SET(options, HAS_CHANGES);
300 }
301
302 static int rev_compare_tree(struct rev_info *revs, struct commit *parent, struct commit *commit)
303 {
304         struct tree *t1 = parent->tree;
305         struct tree *t2 = commit->tree;
306
307         if (!t1)
308                 return REV_TREE_NEW;
309         if (!t2)
310                 return REV_TREE_OLD;
311
312         if (revs->simplify_by_decoration) {
313                 /*
314                  * If we are simplifying by decoration, then the commit
315                  * is worth showing if it has a tag pointing at it.
316                  */
317                 if (lookup_decoration(&name_decoration, &commit->object))
318                         return REV_TREE_DIFFERENT;
319                 /*
320                  * A commit that is not pointed by a tag is uninteresting
321                  * if we are not limited by path.  This means that you will
322                  * see the usual "commits that touch the paths" plus any
323                  * tagged commit by specifying both --simplify-by-decoration
324                  * and pathspec.
325                  */
326                 if (!revs->prune_data)
327                         return REV_TREE_SAME;
328         }
329
330         tree_difference = REV_TREE_SAME;
331         DIFF_OPT_CLR(&revs->pruning, HAS_CHANGES);
332         if (diff_tree_sha1(t1->object.sha1, t2->object.sha1, "",
333                            &revs->pruning) < 0)
334                 return REV_TREE_DIFFERENT;
335         return tree_difference;
336 }
337
338 static int rev_same_tree_as_empty(struct rev_info *revs, struct commit *commit)
339 {
340         int retval;
341         void *tree;
342         unsigned long size;
343         struct tree_desc empty, real;
344         struct tree *t1 = commit->tree;
345
346         if (!t1)
347                 return 0;
348
349         tree = read_object_with_reference(t1->object.sha1, tree_type, &size, NULL);
350         if (!tree)
351                 return 0;
352         init_tree_desc(&real, tree, size);
353         init_tree_desc(&empty, "", 0);
354
355         tree_difference = REV_TREE_SAME;
356         DIFF_OPT_CLR(&revs->pruning, HAS_CHANGES);
357         retval = diff_tree(&empty, &real, "", &revs->pruning);
358         free(tree);
359
360         return retval >= 0 && (tree_difference == REV_TREE_SAME);
361 }
362
363 static void try_to_simplify_commit(struct rev_info *revs, struct commit *commit)
364 {
365         struct commit_list **pp, *parent;
366         int tree_changed = 0, tree_same = 0;
367
368         /*
369          * If we don't do pruning, everything is interesting
370          */
371         if (!revs->prune)
372                 return;
373
374         if (!commit->tree)
375                 return;
376
377         if (!commit->parents) {
378                 if (rev_same_tree_as_empty(revs, commit))
379                         commit->object.flags |= TREESAME;
380                 return;
381         }
382
383         /*
384          * Normal non-merge commit? If we don't want to make the
385          * history dense, we consider it always to be a change..
386          */
387         if (!revs->dense && !commit->parents->next)
388                 return;
389
390         pp = &commit->parents;
391         while ((parent = *pp) != NULL) {
392                 struct commit *p = parent->item;
393
394                 if (parse_commit(p) < 0)
395                         die("cannot simplify commit %s (because of %s)",
396                             sha1_to_hex(commit->object.sha1),
397                             sha1_to_hex(p->object.sha1));
398                 switch (rev_compare_tree(revs, p, commit)) {
399                 case REV_TREE_SAME:
400                         tree_same = 1;
401                         if (!revs->simplify_history || (p->object.flags & UNINTERESTING)) {
402                                 /* Even if a merge with an uninteresting
403                                  * side branch brought the entire change
404                                  * we are interested in, we do not want
405                                  * to lose the other branches of this
406                                  * merge, so we just keep going.
407                                  */
408                                 pp = &parent->next;
409                                 continue;
410                         }
411                         parent->next = NULL;
412                         commit->parents = parent;
413                         commit->object.flags |= TREESAME;
414                         return;
415
416                 case REV_TREE_NEW:
417                         if (revs->remove_empty_trees &&
418                             rev_same_tree_as_empty(revs, p)) {
419                                 /* We are adding all the specified
420                                  * paths from this parent, so the
421                                  * history beyond this parent is not
422                                  * interesting.  Remove its parents
423                                  * (they are grandparents for us).
424                                  * IOW, we pretend this parent is a
425                                  * "root" commit.
426                                  */
427                                 if (parse_commit(p) < 0)
428                                         die("cannot simplify commit %s (invalid %s)",
429                                             sha1_to_hex(commit->object.sha1),
430                                             sha1_to_hex(p->object.sha1));
431                                 p->parents = NULL;
432                         }
433                 /* fallthrough */
434                 case REV_TREE_OLD:
435                 case REV_TREE_DIFFERENT:
436                         tree_changed = 1;
437                         pp = &parent->next;
438                         continue;
439                 }
440                 die("bad tree compare for commit %s", sha1_to_hex(commit->object.sha1));
441         }
442         if (tree_changed && !tree_same)
443                 return;
444         commit->object.flags |= TREESAME;
445 }
446
447 static void insert_by_date_cached(struct commit *p, struct commit_list **head,
448                     struct commit_list *cached_base, struct commit_list **cache)
449 {
450         struct commit_list *new_entry;
451
452         if (cached_base && p->date < cached_base->item->date)
453                 new_entry = insert_by_date(p, &cached_base->next);
454         else
455                 new_entry = insert_by_date(p, head);
456
457         if (cache && (!*cache || p->date < (*cache)->item->date))
458                 *cache = new_entry;
459 }
460
461 static int add_parents_to_list(struct rev_info *revs, struct commit *commit,
462                     struct commit_list **list, struct commit_list **cache_ptr)
463 {
464         struct commit_list *parent = commit->parents;
465         unsigned left_flag;
466         struct commit_list *cached_base = cache_ptr ? *cache_ptr : NULL;
467
468         if (commit->object.flags & ADDED)
469                 return 0;
470         commit->object.flags |= ADDED;
471
472         /*
473          * If the commit is uninteresting, don't try to
474          * prune parents - we want the maximal uninteresting
475          * set.
476          *
477          * Normally we haven't parsed the parent
478          * yet, so we won't have a parent of a parent
479          * here. However, it may turn out that we've
480          * reached this commit some other way (where it
481          * wasn't uninteresting), in which case we need
482          * to mark its parents recursively too..
483          */
484         if (commit->object.flags & UNINTERESTING) {
485                 while (parent) {
486                         struct commit *p = parent->item;
487                         parent = parent->next;
488                         if (p)
489                                 p->object.flags |= UNINTERESTING;
490                         if (parse_commit(p) < 0)
491                                 continue;
492                         if (p->parents)
493                                 mark_parents_uninteresting(p);
494                         if (p->object.flags & SEEN)
495                                 continue;
496                         p->object.flags |= SEEN;
497                         insert_by_date_cached(p, list, cached_base, cache_ptr);
498                 }
499                 return 0;
500         }
501
502         /*
503          * Ok, the commit wasn't uninteresting. Try to
504          * simplify the commit history and find the parent
505          * that has no differences in the path set if one exists.
506          */
507         try_to_simplify_commit(revs, commit);
508
509         if (revs->no_walk)
510                 return 0;
511
512         left_flag = (commit->object.flags & SYMMETRIC_LEFT);
513
514         for (parent = commit->parents; parent; parent = parent->next) {
515                 struct commit *p = parent->item;
516
517                 if (parse_commit(p) < 0)
518                         return -1;
519                 if (revs->show_source && !p->util)
520                         p->util = commit->util;
521                 p->object.flags |= left_flag;
522                 if (!(p->object.flags & SEEN)) {
523                         p->object.flags |= SEEN;
524                         insert_by_date_cached(p, list, cached_base, cache_ptr);
525                 }
526                 if (revs->first_parent_only)
527                         break;
528         }
529         return 0;
530 }
531
532 static void cherry_pick_list(struct commit_list *list, struct rev_info *revs)
533 {
534         struct commit_list *p;
535         int left_count = 0, right_count = 0;
536         int left_first;
537         struct patch_ids ids;
538
539         /* First count the commits on the left and on the right */
540         for (p = list; p; p = p->next) {
541                 struct commit *commit = p->item;
542                 unsigned flags = commit->object.flags;
543                 if (flags & BOUNDARY)
544                         ;
545                 else if (flags & SYMMETRIC_LEFT)
546                         left_count++;
547                 else
548                         right_count++;
549         }
550
551         if (!left_count || !right_count)
552                 return;
553
554         left_first = left_count < right_count;
555         init_patch_ids(&ids);
556         if (revs->diffopt.nr_paths) {
557                 ids.diffopts.nr_paths = revs->diffopt.nr_paths;
558                 ids.diffopts.paths = revs->diffopt.paths;
559                 ids.diffopts.pathlens = revs->diffopt.pathlens;
560         }
561
562         /* Compute patch-ids for one side */
563         for (p = list; p; p = p->next) {
564                 struct commit *commit = p->item;
565                 unsigned flags = commit->object.flags;
566
567                 if (flags & BOUNDARY)
568                         continue;
569                 /*
570                  * If we have fewer left, left_first is set and we omit
571                  * commits on the right branch in this loop.  If we have
572                  * fewer right, we skip the left ones.
573                  */
574                 if (left_first != !!(flags & SYMMETRIC_LEFT))
575                         continue;
576                 commit->util = add_commit_patch_id(commit, &ids);
577         }
578
579         /* Check the other side */
580         for (p = list; p; p = p->next) {
581                 struct commit *commit = p->item;
582                 struct patch_id *id;
583                 unsigned flags = commit->object.flags;
584
585                 if (flags & BOUNDARY)
586                         continue;
587                 /*
588                  * If we have fewer left, left_first is set and we omit
589                  * commits on the left branch in this loop.
590                  */
591                 if (left_first == !!(flags & SYMMETRIC_LEFT))
592                         continue;
593
594                 /*
595                  * Have we seen the same patch id?
596                  */
597                 id = has_commit_patch_id(commit, &ids);
598                 if (!id)
599                         continue;
600                 id->seen = 1;
601                 commit->object.flags |= SHOWN;
602         }
603
604         /* Now check the original side for seen ones */
605         for (p = list; p; p = p->next) {
606                 struct commit *commit = p->item;
607                 struct patch_id *ent;
608
609                 ent = commit->util;
610                 if (!ent)
611                         continue;
612                 if (ent->seen)
613                         commit->object.flags |= SHOWN;
614                 commit->util = NULL;
615         }
616
617         free_patch_ids(&ids);
618 }
619
620 /* How many extra uninteresting commits we want to see.. */
621 #define SLOP 5
622
623 static int still_interesting(struct commit_list *src, unsigned long date, int slop)
624 {
625         /*
626          * No source list at all? We're definitely done..
627          */
628         if (!src)
629                 return 0;
630
631         /*
632          * Does the destination list contain entries with a date
633          * before the source list? Definitely _not_ done.
634          */
635         if (date < src->item->date)
636                 return SLOP;
637
638         /*
639          * Does the source list still have interesting commits in
640          * it? Definitely not done..
641          */
642         if (!everybody_uninteresting(src))
643                 return SLOP;
644
645         /* Ok, we're closing in.. */
646         return slop-1;
647 }
648
649 /*
650  * "rev-list --ancestry-path A..B" computes commits that are ancestors
651  * of B but not ancestors of A but further limits the result to those
652  * that are descendants of A.  This takes the list of bottom commits and
653  * the result of "A..B" without --ancestry-path, and limits the latter
654  * further to the ones that can reach one of the commits in "bottom".
655  */
656 static void limit_to_ancestry(struct commit_list *bottom, struct commit_list *list)
657 {
658         struct commit_list *p;
659         struct commit_list *rlist = NULL;
660         int made_progress;
661
662         /*
663          * Reverse the list so that it will be likely that we would
664          * process parents before children.
665          */
666         for (p = list; p; p = p->next)
667                 commit_list_insert(p->item, &rlist);
668
669         for (p = bottom; p; p = p->next)
670                 p->item->object.flags |= TMP_MARK;
671
672         /*
673          * Mark the ones that can reach bottom commits in "list",
674          * in a bottom-up fashion.
675          */
676         do {
677                 made_progress = 0;
678                 for (p = rlist; p; p = p->next) {
679                         struct commit *c = p->item;
680                         struct commit_list *parents;
681                         if (c->object.flags & (TMP_MARK | UNINTERESTING))
682                                 continue;
683                         for (parents = c->parents;
684                              parents;
685                              parents = parents->next) {
686                                 if (!(parents->item->object.flags & TMP_MARK))
687                                         continue;
688                                 c->object.flags |= TMP_MARK;
689                                 made_progress = 1;
690                                 break;
691                         }
692                 }
693         } while (made_progress);
694
695         /*
696          * NEEDSWORK: decide if we want to remove parents that are
697          * not marked with TMP_MARK from commit->parents for commits
698          * in the resulting list.  We may not want to do that, though.
699          */
700
701         /*
702          * The ones that are not marked with TMP_MARK are uninteresting
703          */
704         for (p = list; p; p = p->next) {
705                 struct commit *c = p->item;
706                 if (c->object.flags & TMP_MARK)
707                         continue;
708                 c->object.flags |= UNINTERESTING;
709         }
710
711         /* We are done with the TMP_MARK */
712         for (p = list; p; p = p->next)
713                 p->item->object.flags &= ~TMP_MARK;
714         for (p = bottom; p; p = p->next)
715                 p->item->object.flags &= ~TMP_MARK;
716         free_commit_list(rlist);
717 }
718
719 /*
720  * Before walking the history, keep the set of "negative" refs the
721  * caller has asked to exclude.
722  *
723  * This is used to compute "rev-list --ancestry-path A..B", as we need
724  * to filter the result of "A..B" further to the ones that can actually
725  * reach A.
726  */
727 static struct commit_list *collect_bottom_commits(struct rev_info *revs)
728 {
729         struct commit_list *bottom = NULL;
730         int i;
731         for (i = 0; i < revs->cmdline.nr; i++) {
732                 struct rev_cmdline_entry *elem = &revs->cmdline.rev[i];
733                 if ((elem->flags & UNINTERESTING) &&
734                     elem->item->type == OBJ_COMMIT)
735                         commit_list_insert((struct commit *)elem->item, &bottom);
736         }
737         return bottom;
738 }
739
740 static int limit_list(struct rev_info *revs)
741 {
742         int slop = SLOP;
743         unsigned long date = ~0ul;
744         struct commit_list *list = revs->commits;
745         struct commit_list *newlist = NULL;
746         struct commit_list **p = &newlist;
747         struct commit_list *bottom = NULL;
748
749         if (revs->ancestry_path) {
750                 bottom = collect_bottom_commits(revs);
751                 if (!bottom)
752                         die("--ancestry-path given but there are no bottom commits");
753         }
754
755         while (list) {
756                 struct commit_list *entry = list;
757                 struct commit *commit = list->item;
758                 struct object *obj = &commit->object;
759                 show_early_output_fn_t show;
760
761                 list = list->next;
762                 free(entry);
763
764                 if (revs->max_age != -1 && (commit->date < revs->max_age))
765                         obj->flags |= UNINTERESTING;
766                 if (add_parents_to_list(revs, commit, &list, NULL) < 0)
767                         return -1;
768                 if (obj->flags & UNINTERESTING) {
769                         mark_parents_uninteresting(commit);
770                         if (revs->show_all)
771                                 p = &commit_list_insert(commit, p)->next;
772                         slop = still_interesting(list, date, slop);
773                         if (slop)
774                                 continue;
775                         /* If showing all, add the whole pending list to the end */
776                         if (revs->show_all)
777                                 *p = list;
778                         break;
779                 }
780                 if (revs->min_age != -1 && (commit->date > revs->min_age))
781                         continue;
782                 date = commit->date;
783                 p = &commit_list_insert(commit, p)->next;
784
785                 show = show_early_output;
786                 if (!show)
787                         continue;
788
789                 show(revs, newlist);
790                 show_early_output = NULL;
791         }
792         if (revs->cherry_pick)
793                 cherry_pick_list(newlist, revs);
794
795         if (bottom) {
796                 limit_to_ancestry(bottom, newlist);
797                 free_commit_list(bottom);
798         }
799
800         revs->commits = newlist;
801         return 0;
802 }
803
804 static void add_rev_cmdline(struct rev_info *revs,
805                             struct object *item,
806                             const char *name,
807                             int whence,
808                             unsigned flags)
809 {
810         struct rev_cmdline_info *info = &revs->cmdline;
811         int nr = info->nr;
812
813         ALLOC_GROW(info->rev, nr + 1, info->alloc);
814         info->rev[nr].item = item;
815         info->rev[nr].name = name;
816         info->rev[nr].whence = whence;
817         info->rev[nr].flags = flags;
818         info->nr++;
819 }
820
821 struct all_refs_cb {
822         int all_flags;
823         int warned_bad_reflog;
824         struct rev_info *all_revs;
825         const char *name_for_errormsg;
826 };
827
828 static int handle_one_ref(const char *path, const unsigned char *sha1, int flag, void *cb_data)
829 {
830         struct all_refs_cb *cb = cb_data;
831         struct object *object = get_reference(cb->all_revs, path, sha1,
832                                               cb->all_flags);
833         add_rev_cmdline(cb->all_revs, object, path, REV_CMD_REF, cb->all_flags);
834         add_pending_object(cb->all_revs, object, path);
835         return 0;
836 }
837
838 static void init_all_refs_cb(struct all_refs_cb *cb, struct rev_info *revs,
839         unsigned flags)
840 {
841         cb->all_revs = revs;
842         cb->all_flags = flags;
843 }
844
845 static void handle_refs(struct rev_info *revs, unsigned flags,
846                 int (*for_each)(each_ref_fn, void *))
847 {
848         struct all_refs_cb cb;
849         init_all_refs_cb(&cb, revs, flags);
850         for_each(handle_one_ref, &cb);
851 }
852
853 static void handle_one_reflog_commit(unsigned char *sha1, void *cb_data)
854 {
855         struct all_refs_cb *cb = cb_data;
856         if (!is_null_sha1(sha1)) {
857                 struct object *o = parse_object(sha1);
858                 if (o) {
859                         o->flags |= cb->all_flags;
860                         /* ??? CMDLINEFLAGS ??? */
861                         add_pending_object(cb->all_revs, o, "");
862                 }
863                 else if (!cb->warned_bad_reflog) {
864                         warning("reflog of '%s' references pruned commits",
865                                 cb->name_for_errormsg);
866                         cb->warned_bad_reflog = 1;
867                 }
868         }
869 }
870
871 static int handle_one_reflog_ent(unsigned char *osha1, unsigned char *nsha1,
872                 const char *email, unsigned long timestamp, int tz,
873                 const char *message, void *cb_data)
874 {
875         handle_one_reflog_commit(osha1, cb_data);
876         handle_one_reflog_commit(nsha1, cb_data);
877         return 0;
878 }
879
880 static int handle_one_reflog(const char *path, const unsigned char *sha1, int flag, void *cb_data)
881 {
882         struct all_refs_cb *cb = cb_data;
883         cb->warned_bad_reflog = 0;
884         cb->name_for_errormsg = path;
885         for_each_reflog_ent(path, handle_one_reflog_ent, cb_data);
886         return 0;
887 }
888
889 static void handle_reflog(struct rev_info *revs, unsigned flags)
890 {
891         struct all_refs_cb cb;
892         cb.all_revs = revs;
893         cb.all_flags = flags;
894         for_each_reflog(handle_one_reflog, &cb);
895 }
896
897 static int add_parents_only(struct rev_info *revs, const char *arg_, int flags)
898 {
899         unsigned char sha1[20];
900         struct object *it;
901         struct commit *commit;
902         struct commit_list *parents;
903         const char *arg = arg_;
904
905         if (*arg == '^') {
906                 flags ^= UNINTERESTING;
907                 arg++;
908         }
909         if (get_sha1(arg, sha1))
910                 return 0;
911         while (1) {
912                 it = get_reference(revs, arg, sha1, 0);
913                 if (it->type != OBJ_TAG)
914                         break;
915                 if (!((struct tag*)it)->tagged)
916                         return 0;
917                 hashcpy(sha1, ((struct tag*)it)->tagged->sha1);
918         }
919         if (it->type != OBJ_COMMIT)
920                 return 0;
921         commit = (struct commit *)it;
922         for (parents = commit->parents; parents; parents = parents->next) {
923                 it = &parents->item->object;
924                 it->flags |= flags;
925                 add_rev_cmdline(revs, it, arg_, REV_CMD_PARENTS_ONLY, flags);
926                 add_pending_object(revs, it, arg);
927         }
928         return 1;
929 }
930
931 void init_revisions(struct rev_info *revs, const char *prefix)
932 {
933         memset(revs, 0, sizeof(*revs));
934
935         revs->abbrev = DEFAULT_ABBREV;
936         revs->ignore_merges = 1;
937         revs->simplify_history = 1;
938         DIFF_OPT_SET(&revs->pruning, RECURSIVE);
939         DIFF_OPT_SET(&revs->pruning, QUICK);
940         revs->pruning.add_remove = file_add_remove;
941         revs->pruning.change = file_change;
942         revs->lifo = 1;
943         revs->dense = 1;
944         revs->prefix = prefix;
945         revs->max_age = -1;
946         revs->min_age = -1;
947         revs->skip_count = -1;
948         revs->max_count = -1;
949
950         revs->commit_format = CMIT_FMT_DEFAULT;
951
952         revs->grep_filter.status_only = 1;
953         revs->grep_filter.pattern_tail = &(revs->grep_filter.pattern_list);
954         revs->grep_filter.header_tail = &(revs->grep_filter.header_list);
955         revs->grep_filter.regflags = REG_NEWLINE;
956
957         diff_setup(&revs->diffopt);
958         if (prefix && !revs->diffopt.prefix) {
959                 revs->diffopt.prefix = prefix;
960                 revs->diffopt.prefix_length = strlen(prefix);
961         }
962 }
963
964 static void add_pending_commit_list(struct rev_info *revs,
965                                     struct commit_list *commit_list,
966                                     unsigned int flags)
967 {
968         while (commit_list) {
969                 struct object *object = &commit_list->item->object;
970                 object->flags |= flags;
971                 add_pending_object(revs, object, sha1_to_hex(object->sha1));
972                 commit_list = commit_list->next;
973         }
974 }
975
976 static void prepare_show_merge(struct rev_info *revs)
977 {
978         struct commit_list *bases;
979         struct commit *head, *other;
980         unsigned char sha1[20];
981         const char **prune = NULL;
982         int i, prune_num = 1; /* counting terminating NULL */
983
984         if (get_sha1("HEAD", sha1) || !(head = lookup_commit(sha1)))
985                 die("--merge without HEAD?");
986         if (get_sha1("MERGE_HEAD", sha1) || !(other = lookup_commit(sha1)))
987                 die("--merge without MERGE_HEAD?");
988         add_pending_object(revs, &head->object, "HEAD");
989         add_pending_object(revs, &other->object, "MERGE_HEAD");
990         bases = get_merge_bases(head, other, 1);
991         add_pending_commit_list(revs, bases, UNINTERESTING);
992         free_commit_list(bases);
993         head->object.flags |= SYMMETRIC_LEFT;
994
995         if (!active_nr)
996                 read_cache();
997         for (i = 0; i < active_nr; i++) {
998                 struct cache_entry *ce = active_cache[i];
999                 if (!ce_stage(ce))
1000                         continue;
1001                 if (ce_path_match(ce, revs->prune_data)) {
1002                         prune_num++;
1003                         prune = xrealloc(prune, sizeof(*prune) * prune_num);
1004                         prune[prune_num-2] = ce->name;
1005                         prune[prune_num-1] = NULL;
1006                 }
1007                 while ((i+1 < active_nr) &&
1008                        ce_same_name(ce, active_cache[i+1]))
1009                         i++;
1010         }
1011         revs->prune_data = prune;
1012         revs->limited = 1;
1013 }
1014
1015 int handle_revision_arg(const char *arg_, struct rev_info *revs,
1016                         int flags,
1017                         int cant_be_filename)
1018 {
1019         unsigned mode;
1020         char *dotdot;
1021         struct object *object;
1022         unsigned char sha1[20];
1023         int local_flags;
1024         const char *arg = arg_;
1025
1026         dotdot = strstr(arg, "..");
1027         if (dotdot) {
1028                 unsigned char from_sha1[20];
1029                 const char *next = dotdot + 2;
1030                 const char *this = arg;
1031                 int symmetric = *next == '.';
1032                 unsigned int flags_exclude = flags ^ UNINTERESTING;
1033                 unsigned int a_flags;
1034
1035                 *dotdot = 0;
1036                 next += symmetric;
1037
1038                 if (!*next)
1039                         next = "HEAD";
1040                 if (dotdot == arg)
1041                         this = "HEAD";
1042                 if (!get_sha1(this, from_sha1) &&
1043                     !get_sha1(next, sha1)) {
1044                         struct commit *a, *b;
1045                         struct commit_list *exclude;
1046
1047                         a = lookup_commit_reference(from_sha1);
1048                         b = lookup_commit_reference(sha1);
1049                         if (!a || !b) {
1050                                 die(symmetric ?
1051                                     "Invalid symmetric difference expression %s...%s" :
1052                                     "Invalid revision range %s..%s",
1053                                     arg, next);
1054                         }
1055
1056                         if (!cant_be_filename) {
1057                                 *dotdot = '.';
1058                                 verify_non_filename(revs->prefix, arg);
1059                         }
1060
1061                         if (symmetric) {
1062                                 exclude = get_merge_bases(a, b, 1);
1063                                 add_pending_commit_list(revs, exclude,
1064                                                         flags_exclude);
1065                                 free_commit_list(exclude);
1066                                 a_flags = flags | SYMMETRIC_LEFT;
1067                         } else
1068                                 a_flags = flags_exclude;
1069                         a->object.flags |= a_flags;
1070                         b->object.flags |= flags;
1071                         add_rev_cmdline(revs, &a->object, this,
1072                                         REV_CMD_LEFT, a_flags);
1073                         add_rev_cmdline(revs, &b->object, next,
1074                                         REV_CMD_RIGHT, flags);
1075                         add_pending_object(revs, &a->object, this);
1076                         add_pending_object(revs, &b->object, next);
1077                         return 0;
1078                 }
1079                 *dotdot = '.';
1080         }
1081         dotdot = strstr(arg, "^@");
1082         if (dotdot && !dotdot[2]) {
1083                 *dotdot = 0;
1084                 if (add_parents_only(revs, arg, flags))
1085                         return 0;
1086                 *dotdot = '^';
1087         }
1088         dotdot = strstr(arg, "^!");
1089         if (dotdot && !dotdot[2]) {
1090                 *dotdot = 0;
1091                 if (!add_parents_only(revs, arg, flags ^ UNINTERESTING))
1092                         *dotdot = '^';
1093         }
1094
1095         local_flags = 0;
1096         if (*arg == '^') {
1097                 local_flags = UNINTERESTING;
1098                 arg++;
1099         }
1100         if (get_sha1_with_mode(arg, sha1, &mode))
1101                 return -1;
1102         if (!cant_be_filename)
1103                 verify_non_filename(revs->prefix, arg);
1104         object = get_reference(revs, arg, sha1, flags ^ local_flags);
1105         add_rev_cmdline(revs, object, arg_, REV_CMD_REV, flags ^ local_flags);
1106         add_pending_object_with_mode(revs, object, arg, mode);
1107         return 0;
1108 }
1109
1110 static void read_pathspec_from_stdin(struct rev_info *revs, struct strbuf *sb, const char ***prune_data)
1111 {
1112         const char **prune = *prune_data;
1113         int prune_nr;
1114         int prune_alloc;
1115
1116         /* count existing ones */
1117         if (!prune)
1118                 prune_nr = 0;
1119         else
1120                 for (prune_nr = 0; prune[prune_nr]; prune_nr++)
1121                         ;
1122         prune_alloc = prune_nr; /* not really, but we do not know */
1123
1124         while (strbuf_getwholeline(sb, stdin, '\n') != EOF) {
1125                 int len = sb->len;
1126                 if (len && sb->buf[len - 1] == '\n')
1127                         sb->buf[--len] = '\0';
1128                 ALLOC_GROW(prune, prune_nr+1, prune_alloc);
1129                 prune[prune_nr++] = xstrdup(sb->buf);
1130         }
1131         if (prune) {
1132                 ALLOC_GROW(prune, prune_nr+1, prune_alloc);
1133                 prune[prune_nr] = NULL;
1134         }
1135         *prune_data = prune;
1136 }
1137
1138 static void read_revisions_from_stdin(struct rev_info *revs, const char ***prune)
1139 {
1140         struct strbuf sb;
1141         int seen_dashdash = 0;
1142
1143         strbuf_init(&sb, 1000);
1144         while (strbuf_getwholeline(&sb, stdin, '\n') != EOF) {
1145                 int len = sb.len;
1146                 if (len && sb.buf[len - 1] == '\n')
1147                         sb.buf[--len] = '\0';
1148                 if (!len)
1149                         break;
1150                 if (sb.buf[0] == '-') {
1151                         if (len == 2 && sb.buf[1] == '-') {
1152                                 seen_dashdash = 1;
1153                                 break;
1154                         }
1155                         die("options not supported in --stdin mode");
1156                 }
1157                 if (handle_revision_arg(sb.buf, revs, 0, 1))
1158                         die("bad revision '%s'", sb.buf);
1159         }
1160         if (seen_dashdash)
1161                 read_pathspec_from_stdin(revs, &sb, prune);
1162         strbuf_release(&sb);
1163 }
1164
1165 static void add_grep(struct rev_info *revs, const char *ptn, enum grep_pat_token what)
1166 {
1167         append_grep_pattern(&revs->grep_filter, ptn, "command line", 0, what);
1168 }
1169
1170 static void add_header_grep(struct rev_info *revs, enum grep_header_field field, const char *pattern)
1171 {
1172         append_header_grep_pattern(&revs->grep_filter, field, pattern);
1173 }
1174
1175 static void add_message_grep(struct rev_info *revs, const char *pattern)
1176 {
1177         add_grep(revs, pattern, GREP_PATTERN_BODY);
1178 }
1179
1180 static int handle_revision_opt(struct rev_info *revs, int argc, const char **argv,
1181                                int *unkc, const char **unkv)
1182 {
1183         const char *arg = argv[0];
1184
1185         /* pseudo revision arguments */
1186         if (!strcmp(arg, "--all") || !strcmp(arg, "--branches") ||
1187             !strcmp(arg, "--tags") || !strcmp(arg, "--remotes") ||
1188             !strcmp(arg, "--reflog") || !strcmp(arg, "--not") ||
1189             !strcmp(arg, "--no-walk") || !strcmp(arg, "--do-walk") ||
1190             !strcmp(arg, "--bisect"))
1191         {
1192                 unkv[(*unkc)++] = arg;
1193                 return 1;
1194         }
1195
1196         if (!prefixcmp(arg, "--max-count=")) {
1197                 revs->max_count = atoi(arg + 12);
1198         } else if (!prefixcmp(arg, "--skip=")) {
1199                 revs->skip_count = atoi(arg + 7);
1200         } else if ((*arg == '-') && isdigit(arg[1])) {
1201         /* accept -<digit>, like traditional "head" */
1202                 revs->max_count = atoi(arg + 1);
1203         } else if (!strcmp(arg, "-n")) {
1204                 if (argc <= 1)
1205                         return error("-n requires an argument");
1206                 revs->max_count = atoi(argv[1]);
1207                 return 2;
1208         } else if (!prefixcmp(arg, "-n")) {
1209                 revs->max_count = atoi(arg + 2);
1210         } else if (!prefixcmp(arg, "--max-age=")) {
1211                 revs->max_age = atoi(arg + 10);
1212         } else if (!prefixcmp(arg, "--since=")) {
1213                 revs->max_age = approxidate(arg + 8);
1214         } else if (!prefixcmp(arg, "--after=")) {
1215                 revs->max_age = approxidate(arg + 8);
1216         } else if (!prefixcmp(arg, "--min-age=")) {
1217                 revs->min_age = atoi(arg + 10);
1218         } else if (!prefixcmp(arg, "--before=")) {
1219                 revs->min_age = approxidate(arg + 9);
1220         } else if (!prefixcmp(arg, "--until=")) {
1221                 revs->min_age = approxidate(arg + 8);
1222         } else if (!strcmp(arg, "--first-parent")) {
1223                 revs->first_parent_only = 1;
1224         } else if (!strcmp(arg, "--ancestry-path")) {
1225                 revs->ancestry_path = 1;
1226                 revs->simplify_history = 0;
1227                 revs->limited = 1;
1228         } else if (!strcmp(arg, "-g") || !strcmp(arg, "--walk-reflogs")) {
1229                 init_reflog_walk(&revs->reflog_info);
1230         } else if (!strcmp(arg, "--default")) {
1231                 if (argc <= 1)
1232                         return error("bad --default argument");
1233                 revs->def = argv[1];
1234                 return 2;
1235         } else if (!strcmp(arg, "--merge")) {
1236                 revs->show_merge = 1;
1237         } else if (!strcmp(arg, "--topo-order")) {
1238                 revs->lifo = 1;
1239                 revs->topo_order = 1;
1240         } else if (!strcmp(arg, "--simplify-merges")) {
1241                 revs->simplify_merges = 1;
1242                 revs->rewrite_parents = 1;
1243                 revs->simplify_history = 0;
1244                 revs->limited = 1;
1245         } else if (!strcmp(arg, "--simplify-by-decoration")) {
1246                 revs->simplify_merges = 1;
1247                 revs->rewrite_parents = 1;
1248                 revs->simplify_history = 0;
1249                 revs->simplify_by_decoration = 1;
1250                 revs->limited = 1;
1251                 revs->prune = 1;
1252                 load_ref_decorations(DECORATE_SHORT_REFS);
1253         } else if (!strcmp(arg, "--date-order")) {
1254                 revs->lifo = 0;
1255                 revs->topo_order = 1;
1256         } else if (!prefixcmp(arg, "--early-output")) {
1257                 int count = 100;
1258                 switch (arg[14]) {
1259                 case '=':
1260                         count = atoi(arg+15);
1261                         /* Fallthrough */
1262                 case 0:
1263                         revs->topo_order = 1;
1264                        revs->early_output = count;
1265                 }
1266         } else if (!strcmp(arg, "--parents")) {
1267                 revs->rewrite_parents = 1;
1268                 revs->print_parents = 1;
1269         } else if (!strcmp(arg, "--dense")) {
1270                 revs->dense = 1;
1271         } else if (!strcmp(arg, "--sparse")) {
1272                 revs->dense = 0;
1273         } else if (!strcmp(arg, "--show-all")) {
1274                 revs->show_all = 1;
1275         } else if (!strcmp(arg, "--remove-empty")) {
1276                 revs->remove_empty_trees = 1;
1277         } else if (!strcmp(arg, "--merges")) {
1278                 revs->merges_only = 1;
1279         } else if (!strcmp(arg, "--no-merges")) {
1280                 revs->no_merges = 1;
1281         } else if (!strcmp(arg, "--boundary")) {
1282                 revs->boundary = 1;
1283         } else if (!strcmp(arg, "--left-right")) {
1284                 revs->left_right = 1;
1285         } else if (!strcmp(arg, "--cherry-pick")) {
1286                 revs->cherry_pick = 1;
1287                 revs->limited = 1;
1288         } else if (!strcmp(arg, "--objects")) {
1289                 revs->tag_objects = 1;
1290                 revs->tree_objects = 1;
1291                 revs->blob_objects = 1;
1292         } else if (!strcmp(arg, "--objects-edge")) {
1293                 revs->tag_objects = 1;
1294                 revs->tree_objects = 1;
1295                 revs->blob_objects = 1;
1296                 revs->edge_hint = 1;
1297         } else if (!strcmp(arg, "--unpacked")) {
1298                 revs->unpacked = 1;
1299         } else if (!prefixcmp(arg, "--unpacked=")) {
1300                 die("--unpacked=<packfile> no longer supported.");
1301         } else if (!strcmp(arg, "-r")) {
1302                 revs->diff = 1;
1303                 DIFF_OPT_SET(&revs->diffopt, RECURSIVE);
1304         } else if (!strcmp(arg, "-t")) {
1305                 revs->diff = 1;
1306                 DIFF_OPT_SET(&revs->diffopt, RECURSIVE);
1307                 DIFF_OPT_SET(&revs->diffopt, TREE_IN_RECURSIVE);
1308         } else if (!strcmp(arg, "-m")) {
1309                 revs->ignore_merges = 0;
1310         } else if (!strcmp(arg, "-c")) {
1311                 revs->diff = 1;
1312                 revs->dense_combined_merges = 0;
1313                 revs->combine_merges = 1;
1314         } else if (!strcmp(arg, "--cc")) {
1315                 revs->diff = 1;
1316                 revs->dense_combined_merges = 1;
1317                 revs->combine_merges = 1;
1318         } else if (!strcmp(arg, "-v")) {
1319                 revs->verbose_header = 1;
1320         } else if (!strcmp(arg, "--pretty")) {
1321                 revs->verbose_header = 1;
1322                 revs->pretty_given = 1;
1323                 get_commit_format(arg+8, revs);
1324         } else if (!prefixcmp(arg, "--pretty=") || !prefixcmp(arg, "--format=")) {
1325                 revs->verbose_header = 1;
1326                 revs->pretty_given = 1;
1327                 get_commit_format(arg+9, revs);
1328         } else if (!strcmp(arg, "--show-notes")) {
1329                 revs->show_notes = 1;
1330                 revs->show_notes_given = 1;
1331         } else if (!prefixcmp(arg, "--show-notes=")) {
1332                 struct strbuf buf = STRBUF_INIT;
1333                 revs->show_notes = 1;
1334                 revs->show_notes_given = 1;
1335                 if (!revs->notes_opt.extra_notes_refs)
1336                         revs->notes_opt.extra_notes_refs = xcalloc(1, sizeof(struct string_list));
1337                 if (!prefixcmp(arg+13, "refs/"))
1338                         /* happy */;
1339                 else if (!prefixcmp(arg+13, "notes/"))
1340                         strbuf_addstr(&buf, "refs/");
1341                 else
1342                         strbuf_addstr(&buf, "refs/notes/");
1343                 strbuf_addstr(&buf, arg+13);
1344                 string_list_append(strbuf_detach(&buf, NULL),
1345                                    revs->notes_opt.extra_notes_refs);
1346         } else if (!strcmp(arg, "--no-notes")) {
1347                 revs->show_notes = 0;
1348                 revs->show_notes_given = 1;
1349         } else if (!strcmp(arg, "--standard-notes")) {
1350                 revs->show_notes_given = 1;
1351                 revs->notes_opt.suppress_default_notes = 0;
1352         } else if (!strcmp(arg, "--no-standard-notes")) {
1353                 revs->notes_opt.suppress_default_notes = 1;
1354         } else if (!strcmp(arg, "--oneline")) {
1355                 revs->verbose_header = 1;
1356                 get_commit_format("oneline", revs);
1357                 revs->pretty_given = 1;
1358                 revs->abbrev_commit = 1;
1359         } else if (!strcmp(arg, "--graph")) {
1360                 revs->topo_order = 1;
1361                 revs->rewrite_parents = 1;
1362                 revs->graph = graph_init(revs);
1363         } else if (!strcmp(arg, "--root")) {
1364                 revs->show_root_diff = 1;
1365         } else if (!strcmp(arg, "--no-commit-id")) {
1366                 revs->no_commit_id = 1;
1367         } else if (!strcmp(arg, "--always")) {
1368                 revs->always_show_header = 1;
1369         } else if (!strcmp(arg, "--no-abbrev")) {
1370                 revs->abbrev = 0;
1371         } else if (!strcmp(arg, "--abbrev")) {
1372                 revs->abbrev = DEFAULT_ABBREV;
1373         } else if (!prefixcmp(arg, "--abbrev=")) {
1374                 revs->abbrev = strtoul(arg + 9, NULL, 10);
1375                 if (revs->abbrev < MINIMUM_ABBREV)
1376                         revs->abbrev = MINIMUM_ABBREV;
1377                 else if (revs->abbrev > 40)
1378                         revs->abbrev = 40;
1379         } else if (!strcmp(arg, "--abbrev-commit")) {
1380                 revs->abbrev_commit = 1;
1381         } else if (!strcmp(arg, "--full-diff")) {
1382                 revs->diff = 1;
1383                 revs->full_diff = 1;
1384         } else if (!strcmp(arg, "--full-history")) {
1385                 revs->simplify_history = 0;
1386         } else if (!strcmp(arg, "--relative-date")) {
1387                 revs->date_mode = DATE_RELATIVE;
1388                 revs->date_mode_explicit = 1;
1389         } else if (!strncmp(arg, "--date=", 7)) {
1390                 revs->date_mode = parse_date_format(arg + 7);
1391                 revs->date_mode_explicit = 1;
1392         } else if (!strcmp(arg, "--log-size")) {
1393                 revs->show_log_size = 1;
1394         }
1395         /*
1396          * Grepping the commit log
1397          */
1398         else if (!prefixcmp(arg, "--author=")) {
1399                 add_header_grep(revs, GREP_HEADER_AUTHOR, arg+9);
1400         } else if (!prefixcmp(arg, "--committer=")) {
1401                 add_header_grep(revs, GREP_HEADER_COMMITTER, arg+12);
1402         } else if (!prefixcmp(arg, "--grep=")) {
1403                 add_message_grep(revs, arg+7);
1404         } else if (!strcmp(arg, "--extended-regexp") || !strcmp(arg, "-E")) {
1405                 revs->grep_filter.regflags |= REG_EXTENDED;
1406         } else if (!strcmp(arg, "--regexp-ignore-case") || !strcmp(arg, "-i")) {
1407                 revs->grep_filter.regflags |= REG_ICASE;
1408         } else if (!strcmp(arg, "--fixed-strings") || !strcmp(arg, "-F")) {
1409                 revs->grep_filter.fixed = 1;
1410         } else if (!strcmp(arg, "--all-match")) {
1411                 revs->grep_filter.all_match = 1;
1412         } else if (!prefixcmp(arg, "--encoding=")) {
1413                 arg += 11;
1414                 if (strcmp(arg, "none"))
1415                         git_log_output_encoding = xstrdup(arg);
1416                 else
1417                         git_log_output_encoding = "";
1418         } else if (!strcmp(arg, "--reverse")) {
1419                 revs->reverse ^= 1;
1420         } else if (!strcmp(arg, "--children")) {
1421                 revs->children.name = "children";
1422                 revs->limited = 1;
1423         } else {
1424                 int opts = diff_opt_parse(&revs->diffopt, argv, argc);
1425                 if (!opts)
1426                         unkv[(*unkc)++] = arg;
1427                 return opts;
1428         }
1429
1430         return 1;
1431 }
1432
1433 void parse_revision_opt(struct rev_info *revs, struct parse_opt_ctx_t *ctx,
1434                         const struct option *options,
1435                         const char * const usagestr[])
1436 {
1437         int n = handle_revision_opt(revs, ctx->argc, ctx->argv,
1438                                     &ctx->cpidx, ctx->out);
1439         if (n <= 0) {
1440                 error("unknown option `%s'", ctx->argv[0]);
1441                 usage_with_options(usagestr, options);
1442         }
1443         ctx->argv += n;
1444         ctx->argc -= n;
1445 }
1446
1447 static int for_each_bad_bisect_ref(each_ref_fn fn, void *cb_data)
1448 {
1449         return for_each_ref_in("refs/bisect/bad", fn, cb_data);
1450 }
1451
1452 static int for_each_good_bisect_ref(each_ref_fn fn, void *cb_data)
1453 {
1454         return for_each_ref_in("refs/bisect/good", fn, cb_data);
1455 }
1456
1457 static void append_prune_data(const char ***prune_data, const char **av)
1458 {
1459         const char **prune = *prune_data;
1460         int prune_nr;
1461         int prune_alloc;
1462
1463         if (!prune) {
1464                 *prune_data = av;
1465                 return;
1466         }
1467
1468         /* count existing ones */
1469         for (prune_nr = 0; prune[prune_nr]; prune_nr++)
1470                 ;
1471         prune_alloc = prune_nr; /* not really, but we do not know */
1472
1473         while (*av) {
1474                 ALLOC_GROW(prune, prune_nr+1, prune_alloc);
1475                 prune[prune_nr++] = *av;
1476                 av++;
1477         }
1478         if (prune) {
1479                 ALLOC_GROW(prune, prune_nr+1, prune_alloc);
1480                 prune[prune_nr] = NULL;
1481         }
1482         *prune_data = prune;
1483 }
1484
1485 /*
1486  * Parse revision information, filling in the "rev_info" structure,
1487  * and removing the used arguments from the argument list.
1488  *
1489  * Returns the number of arguments left that weren't recognized
1490  * (which are also moved to the head of the argument list)
1491  */
1492 int setup_revisions(int argc, const char **argv, struct rev_info *revs, struct setup_revision_opt *opt)
1493 {
1494         int i, flags, left, seen_dashdash, read_from_stdin, got_rev_arg = 0;
1495         const char **prune_data = NULL;
1496
1497         /* First, search for "--" */
1498         seen_dashdash = 0;
1499         for (i = 1; i < argc; i++) {
1500                 const char *arg = argv[i];
1501                 if (strcmp(arg, "--"))
1502                         continue;
1503                 argv[i] = NULL;
1504                 argc = i;
1505                 if (argv[i + 1])
1506                         prune_data = argv + i + 1;
1507                 seen_dashdash = 1;
1508                 break;
1509         }
1510
1511         /* Second, deal with arguments and options */
1512         flags = 0;
1513         read_from_stdin = 0;
1514         for (left = i = 1; i < argc; i++) {
1515                 const char *arg = argv[i];
1516                 if (*arg == '-') {
1517                         int opts;
1518
1519                         if (!strcmp(arg, "--all")) {
1520                                 handle_refs(revs, flags, for_each_ref);
1521                                 handle_refs(revs, flags, head_ref);
1522                                 continue;
1523                         }
1524                         if (!strcmp(arg, "--branches")) {
1525                                 handle_refs(revs, flags, for_each_branch_ref);
1526                                 continue;
1527                         }
1528                         if (!strcmp(arg, "--bisect")) {
1529                                 handle_refs(revs, flags, for_each_bad_bisect_ref);
1530                                 handle_refs(revs, flags ^ UNINTERESTING, for_each_good_bisect_ref);
1531                                 revs->bisect = 1;
1532                                 continue;
1533                         }
1534                         if (!strcmp(arg, "--tags")) {
1535                                 handle_refs(revs, flags, for_each_tag_ref);
1536                                 continue;
1537                         }
1538                         if (!strcmp(arg, "--remotes")) {
1539                                 handle_refs(revs, flags, for_each_remote_ref);
1540                                 continue;
1541                         }
1542                         if (!prefixcmp(arg, "--glob=")) {
1543                                 struct all_refs_cb cb;
1544                                 init_all_refs_cb(&cb, revs, flags);
1545                                 for_each_glob_ref(handle_one_ref, arg + 7, &cb);
1546                                 continue;
1547                         }
1548                         if (!prefixcmp(arg, "--branches=")) {
1549                                 struct all_refs_cb cb;
1550                                 init_all_refs_cb(&cb, revs, flags);
1551                                 for_each_glob_ref_in(handle_one_ref, arg + 11, "refs/heads/", &cb);
1552                                 continue;
1553                         }
1554                         if (!prefixcmp(arg, "--tags=")) {
1555                                 struct all_refs_cb cb;
1556                                 init_all_refs_cb(&cb, revs, flags);
1557                                 for_each_glob_ref_in(handle_one_ref, arg + 7, "refs/tags/", &cb);
1558                                 continue;
1559                         }
1560                         if (!prefixcmp(arg, "--remotes=")) {
1561                                 struct all_refs_cb cb;
1562                                 init_all_refs_cb(&cb, revs, flags);
1563                                 for_each_glob_ref_in(handle_one_ref, arg + 10, "refs/remotes/", &cb);
1564                                 continue;
1565                         }
1566                         if (!strcmp(arg, "--reflog")) {
1567                                 handle_reflog(revs, flags);
1568                                 continue;
1569                         }
1570                         if (!strcmp(arg, "--not")) {
1571                                 flags ^= UNINTERESTING;
1572                                 continue;
1573                         }
1574                         if (!strcmp(arg, "--no-walk")) {
1575                                 revs->no_walk = 1;
1576                                 continue;
1577                         }
1578                         if (!strcmp(arg, "--do-walk")) {
1579                                 revs->no_walk = 0;
1580                                 continue;
1581                         }
1582                         if (!strcmp(arg, "--stdin")) {
1583                                 if (revs->disable_stdin) {
1584                                         argv[left++] = arg;
1585                                         continue;
1586                                 }
1587                                 if (read_from_stdin++)
1588                                         die("--stdin given twice?");
1589                                 read_revisions_from_stdin(revs, &prune_data);
1590                                 continue;
1591                         }
1592
1593                         opts = handle_revision_opt(revs, argc - i, argv + i, &left, argv);
1594                         if (opts > 0) {
1595                                 i += opts - 1;
1596                                 continue;
1597                         }
1598                         if (opts < 0)
1599                                 exit(128);
1600                         continue;
1601                 }
1602
1603                 if (handle_revision_arg(arg, revs, flags, seen_dashdash)) {
1604                         int j;
1605                         if (seen_dashdash || *arg == '^')
1606                                 die("bad revision '%s'", arg);
1607
1608                         /* If we didn't have a "--":
1609                          * (1) all filenames must exist;
1610                          * (2) all rev-args must not be interpretable
1611                          *     as a valid filename.
1612                          * but the latter we have checked in the main loop.
1613                          */
1614                         for (j = i; j < argc; j++)
1615                                 verify_filename(revs->prefix, argv[j]);
1616
1617                         append_prune_data(&prune_data, argv + i);
1618                         break;
1619                 }
1620                 else
1621                         got_rev_arg = 1;
1622         }
1623
1624         if (prune_data)
1625                 revs->prune_data = get_pathspec(revs->prefix, prune_data);
1626
1627         if (revs->def == NULL)
1628                 revs->def = opt ? opt->def : NULL;
1629         if (opt && opt->tweak)
1630                 opt->tweak(revs, opt);
1631         if (revs->show_merge)
1632                 prepare_show_merge(revs);
1633         if (revs->def && !revs->pending.nr && !got_rev_arg) {
1634                 unsigned char sha1[20];
1635                 struct object *object;
1636                 unsigned mode;
1637                 if (get_sha1_with_mode(revs->def, sha1, &mode))
1638                         die("bad default revision '%s'", revs->def);
1639                 object = get_reference(revs, revs->def, sha1, 0);
1640                 add_pending_object_with_mode(revs, object, revs->def, mode);
1641         }
1642
1643         /* Did the user ask for any diff output? Run the diff! */
1644         if (revs->diffopt.output_format & ~DIFF_FORMAT_NO_OUTPUT)
1645                 revs->diff = 1;
1646
1647         /* Pickaxe, diff-filter and rename following need diffs */
1648         if (revs->diffopt.pickaxe ||
1649             revs->diffopt.filter ||
1650             DIFF_OPT_TST(&revs->diffopt, FOLLOW_RENAMES))
1651                 revs->diff = 1;
1652
1653         if (revs->topo_order)
1654                 revs->limited = 1;
1655
1656         if (revs->prune_data) {
1657                 diff_tree_setup_paths(revs->prune_data, &revs->pruning);
1658                 /* Can't prune commits with rename following: the paths change.. */
1659                 if (!DIFF_OPT_TST(&revs->diffopt, FOLLOW_RENAMES))
1660                         revs->prune = 1;
1661                 if (!revs->full_diff)
1662                         diff_tree_setup_paths(revs->prune_data, &revs->diffopt);
1663         }
1664         if (revs->combine_merges)
1665                 revs->ignore_merges = 0;
1666         revs->diffopt.abbrev = revs->abbrev;
1667         if (diff_setup_done(&revs->diffopt) < 0)
1668                 die("diff_setup_done failed");
1669
1670         compile_grep_patterns(&revs->grep_filter);
1671
1672         if (revs->reverse && revs->reflog_info)
1673                 die("cannot combine --reverse with --walk-reflogs");
1674         if (revs->rewrite_parents && revs->children.name)
1675                 die("cannot combine --parents and --children");
1676
1677         /*
1678          * Limitations on the graph functionality
1679          */
1680         if (revs->reverse && revs->graph)
1681                 die("cannot combine --reverse with --graph");
1682
1683         if (revs->reflog_info && revs->graph)
1684                 die("cannot combine --walk-reflogs with --graph");
1685
1686         return left;
1687 }
1688
1689 static void add_child(struct rev_info *revs, struct commit *parent, struct commit *child)
1690 {
1691         struct commit_list *l = xcalloc(1, sizeof(*l));
1692
1693         l->item = child;
1694         l->next = add_decoration(&revs->children, &parent->object, l);
1695 }
1696
1697 static int remove_duplicate_parents(struct commit *commit)
1698 {
1699         struct commit_list **pp, *p;
1700         int surviving_parents;
1701
1702         /* Examine existing parents while marking ones we have seen... */
1703         pp = &commit->parents;
1704         while ((p = *pp) != NULL) {
1705                 struct commit *parent = p->item;
1706                 if (parent->object.flags & TMP_MARK) {
1707                         *pp = p->next;
1708                         continue;
1709                 }
1710                 parent->object.flags |= TMP_MARK;
1711                 pp = &p->next;
1712         }
1713         /* count them while clearing the temporary mark */
1714         surviving_parents = 0;
1715         for (p = commit->parents; p; p = p->next) {
1716                 p->item->object.flags &= ~TMP_MARK;
1717                 surviving_parents++;
1718         }
1719         return surviving_parents;
1720 }
1721
1722 struct merge_simplify_state {
1723         struct commit *simplified;
1724 };
1725
1726 static struct merge_simplify_state *locate_simplify_state(struct rev_info *revs, struct commit *commit)
1727 {
1728         struct merge_simplify_state *st;
1729
1730         st = lookup_decoration(&revs->merge_simplification, &commit->object);
1731         if (!st) {
1732                 st = xcalloc(1, sizeof(*st));
1733                 add_decoration(&revs->merge_simplification, &commit->object, st);
1734         }
1735         return st;
1736 }
1737
1738 static struct commit_list **simplify_one(struct rev_info *revs, struct commit *commit, struct commit_list **tail)
1739 {
1740         struct commit_list *p;
1741         struct merge_simplify_state *st, *pst;
1742         int cnt;
1743
1744         st = locate_simplify_state(revs, commit);
1745
1746         /*
1747          * Have we handled this one?
1748          */
1749         if (st->simplified)
1750                 return tail;
1751
1752         /*
1753          * An UNINTERESTING commit simplifies to itself, so does a
1754          * root commit.  We do not rewrite parents of such commit
1755          * anyway.
1756          */
1757         if ((commit->object.flags & UNINTERESTING) || !commit->parents) {
1758                 st->simplified = commit;
1759                 return tail;
1760         }
1761
1762         /*
1763          * Do we know what commit all of our parents should be rewritten to?
1764          * Otherwise we are not ready to rewrite this one yet.
1765          */
1766         for (cnt = 0, p = commit->parents; p; p = p->next) {
1767                 pst = locate_simplify_state(revs, p->item);
1768                 if (!pst->simplified) {
1769                         tail = &commit_list_insert(p->item, tail)->next;
1770                         cnt++;
1771                 }
1772         }
1773         if (cnt) {
1774                 tail = &commit_list_insert(commit, tail)->next;
1775                 return tail;
1776         }
1777
1778         /*
1779          * Rewrite our list of parents.
1780          */
1781         for (p = commit->parents; p; p = p->next) {
1782                 pst = locate_simplify_state(revs, p->item);
1783                 p->item = pst->simplified;
1784         }
1785         cnt = remove_duplicate_parents(commit);
1786
1787         /*
1788          * It is possible that we are a merge and one side branch
1789          * does not have any commit that touches the given paths;
1790          * in such a case, the immediate parents will be rewritten
1791          * to different commits.
1792          *
1793          *      o----X          X: the commit we are looking at;
1794          *     /    /           o: a commit that touches the paths;
1795          * ---o----'
1796          *
1797          * Further reduce the parents by removing redundant parents.
1798          */
1799         if (1 < cnt) {
1800                 struct commit_list *h = reduce_heads(commit->parents);
1801                 cnt = commit_list_count(h);
1802                 free_commit_list(commit->parents);
1803                 commit->parents = h;
1804         }
1805
1806         /*
1807          * A commit simplifies to itself if it is a root, if it is
1808          * UNINTERESTING, if it touches the given paths, or if it is a
1809          * merge and its parents simplifies to more than one commits
1810          * (the first two cases are already handled at the beginning of
1811          * this function).
1812          *
1813          * Otherwise, it simplifies to what its sole parent simplifies to.
1814          */
1815         if (!cnt ||
1816             (commit->object.flags & UNINTERESTING) ||
1817             !(commit->object.flags & TREESAME) ||
1818             (1 < cnt))
1819                 st->simplified = commit;
1820         else {
1821                 pst = locate_simplify_state(revs, commit->parents->item);
1822                 st->simplified = pst->simplified;
1823         }
1824         return tail;
1825 }
1826
1827 static void simplify_merges(struct rev_info *revs)
1828 {
1829         struct commit_list *list;
1830         struct commit_list *yet_to_do, **tail;
1831
1832         if (!revs->topo_order)
1833                 sort_in_topological_order(&revs->commits, revs->lifo);
1834         if (!revs->prune)
1835                 return;
1836
1837         /* feed the list reversed */
1838         yet_to_do = NULL;
1839         for (list = revs->commits; list; list = list->next)
1840                 commit_list_insert(list->item, &yet_to_do);
1841         while (yet_to_do) {
1842                 list = yet_to_do;
1843                 yet_to_do = NULL;
1844                 tail = &yet_to_do;
1845                 while (list) {
1846                         struct commit *commit = list->item;
1847                         struct commit_list *next = list->next;
1848                         free(list);
1849                         list = next;
1850                         tail = simplify_one(revs, commit, tail);
1851                 }
1852         }
1853
1854         /* clean up the result, removing the simplified ones */
1855         list = revs->commits;
1856         revs->commits = NULL;
1857         tail = &revs->commits;
1858         while (list) {
1859                 struct commit *commit = list->item;
1860                 struct commit_list *next = list->next;
1861                 struct merge_simplify_state *st;
1862                 free(list);
1863                 list = next;
1864                 st = locate_simplify_state(revs, commit);
1865                 if (st->simplified == commit)
1866                         tail = &commit_list_insert(commit, tail)->next;
1867         }
1868 }
1869
1870 static void set_children(struct rev_info *revs)
1871 {
1872         struct commit_list *l;
1873         for (l = revs->commits; l; l = l->next) {
1874                 struct commit *commit = l->item;
1875                 struct commit_list *p;
1876
1877                 for (p = commit->parents; p; p = p->next)
1878                         add_child(revs, p->item, commit);
1879         }
1880 }
1881
1882 int prepare_revision_walk(struct rev_info *revs)
1883 {
1884         int nr = revs->pending.nr;
1885         struct object_array_entry *e, *list;
1886
1887         e = list = revs->pending.objects;
1888         revs->pending.nr = 0;
1889         revs->pending.alloc = 0;
1890         revs->pending.objects = NULL;
1891         while (--nr >= 0) {
1892                 struct commit *commit = handle_commit(revs, e->item, e->name);
1893                 if (commit) {
1894                         if (!(commit->object.flags & SEEN)) {
1895                                 commit->object.flags |= SEEN;
1896                                 insert_by_date(commit, &revs->commits);
1897                         }
1898                 }
1899                 e++;
1900         }
1901         free(list);
1902
1903         if (revs->no_walk)
1904                 return 0;
1905         if (revs->limited)
1906                 if (limit_list(revs) < 0)
1907                         return -1;
1908         if (revs->topo_order)
1909                 sort_in_topological_order(&revs->commits, revs->lifo);
1910         if (revs->simplify_merges)
1911                 simplify_merges(revs);
1912         if (revs->children.name)
1913                 set_children(revs);
1914         return 0;
1915 }
1916
1917 enum rewrite_result {
1918         rewrite_one_ok,
1919         rewrite_one_noparents,
1920         rewrite_one_error,
1921 };
1922
1923 static enum rewrite_result rewrite_one(struct rev_info *revs, struct commit **pp)
1924 {
1925         struct commit_list *cache = NULL;
1926
1927         for (;;) {
1928                 struct commit *p = *pp;
1929                 if (!revs->limited)
1930                         if (add_parents_to_list(revs, p, &revs->commits, &cache) < 0)
1931                                 return rewrite_one_error;
1932                 if (p->parents && p->parents->next)
1933                         return rewrite_one_ok;
1934                 if (p->object.flags & UNINTERESTING)
1935                         return rewrite_one_ok;
1936                 if (!(p->object.flags & TREESAME))
1937                         return rewrite_one_ok;
1938                 if (!p->parents)
1939                         return rewrite_one_noparents;
1940                 *pp = p->parents->item;
1941         }
1942 }
1943
1944 static int rewrite_parents(struct rev_info *revs, struct commit *commit)
1945 {
1946         struct commit_list **pp = &commit->parents;
1947         while (*pp) {
1948                 struct commit_list *parent = *pp;
1949                 switch (rewrite_one(revs, &parent->item)) {
1950                 case rewrite_one_ok:
1951                         break;
1952                 case rewrite_one_noparents:
1953                         *pp = parent->next;
1954                         continue;
1955                 case rewrite_one_error:
1956                         return -1;
1957                 }
1958                 pp = &parent->next;
1959         }
1960         remove_duplicate_parents(commit);
1961         return 0;
1962 }
1963
1964 static int commit_match(struct commit *commit, struct rev_info *opt)
1965 {
1966         if (!opt->grep_filter.pattern_list && !opt->grep_filter.header_list)
1967                 return 1;
1968         return grep_buffer(&opt->grep_filter,
1969                            NULL, /* we say nothing, not even filename */
1970                            commit->buffer, strlen(commit->buffer));
1971 }
1972
1973 static inline int want_ancestry(struct rev_info *revs)
1974 {
1975         return (revs->rewrite_parents || revs->children.name);
1976 }
1977
1978 enum commit_action get_commit_action(struct rev_info *revs, struct commit *commit)
1979 {
1980         if (commit->object.flags & SHOWN)
1981                 return commit_ignore;
1982         if (revs->unpacked && has_sha1_pack(commit->object.sha1))
1983                 return commit_ignore;
1984         if (revs->show_all)
1985                 return commit_show;
1986         if (commit->object.flags & UNINTERESTING)
1987                 return commit_ignore;
1988         if (revs->min_age != -1 && (commit->date > revs->min_age))
1989                 return commit_ignore;
1990         if (revs->no_merges && commit->parents && commit->parents->next)
1991                 return commit_ignore;
1992         if (revs->merges_only && !(commit->parents && commit->parents->next))
1993                 return commit_ignore;
1994         if (!commit_match(commit, revs))
1995                 return commit_ignore;
1996         if (revs->prune && revs->dense) {
1997                 /* Commit without changes? */
1998                 if (commit->object.flags & TREESAME) {
1999                         /* drop merges unless we want parenthood */
2000                         if (!want_ancestry(revs))
2001                                 return commit_ignore;
2002                         /* non-merge - always ignore it */
2003                         if (!commit->parents || !commit->parents->next)
2004                                 return commit_ignore;
2005                 }
2006         }
2007         return commit_show;
2008 }
2009
2010 enum commit_action simplify_commit(struct rev_info *revs, struct commit *commit)
2011 {
2012         enum commit_action action = get_commit_action(revs, commit);
2013
2014         if (action == commit_show &&
2015             !revs->show_all &&
2016             revs->prune && revs->dense && want_ancestry(revs)) {
2017                 if (rewrite_parents(revs, commit) < 0)
2018                         return commit_error;
2019         }
2020         return action;
2021 }
2022
2023 static struct commit *get_revision_1(struct rev_info *revs)
2024 {
2025         if (!revs->commits)
2026                 return NULL;
2027
2028         do {
2029                 struct commit_list *entry = revs->commits;
2030                 struct commit *commit = entry->item;
2031
2032                 revs->commits = entry->next;
2033                 free(entry);
2034
2035                 if (revs->reflog_info)
2036                         fake_reflog_parent(revs->reflog_info, commit);
2037
2038                 /*
2039                  * If we haven't done the list limiting, we need to look at
2040                  * the parents here. We also need to do the date-based limiting
2041                  * that we'd otherwise have done in limit_list().
2042                  */
2043                 if (!revs->limited) {
2044                         if (revs->max_age != -1 &&
2045                             (commit->date < revs->max_age))
2046                                 continue;
2047                         if (add_parents_to_list(revs, commit, &revs->commits, NULL) < 0)
2048                                 die("Failed to traverse parents of commit %s",
2049                                     sha1_to_hex(commit->object.sha1));
2050                 }
2051
2052                 switch (simplify_commit(revs, commit)) {
2053                 case commit_ignore:
2054                         continue;
2055                 case commit_error:
2056                         die("Failed to simplify parents of commit %s",
2057                             sha1_to_hex(commit->object.sha1));
2058                 default:
2059                         return commit;
2060                 }
2061         } while (revs->commits);
2062         return NULL;
2063 }
2064
2065 static void gc_boundary(struct object_array *array)
2066 {
2067         unsigned nr = array->nr;
2068         unsigned alloc = array->alloc;
2069         struct object_array_entry *objects = array->objects;
2070
2071         if (alloc <= nr) {
2072                 unsigned i, j;
2073                 for (i = j = 0; i < nr; i++) {
2074                         if (objects[i].item->flags & SHOWN)
2075                                 continue;
2076                         if (i != j)
2077                                 objects[j] = objects[i];
2078                         j++;
2079                 }
2080                 for (i = j; i < nr; i++)
2081                         objects[i].item = NULL;
2082                 array->nr = j;
2083         }
2084 }
2085
2086 static void create_boundary_commit_list(struct rev_info *revs)
2087 {
2088         unsigned i;
2089         struct commit *c;
2090         struct object_array *array = &revs->boundary_commits;
2091         struct object_array_entry *objects = array->objects;
2092
2093         /*
2094          * If revs->commits is non-NULL at this point, an error occurred in
2095          * get_revision_1().  Ignore the error and continue printing the
2096          * boundary commits anyway.  (This is what the code has always
2097          * done.)
2098          */
2099         if (revs->commits) {
2100                 free_commit_list(revs->commits);
2101                 revs->commits = NULL;
2102         }
2103
2104         /*
2105          * Put all of the actual boundary commits from revs->boundary_commits
2106          * into revs->commits
2107          */
2108         for (i = 0; i < array->nr; i++) {
2109                 c = (struct commit *)(objects[i].item);
2110                 if (!c)
2111                         continue;
2112                 if (!(c->object.flags & CHILD_SHOWN))
2113                         continue;
2114                 if (c->object.flags & (SHOWN | BOUNDARY))
2115                         continue;
2116                 c->object.flags |= BOUNDARY;
2117                 commit_list_insert(c, &revs->commits);
2118         }
2119
2120         /*
2121          * If revs->topo_order is set, sort the boundary commits
2122          * in topological order
2123          */
2124         sort_in_topological_order(&revs->commits, revs->lifo);
2125 }
2126
2127 static struct commit *get_revision_internal(struct rev_info *revs)
2128 {
2129         struct commit *c = NULL;
2130         struct commit_list *l;
2131
2132         if (revs->boundary == 2) {
2133                 /*
2134                  * All of the normal commits have already been returned,
2135                  * and we are now returning boundary commits.
2136                  * create_boundary_commit_list() has populated
2137                  * revs->commits with the remaining commits to return.
2138                  */
2139                 c = pop_commit(&revs->commits);
2140                 if (c)
2141                         c->object.flags |= SHOWN;
2142                 return c;
2143         }
2144
2145         /*
2146          * Now pick up what they want to give us
2147          */
2148         c = get_revision_1(revs);
2149         if (c) {
2150                 while (0 < revs->skip_count) {
2151                         revs->skip_count--;
2152                         c = get_revision_1(revs);
2153                         if (!c)
2154                                 break;
2155                 }
2156         }
2157
2158         /*
2159          * Check the max_count.
2160          */
2161         switch (revs->max_count) {
2162         case -1:
2163                 break;
2164         case 0:
2165                 c = NULL;
2166                 break;
2167         default:
2168                 revs->max_count--;
2169         }
2170
2171         if (c)
2172                 c->object.flags |= SHOWN;
2173
2174         if (!revs->boundary) {
2175                 return c;
2176         }
2177
2178         if (!c) {
2179                 /*
2180                  * get_revision_1() runs out the commits, and
2181                  * we are done computing the boundaries.
2182                  * switch to boundary commits output mode.
2183                  */
2184                 revs->boundary = 2;
2185
2186                 /*
2187                  * Update revs->commits to contain the list of
2188                  * boundary commits.
2189                  */
2190                 create_boundary_commit_list(revs);
2191
2192                 return get_revision_internal(revs);
2193         }
2194
2195         /*
2196          * boundary commits are the commits that are parents of the
2197          * ones we got from get_revision_1() but they themselves are
2198          * not returned from get_revision_1().  Before returning
2199          * 'c', we need to mark its parents that they could be boundaries.
2200          */
2201
2202         for (l = c->parents; l; l = l->next) {
2203                 struct object *p;
2204                 p = &(l->item->object);
2205                 if (p->flags & (CHILD_SHOWN | SHOWN))
2206                         continue;
2207                 p->flags |= CHILD_SHOWN;
2208                 gc_boundary(&revs->boundary_commits);
2209                 add_object_array(p, NULL, &revs->boundary_commits);
2210         }
2211
2212         return c;
2213 }
2214
2215 struct commit *get_revision(struct rev_info *revs)
2216 {
2217         struct commit *c;
2218         struct commit_list *reversed;
2219
2220         if (revs->reverse) {
2221                 reversed = NULL;
2222                 while ((c = get_revision_internal(revs))) {
2223                         commit_list_insert(c, &reversed);
2224                 }
2225                 revs->commits = reversed;
2226                 revs->reverse = 0;
2227                 revs->reverse_output_stage = 1;
2228         }
2229
2230         if (revs->reverse_output_stage)
2231                 return pop_commit(&revs->commits);
2232
2233         c = get_revision_internal(revs);
2234         if (c && revs->graph)
2235                 graph_update(revs->graph, c);
2236         return c;
2237 }