git
10 years agoMerge branch 'da/difftool-mergetool-simplify-reporting-status'
Junio C Hamano [Fri, 12 Dec 2014 22:31:39 +0000 (14:31 -0800)] 
Merge branch 'da/difftool-mergetool-simplify-reporting-status'

Code simplification.

* da/difftool-mergetool-simplify-reporting-status:
  mergetools: stop setting $status in merge_cmd()
  mergetool: simplify conditionals
  difftool--helper: add explicit exit statement
  mergetool--lib: remove use of $status global
  mergetool--lib: remove no-op assignment to $status from setup_user_tool

10 years agoMerge branch 'jk/colors-fix'
Junio C Hamano [Fri, 12 Dec 2014 22:31:38 +0000 (14:31 -0800)] 
Merge branch 'jk/colors-fix'

* jk/colors-fix:
  t4026: test "normal" color
  config: fix parsing of "git config --get-color some.key -1"
  docs: describe ANSI 256-color mode

10 years agoMerge branch 'rt/push-recurse-submodule-usage-string'
Junio C Hamano [Fri, 12 Dec 2014 22:31:38 +0000 (14:31 -0800)] 
Merge branch 'rt/push-recurse-submodule-usage-string'

* rt/push-recurse-submodule-usage-string:
  builtin/push.c: fix description of --recurse-submodules option

10 years agoMerge branch 'jk/rebuild-perl-scripts-with-no-perl-seting-change'
Junio C Hamano [Fri, 12 Dec 2014 22:31:36 +0000 (14:31 -0800)] 
Merge branch 'jk/rebuild-perl-scripts-with-no-perl-seting-change'

The build procedure did not bother fixing perl and python scripts
when NO_PERL and NO_PYTHON build-time configuration changed.

* jk/rebuild-perl-scripts-with-no-perl-seting-change:
  Makefile: have python scripts depend on NO_PYTHON setting
  Makefile: simplify by using SCRIPT_{PERL,SH}_GEN macros
  Makefile: have perl scripts depend on NO_PERL setting

10 years agoMerge branch 'jk/no-perl-tests'
Junio C Hamano [Fri, 12 Dec 2014 22:31:36 +0000 (14:31 -0800)] 
Merge branch 'jk/no-perl-tests'

Some tests that depend on perl lacked PERL prerequisite to protect
them, breaking build with NO_PERL configuration.

* jk/no-perl-tests:
  t960[34]: mark cvsimport tests as requiring perl
  t0090: mark add-interactive test with PERL prerequisite

10 years agoMerge branch 'sv/typofix-apply-error-message'
Junio C Hamano [Fri, 12 Dec 2014 22:31:35 +0000 (14:31 -0800)] 
Merge branch 'sv/typofix-apply-error-message'

* sv/typofix-apply-error-message:
  apply: fix typo in an error message

10 years agoMerge branch 'po/everyday-doc'
Junio C Hamano [Fri, 12 Dec 2014 22:31:34 +0000 (14:31 -0800)] 
Merge branch 'po/everyday-doc'

* po/everyday-doc:
  Documentation: change "gitlink" typo in git-push

10 years agoMerge branch 'mh/config-copy-string-from-git-path'
Junio C Hamano [Fri, 12 Dec 2014 22:31:33 +0000 (14:31 -0800)] 
Merge branch 'mh/config-copy-string-from-git-path'

* mh/config-copy-string-from-git-path:
  cmd_config(): make a copy of path obtained from git_path()

10 years agoMerge branch 'jc/unpack-trees-plug-leak'
Junio C Hamano [Fri, 12 Dec 2014 22:31:33 +0000 (14:31 -0800)] 
Merge branch 'jc/unpack-trees-plug-leak'

* jc/unpack-trees-plug-leak:
  unpack_trees: plug leakage of o->result

10 years agoFirst batch for 2.3 cycle
Junio C Hamano [Fri, 5 Dec 2014 20:03:57 +0000 (12:03 -0800)] 
First batch for 2.3 cycle

Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agoMerge branch 'mh/config-flip-xbit-back-after-checking'
Junio C Hamano [Fri, 5 Dec 2014 19:43:10 +0000 (11:43 -0800)] 
Merge branch 'mh/config-flip-xbit-back-after-checking'

* mh/config-flip-xbit-back-after-checking:
  create_default_files(): don't set u+x bit on $GIT_DIR/config

10 years agoMerge branch 'jk/gitweb-with-newer-cgi-multi-param'
Junio C Hamano [Fri, 5 Dec 2014 19:42:55 +0000 (11:42 -0800)] 
Merge branch 'jk/gitweb-with-newer-cgi-multi-param'

* jk/gitweb-with-newer-cgi-multi-param:
  gitweb: hack around CGI's list-context param() handling

10 years agoMerge branch 'rs/receive-pack-use-labs'
Junio C Hamano [Fri, 5 Dec 2014 19:42:53 +0000 (11:42 -0800)] 
Merge branch 'rs/receive-pack-use-labs'

* rs/receive-pack-use-labs:
  use labs() for variables of type long instead of abs()

10 years agoMerge branch 'rs/maint-config-use-labs'
Junio C Hamano [Fri, 5 Dec 2014 19:42:50 +0000 (11:42 -0800)] 
Merge branch 'rs/maint-config-use-labs'

* rs/maint-config-use-labs:
  use labs() for variables of type long instead of abs()

10 years agoMerge branch 'js/windows-open-eisdir-error'
Junio C Hamano [Fri, 5 Dec 2014 19:42:35 +0000 (11:42 -0800)] 
Merge branch 'js/windows-open-eisdir-error'

* js/windows-open-eisdir-error:
  Windows: correct detection of EISDIR in mingw_open()

10 years agoMerge branch 'jh/empty-notes'
Junio C Hamano [Fri, 5 Dec 2014 19:42:28 +0000 (11:42 -0800)] 
Merge branch 'jh/empty-notes'

A request to store an empty note via "git notes" meant to remove
note from the object but with --allow-empty we will store a (surprise!)
note that is empty.  In the longer run, we might want to deprecate
the somewhat unintuitive "emptying means deletion" behaviour.

* jh/empty-notes:
  t3301: modernize style
  notes: empty notes should be shown by 'git log'
  builtin/notes: add --allow-empty, to allow storing empty notes
  builtin/notes: split create_note() to clarify add vs. remove logic
  builtin/notes: simplify early exit code in add()
  builtin/notes: refactor note file path into struct note_data
  builtin/notes: improve naming
  t3301: verify that 'git notes' removes empty notes by default
  builtin/notes: fix premature failure when trying to add the empty blob

10 years agoMerge branch 'sv/get-builtin'
Junio C Hamano [Fri, 5 Dec 2014 19:42:26 +0000 (11:42 -0800)] 
Merge branch 'sv/get-builtin'

* sv/get-builtin:
  builtin: move builtin retrieval to get_builtin()

10 years agoMerge branch 'jk/checkout-from-tree'
Junio C Hamano [Fri, 5 Dec 2014 19:41:33 +0000 (11:41 -0800)] 
Merge branch 'jk/checkout-from-tree'

"git checkout $treeish $path", when $path in the index and the
working tree already matched what is in $treeish at the $path,
still overwrote the $path unnecessarily.

* jk/checkout-from-tree:
  checkout $tree: do not throw away unchanged index entries

10 years agoMerge branch 'tq/git-ssh-command'
Junio C Hamano [Fri, 5 Dec 2014 19:39:25 +0000 (11:39 -0800)] 
Merge branch 'tq/git-ssh-command'

Allow passing extra set of arguments when ssh is invoked to create
an encrypted & authenticated connection by introducing a new environment
variable GIT_SSH_COMMAND, whose contents is interpreted by shells.

This is not possible with existing GIT_SSH mechanism whose
invocation bypasses shells, which was designed more to match what
other programs with similar variables did, not necessarily to be
more useful.

* tq/git-ssh-command:
  git_connect: set ssh shell command in GIT_SSH_COMMAND

10 years agoMerge branch 'rs/env-array-in-child-process'
Junio C Hamano [Fri, 5 Dec 2014 19:39:21 +0000 (11:39 -0800)] 
Merge branch 'rs/env-array-in-child-process'

* rs/env-array-in-child-process:
  use args member of struct child_process

10 years agoMerge branch 'maint' of git://github.com/git-l10n/git-po into maint
Junio C Hamano [Fri, 5 Dec 2014 19:38:24 +0000 (11:38 -0800)] 
Merge branch 'maint' of git://github.com/git-l10n/git-po into maint

* 'maint' of git://github.com/git-l10n/git-po:
  l10n: de.po: fix typos

10 years agoStart post 2.2 cycle
Junio C Hamano [Fri, 5 Dec 2014 19:38:19 +0000 (11:38 -0800)] 
Start post 2.2 cycle

Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agoMerge branch 'master' of https://github.com/ralfth/git-po-de
Jiang Xin [Sat, 29 Nov 2014 02:44:48 +0000 (10:44 +0800)] 
Merge branch 'master' of https://github.com/ralfth/git-po-de

* 'master' of https://github.com/ralfth/git-po-de:
  l10n: de.po: fix typos

10 years agol10n: de.po: fix typos
Hartmut Henkel [Sun, 23 Nov 2014 15:19:49 +0000 (16:19 +0100)] 
l10n: de.po: fix typos

Signed-off-by: Hartmut Henkel <hartmut_henkel@gmx.de>
Signed-off-by: Ralf Thielow <ralf.thielow@gmail.com>
10 years agoGit 2.2 v2.2.0
Junio C Hamano [Wed, 26 Nov 2014 21:18:34 +0000 (13:18 -0800)] 
Git 2.2

Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agoRelNotes: spelling & grammar tweaks
Marc Branchaud [Fri, 21 Nov 2014 23:10:04 +0000 (18:10 -0500)] 
RelNotes: spelling & grammar tweaks

Signed-off-by: Marc Branchaud <marcnarc@xiplink.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agoGit 2.2.0-rc3 v2.2.0-rc3
Junio C Hamano [Fri, 21 Nov 2014 20:10:56 +0000 (12:10 -0800)] 
Git 2.2.0-rc3

Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agomergetools: stop setting $status in merge_cmd()
David Aguilar [Fri, 21 Nov 2014 09:03:10 +0000 (01:03 -0800)] 
mergetools: stop setting $status in merge_cmd()

No callers rely on $status so there's don't need to set
it during merge_cmd() for diffmerge, emerge, and kdiff3.

Signed-off-by: David Aguilar <davvid@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agomergetool: simplify conditionals
David Aguilar [Fri, 21 Nov 2014 01:20:29 +0000 (17:20 -0800)] 
mergetool: simplify conditionals

Combine the $last_status checks into a single conditional.
Replace $last_status and $rollup_status with a single variable.

Signed-off-by: David Aguilar <davvid@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agodifftool--helper: add explicit exit statement
David Aguilar [Fri, 21 Nov 2014 01:20:28 +0000 (17:20 -0800)] 
difftool--helper: add explicit exit statement

git-difftool--helper returns a zero exit status unless
--trust-exit-code is in effect.  Add an explicit exit statement
to make this clearer.

Signed-off-by: David Aguilar <davvid@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agomergetool--lib: remove use of $status global
David Aguilar [Fri, 21 Nov 2014 01:20:27 +0000 (17:20 -0800)] 
mergetool--lib: remove use of $status global

Remove return statements and rework check_unchanged() so that the exit
status from the last evaluated expression bubbles up to the callers.

Signed-off-by: David Aguilar <davvid@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agomergetool--lib: remove no-op assignment to $status from setup_user_tool
Junio C Hamano [Fri, 21 Nov 2014 19:17:57 +0000 (11:17 -0800)] 
mergetool--lib: remove no-op assignment to $status from setup_user_tool

Even though setup_user_tool assigns the exit status from "eval
$merge_tool_cmd" to $status, the variable is overwritten by the
function it calls next, check_unchanged, without ever getting looked
at by anybody.  And "return $status" at the end of this function
returns the value check_unchanged assigned to it (which is the same
as the value the function returns).  Which makes the assignment a
no-op.

Remove it.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agot4026: test "normal" color
Jeff King [Thu, 20 Nov 2014 15:16:09 +0000 (10:16 -0500)] 
t4026: test "normal" color

If the user specifiers "normal" for a foreground color, this
should be a noop (while this may sound useless, it is the
only way to specify an unchanged foreground color followed
by a specific background color).

We also check that color "-1" does the same thing. This is
not documented, but has worked forever, so let's make sure
we keep supporting it.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agoconfig: fix parsing of "git config --get-color some.key -1"
Jeff King [Thu, 20 Nov 2014 15:15:51 +0000 (10:15 -0500)] 
config: fix parsing of "git config --get-color some.key -1"

Most of git-config's command line options use OPT_BIT to
choose an action, and then parse the non-option arguments
in a context-dependent way. However, --get-color and
--get-colorbool are unlike the rest of the options, in that
they are OPT_STRING, taking the option name as a parameter.

This generally works, because we then use the presence of
those strings to set an action bit anyway. But it does mean
that the option-parser will continue looking for options
even after the key (because it is not a non-option; it is an
argument to an option). And running:

  git config --get-color some.key -1

(to use "-1" as the default color spec) will barf, claiming
that "-1" is not an option. Instead, we should treat
--get-color and --get-colorbool as action bits, just like
--add, --get, and all the other actions, and then check that
the non-option arguments we got are sane. This fixes the
weirdness above, and makes those two options like all the
others.

This "fixes" a test in t4026, which checked that feeding
"-2" as a color should fail (it does fail, but prior to this
patch, because parseopt barfed, not because we actually ever
tried to parse the color).

This also catches other errors, like:

  git config --get-color some.key black blue

which previously silently ignored "blue" (and now will
complain that you gave too many arguments).

There are some possible regressions, though. We now disallow
these, which currently do what you would expect:

  # specifying other options after the action
  git config --get-color some.key --file whatever

  # using long-arg syntax
  git config --get-color=some.key

However, we have never advertised these in the
documentation, and in fact they did not work in some older
versions of git. The behavior was apparently switched as an
accidental side effect of d64ec16 (git config: reorganize to
use parseopt, 2009-02-21).

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agodocs: describe ANSI 256-color mode
Jeff King [Thu, 20 Nov 2014 15:15:31 +0000 (10:15 -0500)] 
docs: describe ANSI 256-color mode

Our color specifications have supported the 256-color ANSI
extension for years, but we never documented it.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agol10n: remove a superfluous translation for push.c
Jiang Xin [Thu, 20 Nov 2014 08:12:34 +0000 (16:12 +0800)] 
l10n: remove a superfluous translation for push.c

Ralf reported that '--recurse-submodules' option in push.c should not be
translated [1].  Before his commit is merged, remove superfluous
translations for push.c.

[1] http://www.spinics.net/lists/git/msg241964.html

Signed-off-by: Jiang Xin <worldhello.net@gmail.com>
10 years agol10n: de.po: translate 2 messages
Ralf Thielow [Thu, 20 Nov 2014 06:15:15 +0000 (07:15 +0100)] 
l10n: de.po: translate 2 messages

Signed-off-by: Ralf Thielow <ralf.thielow@gmail.com>
10 years agol10n: de.po: translate 2 new messages
Ralf Thielow [Tue, 18 Nov 2014 18:06:51 +0000 (19:06 +0100)] 
l10n: de.po: translate 2 new messages

Signed-off-by: Phillip Sz <phillip.szelat@gmail.com>
Signed-off-by: Ralf Thielow <ralf.thielow@gmail.com>
10 years agol10n: batch updates for one trivial change
Jiang Xin [Thu, 20 Nov 2014 02:53:48 +0000 (10:53 +0800)] 
l10n: batch updates for one trivial change

In order to catch up with the release of Git 2.2.0 final, make a batch
l10n update for the new l10n change brought by commit d52adf1 (trailer:
display a trailer without its trailing newline).

Signed-off-by: Jiang Xin <worldhello.net@gmail.com>
10 years agol10n: git.pot: v2.2.0 round 2 (1 updated)
Jiang Xin [Thu, 20 Nov 2014 02:03:10 +0000 (10:03 +0800)] 
l10n: git.pot: v2.2.0 round 2 (1 updated)

Generate po/git.pot from v2.2.0-rc2-23-gca0107e for git v2.2.0 l10n
round 2.

Signed-off-by: Jiang Xin <worldhello.net@gmail.com>
10 years agoMerge branch 'sv/submitting-final-patch'
Junio C Hamano [Wed, 19 Nov 2014 21:48:01 +0000 (13:48 -0800)] 
Merge branch 'sv/submitting-final-patch'

* sv/submitting-final-patch:
  SubmittingPatches: final submission is To: maintainer and CC: list

10 years agoMerge branch 'sn/tutorial-status-output-example'
Junio C Hamano [Wed, 19 Nov 2014 21:47:59 +0000 (13:47 -0800)] 
Merge branch 'sn/tutorial-status-output-example'

* sn/tutorial-status-output-example:
  gittutorial: fix output of 'git status'

10 years agoMerge branch 'mh/doc-remote-helper-xref'
Junio C Hamano [Wed, 19 Nov 2014 21:47:55 +0000 (13:47 -0800)] 
Merge branch 'mh/doc-remote-helper-xref'

* mh/doc-remote-helper-xref:
  doc: add some crossrefs between manual pages

10 years agoMerge branch 'tb/no-relative-file-url'
Junio C Hamano [Wed, 19 Nov 2014 21:47:53 +0000 (13:47 -0800)] 
Merge branch 'tb/no-relative-file-url'

* tb/no-relative-file-url:
  t5705: the file:// URL should be absolute

10 years agoMerge branch 'cc/interpret-trailers'
Junio C Hamano [Wed, 19 Nov 2014 21:47:49 +0000 (13:47 -0800)] 
Merge branch 'cc/interpret-trailers'

Small fixes to a new experimental command already in 'master'.

* cc/interpret-trailers:
  trailer: display a trailer without its trailing newline
  trailer: ignore comment lines inside the trailers

10 years agogitweb: hack around CGI's list-context param() handling
Jeff King [Tue, 18 Nov 2014 17:10:22 +0000 (12:10 -0500)] 
gitweb: hack around CGI's list-context param() handling

As of CGI.pm's 4.08 release, the behavior to call
CGI::param() in a list context is deprecated (because it can
be potentially unsafe if called inside a hash constructor).
This causes gitweb to issue a warning for some of our code,
which in turn causes the tests to fail.

Our use is in fact _not_ one of the dangerous cases, as we
are intentionally using a list context. The recommended
route by 4.08 is to use the new CGI::multi_param() call to
make it explicit that we know what we are doing.
However, that function is only available in 4.08, which is
about a month old; we cannot rely on having it.

One option would be to set $CGI::LIST_CONTEXT_WARN globally,
which turns off the warning. However, that would eliminate
the protection these newer releases are trying to provide.
We want to annotate each site as OK using the new function.

So instead, let's check whether CGI provides the
multi_param() function, and if not, provide an
implementation that just wraps param(). That will work on
both old and new versions of CGI. Sadly, we cannot just
check defined(\&CGI::multi_param), because CGI uses the
autoload feature, which claims that all functions are
defined. Instead, we just do a version check.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agobuiltin/push.c: fix description of --recurse-submodules option
Ralf Thielow [Tue, 18 Nov 2014 17:57:46 +0000 (18:57 +0100)] 
builtin/push.c: fix description of --recurse-submodules option

The description of the option for argument "recurse-submodules"
is marked for translation even if it expects the untranslated
string and it's missing the option "on-demand" which was introduced
in eb21c73 (2014-03-29, push: teach --recurse-submodules the on-demand
option). Fix this by unmark the string for translation and add the
missing option.

Signed-off-by: Ralf Thielow <ralf.thielow@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agoMakefile: have python scripts depend on NO_PYTHON setting
Jonathan Nieder [Tue, 18 Nov 2014 18:43:47 +0000 (10:43 -0800)] 
Makefile: have python scripts depend on NO_PYTHON setting

Like the perl scripts, python scripts need a dependency to ensure they
are rebuilt when switching between the "dummy" versions that run
without Python and the real thing.

Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agoMakefile: simplify by using SCRIPT_{PERL,SH}_GEN macros
Jonathan Nieder [Tue, 18 Nov 2014 18:38:38 +0000 (10:38 -0800)] 
Makefile: simplify by using SCRIPT_{PERL,SH}_GEN macros

SCRIPT_PERL_GEN is defined as $(patsubst %.perl,%,$(SCRIPT_PERL))
for use in targets like build-perl-script used by makefiles in
subdirectories that override SCRIPT_PERL (see v1.8.2-rc0~17^2,
"git-remote-mediawiki: use toplevel's Makefile", 2013-02-08).

The same expression is used in the rules that actually write the
generated perl scripts, and since these rules were introduced before
SCRIPT_PERL_GEN, they use the longhand instead of that macro.  Use the
macro to make reading easier.

Likewise for SCRIPT_SH_GEN.  The Python rules already got the same
simplification in v1.8.4-rc0~162^2~8 (2013-05-24).

Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Reviewed-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agoMerge git://github.com/git-l10n/git-po
Junio C Hamano [Tue, 18 Nov 2014 18:27:46 +0000 (10:27 -0800)] 
Merge git://github.com/git-l10n/git-po

* 'master' of git://github.com/git-l10n/git-po:
  l10n: Update Catalan translation

10 years agoMerge branch 'jc/doc-commit-only'
Junio C Hamano [Tue, 18 Nov 2014 18:19:38 +0000 (10:19 -0800)] 
Merge branch 'jc/doc-commit-only'

* jc/doc-commit-only:
  Documentation/git-commit: clarify that --only/--include records the working tree contents

10 years agoMerge branch 'ta/tutorial-modernize'
Junio C Hamano [Tue, 18 Nov 2014 18:18:28 +0000 (10:18 -0800)] 
Merge branch 'ta/tutorial-modernize'

* ta/tutorial-modernize:
  gittutorial.txt: remove reference to ancient Git version

10 years agoMerge branch 'da/difftool'
Junio C Hamano [Tue, 18 Nov 2014 18:16:54 +0000 (10:16 -0800)] 
Merge branch 'da/difftool'

Fix-up to a new feature in 'master'.

* da/difftool:
  difftool: honor --trust-exit-code for builtin tools

10 years agot960[34]: mark cvsimport tests as requiring perl
Jeff King [Tue, 18 Nov 2014 17:29:32 +0000 (12:29 -0500)] 
t960[34]: mark cvsimport tests as requiring perl

Git-cvsimport is written in perl, which understandably
causes the tests to fail if you build with NO_PERL (which
will avoid building cvsimport at all). The earlier cvsimport
tests in t9600-t9602 are all marked with a PERL
prerequisite, but these ones are not.

The one in t9603 was likely not noticed because it is an
expected failure anyway.

The ones in t9604 have been around for a long time, but it
is likely that the combination of NO_PERL and having cvsps
installed is rare enough that nobody noticed.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agot0090: mark add-interactive test with PERL prerequisite
Jeff King [Tue, 18 Nov 2014 17:22:31 +0000 (12:22 -0500)] 
t0090: mark add-interactive test with PERL prerequisite

The add-interactive system is built in perl. If you build
with NO_PERL, running "git commit --interactive" will exit
with an error and the test will fail.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agoMakefile: have perl scripts depend on NO_PERL setting
Jeff King [Tue, 18 Nov 2014 17:43:09 +0000 (12:43 -0500)] 
Makefile: have perl scripts depend on NO_PERL setting

If NO_PERL is not set, our perl scripts are built as
usual. If it is set, then we build "dummy" versions that
tell you git was built without perl support and exit
gracefully.

However, if you switch to NO_PERL in a directory with
existing build artifacts, we do not notice that the files
need rebuilt. We see only that they are newer than the
"unimplemented.sh" wrapper and assume they are done. So
doing:

  make
  make NO_PERL=Nope

would result in a git-add--interactive script that uses perl
(and running the test suite would make use of it).

Instead, we should trigger a rebuild of the perl scripts
anytime NO_PERL changes.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agocreate_default_files(): don't set u+x bit on $GIT_DIR/config
Michael Haggerty [Tue, 18 Nov 2014 13:50:24 +0000 (14:50 +0100)] 
create_default_files(): don't set u+x bit on $GIT_DIR/config

Since time immemorial, the test of whether to set "core.filemode"
has been done by trying to toggle the u+x bit on $GIT_DIR/config,
which we know always exists, and then testing whether the change
"took".  I find it somewhat odd to use the config file for this
test, but whatever.

The test code didn't set the u+x bit back to its original state
itself, instead relying on the subsequent call to git_config_set()
to re-write the config file with correct permissions.

But ever since

    daa22c6f8d config: preserve config file permissions on edits (2014-05-06)

git_config_set() copies the permissions from the old config file to
the new one.  This is a good change in and of itself, but it
invalidates the create_default_files()'s assumption, causing "git
init" to leave the executable bit set on $GIT_DIR/config.

Reset the permissions on $GIT_DIR/config when we are done with the
test in create_default_files().

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agol10n: Update Catalan translation
Alex Henrie [Tue, 18 Nov 2014 03:22:48 +0000 (20:22 -0700)] 
l10n: Update Catalan translation

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
10 years agounpack_trees: plug leakage of o->result
Junio C Hamano [Mon, 17 Nov 2014 20:12:41 +0000 (12:12 -0800)] 
unpack_trees: plug leakage of o->result

Most of the time the caller specifies to which destination variable
the resulting index_state should be assigned by passing a non-NULL
pointer in o->dst_index to receive that state, but for a caller that
gives a NULL o->dst_index, the resulting index simply leaked.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agoMerge branch 'master' of git://github.com/git-l10n/git-po
Junio C Hamano [Mon, 17 Nov 2014 17:28:23 +0000 (09:28 -0800)] 
Merge branch 'master' of git://github.com/git-l10n/git-po

* 'master' of git://github.com/git-l10n/git-po:
  l10n: de.po: translate 62 new messages
  l10n: de.po: Fixup one translation
  l10n: de.po: use imperative form for command options

10 years agoDocumentation: change "gitlink" typo in git-push
brian m. carlson [Mon, 17 Nov 2014 00:49:00 +0000 (00:49 +0000)] 
Documentation: change "gitlink" typo in git-push

The git-push manual page used "gitlink" in one place instead of
"linkgit".  Fix this so the link renders correctly.

Noticed-by: Dan Allen <dan.j.allen@gmail.com>
Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agoapply: fix typo in an error message
Slavomir Vlcek [Mon, 17 Nov 2014 00:38:26 +0000 (01:38 +0100)] 
apply: fix typo in an error message

s/submoule/submodule

Signed-off-by: Slavomir Vlcek <svlc@inventati.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agocmd_config(): make a copy of path obtained from git_path()
Michael Haggerty [Sun, 16 Nov 2014 07:37:44 +0000 (08:37 +0100)] 
cmd_config(): make a copy of path obtained from git_path()

The strings returned by git_path() are recycled after a while.  Make
a copy of the config filename rather than holding onto the return
value from git_path().

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agouse labs() for variables of type long instead of abs()
René Scharfe [Sat, 15 Nov 2014 13:27:21 +0000 (14:27 +0100)] 
use labs() for variables of type long instead of abs()

Using abs() on long values can cause truncation, so use labs() instead.
Reported by Clang 3.5 (-Wabsolute-value, enabled by -Wall).

Signed-off-by: Rene Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agouse labs() for variables of type long instead of abs()
René Scharfe [Sat, 15 Nov 2014 13:27:21 +0000 (14:27 +0100)] 
use labs() for variables of type long instead of abs()

Using abs() on long values can cause truncation, so use labs() instead.
Reported by Clang 3.5 (-Wabsolute-value, enabled by -Wall).

Signed-off-by: Rene Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agoWindows: correct detection of EISDIR in mingw_open()
Johannes Sixt [Sun, 16 Nov 2014 21:06:26 +0000 (22:06 +0100)] 
Windows: correct detection of EISDIR in mingw_open()

According to the Linux open(2) man page, open() must return EISDIR
if a directory was attempted to be opened for writing. Our emulation
in mingw_open() does not get this right: it checks only for O_CREAT.

Fix it to check for a write request.

This fixes a failure in reflog handling, which opens files with
O_APPEND|O_WRONLY, but without O_CREAT, and expects EISDIR when the
named file happens to be a directory.

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agol10n: de.po: translate 62 new messages
Ralf Thielow [Thu, 30 Oct 2014 08:00:47 +0000 (09:00 +0100)] 
l10n: de.po: translate 62 new messages

Translate 62 new messages came from git.pot update in 16742b0
(l10n: git.pot: proposed updates for v2.2.0 (+62)).

Signed-off-by: Ralf Thielow <ralf.thielow@gmail.com>
10 years agol10n: de.po: Fixup one translation
Stefan Beller [Tue, 23 Sep 2014 12:54:46 +0000 (14:54 +0200)] 
l10n: de.po: Fixup one translation

English grammar with German words doesn't make it a German translation. ;)

Signed-off-by: Stefan Beller <stefanbeller@gmail.com>
Signed-off-by: Ralf Thielow <ralf.thielow@gmail.com>
10 years agodifftool: honor --trust-exit-code for builtin tools
David Aguilar [Fri, 14 Nov 2014 21:33:55 +0000 (13:33 -0800)] 
difftool: honor --trust-exit-code for builtin tools

run_merge_tool() was not setting $status, which prevented the
exit code for builtin tools from being forwarded to the caller.

Capture the exit status and add a test to guarantee the behavior.

Reported-by: Adria Farres <14farresa@gmail.com>
Signed-off-by: David Aguilar <davvid@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agot3301: modernize style
Johan Herland [Wed, 12 Nov 2014 00:40:16 +0000 (01:40 +0100)] 
t3301: modernize style

Make this test script appear somewhat less old-fashioned:

 - Use test helper functions:
    - write_script
    - test_commit
    - test_write_lines
    - test_line_count
    - test_config
    - test_unconfig
    - test_path_is_missing

 - Remove whitespace between redirection operators and their targets.

 - Move preparation of "expect" files into tests.

 - Rename "output" files to "actual".

 - More consistent quoting, especially around commands that might
   expand to nothing.

 - More visibility of important whitespace with ${indent}.

 - Combine pairs of tests that unnecessarily split setup and verification.

Improved-by: Eric Sunshine <sunshine@sunshineco.com>
Improved-by: Junio C Hamano <gitster@pobox.com>
Improved-by: Michael Blume <blume.mike@gmail.com>
Improved-by: Jeff King <peff@peff.net>
Signed-off-by: Johan Herland <johan@herland.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agoGit 2.2.0-rc2 v2.2.0-rc2
Junio C Hamano [Fri, 14 Nov 2014 21:31:15 +0000 (13:31 -0800)] 
Git 2.2.0-rc2

Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agol10n: de.po: use imperative form for command options
Ralf Thielow [Fri, 19 Sep 2014 16:38:13 +0000 (18:38 +0200)] 
l10n: de.po: use imperative form for command options

Signed-off-by: Ralf Thielow <ralf.thielow@gmail.com>
10 years agocheckout $tree: do not throw away unchanged index entries
Jeff King [Thu, 13 Nov 2014 18:30:34 +0000 (13:30 -0500)] 
checkout $tree: do not throw away unchanged index entries

When we "git checkout $tree", we pull paths from $tree into
the index, and then check the resulting entries out to the
worktree. Our method for the first step is rather
heavy-handed, though; it clobbers the entire existing index
entry, even if the content is the same. This means we lose
our stat information, leading checkout_entry to later
rewrite the entire file with identical content.

Instead, let's see if we have the identical entry already in
the index, in which case we leave it in place. That lets
checkout_entry do the right thing. Our tests cover two
interesting cases:

  1. We make sure that a file which has no changes is not
     rewritten.

  2. We make sure that we do update a file that is unchanged
     in the index (versus $tree), but has working tree
     changes. We keep the old index entry, and
     checkout_entry is able to realize that our stat
     information is out of date.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agogittutorial: fix output of 'git status'
Stefan Naewe [Thu, 13 Nov 2014 10:40:07 +0000 (10:40 +0000)] 
gittutorial: fix output of 'git status'

'git status' doesn't output leading '#'s these days.

Signed-off-by: Stefan Naewe <stefan.naewe@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agot5705: the file:// URL should be absolute
Torsten Bögershausen [Thu, 13 Nov 2014 07:36:07 +0000 (08:36 +0100)] 
t5705: the file:// URL should be absolute

The test misused a URL "file://." to mean "relative to here",
which we no longer accept.

In a file:// URL, typically there is no host, and RFC1738 says that
file:///<path> should be used.

Update t5705 to use a working URL.

Reported-by: Michael Blume <blume.mike@gmail.com>
Signed-off-by: Torsten Bögershausen <tboegi@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agobuiltin: move builtin retrieval to get_builtin()
Slavomir Vlcek [Wed, 12 Nov 2014 13:10:22 +0000 (14:10 +0100)] 
builtin: move builtin retrieval to get_builtin()

There was a redundant code for a builtin command retrieval in
'handle_builtin()' and 'is_builtin()'.

Introduce a new function 'get_builtin()' and using it from
both of these places to reduce the redundancy.

Signed-off-by: Slavomir Vlcek <svlc@inventati.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agoSubmittingPatches: final submission is To: maintainer and CC: list
Slavomir Vlcek [Wed, 12 Nov 2014 23:18:39 +0000 (00:18 +0100)] 
SubmittingPatches: final submission is To: maintainer and CC: list

In an earlier part there is:

  "re-send it with "To:" set to the maintainer [*1*] and "cc:" the list [*2*]"

for the final submission, but later we see

  "Send it to the list and cc the maintainer."

Fix the later one to match the previous.

Signed-off-by: Slavomir Vlcek <svlc@inventati.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agoUpdate draft release notes to 2.2
Junio C Hamano [Wed, 12 Nov 2014 20:12:50 +0000 (12:12 -0800)] 
Update draft release notes to 2.2

Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agoSync with 'maint'
Junio C Hamano [Wed, 12 Nov 2014 20:13:25 +0000 (12:13 -0800)] 
Sync with 'maint'

10 years agoMerge branch 'nd/gitignore-trailing-whitespace' into maint
Junio C Hamano [Wed, 12 Nov 2014 20:13:11 +0000 (12:13 -0800)] 
Merge branch 'nd/gitignore-trailing-whitespace' into maint

* nd/gitignore-trailing-whitespace:
  gitignore.txt: fix spelling of "backslash"

10 years agoMerge branch 'jk/fetch-reflog-df-conflict'
Junio C Hamano [Wed, 12 Nov 2014 19:59:58 +0000 (11:59 -0800)] 
Merge branch 'jk/fetch-reflog-df-conflict'

Fix-up a test for portability.

* jk/fetch-reflog-df-conflict:
  t1410: fix breakage on case-insensitive filesystems

10 years agonotes: empty notes should be shown by 'git log'
Johan Herland [Wed, 12 Nov 2014 00:40:15 +0000 (01:40 +0100)] 
notes: empty notes should be shown by 'git log'

If the user has gone through the trouble of explicitly adding an empty
note, then "git log" should not silently skip it (as if it didn't exist).

Signed-off-by: Johan Herland <johan@herland.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agobuiltin/notes: add --allow-empty, to allow storing empty notes
Johan Herland [Wed, 12 Nov 2014 00:40:14 +0000 (01:40 +0100)] 
builtin/notes: add --allow-empty, to allow storing empty notes

Although the "git notes" man page advertises that we support binary-safe
notes addition (using the -C option), we currently do not support adding
the empty note (i.e. using the empty blob to annotate an object). Instead,
an empty note is always treated as an intent to remove the note
altogether.

Introduce the --allow-empty option to the add/append/edit subcommands,
to explicitly allow an empty note to be stored into the notes tree.

Also update the documentation, and add test cases for the new option.

Reported-by: James H. Fisher <jhf@trifork.com>
Improved-by: Kyle J. McKay <mackyle@gmail.com>
Improved-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Johan Herland <johan@herland.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agobuiltin/notes: split create_note() to clarify add vs. remove logic
Johan Herland [Wed, 12 Nov 2014 00:40:13 +0000 (01:40 +0100)] 
builtin/notes: split create_note() to clarify add vs. remove logic

create_note() has a non-trivial interface, and comprises three loosely
related parts:

 1. launching the editor with the note contents, if needed
 2. appending to an existing note, if append_only was given
 3. adding or removing the resulting note, based on whether it's non-empty

Split it along those lines to make the logic clearer: The first part
goes into a new function - prepare_note_data(), with a simpler interface.
The second part is moved into append_edit(), which is the only user of
this code. Finally, the add vs. remove decision is moved into the callers
(add() and append_edit()), keeping the logic for writing the actual note
object in a separate function: write_note_data().

Suggested-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Johan Herland <johan@herland.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agobuiltin/notes: simplify early exit code in add()
Johan Herland [Wed, 12 Nov 2014 00:40:12 +0000 (01:40 +0100)] 
builtin/notes: simplify early exit code in add()

Remove the need for 'retval' and the unnecessary goto. Also reorganize
to only call free_note_data() is actually needed.

Improved-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Johan Herland <johan@herland.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agodoc: add some crossrefs between manual pages
Max Horn [Tue, 11 Nov 2014 20:17:07 +0000 (21:17 +0100)] 
doc: add some crossrefs between manual pages

In particular, git-fast-import and -export link to each
other, and gitremote-helpers links to existing remote
helpers, and vice versa. Also link to fast-import from the
remote helper spec, as this is relevant for remote helpers
using the fast-import format.

Signed-off-by: Max Horn <max@quendi.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agogittutorial.txt: remove reference to ancient Git version
Thomas Ackermann [Tue, 11 Nov 2014 19:13:36 +0000 (20:13 +0100)] 
gittutorial.txt: remove reference to ancient Git version

Signed-off-by: Thomas Ackermann <th.acker@arcor.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agoSync with maint
Junio C Hamano [Tue, 11 Nov 2014 20:45:48 +0000 (12:45 -0800)] 
Sync with maint

* maint:

10 years agoMerge branch 'rs/clean-menu-item-defn' into maint
Junio C Hamano [Tue, 11 Nov 2014 18:20:13 +0000 (10:20 -0800)] 
Merge branch 'rs/clean-menu-item-defn' into maint

* rs/clean-menu-item-defn:
  clean: use f(void) instead of f() to declare a pointer to a function without arguments

10 years agorun-command: use void to declare that functions take no parameters
René Scharfe [Mon, 10 Nov 2014 21:17:00 +0000 (22:17 +0100)] 
run-command: use void to declare that functions take no parameters

Explicitly declare that git_atexit_dispatch() and git_atexit_clear()
take no parameters instead of leaving their parameter list empty and
thus unspecified.

Signed-off-by: Rene Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agobuiltin/notes: refactor note file path into struct note_data
Johan Herland [Sun, 9 Nov 2014 12:30:50 +0000 (13:30 +0100)] 
builtin/notes: refactor note file path into struct note_data

Move the 'path' variable from create_note() and into the
note_data struct. Unify cleanup of note_data objects with
a free_note_data() function.

This might not make too much sense on its own, but it makes the
future refactoring of create_note() considerably cleaner.

Signed-off-by: Johan Herland <johan@herland.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agobuiltin/notes: improve naming
Johan Herland [Sun, 9 Nov 2014 12:30:49 +0000 (13:30 +0100)] 
builtin/notes: improve naming

In preparation for some needed refactoring, rename struct msg_arg to
struct note_data, and rename its instances from "msg" to "d" (also
removing some unnecessary parentheses). The 'msg_arg' name was
inherited from tag.c, but is not really a good name for the contents
of a note.

Also rename write_note_data() to copy_obj_to_fd(), which more aptly
describes what it actually does: Copying the contents of a git object
(given by its SHA1) into a given file descriptor.

Signed-off-by: Johan Herland <johan@herland.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agot3301: verify that 'git notes' removes empty notes by default
Johan Herland [Sun, 9 Nov 2014 12:30:48 +0000 (13:30 +0100)] 
t3301: verify that 'git notes' removes empty notes by default

Add test cases documenting the current behavior when trying to
add/append/edit empty notes. This is in preparation for adding
--allow-empty; to allow empty notes to be stored.

Improved-by: Eric Sunshine <sunshine@sunshineco.com>
Improved-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Johan Herland <johan@herland.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agobuiltin/notes: fix premature failure when trying to add the empty blob
Johan Herland [Sun, 9 Nov 2014 12:30:47 +0000 (13:30 +0100)] 
builtin/notes: fix premature failure when trying to add the empty blob

This fixes a small buglet when trying to explicitly add the empty blob
as a note object using the -c or -C option to git notes add/append.
Instead of failing with a nonsensical error message indicating that the
empty blob does not exist, we should rather behave as if an empty notes
message was given (e.g. using -m "" or -F /dev/null).

The next patch contains a test that verifies the fixed behavior.

Found-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Johan Herland <johan@herland.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agoMerge branch 'master' of git://github.com/git-l10n/git-po
Junio C Hamano [Mon, 10 Nov 2014 19:59:30 +0000 (11:59 -0800)] 
Merge branch 'master' of git://github.com/git-l10n/git-po

* 'master' of git://github.com/git-l10n/git-po:
  l10n: Updated Bulgarian translation of git (2296t,0f,0u)
  l10n: zh_CN: translations for git v2.2.0-rc0
  l10n: sv.po: Update Swedish translation (2296t0f0u)
  l10n: fr.po (2296t) update for version 2.2.0
  l10n: vi.po: Update new message strings
  l10n: git.pot: v2.2.0 round 1 (62 new, 23 removed)

10 years agoSync with maint
Junio C Hamano [Mon, 10 Nov 2014 19:26:18 +0000 (11:26 -0800)] 
Sync with maint

* maint:
  Documentation/config.txt: fix minor typo
  config.txt: fix typo

10 years agoMerge branch 'js/diff-highlight-avoid-sigpipe'
Junio C Hamano [Mon, 10 Nov 2014 19:26:09 +0000 (11:26 -0800)] 
Merge branch 'js/diff-highlight-avoid-sigpipe'

* js/diff-highlight-avoid-sigpipe:
  diff-highlight: exit when a pipe is broken

10 years agoDocumentation/config.txt: fix minor typo
Thomas Quinot [Sat, 8 Nov 2014 10:45:39 +0000 (11:45 +0100)] 
Documentation/config.txt: fix minor typo

Add a missing article at the beginning of a sentence, and rephrase
slightly.

Signed-off-by: Thomas Quinot <thomas@quinot.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agoconfig.txt: fix typo
Nicolas Dermine [Sun, 9 Nov 2014 16:19:33 +0000 (17:19 +0100)] 
config.txt: fix typo

Signed-off-by: Nicolas Dermine <nicolas.dermine@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
10 years agouse args member of struct child_process
René Scharfe [Sun, 9 Nov 2014 13:49:54 +0000 (14:49 +0100)] 
use args member of struct child_process

Convert users of struct child_process to using the managed argv_array
args instead of providing their own.  This shortens the code a bit and
ensures that the allocated memory is released automatically after use.

Suggested-by: Jeff King <peff@peff.net>
Signed-off-by: Rene Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>