1 Known issues with the [[plugins/comments]] plugin:
3 * There is some common code cargo-culted from other plugins (notably inline and editpage) which
4 should probably be shared
6 > Actually, there's less of this now than there used to be - a lot of simple
7 > things that were shared have become unshareable as they became more
10 * Previews always say "unknown IP address"
12 * Add `COMMENTOPENID`: the authenticated/verified user name, if and only if it was an OpenID
14 > Done in my comments git branch --[[smcv]]
16 * The default template should have a (?) icon next to unauthenticated users (with the IP address
17 as title) and an OpenID icon next to OpenIDs
19 > Done in my comments git branch, at least as a mockup (using the (?),
20 > {x} and {*} smileys for anonymous, OpenID and login respectively).
23 * Should the comments be visually set off more from the page above?
24 Rather than just a horizontal rule, I'm thinking put the comments
25 in a box like is used for inlined pages.
27 > I did put them in a box in the CSS... I agree the default template
28 > could do with visual improvement though. --[[smcv]]
30 * Instead of just a link to add a comment, it could have a form to enter
31 the title, similar to the form for adding a new blog post.
33 > I'm not sure this is so useful? On Livejournal titles are allowed on
34 > comments, but very rarely used (and indeed usually not very useful);
35 > it's hard enough to get some people to title their blog posts :-)
38 * If a spammer posts a comment, it is either impossible or hard to clean
39 up via the web. Would be nice to have some kind of link on the comment
40 that allows trusted users to remove it (using the remove plugin of
43 > Won't the remove plugin refuse to remove internal pages? This would be
44 > a good feature to have, though. --[[smcv]]
46 * One can use inline to set up a feed of all comments posted to any page.
47 Using template=comments_display they are displayed right. Only problem
48 is there is no indication in that template of what page each comment in the
49 feed is a comment on. So, if a comment is inlined into a different page,
50 I think it should show a link back to the page commented on.
51 (BTW, the rss feed in this situation seems ok; there the link element
52 points back to the parent page.
54 * It would be useful to have a pagespec that always matches all comments on
55 pages matching a glob. Something like `comment(blog/*)`.
56 Perhaps postcomment could also be folded into this? Then the pagespec
57 would match both existing comments, as well as new comments that are
60 > Please see [[plugins/comment/discussion]]. If I've convinced you that
61 > internal pages are the way forward, then sure, we can do that, because
62 > people who can comment still won't be able to edit others' comments
63 > (one of my goals is that commenters can't put words into each other's
66 > On the other hand, if you still want me to switch this plugin to "real"
67 > pages, or if internal pages might become editable in future, then
68 > configuring lockedit/anonok so a user X can add comments to blog pages
69 > would also let X edit/delete comments on blog pages (including those
70 > written by others) in arbitrary ways, which doesn't seem good. --[[smcv]]
72 * One of Joey's commit messages says "Not ideal, it would be nicer to jump to
73 the actual comment posted, but no anchor is available". In fact there is
74 an anchor - the `\[[_comment]]` preprocessing wraps the comment in a <div>
75 with id="comment_123" or something. I'll fix this, unless Joey gets there
78 * Now that inline has some comments-specific functionality anyway, it would
79 be good to output <link rel="comments"> in Atom and the equivalent in RSS.
projects / ikiwiki / blob