USB: cxacru: Use appropriate logging for errors
[linux-2.6] / drivers / usb / atm / cxacru.c
1 /******************************************************************************
2  *  cxacru.c  -  driver for USB ADSL modems based on
3  *               Conexant AccessRunner chipset
4  *
5  *  Copyright (C) 2004 David Woodhouse, Duncan Sands, Roman Kagan
6  *  Copyright (C) 2005 Duncan Sands, Roman Kagan (rkagan % mail ! ru)
7  *  Copyright (C) 2007 Simon Arlott
8  *
9  *  This program is free software; you can redistribute it and/or modify it
10  *  under the terms of the GNU General Public License as published by the Free
11  *  Software Foundation; either version 2 of the License, or (at your option)
12  *  any later version.
13  *
14  *  This program is distributed in the hope that it will be useful, but WITHOUT
15  *  ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
16  *  FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
17  *  more details.
18  *
19  *  You should have received a copy of the GNU General Public License along with
20  *  this program; if not, write to the Free Software Foundation, Inc., 59
21  *  Temple Place - Suite 330, Boston, MA  02111-1307, USA.
22  *
23  ******************************************************************************/
24
25 /*
26  *  Credit is due for Josep Comas, who created the original patch to speedtch.c
27  *  to support the different padding used by the AccessRunner (now generalized
28  *  into usbatm), and the userspace firmware loading utility.
29  */
30
31 #include <linux/module.h>
32 #include <linux/moduleparam.h>
33 #include <linux/kernel.h>
34 #include <linux/timer.h>
35 #include <linux/errno.h>
36 #include <linux/slab.h>
37 #include <linux/init.h>
38 #include <linux/device.h>
39 #include <linux/firmware.h>
40 #include <linux/mutex.h>
41
42 #include "usbatm.h"
43
44 #define DRIVER_AUTHOR   "Roman Kagan, David Woodhouse, Duncan Sands, Simon Arlott"
45 #define DRIVER_VERSION  "0.3"
46 #define DRIVER_DESC     "Conexant AccessRunner ADSL USB modem driver"
47
48 static const char cxacru_driver_name[] = "cxacru";
49
50 #define CXACRU_EP_CMD           0x01    /* Bulk/interrupt in/out */
51 #define CXACRU_EP_DATA          0x02    /* Bulk in/out */
52
53 #define CMD_PACKET_SIZE         64      /* Should be maxpacket(ep)? */
54
55 /* Addresses */
56 #define PLLFCLK_ADDR    0x00350068
57 #define PLLBCLK_ADDR    0x0035006c
58 #define SDRAMEN_ADDR    0x00350010
59 #define FW_ADDR         0x00801000
60 #define BR_ADDR         0x00180600
61 #define SIG_ADDR        0x00180500
62 #define BR_STACK_ADDR   0x00187f10
63
64 /* Values */
65 #define SDRAM_ENA       0x1
66
67 #define CMD_TIMEOUT     2000    /* msecs */
68 #define POLL_INTERVAL   1       /* secs */
69
70 /* commands for interaction with the modem through the control channel before
71  * firmware is loaded  */
72 enum cxacru_fw_request {
73         FW_CMD_ERR,
74         FW_GET_VER,
75         FW_READ_MEM,
76         FW_WRITE_MEM,
77         FW_RMW_MEM,
78         FW_CHECKSUM_MEM,
79         FW_GOTO_MEM,
80 };
81
82 /* commands for interaction with the modem through the control channel once
83  * firmware is loaded  */
84 enum cxacru_cm_request {
85         CM_REQUEST_UNDEFINED = 0x80,
86         CM_REQUEST_TEST,
87         CM_REQUEST_CHIP_GET_MAC_ADDRESS,
88         CM_REQUEST_CHIP_GET_DP_VERSIONS,
89         CM_REQUEST_CHIP_ADSL_LINE_START,
90         CM_REQUEST_CHIP_ADSL_LINE_STOP,
91         CM_REQUEST_CHIP_ADSL_LINE_GET_STATUS,
92         CM_REQUEST_CHIP_ADSL_LINE_GET_SPEED,
93         CM_REQUEST_CARD_INFO_GET,
94         CM_REQUEST_CARD_DATA_GET,
95         CM_REQUEST_CARD_DATA_SET,
96         CM_REQUEST_COMMAND_HW_IO,
97         CM_REQUEST_INTERFACE_HW_IO,
98         CM_REQUEST_CARD_SERIAL_DATA_PATH_GET,
99         CM_REQUEST_CARD_SERIAL_DATA_PATH_SET,
100         CM_REQUEST_CARD_CONTROLLER_VERSION_GET,
101         CM_REQUEST_CARD_GET_STATUS,
102         CM_REQUEST_CARD_GET_MAC_ADDRESS,
103         CM_REQUEST_CARD_GET_DATA_LINK_STATUS,
104         CM_REQUEST_MAX,
105 };
106
107 /* reply codes to the commands above */
108 enum cxacru_cm_status {
109         CM_STATUS_UNDEFINED,
110         CM_STATUS_SUCCESS,
111         CM_STATUS_ERROR,
112         CM_STATUS_UNSUPPORTED,
113         CM_STATUS_UNIMPLEMENTED,
114         CM_STATUS_PARAMETER_ERROR,
115         CM_STATUS_DBG_LOOPBACK,
116         CM_STATUS_MAX,
117 };
118
119 /* indices into CARD_INFO_GET return array */
120 enum cxacru_info_idx {
121         CXINF_DOWNSTREAM_RATE,
122         CXINF_UPSTREAM_RATE,
123         CXINF_LINK_STATUS,
124         CXINF_LINE_STATUS,
125         CXINF_MAC_ADDRESS_HIGH,
126         CXINF_MAC_ADDRESS_LOW,
127         CXINF_UPSTREAM_SNR_MARGIN,
128         CXINF_DOWNSTREAM_SNR_MARGIN,
129         CXINF_UPSTREAM_ATTENUATION,
130         CXINF_DOWNSTREAM_ATTENUATION,
131         CXINF_TRANSMITTER_POWER,
132         CXINF_UPSTREAM_BITS_PER_FRAME,
133         CXINF_DOWNSTREAM_BITS_PER_FRAME,
134         CXINF_STARTUP_ATTEMPTS,
135         CXINF_UPSTREAM_CRC_ERRORS,
136         CXINF_DOWNSTREAM_CRC_ERRORS,
137         CXINF_UPSTREAM_FEC_ERRORS,
138         CXINF_DOWNSTREAM_FEC_ERRORS,
139         CXINF_UPSTREAM_HEC_ERRORS,
140         CXINF_DOWNSTREAM_HEC_ERRORS,
141         CXINF_LINE_STARTABLE,
142         CXINF_MODULATION,
143         CXINF_ADSL_HEADEND,
144         CXINF_ADSL_HEADEND_ENVIRONMENT,
145         CXINF_CONTROLLER_VERSION,
146         /* dunno what the missing two mean */
147         CXINF_MAX = 0x1c,
148 };
149
150 enum cxacru_poll_state {
151         CXPOLL_STOPPING,
152         CXPOLL_STOPPED,
153         CXPOLL_POLLING,
154         CXPOLL_SHUTDOWN
155 };
156
157 struct cxacru_modem_type {
158         u32 pll_f_clk;
159         u32 pll_b_clk;
160         int boot_rom_patch;
161 };
162
163 struct cxacru_data {
164         struct usbatm_data *usbatm;
165
166         const struct cxacru_modem_type *modem_type;
167
168         int line_status;
169         struct mutex adsl_state_serialize;
170         int adsl_status;
171         struct delayed_work poll_work;
172         u32 card_info[CXINF_MAX];
173         struct mutex poll_state_serialize;
174         enum cxacru_poll_state poll_state;
175
176         /* contol handles */
177         struct mutex cm_serialize;
178         u8 *rcv_buf;
179         u8 *snd_buf;
180         struct urb *rcv_urb;
181         struct urb *snd_urb;
182         struct completion rcv_done;
183         struct completion snd_done;
184 };
185
186 static int cxacru_cm(struct cxacru_data *instance, enum cxacru_cm_request cm,
187         u8 *wdata, int wsize, u8 *rdata, int rsize);
188 static void cxacru_poll_status(struct work_struct *work);
189
190 /* Card info exported through sysfs */
191 #define CXACRU__ATTR_INIT(_name) \
192 static DEVICE_ATTR(_name, S_IRUGO, cxacru_sysfs_show_##_name, NULL)
193
194 #define CXACRU_CMD_INIT(_name) \
195 static DEVICE_ATTR(_name, S_IWUSR | S_IRUGO, \
196         cxacru_sysfs_show_##_name, cxacru_sysfs_store_##_name)
197
198 #define CXACRU_ATTR_INIT(_value, _type, _name) \
199 static ssize_t cxacru_sysfs_show_##_name(struct device *dev, \
200         struct device_attribute *attr, char *buf) \
201 { \
202         struct usb_interface *intf = to_usb_interface(dev); \
203         struct usbatm_data *usbatm_instance = usb_get_intfdata(intf); \
204         struct cxacru_data *instance = usbatm_instance->driver_data; \
205         return cxacru_sysfs_showattr_##_type(instance->card_info[_value], buf); \
206 } \
207 CXACRU__ATTR_INIT(_name)
208
209 #define CXACRU_ATTR_CREATE(_v, _t, _name) CXACRU_DEVICE_CREATE_FILE(_name)
210 #define CXACRU_CMD_CREATE(_name)          CXACRU_DEVICE_CREATE_FILE(_name)
211 #define CXACRU__ATTR_CREATE(_name)        CXACRU_DEVICE_CREATE_FILE(_name)
212
213 #define CXACRU_ATTR_REMOVE(_v, _t, _name) CXACRU_DEVICE_REMOVE_FILE(_name)
214 #define CXACRU_CMD_REMOVE(_name)          CXACRU_DEVICE_REMOVE_FILE(_name)
215 #define CXACRU__ATTR_REMOVE(_name)        CXACRU_DEVICE_REMOVE_FILE(_name)
216
217 static ssize_t cxacru_sysfs_showattr_u32(u32 value, char *buf)
218 {
219         return snprintf(buf, PAGE_SIZE, "%u\n", value);
220 }
221
222 static ssize_t cxacru_sysfs_showattr_s8(s8 value, char *buf)
223 {
224         return snprintf(buf, PAGE_SIZE, "%d\n", value);
225 }
226
227 static ssize_t cxacru_sysfs_showattr_dB(s16 value, char *buf)
228 {
229         return snprintf(buf, PAGE_SIZE, "%d.%02u\n",
230                                         value / 100, abs(value) % 100);
231 }
232
233 static ssize_t cxacru_sysfs_showattr_bool(u32 value, char *buf)
234 {
235         static char *str[] = { "no", "yes" };
236         if (unlikely(value >= ARRAY_SIZE(str)))
237                 return snprintf(buf, PAGE_SIZE, "%u\n", value);
238         return snprintf(buf, PAGE_SIZE, "%s\n", str[value]);
239 }
240
241 static ssize_t cxacru_sysfs_showattr_LINK(u32 value, char *buf)
242 {
243         static char *str[] = { NULL, "not connected", "connected", "lost" };
244         if (unlikely(value >= ARRAY_SIZE(str) || str[value] == NULL))
245                 return snprintf(buf, PAGE_SIZE, "%u\n", value);
246         return snprintf(buf, PAGE_SIZE, "%s\n", str[value]);
247 }
248
249 static ssize_t cxacru_sysfs_showattr_LINE(u32 value, char *buf)
250 {
251         static char *str[] = { "down", "attempting to activate",
252                 "training", "channel analysis", "exchange", "up",
253                 "waiting", "initialising"
254         };
255         if (unlikely(value >= ARRAY_SIZE(str)))
256                 return snprintf(buf, PAGE_SIZE, "%u\n", value);
257         return snprintf(buf, PAGE_SIZE, "%s\n", str[value]);
258 }
259
260 static ssize_t cxacru_sysfs_showattr_MODU(u32 value, char *buf)
261 {
262         static char *str[] = {
263                         NULL,
264                         "ANSI T1.413",
265                         "ITU-T G.992.1 (G.DMT)",
266                         "ITU-T G.992.2 (G.LITE)"
267         };
268         if (unlikely(value >= ARRAY_SIZE(str) || str[value] == NULL))
269                 return snprintf(buf, PAGE_SIZE, "%u\n", value);
270         return snprintf(buf, PAGE_SIZE, "%s\n", str[value]);
271 }
272
273 /*
274  * This could use MAC_ADDRESS_HIGH and MAC_ADDRESS_LOW, but since
275  * this data is already in atm_dev there's no point.
276  *
277  * MAC_ADDRESS_HIGH = 0x????5544
278  * MAC_ADDRESS_LOW  = 0x33221100
279  * Where 00-55 are bytes 0-5 of the MAC.
280  */
281 static ssize_t cxacru_sysfs_show_mac_address(struct device *dev,
282         struct device_attribute *attr, char *buf)
283 {
284         struct usb_interface *intf = to_usb_interface(dev);
285         struct usbatm_data *usbatm_instance = usb_get_intfdata(intf);
286         struct atm_dev *atm_dev = usbatm_instance->atm_dev;
287
288         return snprintf(buf, PAGE_SIZE, "%02x:%02x:%02x:%02x:%02x:%02x\n",
289                         atm_dev->esi[0], atm_dev->esi[1], atm_dev->esi[2],
290                         atm_dev->esi[3], atm_dev->esi[4], atm_dev->esi[5]);
291 }
292
293 static ssize_t cxacru_sysfs_show_adsl_state(struct device *dev,
294         struct device_attribute *attr, char *buf)
295 {
296         struct usb_interface *intf = to_usb_interface(dev);
297         struct usbatm_data *usbatm_instance = usb_get_intfdata(intf);
298         struct cxacru_data *instance = usbatm_instance->driver_data;
299         u32 value = instance->card_info[CXINF_LINE_STARTABLE];
300
301         static char *str[] = { "running", "stopped" };
302         if (unlikely(value >= ARRAY_SIZE(str)))
303                 return snprintf(buf, PAGE_SIZE, "%u\n", value);
304         return snprintf(buf, PAGE_SIZE, "%s\n", str[value]);
305 }
306
307 static ssize_t cxacru_sysfs_store_adsl_state(struct device *dev,
308         struct device_attribute *attr, const char *buf, size_t count)
309 {
310         struct usb_interface *intf = to_usb_interface(dev);
311         struct usbatm_data *usbatm_instance = usb_get_intfdata(intf);
312         struct cxacru_data *instance = usbatm_instance->driver_data;
313         int ret;
314         int poll = -1;
315         char str_cmd[8];
316         int len = strlen(buf);
317
318         if (!capable(CAP_NET_ADMIN))
319                 return -EACCES;
320
321         ret = sscanf(buf, "%7s", str_cmd);
322         if (ret != 1)
323                 return -EINVAL;
324         ret = 0;
325
326         if (mutex_lock_interruptible(&instance->adsl_state_serialize))
327                 return -ERESTARTSYS;
328
329         if (!strcmp(str_cmd, "stop") || !strcmp(str_cmd, "restart")) {
330                 ret = cxacru_cm(instance, CM_REQUEST_CHIP_ADSL_LINE_STOP, NULL, 0, NULL, 0);
331                 if (ret < 0) {
332                         atm_err(usbatm_instance, "change adsl state:"
333                                 " CHIP_ADSL_LINE_STOP returned %d\n", ret);
334
335                         ret = -EIO;
336                 } else {
337                         ret = len;
338                         poll = CXPOLL_STOPPED;
339                 }
340         }
341
342         /* Line status is only updated every second
343          * and the device appears to only react to
344          * START/STOP every second too. Wait 1.5s to
345          * be sure that restart will have an effect. */
346         if (!strcmp(str_cmd, "restart"))
347                 msleep(1500);
348
349         if (!strcmp(str_cmd, "start") || !strcmp(str_cmd, "restart")) {
350                 ret = cxacru_cm(instance, CM_REQUEST_CHIP_ADSL_LINE_START, NULL, 0, NULL, 0);
351                 if (ret < 0) {
352                         atm_err(usbatm_instance, "change adsl state:"
353                                 " CHIP_ADSL_LINE_START returned %d\n", ret);
354
355                         ret = -EIO;
356                 } else {
357                         ret = len;
358                         poll = CXPOLL_POLLING;
359                 }
360         }
361
362         if (!strcmp(str_cmd, "poll")) {
363                 ret = len;
364                 poll = CXPOLL_POLLING;
365         }
366
367         if (ret == 0) {
368                 ret = -EINVAL;
369                 poll = -1;
370         }
371
372         if (poll == CXPOLL_POLLING) {
373                 mutex_lock(&instance->poll_state_serialize);
374                 switch (instance->poll_state) {
375                 case CXPOLL_STOPPED:
376                         /* start polling */
377                         instance->poll_state = CXPOLL_POLLING;
378                         break;
379
380                 case CXPOLL_STOPPING:
381                         /* abort stop request */
382                         instance->poll_state = CXPOLL_POLLING;
383                 case CXPOLL_POLLING:
384                 case CXPOLL_SHUTDOWN:
385                         /* don't start polling */
386                         poll = -1;
387                 }
388                 mutex_unlock(&instance->poll_state_serialize);
389         } else if (poll == CXPOLL_STOPPED) {
390                 mutex_lock(&instance->poll_state_serialize);
391                 /* request stop */
392                 if (instance->poll_state == CXPOLL_POLLING)
393                         instance->poll_state = CXPOLL_STOPPING;
394                 mutex_unlock(&instance->poll_state_serialize);
395         }
396
397         mutex_unlock(&instance->adsl_state_serialize);
398
399         if (poll == CXPOLL_POLLING)
400                 cxacru_poll_status(&instance->poll_work.work);
401
402         return ret;
403 }
404
405 /*
406  * All device attributes are included in CXACRU_ALL_FILES
407  * so that the same list can be used multiple times:
408  *     INIT   (define the device attributes)
409  *     CREATE (create all the device files)
410  *     REMOVE (remove all the device files)
411  *
412  * With the last two being defined as needed in the functions
413  * they are used in before calling CXACRU_ALL_FILES()
414  */
415 #define CXACRU_ALL_FILES(_action) \
416 CXACRU_ATTR_##_action(CXINF_DOWNSTREAM_RATE,           u32,  downstream_rate); \
417 CXACRU_ATTR_##_action(CXINF_UPSTREAM_RATE,             u32,  upstream_rate); \
418 CXACRU_ATTR_##_action(CXINF_LINK_STATUS,               LINK, link_status); \
419 CXACRU_ATTR_##_action(CXINF_LINE_STATUS,               LINE, line_status); \
420 CXACRU__ATTR_##_action(                                      mac_address); \
421 CXACRU_ATTR_##_action(CXINF_UPSTREAM_SNR_MARGIN,       dB,   upstream_snr_margin); \
422 CXACRU_ATTR_##_action(CXINF_DOWNSTREAM_SNR_MARGIN,     dB,   downstream_snr_margin); \
423 CXACRU_ATTR_##_action(CXINF_UPSTREAM_ATTENUATION,      dB,   upstream_attenuation); \
424 CXACRU_ATTR_##_action(CXINF_DOWNSTREAM_ATTENUATION,    dB,   downstream_attenuation); \
425 CXACRU_ATTR_##_action(CXINF_TRANSMITTER_POWER,         s8,   transmitter_power); \
426 CXACRU_ATTR_##_action(CXINF_UPSTREAM_BITS_PER_FRAME,   u32,  upstream_bits_per_frame); \
427 CXACRU_ATTR_##_action(CXINF_DOWNSTREAM_BITS_PER_FRAME, u32,  downstream_bits_per_frame); \
428 CXACRU_ATTR_##_action(CXINF_STARTUP_ATTEMPTS,          u32,  startup_attempts); \
429 CXACRU_ATTR_##_action(CXINF_UPSTREAM_CRC_ERRORS,       u32,  upstream_crc_errors); \
430 CXACRU_ATTR_##_action(CXINF_DOWNSTREAM_CRC_ERRORS,     u32,  downstream_crc_errors); \
431 CXACRU_ATTR_##_action(CXINF_UPSTREAM_FEC_ERRORS,       u32,  upstream_fec_errors); \
432 CXACRU_ATTR_##_action(CXINF_DOWNSTREAM_FEC_ERRORS,     u32,  downstream_fec_errors); \
433 CXACRU_ATTR_##_action(CXINF_UPSTREAM_HEC_ERRORS,       u32,  upstream_hec_errors); \
434 CXACRU_ATTR_##_action(CXINF_DOWNSTREAM_HEC_ERRORS,     u32,  downstream_hec_errors); \
435 CXACRU_ATTR_##_action(CXINF_LINE_STARTABLE,            bool, line_startable); \
436 CXACRU_ATTR_##_action(CXINF_MODULATION,                MODU, modulation); \
437 CXACRU_ATTR_##_action(CXINF_ADSL_HEADEND,              u32,  adsl_headend); \
438 CXACRU_ATTR_##_action(CXINF_ADSL_HEADEND_ENVIRONMENT,  u32,  adsl_headend_environment); \
439 CXACRU_ATTR_##_action(CXINF_CONTROLLER_VERSION,        u32,  adsl_controller_version); \
440 CXACRU_CMD_##_action(                                        adsl_state);
441
442 CXACRU_ALL_FILES(INIT);
443
444 /* the following three functions are stolen from drivers/usb/core/message.c */
445 static void cxacru_blocking_completion(struct urb *urb)
446 {
447         complete((struct completion *)urb->context);
448 }
449
450 static void cxacru_timeout_kill(unsigned long data)
451 {
452         usb_unlink_urb((struct urb *) data);
453 }
454
455 static int cxacru_start_wait_urb(struct urb *urb, struct completion *done,
456                                  int* actual_length)
457 {
458         struct timer_list timer;
459
460         init_timer(&timer);
461         timer.expires = jiffies + msecs_to_jiffies(CMD_TIMEOUT);
462         timer.data = (unsigned long) urb;
463         timer.function = cxacru_timeout_kill;
464         add_timer(&timer);
465         wait_for_completion(done);
466         del_timer_sync(&timer);
467
468         if (actual_length)
469                 *actual_length = urb->actual_length;
470         return urb->status; /* must read status after completion */
471 }
472
473 static int cxacru_cm(struct cxacru_data *instance, enum cxacru_cm_request cm,
474                      u8 *wdata, int wsize, u8 *rdata, int rsize)
475 {
476         int ret, actlen;
477         int offb, offd;
478         const int stride = CMD_PACKET_SIZE - 4;
479         u8 *wbuf = instance->snd_buf;
480         u8 *rbuf = instance->rcv_buf;
481         int wbuflen = ((wsize - 1) / stride + 1) * CMD_PACKET_SIZE;
482         int rbuflen = ((rsize - 1) / stride + 1) * CMD_PACKET_SIZE;
483
484         if (wbuflen > PAGE_SIZE || rbuflen > PAGE_SIZE) {
485                 if (printk_ratelimit())
486                         usb_err(instance->usbatm, "requested transfer size too large (%d, %d)\n",
487                                 wbuflen, rbuflen);
488                 ret = -ENOMEM;
489                 goto fail;
490         }
491
492         mutex_lock(&instance->cm_serialize);
493
494         /* submit reading urb before the writing one */
495         init_completion(&instance->rcv_done);
496         ret = usb_submit_urb(instance->rcv_urb, GFP_KERNEL);
497         if (ret < 0) {
498                 if (printk_ratelimit())
499                         usb_err(instance->usbatm, "submit of read urb for cm %#x failed (%d)\n",
500                                 cm, ret);
501                 goto fail;
502         }
503
504         memset(wbuf, 0, wbuflen);
505         /* handle wsize == 0 */
506         wbuf[0] = cm;
507         for (offb = offd = 0; offd < wsize; offd += stride, offb += CMD_PACKET_SIZE) {
508                 wbuf[offb] = cm;
509                 memcpy(wbuf + offb + 4, wdata + offd, min_t(int, stride, wsize - offd));
510         }
511
512         instance->snd_urb->transfer_buffer_length = wbuflen;
513         init_completion(&instance->snd_done);
514         ret = usb_submit_urb(instance->snd_urb, GFP_KERNEL);
515         if (ret < 0) {
516                 if (printk_ratelimit())
517                         usb_err(instance->usbatm, "submit of write urb for cm %#x failed (%d)\n",
518                                 cm, ret);
519                 goto fail;
520         }
521
522         ret = cxacru_start_wait_urb(instance->snd_urb, &instance->snd_done, NULL);
523         if (ret < 0) {
524                 if (printk_ratelimit())
525                         usb_err(instance->usbatm, "send of cm %#x failed (%d)\n", cm, ret);
526                 goto fail;
527         }
528
529         ret = cxacru_start_wait_urb(instance->rcv_urb, &instance->rcv_done, &actlen);
530         if (ret < 0) {
531                 if (printk_ratelimit())
532                         usb_err(instance->usbatm, "receive of cm %#x failed (%d)\n", cm, ret);
533                 goto fail;
534         }
535         if (actlen % CMD_PACKET_SIZE || !actlen) {
536                 if (printk_ratelimit())
537                         usb_err(instance->usbatm, "invalid response length to cm %#x: %d\n",
538                                 cm, actlen);
539                 ret = -EIO;
540                 goto fail;
541         }
542
543         /* check the return status and copy the data to the output buffer, if needed */
544         for (offb = offd = 0; offd < rsize && offb < actlen; offb += CMD_PACKET_SIZE) {
545                 if (rbuf[offb] != cm) {
546                         if (printk_ratelimit())
547                                 usb_err(instance->usbatm, "wrong cm %#x in response to cm %#x\n",
548                                         rbuf[offb], cm);
549                         ret = -EIO;
550                         goto fail;
551                 }
552                 if (rbuf[offb + 1] != CM_STATUS_SUCCESS) {
553                         if (printk_ratelimit())
554                                 usb_err(instance->usbatm, "response to cm %#x failed: %#x\n",
555                                         cm, rbuf[offb + 1]);
556                         ret = -EIO;
557                         goto fail;
558                 }
559                 if (offd >= rsize)
560                         break;
561                 memcpy(rdata + offd, rbuf + offb + 4, min_t(int, stride, rsize - offd));
562                 offd += stride;
563         }
564
565         ret = offd;
566         dbg("cm %#x", cm);
567 fail:
568         mutex_unlock(&instance->cm_serialize);
569         return ret;
570 }
571
572 static int cxacru_cm_get_array(struct cxacru_data *instance, enum cxacru_cm_request cm,
573                                u32 *data, int size)
574 {
575         int ret, len;
576         u32 *buf;
577         int offb, offd;
578         const int stride = CMD_PACKET_SIZE / (4 * 2) - 1;
579         int buflen =  ((size - 1) / stride + 1 + size * 2) * 4;
580
581         buf = kmalloc(buflen, GFP_KERNEL);
582         if (!buf)
583                 return -ENOMEM;
584
585         ret = cxacru_cm(instance, cm, NULL, 0, (u8 *) buf, buflen);
586         if (ret < 0)
587                 goto cleanup;
588
589         /* len > 0 && len % 4 == 0 guaranteed by cxacru_cm() */
590         len = ret / 4;
591         for (offb = 0; offb < len; ) {
592                 int l = le32_to_cpu(buf[offb++]);
593                 if (l > stride || l > (len - offb) / 2) {
594                         if (printk_ratelimit())
595                                 usb_err(instance->usbatm, "invalid data length from cm %#x: %d\n",
596                                         cm, l);
597                         ret = -EIO;
598                         goto cleanup;
599                 }
600                 while (l--) {
601                         offd = le32_to_cpu(buf[offb++]);
602                         if (offd >= size) {
603                                 if (printk_ratelimit())
604                                         usb_err(instance->usbatm, "wrong index #%x in response to cm #%x\n",
605                                                 offd, cm);
606                                 ret = -EIO;
607                                 goto cleanup;
608                         }
609                         data[offd] = le32_to_cpu(buf[offb++]);
610                 }
611         }
612
613         ret = 0;
614
615 cleanup:
616         kfree(buf);
617         return ret;
618 }
619
620 static int cxacru_card_status(struct cxacru_data *instance)
621 {
622         int ret = cxacru_cm(instance, CM_REQUEST_CARD_GET_STATUS, NULL, 0, NULL, 0);
623         if (ret < 0) {          /* firmware not loaded */
624                 dbg("cxacru_adsl_start: CARD_GET_STATUS returned %d", ret);
625                 return ret;
626         }
627         return 0;
628 }
629
630 static void cxacru_remove_device_files(struct usbatm_data *usbatm_instance,
631                 struct atm_dev *atm_dev)
632 {
633         struct usb_interface *intf = usbatm_instance->usb_intf;
634
635         #define CXACRU_DEVICE_REMOVE_FILE(_name) \
636                 device_remove_file(&intf->dev, &dev_attr_##_name);
637         CXACRU_ALL_FILES(REMOVE);
638         #undef CXACRU_DEVICE_REMOVE_FILE
639 }
640
641 static int cxacru_atm_start(struct usbatm_data *usbatm_instance,
642                 struct atm_dev *atm_dev)
643 {
644         struct cxacru_data *instance = usbatm_instance->driver_data;
645         struct usb_interface *intf = usbatm_instance->usb_intf;
646         /*
647         struct atm_dev *atm_dev = usbatm_instance->atm_dev;
648         */
649         int ret;
650         int start_polling = 1;
651
652         dbg("cxacru_atm_start");
653
654         /* Read MAC address */
655         ret = cxacru_cm(instance, CM_REQUEST_CARD_GET_MAC_ADDRESS, NULL, 0,
656                         atm_dev->esi, sizeof(atm_dev->esi));
657         if (ret < 0) {
658                 atm_err(usbatm_instance, "cxacru_atm_start: CARD_GET_MAC_ADDRESS returned %d\n", ret);
659                 return ret;
660         }
661
662         #define CXACRU_DEVICE_CREATE_FILE(_name) \
663                 ret = device_create_file(&intf->dev, &dev_attr_##_name); \
664                 if (unlikely(ret)) \
665                         goto fail_sysfs;
666         CXACRU_ALL_FILES(CREATE);
667         #undef CXACRU_DEVICE_CREATE_FILE
668
669         /* start ADSL */
670         mutex_lock(&instance->adsl_state_serialize);
671         ret = cxacru_cm(instance, CM_REQUEST_CHIP_ADSL_LINE_START, NULL, 0, NULL, 0);
672         if (ret < 0)
673                 atm_err(usbatm_instance, "cxacru_atm_start: CHIP_ADSL_LINE_START returned %d\n", ret);
674
675         /* Start status polling */
676         mutex_lock(&instance->poll_state_serialize);
677         switch (instance->poll_state) {
678         case CXPOLL_STOPPED:
679                 /* start polling */
680                 instance->poll_state = CXPOLL_POLLING;
681                 break;
682
683         case CXPOLL_STOPPING:
684                 /* abort stop request */
685                 instance->poll_state = CXPOLL_POLLING;
686         case CXPOLL_POLLING:
687         case CXPOLL_SHUTDOWN:
688                 /* don't start polling */
689                 start_polling = 0;
690         }
691         mutex_unlock(&instance->poll_state_serialize);
692         mutex_unlock(&instance->adsl_state_serialize);
693
694         if (start_polling)
695                 cxacru_poll_status(&instance->poll_work.work);
696         return 0;
697
698 fail_sysfs:
699         usb_err(usbatm_instance, "cxacru_atm_start: device_create_file failed (%d)\n", ret);
700         cxacru_remove_device_files(usbatm_instance, atm_dev);
701         return ret;
702 }
703
704 static void cxacru_poll_status(struct work_struct *work)
705 {
706         struct cxacru_data *instance =
707                 container_of(work, struct cxacru_data, poll_work.work);
708         u32 buf[CXINF_MAX] = {};
709         struct usbatm_data *usbatm = instance->usbatm;
710         struct atm_dev *atm_dev = usbatm->atm_dev;
711         int keep_polling = 1;
712         int ret;
713
714         ret = cxacru_cm_get_array(instance, CM_REQUEST_CARD_INFO_GET, buf, CXINF_MAX);
715         if (ret < 0) {
716                 if (ret != -ESHUTDOWN)
717                         atm_warn(usbatm, "poll status: error %d\n", ret);
718
719                 mutex_lock(&instance->poll_state_serialize);
720                 if (instance->poll_state != CXPOLL_SHUTDOWN) {
721                         instance->poll_state = CXPOLL_STOPPED;
722
723                         if (ret != -ESHUTDOWN)
724                                 atm_warn(usbatm, "polling disabled, set adsl_state"
725                                                 " to 'start' or 'poll' to resume\n");
726                 }
727                 mutex_unlock(&instance->poll_state_serialize);
728                 goto reschedule;
729         }
730
731         memcpy(instance->card_info, buf, sizeof(instance->card_info));
732
733         if (instance->adsl_status != buf[CXINF_LINE_STARTABLE]) {
734                 instance->adsl_status = buf[CXINF_LINE_STARTABLE];
735
736                 switch (instance->adsl_status) {
737                 case 0:
738                         atm_printk(KERN_INFO, usbatm, "ADSL state: running\n");
739                         break;
740
741                 case 1:
742                         atm_printk(KERN_INFO, usbatm, "ADSL state: stopped\n");
743                         break;
744
745                 default:
746                         atm_printk(KERN_INFO, usbatm, "Unknown adsl status %02x\n", instance->adsl_status);
747                         break;
748                 }
749         }
750
751         if (instance->line_status == buf[CXINF_LINE_STATUS])
752                 goto reschedule;
753
754         instance->line_status = buf[CXINF_LINE_STATUS];
755         switch (instance->line_status) {
756         case 0:
757                 atm_dev->signal = ATM_PHY_SIG_LOST;
758                 atm_info(usbatm, "ADSL line: down\n");
759                 break;
760
761         case 1:
762                 atm_dev->signal = ATM_PHY_SIG_LOST;
763                 atm_info(usbatm, "ADSL line: attempting to activate\n");
764                 break;
765
766         case 2:
767                 atm_dev->signal = ATM_PHY_SIG_LOST;
768                 atm_info(usbatm, "ADSL line: training\n");
769                 break;
770
771         case 3:
772                 atm_dev->signal = ATM_PHY_SIG_LOST;
773                 atm_info(usbatm, "ADSL line: channel analysis\n");
774                 break;
775
776         case 4:
777                 atm_dev->signal = ATM_PHY_SIG_LOST;
778                 atm_info(usbatm, "ADSL line: exchange\n");
779                 break;
780
781         case 5:
782                 atm_dev->link_rate = buf[CXINF_DOWNSTREAM_RATE] * 1000 / 424;
783                 atm_dev->signal = ATM_PHY_SIG_FOUND;
784
785                 atm_info(usbatm, "ADSL line: up (%d kb/s down | %d kb/s up)\n",
786                      buf[CXINF_DOWNSTREAM_RATE], buf[CXINF_UPSTREAM_RATE]);
787                 break;
788
789         case 6:
790                 atm_dev->signal = ATM_PHY_SIG_LOST;
791                 atm_info(usbatm, "ADSL line: waiting\n");
792                 break;
793
794         case 7:
795                 atm_dev->signal = ATM_PHY_SIG_LOST;
796                 atm_info(usbatm, "ADSL line: initializing\n");
797                 break;
798
799         default:
800                 atm_dev->signal = ATM_PHY_SIG_UNKNOWN;
801                 atm_info(usbatm, "Unknown line state %02x\n", instance->line_status);
802                 break;
803         }
804 reschedule:
805
806         mutex_lock(&instance->poll_state_serialize);
807         if (instance->poll_state == CXPOLL_STOPPING &&
808                                 instance->adsl_status == 1 && /* stopped */
809                                 instance->line_status == 0) /* down */
810                 instance->poll_state = CXPOLL_STOPPED;
811
812         if (instance->poll_state == CXPOLL_STOPPED)
813                 keep_polling = 0;
814         mutex_unlock(&instance->poll_state_serialize);
815
816         if (keep_polling)
817                 schedule_delayed_work(&instance->poll_work,
818                                 round_jiffies_relative(POLL_INTERVAL*HZ));
819 }
820
821 static int cxacru_fw(struct usb_device *usb_dev, enum cxacru_fw_request fw,
822                      u8 code1, u8 code2, u32 addr, u8 *data, int size)
823 {
824         int ret;
825         u8 *buf;
826         int offd, offb;
827         const int stride = CMD_PACKET_SIZE - 8;
828
829         buf = (u8 *) __get_free_page(GFP_KERNEL);
830         if (!buf)
831                 return -ENOMEM;
832
833         offb = offd = 0;
834         do {
835                 int l = min_t(int, stride, size - offd);
836                 buf[offb++] = fw;
837                 buf[offb++] = l;
838                 buf[offb++] = code1;
839                 buf[offb++] = code2;
840                 *((u32 *) (buf + offb)) = cpu_to_le32(addr);
841                 offb += 4;
842                 addr += l;
843                 if(l)
844                         memcpy(buf + offb, data + offd, l);
845                 if (l < stride)
846                         memset(buf + offb + l, 0, stride - l);
847                 offb += stride;
848                 offd += stride;
849                 if ((offb >= PAGE_SIZE) || (offd >= size)) {
850                         ret = usb_bulk_msg(usb_dev, usb_sndbulkpipe(usb_dev, CXACRU_EP_CMD),
851                                            buf, offb, NULL, CMD_TIMEOUT);
852                         if (ret < 0) {
853                                 dbg("sending fw %#x failed", fw);
854                                 goto cleanup;
855                         }
856                         offb = 0;
857                 }
858         } while(offd < size);
859         dbg("sent fw %#x", fw);
860
861         ret = 0;
862
863 cleanup:
864         free_page((unsigned long) buf);
865         return ret;
866 }
867
868 static void cxacru_upload_firmware(struct cxacru_data *instance,
869                                    const struct firmware *fw,
870                                    const struct firmware *bp,
871                                    const struct firmware *cf)
872 {
873         int ret;
874         int off;
875         struct usbatm_data *usbatm = instance->usbatm;
876         struct usb_device *usb_dev = usbatm->usb_dev;
877         u16 signature[] = { usb_dev->descriptor.idVendor, usb_dev->descriptor.idProduct };
878         u32 val;
879
880         dbg("cxacru_upload_firmware");
881
882         /* FirmwarePllFClkValue */
883         val = cpu_to_le32(instance->modem_type->pll_f_clk);
884         ret = cxacru_fw(usb_dev, FW_WRITE_MEM, 0x2, 0x0, PLLFCLK_ADDR, (u8 *) &val, 4);
885         if (ret) {
886                 usb_err(usbatm, "FirmwarePllFClkValue failed: %d\n", ret);
887                 return;
888         }
889
890         /* FirmwarePllBClkValue */
891         val = cpu_to_le32(instance->modem_type->pll_b_clk);
892         ret = cxacru_fw(usb_dev, FW_WRITE_MEM, 0x2, 0x0, PLLBCLK_ADDR, (u8 *) &val, 4);
893         if (ret) {
894                 usb_err(usbatm, "FirmwarePllBClkValue failed: %d\n", ret);
895                 return;
896         }
897
898         /* Enable SDRAM */
899         val = cpu_to_le32(SDRAM_ENA);
900         ret = cxacru_fw(usb_dev, FW_WRITE_MEM, 0x2, 0x0, SDRAMEN_ADDR, (u8 *) &val, 4);
901         if (ret) {
902                 usb_err(usbatm, "Enable SDRAM failed: %d\n", ret);
903                 return;
904         }
905
906         /* Firmware */
907         ret = cxacru_fw(usb_dev, FW_WRITE_MEM, 0x2, 0x0, FW_ADDR, fw->data, fw->size);
908         if (ret) {
909                 usb_err(usbatm, "Firmware upload failed: %d\n", ret);
910                 return;
911         }
912
913         /* Boot ROM patch */
914         if (instance->modem_type->boot_rom_patch) {
915                 ret = cxacru_fw(usb_dev, FW_WRITE_MEM, 0x2, 0x0, BR_ADDR, bp->data, bp->size);
916                 if (ret) {
917                         usb_err(usbatm, "Boot ROM patching failed: %d\n", ret);
918                         return;
919                 }
920         }
921
922         /* Signature */
923         ret = cxacru_fw(usb_dev, FW_WRITE_MEM, 0x2, 0x0, SIG_ADDR, (u8 *) signature, 4);
924         if (ret) {
925                 usb_err(usbatm, "Signature storing failed: %d\n", ret);
926                 return;
927         }
928
929         if (instance->modem_type->boot_rom_patch) {
930                 val = cpu_to_le32(BR_ADDR);
931                 ret = cxacru_fw(usb_dev, FW_WRITE_MEM, 0x2, 0x0, BR_STACK_ADDR, (u8 *) &val, 4);
932         }
933         else {
934                 ret = cxacru_fw(usb_dev, FW_GOTO_MEM, 0x0, 0x0, FW_ADDR, NULL, 0);
935         }
936         if (ret) {
937                 usb_err(usbatm, "Passing control to firmware failed: %d\n", ret);
938                 return;
939         }
940
941         /* Delay to allow firmware to start up. */
942         msleep_interruptible(1000);
943
944         usb_clear_halt(usb_dev, usb_sndbulkpipe(usb_dev, CXACRU_EP_CMD));
945         usb_clear_halt(usb_dev, usb_rcvbulkpipe(usb_dev, CXACRU_EP_CMD));
946         usb_clear_halt(usb_dev, usb_sndbulkpipe(usb_dev, CXACRU_EP_DATA));
947         usb_clear_halt(usb_dev, usb_rcvbulkpipe(usb_dev, CXACRU_EP_DATA));
948
949         ret = cxacru_cm(instance, CM_REQUEST_CARD_GET_STATUS, NULL, 0, NULL, 0);
950         if (ret < 0) {
951                 usb_err(usbatm, "modem failed to initialize: %d\n", ret);
952                 return;
953         }
954
955         /* Load config data (le32), doing one packet at a time */
956         if (cf)
957                 for (off = 0; off < cf->size / 4; ) {
958                         u32 buf[CMD_PACKET_SIZE / 4 - 1];
959                         int i, len = min_t(int, cf->size / 4 - off, CMD_PACKET_SIZE / 4 / 2 - 1);
960                         buf[0] = cpu_to_le32(len);
961                         for (i = 0; i < len; i++, off++) {
962                                 buf[i * 2 + 1] = cpu_to_le32(off);
963                                 memcpy(buf + i * 2 + 2, cf->data + off * 4, 4);
964                         }
965                         ret = cxacru_cm(instance, CM_REQUEST_CARD_DATA_SET,
966                                         (u8 *) buf, len, NULL, 0);
967                         if (ret < 0) {
968                                 usb_err(usbatm, "load config data failed: %d\n", ret);
969                                 return;
970                         }
971                 }
972
973         msleep_interruptible(4000);
974 }
975
976 static int cxacru_find_firmware(struct cxacru_data *instance,
977                                 char* phase, const struct firmware **fw_p)
978 {
979         struct usbatm_data *usbatm = instance->usbatm;
980         struct device *dev = &usbatm->usb_intf->dev;
981         char buf[16];
982
983         sprintf(buf, "cxacru-%s.bin", phase);
984         dbg("cxacru_find_firmware: looking for %s", buf);
985
986         if (request_firmware(fw_p, buf, dev)) {
987                 usb_dbg(usbatm, "no stage %s firmware found\n", phase);
988                 return -ENOENT;
989         }
990
991         usb_info(usbatm, "found firmware %s\n", buf);
992
993         return 0;
994 }
995
996 static int cxacru_heavy_init(struct usbatm_data *usbatm_instance,
997                              struct usb_interface *usb_intf)
998 {
999         const struct firmware *fw, *bp, *cf;
1000         struct cxacru_data *instance = usbatm_instance->driver_data;
1001
1002         int ret = cxacru_find_firmware(instance, "fw", &fw);
1003         if (ret) {
1004                 usb_warn(usbatm_instance, "firmware (cxacru-fw.bin) unavailable (system misconfigured?)\n");
1005                 return ret;
1006         }
1007
1008         if (instance->modem_type->boot_rom_patch) {
1009                 ret = cxacru_find_firmware(instance, "bp", &bp);
1010                 if (ret) {
1011                         usb_warn(usbatm_instance, "boot ROM patch (cxacru-bp.bin) unavailable (system misconfigured?)\n");
1012                         release_firmware(fw);
1013                         return ret;
1014                 }
1015         }
1016
1017         if (cxacru_find_firmware(instance, "cf", &cf))          /* optional */
1018                 cf = NULL;
1019
1020         cxacru_upload_firmware(instance, fw, bp, cf);
1021
1022         if (cf)
1023                 release_firmware(cf);
1024         if (instance->modem_type->boot_rom_patch)
1025                 release_firmware(bp);
1026         release_firmware(fw);
1027
1028         ret = cxacru_card_status(instance);
1029         if (ret)
1030                 dbg("modem initialisation failed");
1031         else
1032                 dbg("done setting up the modem");
1033
1034         return ret;
1035 }
1036
1037 static int cxacru_bind(struct usbatm_data *usbatm_instance,
1038                        struct usb_interface *intf, const struct usb_device_id *id)
1039 {
1040         struct cxacru_data *instance;
1041         struct usb_device *usb_dev = interface_to_usbdev(intf);
1042         int ret;
1043
1044         /* instance init */
1045         instance = kzalloc(sizeof(*instance), GFP_KERNEL);
1046         if (!instance) {
1047                 dbg("cxacru_bind: no memory for instance data");
1048                 return -ENOMEM;
1049         }
1050
1051         instance->usbatm = usbatm_instance;
1052         instance->modem_type = (struct cxacru_modem_type *) id->driver_info;
1053         memset(instance->card_info, 0, sizeof(instance->card_info));
1054
1055         mutex_init(&instance->poll_state_serialize);
1056         instance->poll_state = CXPOLL_STOPPED;
1057         instance->line_status = -1;
1058         instance->adsl_status = -1;
1059
1060         mutex_init(&instance->adsl_state_serialize);
1061
1062         instance->rcv_buf = (u8 *) __get_free_page(GFP_KERNEL);
1063         if (!instance->rcv_buf) {
1064                 dbg("cxacru_bind: no memory for rcv_buf");
1065                 ret = -ENOMEM;
1066                 goto fail;
1067         }
1068         instance->snd_buf = (u8 *) __get_free_page(GFP_KERNEL);
1069         if (!instance->snd_buf) {
1070                 dbg("cxacru_bind: no memory for snd_buf");
1071                 ret = -ENOMEM;
1072                 goto fail;
1073         }
1074         instance->rcv_urb = usb_alloc_urb(0, GFP_KERNEL);
1075         if (!instance->rcv_urb) {
1076                 dbg("cxacru_bind: no memory for rcv_urb");
1077                 ret = -ENOMEM;
1078                 goto fail;
1079         }
1080         instance->snd_urb = usb_alloc_urb(0, GFP_KERNEL);
1081         if (!instance->snd_urb) {
1082                 dbg("cxacru_bind: no memory for snd_urb");
1083                 ret = -ENOMEM;
1084                 goto fail;
1085         }
1086
1087         usb_fill_int_urb(instance->rcv_urb,
1088                         usb_dev, usb_rcvintpipe(usb_dev, CXACRU_EP_CMD),
1089                         instance->rcv_buf, PAGE_SIZE,
1090                         cxacru_blocking_completion, &instance->rcv_done, 1);
1091
1092         usb_fill_int_urb(instance->snd_urb,
1093                         usb_dev, usb_sndintpipe(usb_dev, CXACRU_EP_CMD),
1094                         instance->snd_buf, PAGE_SIZE,
1095                         cxacru_blocking_completion, &instance->snd_done, 4);
1096
1097         mutex_init(&instance->cm_serialize);
1098
1099         INIT_DELAYED_WORK(&instance->poll_work, cxacru_poll_status);
1100
1101         usbatm_instance->driver_data = instance;
1102
1103         usbatm_instance->flags = (cxacru_card_status(instance) ? 0 : UDSL_SKIP_HEAVY_INIT);
1104
1105         return 0;
1106
1107  fail:
1108         free_page((unsigned long) instance->snd_buf);
1109         free_page((unsigned long) instance->rcv_buf);
1110         usb_free_urb(instance->snd_urb);
1111         usb_free_urb(instance->rcv_urb);
1112         kfree(instance);
1113
1114         return ret;
1115 }
1116
1117 static void cxacru_unbind(struct usbatm_data *usbatm_instance,
1118                 struct usb_interface *intf)
1119 {
1120         struct cxacru_data *instance = usbatm_instance->driver_data;
1121         int is_polling = 1;
1122
1123         dbg("cxacru_unbind entered");
1124
1125         if (!instance) {
1126                 dbg("cxacru_unbind: NULL instance!");
1127                 return;
1128         }
1129
1130         mutex_lock(&instance->poll_state_serialize);
1131         BUG_ON(instance->poll_state == CXPOLL_SHUTDOWN);
1132
1133         /* ensure that status polling continues unless
1134          * it has already stopped */
1135         if (instance->poll_state == CXPOLL_STOPPED)
1136                 is_polling = 0;
1137
1138         /* stop polling from being stopped or started */
1139         instance->poll_state = CXPOLL_SHUTDOWN;
1140         mutex_unlock(&instance->poll_state_serialize);
1141
1142         if (is_polling)
1143                 cancel_rearming_delayed_work(&instance->poll_work);
1144
1145         usb_kill_urb(instance->snd_urb);
1146         usb_kill_urb(instance->rcv_urb);
1147         usb_free_urb(instance->snd_urb);
1148         usb_free_urb(instance->rcv_urb);
1149
1150         free_page((unsigned long) instance->snd_buf);
1151         free_page((unsigned long) instance->rcv_buf);
1152
1153         kfree(instance);
1154
1155         usbatm_instance->driver_data = NULL;
1156 }
1157
1158 static const struct cxacru_modem_type cxacru_cafe = {
1159         .pll_f_clk = 0x02d874df,
1160         .pll_b_clk = 0x0196a51a,
1161         .boot_rom_patch = 1,
1162 };
1163
1164 static const struct cxacru_modem_type cxacru_cb00 = {
1165         .pll_f_clk = 0x5,
1166         .pll_b_clk = 0x3,
1167         .boot_rom_patch = 0,
1168 };
1169
1170 static const struct usb_device_id cxacru_usb_ids[] = {
1171         { /* V = Conexant                       P = ADSL modem (Euphrates project)      */
1172                 USB_DEVICE(0x0572, 0xcafe),     .driver_info = (unsigned long) &cxacru_cafe
1173         },
1174         { /* V = Conexant                       P = ADSL modem (Hasbani project)        */
1175                 USB_DEVICE(0x0572, 0xcb00),     .driver_info = (unsigned long) &cxacru_cb00
1176         },
1177         { /* V = Conexant                       P = ADSL modem                          */
1178                 USB_DEVICE(0x0572, 0xcb01),     .driver_info = (unsigned long) &cxacru_cb00
1179         },
1180         { /* V = Conexant                       P = ADSL modem (Well PTI-800) */
1181                 USB_DEVICE(0x0572, 0xcb02),     .driver_info = (unsigned long) &cxacru_cb00
1182         },
1183         { /* V = Conexant                       P = ADSL modem                          */
1184                 USB_DEVICE(0x0572, 0xcb06),     .driver_info = (unsigned long) &cxacru_cb00
1185         },
1186         { /* V = Conexant                       P = ADSL modem (ZTE ZXDSL 852)          */
1187                 USB_DEVICE(0x0572, 0xcb07),     .driver_info = (unsigned long) &cxacru_cb00
1188         },
1189         { /* V = Olitec                         P = ADSL modem version 2                */
1190                 USB_DEVICE(0x08e3, 0x0100),     .driver_info = (unsigned long) &cxacru_cafe
1191         },
1192         { /* V = Olitec                         P = ADSL modem version 3                */
1193                 USB_DEVICE(0x08e3, 0x0102),     .driver_info = (unsigned long) &cxacru_cb00
1194         },
1195         { /* V = Trust/Amigo Technology Co.     P = AMX-CA86U                           */
1196                 USB_DEVICE(0x0eb0, 0x3457),     .driver_info = (unsigned long) &cxacru_cafe
1197         },
1198         { /* V = Zoom                           P = 5510                                */
1199                 USB_DEVICE(0x1803, 0x5510),     .driver_info = (unsigned long) &cxacru_cb00
1200         },
1201         { /* V = Draytek                        P = Vigor 318                           */
1202                 USB_DEVICE(0x0675, 0x0200),     .driver_info = (unsigned long) &cxacru_cb00
1203         },
1204         { /* V = Zyxel                          P = 630-C1 aka OMNI ADSL USB (Annex A)  */
1205                 USB_DEVICE(0x0586, 0x330a),     .driver_info = (unsigned long) &cxacru_cb00
1206         },
1207         { /* V = Zyxel                          P = 630-C3 aka OMNI ADSL USB (Annex B)  */
1208                 USB_DEVICE(0x0586, 0x330b),     .driver_info = (unsigned long) &cxacru_cb00
1209         },
1210         { /* V = Aethra                         P = Starmodem UM1020                    */
1211                 USB_DEVICE(0x0659, 0x0020),     .driver_info = (unsigned long) &cxacru_cb00
1212         },
1213         { /* V = Aztech Systems                 P = ? AKA Pirelli AUA-010               */
1214                 USB_DEVICE(0x0509, 0x0812),     .driver_info = (unsigned long) &cxacru_cb00
1215         },
1216         { /* V = Netopia                        P = Cayman 3341(Annex A)/3351(Annex B)  */
1217                 USB_DEVICE(0x100d, 0xcb01),     .driver_info = (unsigned long) &cxacru_cb00
1218         },
1219         { /* V = Netopia                        P = Cayman 3342(Annex A)/3352(Annex B)  */
1220                 USB_DEVICE(0x100d, 0x3342),     .driver_info = (unsigned long) &cxacru_cb00
1221         },
1222         {}
1223 };
1224
1225 MODULE_DEVICE_TABLE(usb, cxacru_usb_ids);
1226
1227 static struct usbatm_driver cxacru_driver = {
1228         .driver_name    = cxacru_driver_name,
1229         .bind           = cxacru_bind,
1230         .heavy_init     = cxacru_heavy_init,
1231         .unbind         = cxacru_unbind,
1232         .atm_start      = cxacru_atm_start,
1233         .atm_stop       = cxacru_remove_device_files,
1234         .bulk_in        = CXACRU_EP_DATA,
1235         .bulk_out       = CXACRU_EP_DATA,
1236         .rx_padding     = 3,
1237         .tx_padding     = 11,
1238 };
1239
1240 static int cxacru_usb_probe(struct usb_interface *intf, const struct usb_device_id *id)
1241 {
1242         return usbatm_usb_probe(intf, id, &cxacru_driver);
1243 }
1244
1245 static struct usb_driver cxacru_usb_driver = {
1246         .name           = cxacru_driver_name,
1247         .probe          = cxacru_usb_probe,
1248         .disconnect     = usbatm_usb_disconnect,
1249         .id_table       = cxacru_usb_ids
1250 };
1251
1252 static int __init cxacru_init(void)
1253 {
1254         return usb_register(&cxacru_usb_driver);
1255 }
1256
1257 static void __exit cxacru_cleanup(void)
1258 {
1259         usb_deregister(&cxacru_usb_driver);
1260 }
1261
1262 module_init(cxacru_init);
1263 module_exit(cxacru_cleanup);
1264
1265 MODULE_AUTHOR(DRIVER_AUTHOR);
1266 MODULE_DESCRIPTION(DRIVER_DESC);
1267 MODULE_LICENSE("GPL");
1268 MODULE_VERSION(DRIVER_VERSION);