2 * Intel & MS High Precision Event Timer Implementation.
4 * Copyright (C) 2003 Intel Corporation
6 * (c) Copyright 2004 Hewlett-Packard Development Company, L.P.
7 * Bob Picco <robert.picco@hp.com>
9 * This program is free software; you can redistribute it and/or modify
10 * it under the terms of the GNU General Public License version 2 as
11 * published by the Free Software Foundation.
14 #include <linux/config.h>
15 #include <linux/interrupt.h>
16 #include <linux/module.h>
17 #include <linux/kernel.h>
18 #include <linux/types.h>
19 #include <linux/miscdevice.h>
20 #include <linux/major.h>
21 #include <linux/ioport.h>
22 #include <linux/fcntl.h>
23 #include <linux/init.h>
24 #include <linux/poll.h>
25 #include <linux/proc_fs.h>
26 #include <linux/spinlock.h>
27 #include <linux/sysctl.h>
28 #include <linux/wait.h>
29 #include <linux/bcd.h>
30 #include <linux/seq_file.h>
31 #include <linux/bitops.h>
33 #include <asm/current.h>
34 #include <asm/uaccess.h>
35 #include <asm/system.h>
38 #include <asm/div64.h>
40 #include <linux/acpi.h>
41 #include <acpi/acpi_bus.h>
42 #include <linux/hpet.h>
45 * The High Precision Event Timer driver.
46 * This driver is closely modelled after the rtc.c driver.
47 * http://www.intel.com/labs/platcomp/hpet/hpetspec.htm
49 #define HPET_USER_FREQ (64)
50 #define HPET_DRIFT (500)
52 static u32 hpet_ntimer, hpet_nhpet, hpet_max_freq = HPET_USER_FREQ;
54 /* A lock for concurrent access by app and isr hpet activity. */
55 static DEFINE_SPINLOCK(hpet_lock);
56 /* A lock for concurrent intermodule access to hpet and isr hpet activity. */
57 static DEFINE_SPINLOCK(hpet_task_lock);
59 #define HPET_DEV_NAME (7)
62 struct hpets *hd_hpets;
63 struct hpet __iomem *hd_hpet;
64 struct hpet_timer __iomem *hd_timer;
65 unsigned long hd_ireqfreq;
66 unsigned long hd_irqdata;
67 wait_queue_head_t hd_waitqueue;
68 struct fasync_struct *hd_async_queue;
69 struct hpet_task *hd_task;
70 unsigned int hd_flags;
72 unsigned int hd_hdwirq;
73 char hd_name[HPET_DEV_NAME];
77 struct hpets *hp_next;
78 struct hpet __iomem *hp_hpet;
79 unsigned long hp_hpet_phys;
80 struct time_interpolator *hp_interpolator;
81 unsigned long hp_period;
82 unsigned long hp_delta;
83 unsigned int hp_ntimer;
84 unsigned int hp_which;
85 struct hpet_dev hp_dev[1];
88 static struct hpets *hpets;
90 #define HPET_OPEN 0x0001
91 #define HPET_IE 0x0002 /* interrupt enabled */
92 #define HPET_PERIODIC 0x0004
94 #if BITS_PER_LONG == 64
95 #define write_counter(V, MC) writeq(V, MC)
96 #define read_counter(MC) readq(MC)
98 #define write_counter(V, MC) writel(V, MC)
99 #define read_counter(MC) readl(MC)
103 static unsigned long long __inline readq(void __iomem *addr)
105 return readl(addr) | (((unsigned long long)readl(addr + 4)) << 32LL);
110 static void __inline writeq(unsigned long long v, void __iomem *addr)
112 writel(v & 0xffffffff, addr);
113 writel(v >> 32, addr + 4);
117 static irqreturn_t hpet_interrupt(int irq, void *data, struct pt_regs *regs)
119 struct hpet_dev *devp;
124 spin_lock(&hpet_lock);
128 * For non-periodic timers, increment the accumulator.
129 * This has the effect of treating non-periodic like periodic.
131 if ((devp->hd_flags & (HPET_IE | HPET_PERIODIC)) == HPET_IE) {
134 t = devp->hd_ireqfreq;
135 m = read_counter(&devp->hd_hpet->hpet_mc);
136 write_counter(t + m + devp->hd_hpets->hp_delta,
137 &devp->hd_timer->hpet_compare);
140 isr = (1 << (devp - devp->hd_hpets->hp_dev));
141 writeq(isr, &devp->hd_hpet->hpet_isr);
142 spin_unlock(&hpet_lock);
144 spin_lock(&hpet_task_lock);
146 devp->hd_task->ht_func(devp->hd_task->ht_data);
147 spin_unlock(&hpet_task_lock);
149 wake_up_interruptible(&devp->hd_waitqueue);
151 kill_fasync(&devp->hd_async_queue, SIGIO, POLL_IN);
156 static int hpet_open(struct inode *inode, struct file *file)
158 struct hpet_dev *devp;
162 if (file->f_mode & FMODE_WRITE)
165 spin_lock_irq(&hpet_lock);
167 for (devp = NULL, hpetp = hpets; hpetp && !devp; hpetp = hpetp->hp_next)
168 for (i = 0; i < hpetp->hp_ntimer; i++)
169 if (hpetp->hp_dev[i].hd_flags & HPET_OPEN
170 || hpetp->hp_dev[i].hd_task)
173 devp = &hpetp->hp_dev[i];
178 spin_unlock_irq(&hpet_lock);
182 file->private_data = devp;
183 devp->hd_irqdata = 0;
184 devp->hd_flags |= HPET_OPEN;
185 spin_unlock_irq(&hpet_lock);
191 hpet_read(struct file *file, char __user *buf, size_t count, loff_t * ppos)
193 DECLARE_WAITQUEUE(wait, current);
196 struct hpet_dev *devp;
198 devp = file->private_data;
199 if (!devp->hd_ireqfreq)
202 if (count < sizeof(unsigned long))
205 add_wait_queue(&devp->hd_waitqueue, &wait);
208 set_current_state(TASK_INTERRUPTIBLE);
210 spin_lock_irq(&hpet_lock);
211 data = devp->hd_irqdata;
212 devp->hd_irqdata = 0;
213 spin_unlock_irq(&hpet_lock);
217 else if (file->f_flags & O_NONBLOCK) {
220 } else if (signal_pending(current)) {
221 retval = -ERESTARTSYS;
227 retval = put_user(data, (unsigned long __user *)buf);
229 retval = sizeof(unsigned long);
231 __set_current_state(TASK_RUNNING);
232 remove_wait_queue(&devp->hd_waitqueue, &wait);
237 static unsigned int hpet_poll(struct file *file, poll_table * wait)
240 struct hpet_dev *devp;
242 devp = file->private_data;
244 if (!devp->hd_ireqfreq)
247 poll_wait(file, &devp->hd_waitqueue, wait);
249 spin_lock_irq(&hpet_lock);
250 v = devp->hd_irqdata;
251 spin_unlock_irq(&hpet_lock);
254 return POLLIN | POLLRDNORM;
259 static int hpet_mmap(struct file *file, struct vm_area_struct *vma)
261 #ifdef CONFIG_HPET_MMAP
262 struct hpet_dev *devp;
265 if (((vma->vm_end - vma->vm_start) != PAGE_SIZE) || vma->vm_pgoff)
268 devp = file->private_data;
269 addr = devp->hd_hpets->hp_hpet_phys;
271 if (addr & (PAGE_SIZE - 1))
274 vma->vm_flags |= VM_IO;
275 vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot);
278 if (io_remap_pfn_range(vma, vma->vm_start, addr >> PAGE_SHIFT,
279 PAGE_SIZE, vma->vm_page_prot)) {
280 printk(KERN_ERR "remap_pfn_range failed in hpet.c\n");
290 static int hpet_fasync(int fd, struct file *file, int on)
292 struct hpet_dev *devp;
294 devp = file->private_data;
296 if (fasync_helper(fd, file, on, &devp->hd_async_queue) >= 0)
302 static int hpet_release(struct inode *inode, struct file *file)
304 struct hpet_dev *devp;
305 struct hpet_timer __iomem *timer;
308 devp = file->private_data;
309 timer = devp->hd_timer;
311 spin_lock_irq(&hpet_lock);
313 writeq((readq(&timer->hpet_config) & ~Tn_INT_ENB_CNF_MASK),
314 &timer->hpet_config);
319 devp->hd_ireqfreq = 0;
321 if (devp->hd_flags & HPET_PERIODIC
322 && readq(&timer->hpet_config) & Tn_TYPE_CNF_MASK) {
325 v = readq(&timer->hpet_config);
326 v ^= Tn_TYPE_CNF_MASK;
327 writeq(v, &timer->hpet_config);
330 devp->hd_flags &= ~(HPET_OPEN | HPET_IE | HPET_PERIODIC);
331 spin_unlock_irq(&hpet_lock);
336 if (file->f_flags & FASYNC)
337 hpet_fasync(-1, file, 0);
339 file->private_data = NULL;
343 static int hpet_ioctl_common(struct hpet_dev *, int, unsigned long, int);
346 hpet_ioctl(struct inode *inode, struct file *file, unsigned int cmd,
349 struct hpet_dev *devp;
351 devp = file->private_data;
352 return hpet_ioctl_common(devp, cmd, arg, 0);
355 static int hpet_ioctl_ieon(struct hpet_dev *devp)
357 struct hpet_timer __iomem *timer;
358 struct hpet __iomem *hpet;
361 unsigned long g, v, t, m;
362 unsigned long flags, isr;
364 timer = devp->hd_timer;
365 hpet = devp->hd_hpet;
366 hpetp = devp->hd_hpets;
368 v = readq(&timer->hpet_config);
369 spin_lock_irq(&hpet_lock);
371 if (devp->hd_flags & HPET_IE) {
372 spin_unlock_irq(&hpet_lock);
376 devp->hd_flags |= HPET_IE;
377 spin_unlock_irq(&hpet_lock);
379 t = readq(&timer->hpet_config);
380 irq = devp->hd_hdwirq;
383 sprintf(devp->hd_name, "hpet%d", (int)(devp - hpetp->hp_dev));
386 (irq, hpet_interrupt, SA_INTERRUPT, devp->hd_name, (void *)devp)) {
387 printk(KERN_ERR "hpet: IRQ %d is not free\n", irq);
393 spin_lock_irq(&hpet_lock);
394 devp->hd_flags ^= HPET_IE;
395 spin_unlock_irq(&hpet_lock);
400 t = devp->hd_ireqfreq;
401 v = readq(&timer->hpet_config);
402 g = v | Tn_INT_ENB_CNF_MASK;
404 if (devp->hd_flags & HPET_PERIODIC) {
405 write_counter(t, &timer->hpet_compare);
406 g |= Tn_TYPE_CNF_MASK;
407 v |= Tn_TYPE_CNF_MASK;
408 writeq(v, &timer->hpet_config);
409 v |= Tn_VAL_SET_CNF_MASK;
410 writeq(v, &timer->hpet_config);
411 local_irq_save(flags);
412 m = read_counter(&hpet->hpet_mc);
413 write_counter(t + m + hpetp->hp_delta, &timer->hpet_compare);
415 local_irq_save(flags);
416 m = read_counter(&hpet->hpet_mc);
417 write_counter(t + m + hpetp->hp_delta, &timer->hpet_compare);
420 isr = (1 << (devp - hpets->hp_dev));
421 writeq(isr, &hpet->hpet_isr);
422 writeq(g, &timer->hpet_config);
423 local_irq_restore(flags);
428 static inline unsigned long hpet_time_div(unsigned long dis)
430 unsigned long long m = 1000000000000000ULL;
434 return (unsigned long)m;
438 hpet_ioctl_common(struct hpet_dev *devp, int cmd, unsigned long arg, int kernel)
440 struct hpet_timer __iomem *timer;
441 struct hpet __iomem *hpet;
452 timer = devp->hd_timer;
453 hpet = devp->hd_hpet;
454 hpetp = devp->hd_hpets;
457 return hpet_ioctl_ieon(devp);
466 if ((devp->hd_flags & HPET_IE) == 0)
468 v = readq(&timer->hpet_config);
469 v &= ~Tn_INT_ENB_CNF_MASK;
470 writeq(v, &timer->hpet_config);
472 free_irq(devp->hd_irq, devp);
475 devp->hd_flags ^= HPET_IE;
479 struct hpet_info info;
481 info.hi_ireqfreq = hpet_time_div(hpetp->hp_period *
484 readq(&timer->hpet_config) & Tn_PER_INT_CAP_MASK;
485 info.hi_hpet = devp->hd_hpets->hp_which;
486 info.hi_timer = devp - devp->hd_hpets->hp_dev;
487 if (copy_to_user((void __user *)arg, &info, sizeof(info)))
492 v = readq(&timer->hpet_config);
493 if ((v & Tn_PER_INT_CAP_MASK) == 0) {
497 devp->hd_flags |= HPET_PERIODIC;
500 v = readq(&timer->hpet_config);
501 if ((v & Tn_PER_INT_CAP_MASK) == 0) {
505 if (devp->hd_flags & HPET_PERIODIC &&
506 readq(&timer->hpet_config) & Tn_TYPE_CNF_MASK) {
507 v = readq(&timer->hpet_config);
508 v ^= Tn_TYPE_CNF_MASK;
509 writeq(v, &timer->hpet_config);
511 devp->hd_flags &= ~HPET_PERIODIC;
514 if (!kernel && (arg > hpet_max_freq) &&
515 !capable(CAP_SYS_RESOURCE)) {
520 if (arg & (arg - 1)) {
525 devp->hd_ireqfreq = hpet_time_div(hpetp->hp_period * arg);
531 static struct file_operations hpet_fops = {
532 .owner = THIS_MODULE,
538 .release = hpet_release,
539 .fasync = hpet_fasync,
543 EXPORT_SYMBOL(hpet_alloc);
544 EXPORT_SYMBOL(hpet_register);
545 EXPORT_SYMBOL(hpet_unregister);
546 EXPORT_SYMBOL(hpet_control);
548 int hpet_register(struct hpet_task *tp, int periodic)
552 struct hpet_timer __iomem *timer;
553 struct hpet_dev *devp;
558 mask = Tn_PER_INT_CAP_MASK;
567 spin_lock_irq(&hpet_task_lock);
568 spin_lock(&hpet_lock);
570 for (devp = NULL, hpetp = hpets; hpetp && !devp; hpetp = hpetp->hp_next)
571 for (timer = hpetp->hp_hpet->hpet_timers, i = 0;
572 i < hpetp->hp_ntimer; i++, timer++) {
573 if ((readq(&timer->hpet_config) & Tn_PER_INT_CAP_MASK)
577 devp = &hpetp->hp_dev[i];
579 if (devp->hd_flags & HPET_OPEN || devp->hd_task) {
584 tp->ht_opaque = devp;
589 spin_unlock(&hpet_lock);
590 spin_unlock_irq(&hpet_task_lock);
598 static inline int hpet_tpcheck(struct hpet_task *tp)
600 struct hpet_dev *devp;
603 devp = tp->ht_opaque;
608 for (hpetp = hpets; hpetp; hpetp = hpetp->hp_next)
609 if (devp >= hpetp->hp_dev
610 && devp < (hpetp->hp_dev + hpetp->hp_ntimer)
611 && devp->hd_hpet == hpetp->hp_hpet)
617 int hpet_unregister(struct hpet_task *tp)
619 struct hpet_dev *devp;
620 struct hpet_timer __iomem *timer;
623 if ((err = hpet_tpcheck(tp)))
626 spin_lock_irq(&hpet_task_lock);
627 spin_lock(&hpet_lock);
629 devp = tp->ht_opaque;
630 if (devp->hd_task != tp) {
631 spin_unlock(&hpet_lock);
632 spin_unlock_irq(&hpet_task_lock);
636 timer = devp->hd_timer;
637 writeq((readq(&timer->hpet_config) & ~Tn_INT_ENB_CNF_MASK),
638 &timer->hpet_config);
639 devp->hd_flags &= ~(HPET_IE | HPET_PERIODIC);
640 devp->hd_task = NULL;
641 spin_unlock(&hpet_lock);
642 spin_unlock_irq(&hpet_task_lock);
647 int hpet_control(struct hpet_task *tp, unsigned int cmd, unsigned long arg)
649 struct hpet_dev *devp;
652 if ((err = hpet_tpcheck(tp)))
655 spin_lock_irq(&hpet_lock);
656 devp = tp->ht_opaque;
657 if (devp->hd_task != tp) {
658 spin_unlock_irq(&hpet_lock);
661 spin_unlock_irq(&hpet_lock);
662 return hpet_ioctl_common(devp, cmd, arg, 1);
665 static ctl_table hpet_table[] = {
668 .procname = "max-user-freq",
669 .data = &hpet_max_freq,
670 .maxlen = sizeof(int),
672 .proc_handler = &proc_dointvec,
677 static ctl_table hpet_root[] = {
688 static ctl_table dev_root[] = {
699 static struct ctl_table_header *sysctl_header;
701 static void hpet_register_interpolator(struct hpets *hpetp)
703 #ifdef CONFIG_TIME_INTERPOLATION
704 struct time_interpolator *ti;
706 ti = kmalloc(sizeof(*ti), GFP_KERNEL);
710 memset(ti, 0, sizeof(*ti));
711 ti->source = TIME_SOURCE_MMIO64;
713 ti->addr = &hpetp->hp_hpet->hpet_mc;
714 ti->frequency = hpet_time_div(hpets->hp_period);
715 ti->drift = ti->frequency * HPET_DRIFT / 1000000;
718 hpetp->hp_interpolator = ti;
719 register_time_interpolator(ti);
724 * Adjustment for when arming the timer with
725 * initial conditions. That is, main counter
726 * ticks expired before interrupts are enabled.
728 #define TICK_CALIBRATE (1000UL)
730 static unsigned long hpet_calibrate(struct hpets *hpetp)
732 struct hpet_timer __iomem *timer = NULL;
733 unsigned long t, m, count, i, flags, start;
734 struct hpet_dev *devp;
736 struct hpet __iomem *hpet;
738 for (j = 0, devp = hpetp->hp_dev; j < hpetp->hp_ntimer; j++, devp++)
739 if ((devp->hd_flags & HPET_OPEN) == 0) {
740 timer = devp->hd_timer;
747 hpet = hpets->hp_hpet;
748 t = read_counter(&timer->hpet_compare);
751 count = hpet_time_div(hpetp->hp_period * TICK_CALIBRATE);
753 local_irq_save(flags);
755 start = read_counter(&hpet->hpet_mc);
758 m = read_counter(&hpet->hpet_mc);
759 write_counter(t + m + hpetp->hp_delta, &timer->hpet_compare);
760 } while (i++, (m - start) < count);
762 local_irq_restore(flags);
764 return (m - start) / i;
767 int hpet_alloc(struct hpet_data *hdp)
770 struct hpet_dev *devp;
774 struct hpet __iomem *hpet;
775 static struct hpets *last = (struct hpets *)0;
779 * hpet_alloc can be called by platform dependent code.
780 * if platform dependent code has allocated the hpet
781 * ACPI also reports hpet, then we catch it here.
783 for (hpetp = hpets; hpetp; hpetp = hpetp->hp_next)
784 if (hpetp->hp_hpet == hdp->hd_address)
787 siz = sizeof(struct hpets) + ((hdp->hd_nirqs - 1) *
788 sizeof(struct hpet_dev));
790 hpetp = kmalloc(siz, GFP_KERNEL);
795 memset(hpetp, 0, siz);
797 hpetp->hp_which = hpet_nhpet++;
798 hpetp->hp_hpet = hdp->hd_address;
799 hpetp->hp_hpet_phys = hdp->hd_phys_address;
801 hpetp->hp_ntimer = hdp->hd_nirqs;
803 for (i = 0; i < hdp->hd_nirqs; i++)
804 hpetp->hp_dev[i].hd_hdwirq = hdp->hd_irq[i];
806 hpet = hpetp->hp_hpet;
808 cap = readq(&hpet->hpet_cap);
810 ntimer = ((cap & HPET_NUM_TIM_CAP_MASK) >> HPET_NUM_TIM_CAP_SHIFT) + 1;
812 if (hpetp->hp_ntimer != ntimer) {
813 printk(KERN_WARNING "hpet: number irqs doesn't agree"
814 " with number of timers\n");
820 last->hp_next = hpetp;
826 hpetp->hp_period = (cap & HPET_COUNTER_CLK_PERIOD_MASK) >>
827 HPET_COUNTER_CLK_PERIOD_SHIFT;
829 printk(KERN_INFO "hpet%d: at MMIO 0x%lx, IRQ%s",
830 hpetp->hp_which, hdp->hd_phys_address,
831 hpetp->hp_ntimer > 1 ? "s" : "");
832 for (i = 0; i < hpetp->hp_ntimer; i++)
833 printk("%s %d", i > 0 ? "," : "", hdp->hd_irq[i]);
836 ns = hpetp->hp_period; /* femptoseconds, 10^-15 */
837 ns /= 1000000; /* convert to nanoseconds, 10^-9 */
838 printk(KERN_INFO "hpet%d: %ldns tick, %d %d-bit timers\n",
839 hpetp->hp_which, ns, hpetp->hp_ntimer,
840 cap & HPET_COUNTER_SIZE_MASK ? 64 : 32);
842 mcfg = readq(&hpet->hpet_config);
843 if ((mcfg & HPET_ENABLE_CNF_MASK) == 0) {
844 write_counter(0L, &hpet->hpet_mc);
845 mcfg |= HPET_ENABLE_CNF_MASK;
846 writeq(mcfg, &hpet->hpet_config);
849 for (i = 0, devp = hpetp->hp_dev; i < hpetp->hp_ntimer;
850 i++, hpet_ntimer++, devp++) {
852 struct hpet_timer __iomem *timer;
854 timer = &hpet->hpet_timers[devp - hpetp->hp_dev];
855 v = readq(&timer->hpet_config);
857 devp->hd_hpets = hpetp;
858 devp->hd_hpet = hpet;
859 devp->hd_timer = timer;
862 * If the timer was reserved by platform code,
863 * then make timer unavailable for opens.
865 if (hdp->hd_state & (1 << i)) {
866 devp->hd_flags = HPET_OPEN;
870 init_waitqueue_head(&devp->hd_waitqueue);
873 hpetp->hp_delta = hpet_calibrate(hpetp);
874 hpet_register_interpolator(hpetp);
879 static acpi_status hpet_resources(struct acpi_resource *res, void *data)
881 struct hpet_data *hdp;
883 struct acpi_resource_address64 addr;
888 status = acpi_resource_to_address64(res, &addr);
890 if (ACPI_SUCCESS(status)) {
893 size = addr.max_address_range - addr.min_address_range + 1;
894 hdp->hd_phys_address = addr.min_address_range;
895 hdp->hd_address = ioremap(addr.min_address_range, size);
897 for (hpetp = hpets; hpetp; hpetp = hpetp->hp_next)
898 if (hpetp->hp_hpet == hdp->hd_address)
900 } else if (res->id == ACPI_RSTYPE_EXT_IRQ) {
901 struct acpi_resource_ext_irq *irqp;
904 irqp = &res->data.extended_irq;
906 if (irqp->number_of_interrupts > 0) {
907 hdp->hd_nirqs = irqp->number_of_interrupts;
909 for (i = 0; i < hdp->hd_nirqs; i++)
911 acpi_register_gsi(irqp->interrupts[i],
913 irqp->active_high_low);
920 static int hpet_acpi_add(struct acpi_device *device)
923 struct hpet_data data;
925 memset(&data, 0, sizeof(data));
928 acpi_walk_resources(device->handle, METHOD_NAME__CRS,
929 hpet_resources, &data);
931 if (ACPI_FAILURE(result))
934 if (!data.hd_address || !data.hd_nirqs) {
935 printk("%s: no address or irqs in _CRS\n", __FUNCTION__);
939 return hpet_alloc(&data);
942 static int hpet_acpi_remove(struct acpi_device *device, int type)
944 /* XXX need to unregister interpolator, dealloc mem, etc */
948 static struct acpi_driver hpet_acpi_driver = {
952 .add = hpet_acpi_add,
953 .remove = hpet_acpi_remove,
957 static struct miscdevice hpet_misc = { HPET_MINOR, "hpet", &hpet_fops };
959 static int __init hpet_init(void)
963 result = misc_register(&hpet_misc);
967 sysctl_header = register_sysctl_table(dev_root, 0);
969 result = acpi_bus_register_driver(&hpet_acpi_driver);
972 unregister_sysctl_table(sysctl_header);
973 misc_deregister(&hpet_misc);
980 static void __exit hpet_exit(void)
982 acpi_bus_unregister_driver(&hpet_acpi_driver);
985 unregister_sysctl_table(sysctl_header);
986 misc_deregister(&hpet_misc);
991 module_init(hpet_init);
992 module_exit(hpet_exit);
993 MODULE_AUTHOR("Bob Picco <Robert.Picco@hp.com>");
994 MODULE_LICENSE("GPL");