git.oblomov.eu Git - linux-2.6/blob - drivers/media/video/msp3400-driver.c

   1 /*
   2  * Programming the mspx4xx sound processor family
   3  *
   4  * (c) 1997-2001 Gerd Knorr <kraxel@bytesex.org>
   5  *
   6  * what works and what doesn't:
   7  *
   8  *  AM-Mono
   9  *      Support for Hauppauge cards added (decoding handled by tuner) added by
  10  *      Frederic Crozat <fcrozat@mail.dotcom.fr>
  11  *
  12  *  FM-Mono
  13  *      should work. The stereo modes are backward compatible to FM-mono,
  14  *      therefore FM-Mono should be allways available.
  15  *
  16  *  FM-Stereo (B/G, used in germany)
  17  *      should work, with autodetect
  18  *
  19  *  FM-Stereo (satellite)
  20  *      should work, no autodetect (i.e. default is mono, but you can
  21  *      switch to stereo -- untested)
  22  *
  23  *  NICAM (B/G, L , used in UK, Scandinavia, Spain and France)
  24  *      should work, with autodetect. Support for NICAM was added by
  25  *      Pekka Pietikainen <pp@netppl.fi>
  26  *
  27  * TODO:
  28  *   - better SAT support
  29  *
  30  * 980623  Thomas Sailer (sailer@ife.ee.ethz.ch)
  31  *         using soundcore instead of OSS
  32  *
  33  * This program is free software; you can redistribute it and/or
  34  * modify it under the terms of the GNU General Public License
  35  * as published by the Free Software Foundation; either version 2
  36  * of the License, or (at your option) any later version.
  37  *
  38  * This program is distributed in the hope that it will be useful,
  39  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  40  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  41  * GNU General Public License for more details.
  42  *
  43  * You should have received a copy of the GNU General Public License
  44  * along with this program; if not, write to the Free Software
  45  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
  46  */
  47
  48
  49 #include <linux/kernel.h>
  50 #include <linux/module.h>
  51 #include <linux/slab.h>
  52 #include <linux/i2c.h>
  53 #include <linux/videodev.h>
  54 #include <linux/videodev2.h>
  55 #include <media/v4l2-common.h>
  56 #include <media/audiochip.h>
  57 #include <linux/kthread.h>
  58 #include <linux/suspend.h>
  59 #include "msp3400.h"
  60
  61 /* ---------------------------------------------------------------------- */
  62
  63 MODULE_DESCRIPTION("device driver for msp34xx TV sound processor");
  64 MODULE_AUTHOR("Gerd Knorr");
  65 MODULE_LICENSE("GPL");
  66
  67 /* module parameters */
  68 static int opmode   = OPMODE_AUTO;
  69 int msp_debug;           /* msp_debug output */
  70 int msp_once;            /* no continous stereo monitoring */
  71 int msp_amsound;         /* hard-wire AM sound at 6.5 Hz (france),
  72                             the autoscan seems work well only with FM... */
  73 int msp_standard = 1;    /* Override auto detect of audio msp_standard, if needed. */
  74 int msp_dolby;
  75
  76 int msp_stereo_thresh = 0x190; /* a2 threshold for stereo/bilingual
  77                                         (msp34xxg only) 0x00a0-0x03c0 */
  78
  79 /* read-only */
  80 module_param(opmode,           int, 0444);
  81
  82 /* read-write */
  83 module_param_named(once,msp_once,                      bool, 0644);
  84 module_param_named(debug,msp_debug,                    int,  0644);
  85 module_param_named(stereo_threshold,msp_stereo_thresh, int,  0644);
  86 module_param_named(standard,msp_standard,              int,  0644);
  87 module_param_named(amsound,msp_amsound,                bool, 0644);
  88 module_param_named(dolby,msp_dolby,                    bool, 0644);
  89
  90 MODULE_PARM_DESC(opmode, "Forces a MSP3400 opmode. 0=Manual, 1=Autodetect, 2=Autodetect and autoselect");
  91 MODULE_PARM_DESC(once, "No continuous stereo monitoring");
  92 MODULE_PARM_DESC(debug, "Enable debug messages [0-3]");
  93 MODULE_PARM_DESC(stereo_threshold, "Sets signal threshold to activate stereo");
  94 MODULE_PARM_DESC(standard, "Specify audio standard: 32 = NTSC, 64 = radio, Default: Autodetect");
  95 MODULE_PARM_DESC(amsound, "Hardwire AM sound at 6.5Hz (France), FM can autoscan");
  96 MODULE_PARM_DESC(dolby, "Activates Dolby processsing");
  97
  98 /* ---------------------------------------------------------------------- */
  99
 100 /* control subaddress */
 101 #define I2C_MSP_CONTROL 0x00
 102 /* demodulator unit subaddress */
 103 #define I2C_MSP_DEM     0x10
 104 /* DSP unit subaddress */
 105 #define I2C_MSP_DSP     0x12
 106
 107 /* Addresses to scan */
 108 static unsigned short normal_i2c[] = { 0x80 >> 1, 0x88 >> 1, I2C_CLIENT_END };
 109 I2C_CLIENT_INSMOD;
 110
 111 /* ----------------------------------------------------------------------- */
 112 /* functions for talking to the MSP3400C Sound processor                   */
 113
 114 int msp_reset(struct i2c_client *client)
 115 {
 116         /* reset and read revision code */
 117         static u8 reset_off[3] = { I2C_MSP_CONTROL, 0x80, 0x00 };
 118         static u8 reset_on[3]  = { I2C_MSP_CONTROL, 0x00, 0x00 };
 119         static u8 write[3]     = { I2C_MSP_DSP + 1, 0x00, 0x1e };
 120         u8 read[2];
 121         struct i2c_msg reset[2] = {
 122                 { client->addr, I2C_M_IGNORE_NAK, 3, reset_off },
 123                 { client->addr, I2C_M_IGNORE_NAK, 3, reset_on  },
 124         };
 125         struct i2c_msg test[2] = {
 126                 { client->addr, 0,        3, write },
 127                 { client->addr, I2C_M_RD, 2, read  },
 128         };
 129
 130         v4l_dbg(3, msp_debug, client, "msp_reset\n");
 131         if (i2c_transfer(client->adapter, &reset[0], 1) != 1 ||
 132             i2c_transfer(client->adapter, &reset[1], 1) != 1 ||
 133             i2c_transfer(client->adapter, test, 2) != 2) {
 134                 v4l_err(client, "chip reset failed\n");
 135                 return -1;
 136         }
 137         return 0;
 138 }
 139
 140 static int msp_read(struct i2c_client *client, int dev, int addr)
 141 {
 142         int err, retval;
 143         u8 write[3];
 144         u8 read[2];
 145         struct i2c_msg msgs[2] = {
 146                 { client->addr, 0,        3, write },
 147                 { client->addr, I2C_M_RD, 2, read  }
 148         };
 149
 150         write[0] = dev + 1;
 151         write[1] = addr >> 8;
 152         write[2] = addr & 0xff;
 153
 154         for (err = 0; err < 3; err++) {
 155                 if (i2c_transfer(client->adapter, msgs, 2) == 2)
 156                         break;
 157                 v4l_warn(client, "I/O error #%d (read 0x%02x/0x%02x)\n", err,
 158                        dev, addr);
 159                 current->state = TASK_INTERRUPTIBLE;
 160                 schedule_timeout(msecs_to_jiffies(10));
 161         }
 162         if (err == 3) {
 163                 v4l_warn(client, "giving up, resetting chip. Sound will go off, sorry folks :-|\n");
 164                 msp_reset(client);
 165                 return -1;
 166         }
 167         retval = read[0] << 8 | read[1];
 168         v4l_dbg(3, msp_debug, client, "msp_read(0x%x, 0x%x): 0x%x\n", dev, addr, retval);
 169         return retval;
 170 }
 171
 172 int msp_read_dem(struct i2c_client *client, int addr)
 173 {
 174         return msp_read(client, I2C_MSP_DEM, addr);
 175 }
 176
 177 int msp_read_dsp(struct i2c_client *client, int addr)
 178 {
 179         return msp_read(client, I2C_MSP_DSP, addr);
 180 }
 181
 182 static int msp_write(struct i2c_client *client, int dev, int addr, int val)
 183 {
 184         int err;
 185         u8 buffer[5];
 186
 187         buffer[0] = dev;
 188         buffer[1] = addr >> 8;
 189         buffer[2] = addr &  0xff;
 190         buffer[3] = val  >> 8;
 191         buffer[4] = val  &  0xff;
 192
 193         v4l_dbg(3, msp_debug, client, "msp_write(0x%x, 0x%x, 0x%x)\n", dev, addr, val);
 194         for (err = 0; err < 3; err++) {
 195                 if (i2c_master_send(client, buffer, 5) == 5)
 196                         break;
 197                 v4l_warn(client, "I/O error #%d (write 0x%02x/0x%02x)\n", err,
 198                        dev, addr);
 199                 current->state = TASK_INTERRUPTIBLE;
 200                 schedule_timeout(msecs_to_jiffies(10));
 201         }
 202         if (err == 3) {
 203                 v4l_warn(client, "giving up, resetting chip. Sound will go off, sorry folks :-|\n");
 204                 msp_reset(client);
 205                 return -1;
 206         }
 207         return 0;
 208 }
 209
 210 int msp_write_dem(struct i2c_client *client, int addr, int val)
 211 {
 212         return msp_write(client, I2C_MSP_DEM, addr, val);
 213 }
 214
 215 int msp_write_dsp(struct i2c_client *client, int addr, int val)
 216 {
 217         return msp_write(client, I2C_MSP_DSP, addr, val);
 218 }
 219
 220 /* ----------------------------------------------------------------------- *
 221  * bits  9  8  5 - SCART DSP input Select:
 222  *       0  0  0 - SCART 1 to DSP input (reset position)
 223  *       0  1  0 - MONO to DSP input
 224  *       1  0  0 - SCART 2 to DSP input
 225  *       1  1  1 - Mute DSP input
 226  *
 227  * bits 11 10  6 - SCART 1 Output Select:
 228  *       0  0  0 - undefined (reset position)
 229  *       0  1  0 - SCART 2 Input to SCART 1 Output (for devices with 2 SCARTS)
 230  *       1  0  0 - MONO input to SCART 1 Output
 231  *       1  1  0 - SCART 1 DA to SCART 1 Output
 232  *       0  0  1 - SCART 2 DA to SCART 1 Output
 233  *       0  1  1 - SCART 1 Input to SCART 1 Output
 234  *       1  1  1 - Mute SCART 1 Output
 235  *
 236  * bits 13 12  7 - SCART 2 Output Select (for devices with 2 Output SCART):
 237  *       0  0  0 - SCART 1 DA to SCART 2 Output (reset position)
 238  *       0  1  0 - SCART 1 Input to SCART 2 Output
 239  *       1  0  0 - MONO input to SCART 2 Output
 240  *       0  0  1 - SCART 2 DA to SCART 2 Output
 241  *       0  1  1 - SCART 2 Input to SCART 2 Output
 242  *       1  1  0 - Mute SCART 2 Output
 243  *
 244  * Bits 4 to 0 should be zero.
 245  * ----------------------------------------------------------------------- */
 246
 247 static int scarts[3][9] = {
 248         /* MASK    IN1     IN2     IN1_DA  IN2_DA  IN3     IN4     MONO    MUTE   */
 249         /* SCART DSP Input select */
 250         { 0x0320, 0x0000, 0x0200, -1,     -1,     0x0300, 0x0020, 0x0100, 0x0320 },
 251         /* SCART1 Output select */
 252         { 0x0c40, 0x0440, 0x0400, 0x0c00, 0x0040, 0x0000, 0x0840, 0x0800, 0x0c40 },
 253         /* SCART2 Output select */
 254         { 0x3080, 0x1000, 0x1080, 0x0000, 0x0080, 0x2080, 0x3080, 0x2000, 0x3000 },
 255 };
 256
 257 static char *scart_names[] = {
 258         "mask", "in1", "in2", "in1 da", "in2 da", "in3", "in4", "mono", "mute"
 259 };
 260
 261 void msp_set_scart(struct i2c_client *client, int in, int out)
 262 {
 263         struct msp_state *state = i2c_get_clientdata(client);
 264
 265         state->in_scart=in;
 266
 267         if (in >= 1 && in <= 8 && out >= 0 && out <= 2) {
 268                 if (-1 == scarts[out][in])
 269                         return;
 270
 271                 state->acb &= ~scarts[out][SCART_MASK];
 272                 state->acb |=  scarts[out][in];
 273         } else
 274                 state->acb = 0xf60; /* Mute Input and SCART 1 Output */
 275
 276         v4l_dbg(1, msp_debug, client, "scart switch: %s => %d (ACB=0x%04x)\n",
 277                                                 scart_names[in], out, state->acb);
 278         msp_write_dsp(client, 0x13, state->acb);
 279
 280         /* Sets I2S speed 0 = 1.024 Mbps, 1 = 2.048 Mbps */
 281         msp_write_dem(client, 0x40, state->i2s_mode);
 282 }
 283
 284 void msp_set_mute(struct i2c_client *client)
 285 {
 286         struct msp_state *state = i2c_get_clientdata(client);
 287
 288         v4l_dbg(1, msp_debug, client, "mute audio\n");
 289         msp_write_dsp(client, 0x0000, 0);
 290         msp_write_dsp(client, 0x0007, 1);
 291         if (state->has_scart2_out_volume)
 292                 msp_write_dsp(client, 0x0040, 1);
 293         if (state->has_headphones)
 294                 msp_write_dsp(client, 0x0006, 0);
 295 }
 296
 297 void msp_set_audio(struct i2c_client *client)
 298 {
 299         struct msp_state *state = i2c_get_clientdata(client);
 300         int bal = 0, bass, treble, loudness;
 301         int val = 0;
 302
 303         if (!state->muted)
 304                 val = (state->volume * 0x7f / 65535) << 8;
 305
 306         v4l_dbg(1, msp_debug, client, "mute=%s volume=%d\n",
 307                 state->muted ? "on" : "off", state->volume);
 308
 309         msp_write_dsp(client, 0x0000, val);
 310         msp_write_dsp(client, 0x0007, state->muted ? 0x1 : (val | 0x1));
 311         if (state->has_scart2_out_volume)
 312                 msp_write_dsp(client, 0x0040, state->muted ? 0x1 : (val | 0x1));
 313         if (state->has_headphones)
 314                 msp_write_dsp(client, 0x0006, val);
 315         if (!state->has_sound_processing)
 316                 return;
 317
 318         if (val)
 319                 bal = (u8)((state->balance / 256) - 128);
 320         bass = ((state->bass - 32768) * 0x60 / 65535) << 8;
 321         treble = ((state->treble - 32768) * 0x60 / 65535) << 8;
 322         loudness = state->loudness ? ((5 * 4) << 8) : 0;
 323
 324         v4l_dbg(1, msp_debug, client, "balance=%d bass=%d treble=%d loudness=%d\n",
 325                 state->balance, state->bass, state->treble, state->loudness);
 326
 327         msp_write_dsp(client, 0x0001, bal << 8);
 328         msp_write_dsp(client, 0x0002, bass);
 329         msp_write_dsp(client, 0x0003, treble);
 330         msp_write_dsp(client, 0x0004, loudness);
 331         if (!state->has_headphones)
 332                 return;
 333         msp_write_dsp(client, 0x0030, bal << 8);
 334         msp_write_dsp(client, 0x0031, bass);
 335         msp_write_dsp(client, 0x0032, treble);
 336         msp_write_dsp(client, 0x0033, loudness);
 337 }
 338
 339 int msp_modus(struct i2c_client *client)
 340 {
 341         struct msp_state *state = i2c_get_clientdata(client);
 342
 343         if (state->radio) {
 344                 v4l_dbg(1, msp_debug, client, "video mode selected to Radio\n");
 345                 return 0x0003;
 346         }
 347
 348         if (state->v4l2_std & V4L2_STD_PAL) {
 349                 v4l_dbg(1, msp_debug, client, "video mode selected to PAL\n");
 350
 351 #if 1
 352                 /* experimental: not sure this works with all chip versions */
 353                 return 0x7003;
 354 #else
 355                 /* previous value, try this if it breaks ... */
 356                 return 0x1003;
 357 #endif
 358         }
 359         if (state->v4l2_std & V4L2_STD_NTSC) {
 360                 v4l_dbg(1, msp_debug, client, "video mode selected to NTSC\n");
 361                 return 0x2003;
 362         }
 363         if (state->v4l2_std & V4L2_STD_SECAM) {
 364                 v4l_dbg(1, msp_debug, client, "video mode selected to SECAM\n");
 365                 return 0x0003;
 366         }
 367         return 0x0003;
 368 }
 369
 370 /* ------------------------------------------------------------------------ */
 371
 372
 373 static void msp_wake_thread(struct i2c_client *client)
 374 {
 375         struct msp_state *state = i2c_get_clientdata(client);
 376
 377         if (NULL == state->kthread)
 378                 return;
 379         msp_set_mute(client);
 380         state->watch_stereo = 0;
 381         state->restart = 1;
 382         wake_up_interruptible(&state->wq);
 383 }
 384
 385 int msp_sleep(struct msp_state *state, int timeout)
 386 {
 387         DECLARE_WAITQUEUE(wait, current);
 388
 389         add_wait_queue(&state->wq, &wait);
 390         if (!kthread_should_stop()) {
 391                 if (timeout < 0) {
 392                         set_current_state(TASK_INTERRUPTIBLE);
 393                         schedule();
 394                 } else {
 395                         schedule_timeout_interruptible
 396                                                 (msecs_to_jiffies(timeout));
 397                 }
 398         }
 399
 400         remove_wait_queue(&state->wq, &wait);
 401         try_to_freeze();
 402         return state->restart;
 403 }
 404
 405 /* ------------------------------------------------------------------------ */
 406
 407 static int msp_mode_v4l2_to_v4l1(int rxsubchans)
 408 {
 409         int mode = 0;
 410
 411         if (rxsubchans & V4L2_TUNER_SUB_STEREO)
 412                 mode |= VIDEO_SOUND_STEREO;
 413         if (rxsubchans & V4L2_TUNER_SUB_LANG2)
 414                 mode |= VIDEO_SOUND_LANG2;
 415         if (rxsubchans & V4L2_TUNER_SUB_LANG1)
 416                 mode |= VIDEO_SOUND_LANG1;
 417         if (mode == 0)
 418                 mode |= VIDEO_SOUND_MONO;
 419         return mode;
 420 }
 421
 422 static int msp_mode_v4l1_to_v4l2(int mode)
 423 {
 424         if (mode & VIDEO_SOUND_STEREO)
 425                 return V4L2_TUNER_MODE_STEREO;
 426         if (mode & VIDEO_SOUND_LANG2)
 427                 return V4L2_TUNER_MODE_LANG2;
 428         if (mode & VIDEO_SOUND_LANG1)
 429                 return V4L2_TUNER_MODE_LANG1;
 430         return V4L2_TUNER_MODE_MONO;
 431 }
 432
 433 static void msp_any_detect_stereo(struct i2c_client *client)
 434 {
 435         struct msp_state *state  = i2c_get_clientdata(client);
 436
 437         switch (state->opmode) {
 438         case OPMODE_MANUAL:
 439         case OPMODE_AUTODETECT:
 440                 autodetect_stereo(client);
 441                 break;
 442         case OPMODE_AUTOSELECT:
 443                 msp34xxg_detect_stereo(client);
 444                 break;
 445         }
 446 }
 447
 448 static struct v4l2_queryctrl msp_qctrl_std[] = {
 449         {
 450                 .id            = V4L2_CID_AUDIO_VOLUME,
 451                 .name          = "Volume",
 452                 .minimum       = 0,
 453                 .maximum       = 65535,
 454                 .step          = 65535/100,
 455                 .default_value = 58880,
 456                 .flags         = 0,
 457                 .type          = V4L2_CTRL_TYPE_INTEGER,
 458         },{
 459                 .id            = V4L2_CID_AUDIO_MUTE,
 460                 .name          = "Mute",
 461                 .minimum       = 0,
 462                 .maximum       = 1,
 463                 .step          = 1,
 464                 .default_value = 1,
 465                 .flags         = 0,
 466                 .type          = V4L2_CTRL_TYPE_BOOLEAN,
 467         },
 468 };
 469
 470 static struct v4l2_queryctrl msp_qctrl_sound_processing[] = {
 471         {
 472                 .id            = V4L2_CID_AUDIO_BALANCE,
 473                 .name          = "Balance",
 474                 .minimum       = 0,
 475                 .maximum       = 65535,
 476                 .step          = 65535/100,
 477                 .default_value = 32768,
 478                 .flags         = 0,
 479                 .type          = V4L2_CTRL_TYPE_INTEGER,
 480         },{
 481                 .id            = V4L2_CID_AUDIO_BASS,
 482                 .name          = "Bass",
 483                 .minimum       = 0,
 484                 .maximum       = 65535,
 485                 .step          = 65535/100,
 486                 .default_value = 32768,
 487                 .type          = V4L2_CTRL_TYPE_INTEGER,
 488         },{
 489                 .id            = V4L2_CID_AUDIO_TREBLE,
 490                 .name          = "Treble",
 491                 .minimum       = 0,
 492                 .maximum       = 65535,
 493                 .step          = 65535/100,
 494                 .default_value = 32768,
 495                 .type          = V4L2_CTRL_TYPE_INTEGER,
 496         },{
 497                 .id            = V4L2_CID_AUDIO_LOUDNESS,
 498                 .name          = "Loudness",
 499                 .minimum       = 0,
 500                 .maximum       = 1,
 501                 .step          = 1,
 502                 .default_value = 1,
 503                 .flags         = 0,
 504                 .type          = V4L2_CTRL_TYPE_BOOLEAN,
 505         },
 506 };
 507
 508
 509 static void msp_any_set_audmode(struct i2c_client *client, int audmode)
 510 {
 511         struct msp_state *state = i2c_get_clientdata(client);
 512
 513         switch (state->opmode) {
 514         case OPMODE_MANUAL:
 515         case OPMODE_AUTODETECT:
 516                 state->watch_stereo = 0;
 517                 msp3400c_setstereo(client, audmode);
 518                 break;
 519         case OPMODE_AUTOSELECT:
 520                 msp34xxg_set_audmode(client, audmode);
 521                 break;
 522         }
 523 }
 524
 525 static int msp_get_ctrl(struct i2c_client *client, struct v4l2_control *ctrl)
 526 {
 527         struct msp_state *state = i2c_get_clientdata(client);
 528
 529         switch (ctrl->id) {
 530         case V4L2_CID_AUDIO_VOLUME:
 531                 ctrl->value = state->volume;
 532                 break;
 533
 534         case V4L2_CID_AUDIO_MUTE:
 535                 ctrl->value = state->muted;
 536                 break;
 537
 538         case V4L2_CID_AUDIO_BALANCE:
 539                 if (!state->has_sound_processing)
 540                         return -EINVAL;
 541                 ctrl->value = state->balance;
 542                 break;
 543
 544         case V4L2_CID_AUDIO_BASS:
 545                 if (!state->has_sound_processing)
 546                         return -EINVAL;
 547                 ctrl->value = state->bass;
 548                 break;
 549
 550         case V4L2_CID_AUDIO_TREBLE:
 551                 if (!state->has_sound_processing)
 552                         return -EINVAL;
 553                 ctrl->value = state->treble;
 554                 break;
 555
 556         case V4L2_CID_AUDIO_LOUDNESS:
 557                 if (!state->has_sound_processing)
 558                         return -EINVAL;
 559                 ctrl->value = state->loudness;
 560                 break;
 561
 562         default:
 563                 return -EINVAL;
 564         }
 565         return 0;
 566 }
 567
 568 static int msp_set_ctrl(struct i2c_client *client, struct v4l2_control *ctrl)
 569 {
 570         struct msp_state *state = i2c_get_clientdata(client);
 571
 572         switch (ctrl->id) {
 573         case V4L2_CID_AUDIO_VOLUME:
 574                 state->volume = ctrl->value;
 575                 if (state->volume == 0)
 576                         state->balance = 32768;
 577                 break;
 578
 579         case V4L2_CID_AUDIO_MUTE:
 580                 if (ctrl->value < 0 || ctrl->value >= 2)
 581                         return -ERANGE;
 582                 state->muted = ctrl->value;
 583                 break;
 584
 585         case V4L2_CID_AUDIO_BASS:
 586                 if (!state->has_sound_processing)
 587                         return -EINVAL;
 588                 state->bass = ctrl->value;
 589                 break;
 590
 591         case V4L2_CID_AUDIO_TREBLE:
 592                 if (!state->has_sound_processing)
 593                         return -EINVAL;
 594                 state->treble = ctrl->value;
 595                 break;
 596
 597         case V4L2_CID_AUDIO_LOUDNESS:
 598                 if (!state->has_sound_processing)
 599                         return -EINVAL;
 600                 state->loudness = ctrl->value;
 601                 break;
 602
 603         case V4L2_CID_AUDIO_BALANCE:
 604                 if (!state->has_sound_processing)
 605                         return -EINVAL;
 606                 state->balance = ctrl->value;
 607                 break;
 608
 609         default:
 610                 return -EINVAL;
 611         }
 612         msp_set_audio(client);
 613         return 0;
 614 }
 615
 616 static int msp_command(struct i2c_client *client, unsigned int cmd, void *arg)
 617 {
 618         struct msp_state *state = i2c_get_clientdata(client);
 619         u16 *sarg = arg;
 620         int scart = 0;
 621
 622         if (msp_debug >= 2)
 623                 v4l_i2c_print_ioctl(client, cmd);
 624
 625         switch (cmd) {
 626         case AUDC_SET_INPUT:
 627                 if (*sarg == state->input)
 628                         break;
 629                 state->input = *sarg;
 630                 switch (*sarg) {
 631                 case AUDIO_RADIO:
 632                         /* Hauppauge uses IN2 for the radio */
 633                         state->mode = MSP_MODE_FM_RADIO;
 634                         scart       = SCART_IN2;
 635                         break;
 636                 case AUDIO_EXTERN_1:
 637                         /* IN1 is often used for external input ... */
 638                         state->mode = MSP_MODE_EXTERN;
 639                         scart       = SCART_IN1;
 640                         break;
 641                 case AUDIO_EXTERN_2:
 642                         /* ... sometimes it is IN2 through ;) */
 643                         state->mode = MSP_MODE_EXTERN;
 644                         scart       = SCART_IN2;
 645                         break;
 646                 case AUDIO_TUNER:
 647                         state->mode = -1;
 648                         break;
 649                 default:
 650                         if (*sarg & AUDIO_MUTE)
 651                                 msp_set_scart(client, SCART_MUTE, 0);
 652                         break;
 653                 }
 654                 if (scart) {
 655                         state->rxsubchans = V4L2_TUNER_SUB_STEREO;
 656                         state->audmode = V4L2_TUNER_MODE_STEREO;
 657                         msp_set_scart(client, scart, 0);
 658                         msp_write_dsp(client, 0x000d, 0x1900);
 659                         if (state->opmode != OPMODE_AUTOSELECT)
 660                                 msp3400c_setstereo(client, state->audmode);
 661                 }
 662                 msp_wake_thread(client);
 663                 break;
 664
 665         case AUDC_SET_RADIO:
 666                 if (state->radio)
 667                         return 0;
 668                 state->radio = 1;
 669                 v4l_dbg(1, msp_debug, client, "switching to radio mode\n");
 670                 state->watch_stereo = 0;
 671                 switch (state->opmode) {
 672                 case OPMODE_MANUAL:
 673                         /* set msp3400 to FM radio mode */
 674                         msp3400c_setmode(client, MSP_MODE_FM_RADIO);
 675                         msp3400c_setcarrier(client, MSP_CARRIER(10.7),
 676                                             MSP_CARRIER(10.7));
 677                         msp_set_audio(client);
 678                         break;
 679                 case OPMODE_AUTODETECT:
 680                 case OPMODE_AUTOSELECT:
 681                         /* the thread will do for us */
 682                         msp_wake_thread(client);
 683                         break;
 684                 }
 685                 break;
 686
 687         /* --- v4l ioctls --- */
 688         /* take care: bttv does userspace copying, we'll get a
 689            kernel pointer here... */
 690         case VIDIOCGAUDIO:
 691         {
 692                 struct video_audio *va = arg;
 693
 694                 va->flags |= VIDEO_AUDIO_VOLUME | VIDEO_AUDIO_MUTABLE;
 695                 if (state->has_sound_processing)
 696                         va->flags |= VIDEO_AUDIO_BALANCE |
 697                                 VIDEO_AUDIO_BASS |
 698                                 VIDEO_AUDIO_TREBLE;
 699                 if (state->muted)
 700                         va->flags |= VIDEO_AUDIO_MUTE;
 701                 va->volume = state->volume;
 702                 va->balance = state->volume ? state->balance : 32768;
 703                 va->bass = state->bass;
 704                 va->treble = state->treble;
 705
 706                 if (state->radio)
 707                         break;
 708                 if (state->opmode == OPMODE_AUTOSELECT)
 709                         msp_any_detect_stereo(client);
 710                 va->mode = msp_mode_v4l2_to_v4l1(state->rxsubchans);
 711                 break;
 712         }
 713
 714         case VIDIOCSAUDIO:
 715         {
 716                 struct video_audio *va = arg;
 717
 718                 state->muted = (va->flags & VIDEO_AUDIO_MUTE);
 719                 state->volume = va->volume;
 720                 state->balance = va->balance;
 721                 state->bass = va->bass;
 722                 state->treble = va->treble;
 723                 msp_set_audio(client);
 724
 725                 if (va->mode != 0 && state->radio == 0)
 726                         msp_any_set_audmode(client, msp_mode_v4l1_to_v4l2(va->mode));
 727                 break;
 728         }
 729
 730         case VIDIOCSCHAN:
 731         {
 732                 struct video_channel *vc = arg;
 733                 int update = 0;
 734                 v4l2_std_id std;
 735
 736                 if (state->radio)
 737                         update = 1;
 738                 state->radio = 0;
 739                 if (vc->norm == VIDEO_MODE_PAL)
 740                         std = V4L2_STD_PAL;
 741                 else if (vc->norm == VIDEO_MODE_SECAM)
 742                         std = V4L2_STD_SECAM;
 743                 else
 744                         std = V4L2_STD_NTSC;
 745                 if (std != state->v4l2_std) {
 746                         state->v4l2_std = std;
 747                         update = 1;
 748                 }
 749                 if (update)
 750                         msp_wake_thread(client);
 751                 break;
 752         }
 753
 754         case VIDIOCSFREQ:
 755         case VIDIOC_S_FREQUENCY:
 756         {
 757                 /* new channel -- kick audio carrier scan */
 758                 msp_wake_thread(client);
 759                 break;
 760         }
 761
 762         /* msp34xx specific */
 763         case MSP_SET_MATRIX:
 764         {
 765                 struct msp_matrix *mspm = arg;
 766
 767                 msp_set_scart(client, mspm->input, mspm->output);
 768                 break;
 769         }
 770
 771         /* --- v4l2 ioctls --- */
 772         case VIDIOC_S_STD:
 773         {
 774                 v4l2_std_id *id = arg;
 775                 int update = state->radio || state->v4l2_std != *id;
 776
 777                 state->v4l2_std = *id;
 778                 state->radio = 0;
 779                 if (update)
 780                         msp_wake_thread(client);
 781                 return 0;
 782         }
 783
 784         case VIDIOC_ENUMINPUT:
 785         {
 786                 struct v4l2_input *i = arg;
 787
 788                 if (i->index != 0)
 789                         return -EINVAL;
 790
 791                 i->type = V4L2_INPUT_TYPE_TUNER;
 792                 switch (i->index) {
 793                 case AUDIO_RADIO:
 794                         strcpy(i->name, "Radio");
 795                         break;
 796                 case AUDIO_EXTERN_1:
 797                         strcpy(i->name, "Extern 1");
 798                         break;
 799                 case AUDIO_EXTERN_2:
 800                         strcpy(i->name, "Extern 2");
 801                         break;
 802                 case AUDIO_TUNER:
 803                         strcpy(i->name, "Television");
 804                         break;
 805                 default:
 806                         return -EINVAL;
 807                 }
 808                 return 0;
 809         }
 810
 811         case VIDIOC_G_AUDIO:
 812         {
 813                 struct v4l2_audio *a = arg;
 814
 815                 memset(a, 0, sizeof(*a));
 816
 817                 switch (a->index) {
 818                 case AUDIO_RADIO:
 819                         strcpy(a->name, "Radio");
 820                         break;
 821                 case AUDIO_EXTERN_1:
 822                         strcpy(a->name, "Extern 1");
 823                         break;
 824                 case AUDIO_EXTERN_2:
 825                         strcpy(a->name, "Extern 2");
 826                         break;
 827                 case AUDIO_TUNER:
 828                         strcpy(a->name, "Television");
 829                         break;
 830                 default:
 831                         return -EINVAL;
 832                 }
 833
 834                 msp_any_detect_stereo(client);
 835                 if (state->audmode == V4L2_TUNER_MODE_STEREO) {
 836                         a->capability = V4L2_AUDCAP_STEREO;
 837                 }
 838
 839                 break;
 840         }
 841
 842         case VIDIOC_S_AUDIO:
 843         {
 844                 struct v4l2_audio *sarg = arg;
 845
 846                 switch (sarg->index) {
 847                 case AUDIO_RADIO:
 848                         /* Hauppauge uses IN2 for the radio */
 849                         state->mode = MSP_MODE_FM_RADIO;
 850                         scart       = SCART_IN2;
 851                         break;
 852                 case AUDIO_EXTERN_1:
 853                         /* IN1 is often used for external input ... */
 854                         state->mode = MSP_MODE_EXTERN;
 855                         scart       = SCART_IN1;
 856                         break;
 857                 case AUDIO_EXTERN_2:
 858                         /* ... sometimes it is IN2 through ;) */
 859                         state->mode = MSP_MODE_EXTERN;
 860                         scart       = SCART_IN2;
 861                         break;
 862                 case AUDIO_TUNER:
 863                         state->mode = -1;
 864                         break;
 865                 }
 866                 if (scart) {
 867                         state->rxsubchans = V4L2_TUNER_SUB_STEREO;
 868                         state->audmode = V4L2_TUNER_MODE_STEREO;
 869                         msp_set_scart(client, scart, 0);
 870                         msp_write_dsp(client, 0x000d, 0x1900);
 871                 }
 872                 if (sarg->capability == V4L2_AUDCAP_STEREO) {
 873                         state->audmode = V4L2_TUNER_MODE_STEREO;
 874                 } else {
 875                         state->audmode &= ~V4L2_TUNER_MODE_STEREO;
 876                 }
 877                 msp_any_set_audmode(client, state->audmode);
 878                 msp_wake_thread(client);
 879                 break;
 880         }
 881
 882         case VIDIOC_G_TUNER:
 883         {
 884                 struct v4l2_tuner *vt = arg;
 885
 886                 if (state->radio)
 887                         break;
 888                 if (state->opmode == OPMODE_AUTOSELECT)
 889                         msp_any_detect_stereo(client);
 890                 vt->audmode    = state->audmode;
 891                 vt->rxsubchans = state->rxsubchans;
 892                 vt->capability = V4L2_TUNER_CAP_STEREO |
 893                         V4L2_TUNER_CAP_LANG1 | V4L2_TUNER_CAP_LANG2;
 894                 break;
 895         }
 896
 897         case VIDIOC_S_TUNER:
 898         {
 899                 struct v4l2_tuner *vt = (struct v4l2_tuner *)arg;
 900
 901                 if (state->radio)
 902                         break;
 903                 /* only set audmode */
 904                 if (vt->audmode != -1 && vt->audmode != 0)
 905                         msp_any_set_audmode(client, vt->audmode);
 906                 break;
 907         }
 908
 909         case VIDIOC_G_AUDOUT:
 910         {
 911                 struct v4l2_audioout *a = (struct v4l2_audioout *)arg;
 912                 int idx = a->index;
 913
 914                 memset(a, 0, sizeof(*a));
 915
 916                 switch (idx) {
 917                 case 0:
 918                         strcpy(a->name, "Scart1 Out");
 919                         break;
 920                 case 1:
 921                         strcpy(a->name, "Scart2 Out");
 922                         break;
 923                 case 2:
 924                         strcpy(a->name, "I2S Out");
 925                         break;
 926                 default:
 927                         return -EINVAL;
 928                 }
 929                 break;
 930
 931         }
 932
 933         case VIDIOC_S_AUDOUT:
 934         {
 935                 struct v4l2_audioout *a = (struct v4l2_audioout *)arg;
 936
 937                 if (a->index < 0 || a->index > 2)
 938                         return -EINVAL;
 939
 940                 v4l_dbg(1, msp_debug, client, "Setting audio out on msp34xx to input %i\n", a->index);
 941                 msp_set_scart(client, state->in_scart, a->index + 1);
 942
 943                 break;
 944         }
 945
 946         case VIDIOC_INT_I2S_CLOCK_FREQ:
 947         {
 948                 u32 *a = (u32 *)arg;
 949
 950                 v4l_dbg(1, msp_debug, client, "Setting I2S speed to %d\n", *a);
 951
 952                 switch (*a) {
 953                         case 1024000:
 954                                 state->i2s_mode = 0;
 955                                 break;
 956                         case 2048000:
 957                                 state->i2s_mode = 1;
 958                                 break;
 959                         default:
 960                                 return -EINVAL;
 961                 }
 962                 break;
 963         }
 964
 965         case VIDIOC_QUERYCTRL:
 966         {
 967                 struct v4l2_queryctrl *qc = arg;
 968                 int i;
 969
 970                 for (i = 0; i < ARRAY_SIZE(msp_qctrl_std); i++)
 971                         if (qc->id && qc->id == msp_qctrl_std[i].id) {
 972                                 memcpy(qc, &msp_qctrl_std[i], sizeof(*qc));
 973                                 return 0;
 974                         }
 975                 if (!state->has_sound_processing)
 976                         return -EINVAL;
 977                 for (i = 0; i < ARRAY_SIZE(msp_qctrl_sound_processing); i++)
 978                         if (qc->id && qc->id == msp_qctrl_sound_processing[i].id) {
 979                                 memcpy(qc, &msp_qctrl_sound_processing[i], sizeof(*qc));
 980                                 return 0;
 981                         }
 982                 return -EINVAL;
 983         }
 984
 985         case VIDIOC_G_CTRL:
 986                 return msp_get_ctrl(client, arg);
 987
 988         case VIDIOC_S_CTRL:
 989                 return msp_set_ctrl(client, arg);
 990
 991         case VIDIOC_LOG_STATUS:
 992         {
 993                 const char *p;
 994
 995                 if (state->opmode == OPMODE_AUTOSELECT)
 996                         msp_any_detect_stereo(client);
 997                 v4l_info(client, "%s rev1 = 0x%04x rev2 = 0x%04x\n",
 998                                 client->name, state->rev1, state->rev2);
 999                 v4l_info(client, "Audio:    volume %d%s\n",
1000                                 state->volume, state->muted ? " (muted)" : "");
1001                 if (state->has_sound_processing) {
1002                         v4l_info(client, "Audio:    balance %d bass %d treble %d loudness %s\n",
1003                                         state->balance, state->bass, state->treble,
1004                                         state->loudness ? "on" : "off");
1005                 }
1006                 switch (state->mode) {
1007                 case MSP_MODE_AM_DETECT: p = "AM (for carrier detect)"; break;
1008                 case MSP_MODE_FM_RADIO: p = "FM Radio"; break;
1009                 case MSP_MODE_FM_TERRA: p = "Terrestial FM-mono + FM-stereo"; break;
1010                 case MSP_MODE_FM_SAT: p = "Satellite FM-mono"; break;
1011                 case MSP_MODE_FM_NICAM1: p = "NICAM/FM (B/G, D/K)"; break;
1012                 case MSP_MODE_FM_NICAM2: p = "NICAM/FM (I)"; break;
1013                 case MSP_MODE_AM_NICAM: p = "NICAM/AM (L)"; break;
1014                 case MSP_MODE_BTSC: p = "BTSC"; break;
1015                 case MSP_MODE_EXTERN: p = "External input"; break;
1016                 default: p = "unknown"; break;
1017                 }
1018                 if (state->opmode == OPMODE_MANUAL) {
1019                         v4l_info(client, "Mode:     %s (%s%s)\n", p,
1020                                 (state->rxsubchans & V4L2_TUNER_SUB_STEREO) ? "stereo" : "mono",
1021                                 (state->rxsubchans & V4L2_TUNER_SUB_LANG2) ? ", dual" : "");
1022                 } else {
1023                         v4l_info(client, "Mode:     %s\n", p);
1024                         v4l_info(client, "Standard: %s (%s%s)\n",
1025                                 msp_standard_std_name(state->std),
1026                                 (state->rxsubchans & V4L2_TUNER_SUB_STEREO) ? "stereo" : "mono",
1027                                 (state->rxsubchans & V4L2_TUNER_SUB_LANG2) ? ", dual" : "");
1028                 }
1029                 v4l_info(client, "ACB:      0x%04x\n", state->acb);
1030                 break;
1031         }
1032
1033         default:
1034                 /* nothing */
1035                 break;
1036         }
1037         return 0;
1038 }
1039
1040 static int msp_suspend(struct device * dev, pm_message_t state)
1041 {
1042         struct i2c_client *client = container_of(dev, struct i2c_client, dev);
1043
1044         v4l_dbg(1, msp_debug, client, "suspend\n");
1045         msp_reset(client);
1046         return 0;
1047 }
1048
1049 static int msp_resume(struct device * dev)
1050 {
1051         struct i2c_client *client = container_of(dev, struct i2c_client, dev);
1052
1053         v4l_dbg(1, msp_debug, client, "resume\n");
1054         msp_wake_thread(client);
1055         return 0;
1056 }
1057
1058 /* ----------------------------------------------------------------------- */
1059
1060 static struct i2c_driver i2c_driver;
1061
1062 static int msp_attach(struct i2c_adapter *adapter, int address, int kind)
1063 {
1064         struct i2c_client *client;
1065         struct msp_state *state;
1066         int (*thread_func)(void *data) = NULL;
1067         int msp_hard;
1068         int msp_family;
1069         int msp_revision;
1070         int msp_product, msp_prod_hi, msp_prod_lo;
1071         int msp_rom;
1072
1073         client = kmalloc(sizeof(*client), GFP_KERNEL);
1074         if (client == NULL)
1075                 return -ENOMEM;
1076         memset(client, 0, sizeof(*client));
1077         client->addr = address;
1078         client->adapter = adapter;
1079         client->driver = &i2c_driver;
1080         snprintf(client->name, sizeof(client->name) - 1, "msp3400");
1081
1082         if (msp_reset(client) == -1) {
1083                 v4l_dbg(1, msp_debug, client, "msp3400 not found\n");
1084                 kfree(client);
1085                 return -1;
1086         }
1087
1088         state = kmalloc(sizeof(*state), GFP_KERNEL);
1089         if (state == NULL) {
1090                 kfree(client);
1091                 return -ENOMEM;
1092         }
1093         i2c_set_clientdata(client, state);
1094
1095         memset(state, 0, sizeof(*state));
1096         state->v4l2_std = V4L2_STD_NTSC;
1097         state->volume = 58880;  /* 0db gain */
1098         state->balance = 32768; /* 0db gain */
1099         state->bass = 32768;
1100         state->treble = 32768;
1101         state->loudness = 0;
1102         state->input = -1;
1103         state->muted = 0;
1104         state->i2s_mode = 0;
1105         init_waitqueue_head(&state->wq);
1106
1107         state->rev1 = msp_read_dsp(client, 0x1e);
1108         if (state->rev1 != -1)
1109                 state->rev2 = msp_read_dsp(client, 0x1f);
1110         v4l_dbg(1, msp_debug, client, "rev1=0x%04x, rev2=0x%04x\n", state->rev1, state->rev2);
1111         if (state->rev1 == -1 || (state->rev1 == 0 && state->rev2 == 0)) {
1112                 v4l_dbg(1, msp_debug, client, "not an msp3400 (cannot read chip version)\n");
1113                 kfree(state);
1114                 kfree(client);
1115                 return -1;
1116         }
1117
1118         msp_set_audio(client);
1119
1120         msp_family = ((state->rev1 >> 4) & 0x0f) + 3;
1121         msp_product = (state->rev2 >> 8) & 0xff;
1122         msp_prod_hi = msp_product / 10;
1123         msp_prod_lo = msp_product % 10;
1124         msp_revision = (state->rev1 & 0x0f) + '@';
1125         msp_hard = ((state->rev1 >> 8) & 0xff) + '@';
1126         msp_rom = state->rev2 & 0x1f;
1127         snprintf(client->name, sizeof(client->name), "MSP%d4%02d%c-%c%d",
1128                         msp_family, msp_product,
1129                         msp_revision, msp_hard, msp_rom);
1130
1131         /* Has NICAM support: all mspx41x and mspx45x products have NICAM */
1132         state->has_nicam = msp_prod_hi == 1 || msp_prod_hi == 5;
1133         /* Has radio support: was added with revision G */
1134         state->has_radio = msp_revision >= 'G';
1135         /* Has headphones output: not for stripped down products */
1136         state->has_headphones = msp_prod_lo < 5;
1137         /* Has scart4 input: not in pre D revisions, not in stripped D revs */
1138         state->has_scart4 = msp_family >= 4 || (msp_revision >= 'D' && msp_prod_lo < 5);
1139         /* Has scart2 and scart3 inputs and scart2 output: not in stripped
1140            down products of the '3' family */
1141         state->has_scart23_in_scart2_out = msp_family >= 4 || msp_prod_lo < 5;
1142         /* Has scart2 a volume control? Not in pre-D revisions. */
1143         state->has_scart2_out_volume = msp_revision > 'C' && state->has_scart23_in_scart2_out;
1144         /* Has a configurable i2s out? */
1145         state->has_i2s_conf = msp_revision >= 'G' && msp_prod_lo < 7;
1146         /* Has subwoofer output: not in pre-D revs and not in stripped down products */
1147         state->has_subwoofer = msp_revision >= 'D' && msp_prod_lo < 5;
1148         /* Has soundprocessing (bass/treble/balance/loudness/equalizer): not in
1149            stripped down products */
1150         state->has_sound_processing = msp_prod_lo < 7;
1151         /* Has Virtual Dolby Surround: only in msp34x1 */
1152         state->has_virtual_dolby_surround = msp_revision == 'G' && msp_prod_lo == 1;
1153         /* Has Virtual Dolby Surround & Dolby Pro Logic: only in msp34x2 */
1154         state->has_dolby_pro_logic = msp_revision == 'G' && msp_prod_lo == 2;
1155
1156         state->opmode = opmode;
1157         if (state->opmode == OPMODE_AUTO) {
1158                 /* MSP revision G and up have both autodetect and autoselect */
1159                 if (msp_revision >= 'G')
1160                         state->opmode = OPMODE_AUTOSELECT;
1161                 /* MSP revision D and up have autodetect */
1162                 else if (msp_revision >= 'D')
1163                         state->opmode = OPMODE_AUTODETECT;
1164                 else
1165                         state->opmode = OPMODE_MANUAL;
1166         }
1167
1168         /* hello world :-) */
1169         v4l_info(client, "%s found @ 0x%x (%s)\n", client->name, address << 1, adapter->name);
1170         v4l_info(client, "%s ", client->name);
1171         if (state->has_nicam && state->has_radio)
1172                 printk("supports nicam and radio, ");
1173         else if (state->has_nicam)
1174                 printk("supports nicam, ");
1175         else if (state->has_radio)
1176                 printk("supports radio, ");
1177         printk("mode is ");
1178
1179         /* version-specific initialization */
1180         switch (state->opmode) {
1181         case OPMODE_MANUAL:
1182                 printk("manual");
1183                 thread_func = msp3400c_thread;
1184                 break;
1185         case OPMODE_AUTODETECT:
1186                 printk("autodetect");
1187                 thread_func = msp3410d_thread;
1188                 break;
1189         case OPMODE_AUTOSELECT:
1190                 printk("autodetect and autoselect");
1191                 thread_func = msp34xxg_thread;
1192                 break;
1193         }
1194         printk("\n");
1195
1196         /* startup control thread if needed */
1197         if (thread_func) {
1198                 state->kthread = kthread_run(thread_func, client, "msp34xx");
1199
1200                 if (state->kthread == NULL)
1201                         v4l_warn(client, "kernel_thread() failed\n");
1202                 msp_wake_thread(client);
1203         }
1204
1205         /* done */
1206         i2c_attach_client(client);
1207
1208         return 0;
1209 }
1210
1211 static int msp_probe(struct i2c_adapter *adapter)
1212 {
1213         if (adapter->class & I2C_CLASS_TV_ANALOG)
1214                 return i2c_probe(adapter, &addr_data, msp_attach);
1215         return 0;
1216 }
1217
1218 static int msp_detach(struct i2c_client *client)
1219 {
1220         struct msp_state *state = i2c_get_clientdata(client);
1221         int err;
1222
1223         /* shutdown control thread */
1224         if (state->kthread) {
1225                 state->restart = 1;
1226                 kthread_stop(state->kthread);
1227         }
1228         msp_reset(client);
1229
1230         err = i2c_detach_client(client);
1231         if (err) {
1232                 return err;
1233         }
1234
1235         kfree(state);
1236         kfree(client);
1237         return 0;
1238 }
1239
1240 /* ----------------------------------------------------------------------- */
1241
1242 /* i2c implementation */
1243 static struct i2c_driver i2c_driver = {
1244         .id             = I2C_DRIVERID_MSP3400,
1245         .attach_adapter = msp_probe,
1246         .detach_client  = msp_detach,
1247         .command        = msp_command,
1248         .driver = {
1249                 .name    = "msp3400",
1250                 .suspend = msp_suspend,
1251                 .resume  = msp_resume,
1252         },
1253 };
1254
1255 static int __init msp3400_init_module(void)
1256 {
1257         return i2c_add_driver(&i2c_driver);
1258 }
1259
1260 static void __exit msp3400_cleanup_module(void)
1261 {
1262         i2c_del_driver(&i2c_driver);
1263 }
1264
1265 module_init(msp3400_init_module);
1266 module_exit(msp3400_cleanup_module);
1267
1268 /*
1269  * Overrides for Emacs so that we follow Linus's tabbing style.
1270  * ---------------------------------------------------------------------------
1271  * Local variables:
1272  * c-basic-offset: 8
1273  * End:
1274  */