janitorial: Remove remaining NULL checks before free() (found by Smatch).
[wine] / dlls / d3d8 / tests / device.c
1 /*
2  * Copyright (C) 2006 Vitaliy Margolen
3  *
4  * This library is free software; you can redistribute it and/or
5  * modify it under the terms of the GNU Lesser General Public
6  * License as published by the Free Software Foundation; either
7  * version 2.1 of the License, or (at your option) any later version.
8  *
9  * This library is distributed in the hope that it will be useful,
10  * but WITHOUT ANY WARRANTY; without even the implied warranty of
11  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
12  * Lesser General Public License for more details.
13  *
14  * You should have received a copy of the GNU Lesser General Public
15  * License along with this library; if not, write to the Free Software
16  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
17  */
18
19 #define COBJMACROS
20 #include <d3d8.h>
21 #include <dxerr8.h>
22 #include "wine/test.h"
23
24 static IDirect3D8 *(WINAPI *pDirect3DCreate8)(UINT);
25
26 static int get_refcount(IUnknown *object)
27 {
28     IUnknown_AddRef( object );
29     return IUnknown_Release( object );
30 }
31
32 #define CHECK_CALL(r,c,d,rc) \
33     if (SUCCEEDED(r)) {\
34         int tmp1 = get_refcount( (IUnknown *)d ); \
35         int rc_new = rc; \
36         ok(tmp1 == rc_new, "Invalid refcount. Expected %d got %d\n", rc_new, tmp1); \
37     } else {\
38         trace("%s failed: %s\n", c, DXGetErrorString8(r)); \
39     }
40 #define CHECK_RELEASE(obj,d,rc) \
41     if (obj) { \
42         int tmp1, rc_new = rc; \
43         IUnknown_Release( obj ); \
44         tmp1 = get_refcount( (IUnknown *)d ); \
45         ok(tmp1 == rc_new, "Invalid refcount. Expected %d got %d\n", rc_new, tmp1); \
46     }
47
48 static void test_swapchain(void)
49 {
50     HRESULT                      hr;
51     HWND                         hwnd               = NULL;
52     IDirect3D8                  *pD3d               = NULL;
53     IDirect3DDevice8            *pDevice            = NULL;
54     IDirect3DSwapChain8         *swapchain1         = NULL;
55     IDirect3DSwapChain8         *swapchain2         = NULL;
56     IDirect3DSwapChain8         *swapchain3         = NULL;
57     IDirect3DSurface8           *backbuffer         = NULL;
58     D3DPRESENT_PARAMETERS        d3dpp;
59     D3DDISPLAYMODE               d3ddm;
60
61     pD3d = pDirect3DCreate8( D3D_SDK_VERSION );
62     ok(pD3d != NULL, "Failed to create IDirect3D8 object\n");
63     hwnd = CreateWindow( "static", "d3d8_test", WS_OVERLAPPEDWINDOW, 100, 100, 160, 160, NULL, NULL, NULL, NULL );
64     ok(hwnd != NULL, "Failed to create window\n");
65     if (!pD3d || !hwnd) goto cleanup;
66
67     IDirect3D8_GetAdapterDisplayMode( pD3d, D3DADAPTER_DEFAULT, &d3ddm );
68     ZeroMemory( &d3dpp, sizeof(d3dpp) );
69     d3dpp.Windowed         = TRUE;
70     d3dpp.SwapEffect       = D3DSWAPEFFECT_DISCARD;
71     d3dpp.BackBufferFormat = d3ddm.Format;
72     d3dpp.BackBufferCount  = 0;
73
74     hr = IDirect3D8_CreateDevice( pD3d, D3DADAPTER_DEFAULT, D3DDEVTYPE_HAL, hwnd,
75                                   D3DCREATE_SOFTWARE_VERTEXPROCESSING, &d3dpp, &pDevice );
76     ok(SUCCEEDED(hr), "Failed to create IDirect3D8Device (%s)\n", DXGetErrorString8(hr));
77     if (FAILED(hr)) goto cleanup;
78
79     /* Check if the back buffer count was modified */
80     ok(d3dpp.BackBufferCount == 1, "The back buffer count in the presentparams struct is %d\n", d3dpp.BackBufferCount);
81
82     /* Create a bunch of swapchains */
83     d3dpp.BackBufferCount = 0;
84     hr = IDirect3DDevice8_CreateAdditionalSwapChain(pDevice, &d3dpp, &swapchain1);
85     ok(SUCCEEDED(hr), "Failed to create a swapchain (%s)\n", DXGetErrorString8(hr));
86     ok(d3dpp.BackBufferCount == 1, "The back buffer count in the presentparams struct is %d\n", d3dpp.BackBufferCount);
87
88     d3dpp.BackBufferCount  = 1;
89     hr = IDirect3DDevice8_CreateAdditionalSwapChain(pDevice, &d3dpp, &swapchain2);
90     ok(SUCCEEDED(hr), "Failed to create a swapchain (%s)\n", DXGetErrorString8(hr));
91
92     d3dpp.BackBufferCount  = 2;
93     hr = IDirect3DDevice8_CreateAdditionalSwapChain(pDevice, &d3dpp, &swapchain3);
94     ok(SUCCEEDED(hr), "Failed to create a swapchain (%s)\n", DXGetErrorString8(hr));
95     if(SUCCEEDED(hr)) {
96         /* Swapchain 3, created with backbuffercount 2 */
97         backbuffer = (void *) 0xdeadbeef;
98         hr = IDirect3DSwapChain8_GetBackBuffer(swapchain3, 0, 0, &backbuffer);
99         ok(SUCCEEDED(hr), "Failed to get the 1st back buffer (%s)\n", DXGetErrorString8(hr));
100         ok(backbuffer != NULL && backbuffer != (void *) 0xdeadbeef, "The back buffer is %p\n", backbuffer);
101         if(backbuffer && backbuffer != (void *) 0xdeadbeef) IDirect3DSurface8_Release(backbuffer);
102
103         backbuffer = (void *) 0xdeadbeef;
104         hr = IDirect3DSwapChain8_GetBackBuffer(swapchain3, 1, 0, &backbuffer);
105         ok(SUCCEEDED(hr), "Failed to get the 2nd back buffer (%s)\n", DXGetErrorString8(hr));
106         ok(backbuffer != NULL && backbuffer != (void *) 0xdeadbeef, "The back buffer is %p\n", backbuffer);
107         if(backbuffer && backbuffer != (void *) 0xdeadbeef) IDirect3DSurface8_Release(backbuffer);
108
109         backbuffer = (void *) 0xdeadbeef;
110         hr = IDirect3DSwapChain8_GetBackBuffer(swapchain3, 2, 0, &backbuffer);
111         ok(hr == D3DERR_INVALIDCALL, "GetBackBuffer returned %s\n", DXGetErrorString8(hr));
112         ok(backbuffer == (void *) 0xdeadbeef, "The back buffer pointer was modified (%p)\n", backbuffer);
113         if(backbuffer && backbuffer != (void *) 0xdeadbeef) IDirect3DSurface8_Release(backbuffer);
114
115         backbuffer = (void *) 0xdeadbeef;
116         hr = IDirect3DSwapChain8_GetBackBuffer(swapchain3, 3, 0, &backbuffer);
117         ok(FAILED(hr), "Failed to get the back buffer (%s)\n", DXGetErrorString8(hr));
118         ok(backbuffer == (void *) 0xdeadbeef, "The back buffer pointer was modified (%p)\n", backbuffer);
119         if(backbuffer && backbuffer != (void *) 0xdeadbeef) IDirect3DSurface8_Release(backbuffer);
120     }
121
122     /* Check the back buffers of the swapchains */
123     /* Swapchain 1, created with backbuffercount 0 */
124     hr = IDirect3DSwapChain8_GetBackBuffer(swapchain1, 0, D3DBACKBUFFER_TYPE_MONO, &backbuffer);
125     ok(SUCCEEDED(hr), "Failed to get the back buffer (%s)\n", DXGetErrorString8(hr));
126     ok(backbuffer != NULL, "The back buffer is NULL (%s)\n", DXGetErrorString8(hr));
127     if(backbuffer) IDirect3DSurface8_Release(backbuffer);
128
129     backbuffer = (void *) 0xdeadbeef;
130     hr = IDirect3DSwapChain8_GetBackBuffer(swapchain1, 1, 0, &backbuffer);
131     ok(FAILED(hr), "Failed to get the back buffer (%s)\n", DXGetErrorString8(hr));
132     ok(backbuffer == (void *) 0xdeadbeef, "The back buffer pointer was modified (%p)\n", backbuffer);
133     if(backbuffer && backbuffer != (void *) 0xdeadbeef) IDirect3DSurface8_Release(backbuffer);
134
135     /* Swapchain 2 - created with backbuffercount 1 */
136     backbuffer = (void *) 0xdeadbeef;
137     hr = IDirect3DSwapChain8_GetBackBuffer(swapchain2, 0, 0, &backbuffer);
138     ok(SUCCEEDED(hr), "Failed to get the back buffer (%s)\n", DXGetErrorString8(hr));
139     ok(backbuffer != NULL && backbuffer != (void *) 0xdeadbeef, "The back buffer is %p\n", backbuffer);
140     if(backbuffer && backbuffer != (void *) 0xdeadbeef) IDirect3DSurface8_Release(backbuffer);
141
142     backbuffer = (void *) 0xdeadbeef;
143     hr = IDirect3DSwapChain8_GetBackBuffer(swapchain2, 1, 0, &backbuffer);
144     ok(hr == D3DERR_INVALIDCALL, "GetBackBuffer returned %s\n", DXGetErrorString8(hr));
145     ok(backbuffer == (void *) 0xdeadbeef, "The back buffer pointer was modified (%p)\n", backbuffer);
146     if(backbuffer && backbuffer != (void *) 0xdeadbeef) IDirect3DSurface8_Release(backbuffer);
147
148     backbuffer = (void *) 0xdeadbeef;
149     hr = IDirect3DSwapChain8_GetBackBuffer(swapchain2, 2, 0, &backbuffer);
150     ok(FAILED(hr), "Failed to get the back buffer (%s)\n", DXGetErrorString8(hr));
151     ok(backbuffer == (void *) 0xdeadbeef, "The back buffer pointer was modified (%p)\n", backbuffer);
152     if(backbuffer && backbuffer != (void *) 0xdeadbeef) IDirect3DSurface8_Release(backbuffer);
153
154     cleanup:
155     if(swapchain1) IDirect3DSwapChain8_Release(swapchain1);
156     if(swapchain2) IDirect3DSwapChain8_Release(swapchain2);
157     if(swapchain3) IDirect3DSwapChain8_Release(swapchain3);
158     if(pDevice) IDirect3DDevice8_Release(pDevice);
159     if(pD3d) IDirect3DDevice8_Release(pD3d);
160     DestroyWindow( hwnd );
161 }
162
163 static void test_refcount(void)
164 {
165     HRESULT                      hr;
166     HWND                         hwnd               = NULL;
167     IDirect3D8                  *pD3d               = NULL;
168     IDirect3DDevice8            *pDevice            = NULL;
169     IDirect3DVertexBuffer8      *pVertexBuffer      = NULL;
170     IDirect3DIndexBuffer8       *pIndexBuffer       = NULL;
171     DWORD                       dVertexShader       = -1;
172     DWORD                       dPixelShader        = -1;
173     IDirect3DCubeTexture8       *pCubeTexture       = NULL;
174     IDirect3DTexture8           *pTexture           = NULL;
175     IDirect3DVolumeTexture8     *pVolumeTexture     = NULL;
176     IDirect3DSurface8           *pStencilSurface    = NULL;
177     IDirect3DSurface8           *pImageSurface      = NULL;
178     IDirect3DSurface8           *pRenderTarget      = NULL;
179     IDirect3DSurface8           *pTextureLevel      = NULL;
180     DWORD                       dStateBlock         = -1;
181     IDirect3DSwapChain8         *pSwapChain         = NULL;
182
183     D3DPRESENT_PARAMETERS        d3dpp;
184     D3DDISPLAYMODE               d3ddm;
185     int                          refcount = 0, tmp;
186
187     DWORD decl[] =
188     {
189         D3DVSD_STREAM(0),
190         D3DVSD_REG(D3DVSDE_POSITION, D3DVSDT_FLOAT3),  /* D3DVSDE_POSITION, Register v0 */
191         D3DVSD_REG(D3DVSDE_DIFFUSE, D3DVSDT_D3DCOLOR), /* D3DVSDE_DIFFUSE, Register v5 */
192         D3DVSD_END()
193     };
194     static DWORD simple_vs[] = {0xFFFE0101,             /* vs_1_1               */
195         0x00000009, 0xC0010000, 0x90E40000, 0xA0E40000, /* dp4 oPos.x, v0, c0   */
196         0x00000009, 0xC0020000, 0x90E40000, 0xA0E40001, /* dp4 oPos.y, v0, c1   */
197         0x00000009, 0xC0040000, 0x90E40000, 0xA0E40002, /* dp4 oPos.z, v0, c2   */
198         0x00000009, 0xC0080000, 0x90E40000, 0xA0E40003, /* dp4 oPos.w, v0, c3   */
199         0x0000FFFF};                                    /* END                  */
200     static DWORD simple_ps[] = {0xFFFF0101,                                     /* ps_1_1                       */
201         0x00000051, 0xA00F0001, 0x3F800000, 0x00000000, 0x00000000, 0x00000000, /* def c1 = 1.0, 0.0, 0.0, 0.0  */
202         0x00000042, 0xB00F0000,                                                 /* tex t0                       */
203         0x00000008, 0x800F0000, 0xA0E40001, 0xA0E40000,                         /* dp3 r0, c1, c0               */
204         0x00000005, 0x800F0000, 0x90E40000, 0x80E40000,                         /* mul r0, v0, r0               */
205         0x00000005, 0x800F0000, 0xB0E40000, 0x80E40000,                         /* mul r0, t0, r0               */
206         0x0000FFFF};                                                            /* END                          */
207
208
209     pD3d = pDirect3DCreate8( D3D_SDK_VERSION );
210     ok(pD3d != NULL, "Failed to create IDirect3D8 object\n");
211     hwnd = CreateWindow( "static", "d3d8_test", WS_OVERLAPPEDWINDOW, 100, 100, 160, 160, NULL, NULL, NULL, NULL );
212     ok(hwnd != NULL, "Failed to create window\n");
213     if (!pD3d || !hwnd) goto cleanup;
214
215     IDirect3D8_GetAdapterDisplayMode( pD3d, D3DADAPTER_DEFAULT, &d3ddm );
216     ZeroMemory( &d3dpp, sizeof(d3dpp) );
217     d3dpp.Windowed         = TRUE;
218     d3dpp.SwapEffect       = D3DSWAPEFFECT_DISCARD;
219     d3dpp.BackBufferFormat = d3ddm.Format;
220
221     hr = IDirect3D8_CreateDevice( pD3d, D3DADAPTER_DEFAULT, D3DDEVTYPE_HAL, hwnd,
222                                   D3DCREATE_SOFTWARE_VERTEXPROCESSING, &d3dpp, &pDevice );
223     ok(SUCCEEDED(hr), "Failed to create IDirect3D8Device (%s)\n", DXGetErrorString8(hr));
224     if (FAILED(hr)) goto cleanup;
225
226     refcount = get_refcount( (IUnknown *)pDevice );
227     ok(refcount == 1, "Invalid device RefCount %d\n", refcount);
228
229     /* Buffers */
230     hr = IDirect3DDevice8_CreateIndexBuffer( pDevice, 16, 0, D3DFMT_INDEX32, D3DPOOL_DEFAULT, &pIndexBuffer );
231     CHECK_CALL( hr, "CreateIndexBuffer", pDevice, ++refcount );
232     hr = IDirect3DDevice8_CreateVertexBuffer( pDevice, 16, 0, D3DFVF_XYZ, D3DPOOL_DEFAULT, &pVertexBuffer );
233     CHECK_CALL( hr, "CreateVertexBuffer", pDevice, ++refcount );
234     /* Shaders */
235     hr = IDirect3DDevice8_CreateVertexShader( pDevice, decl, simple_vs, &dVertexShader, 0 );
236     CHECK_CALL( hr, "CreateVertexShader", pDevice, refcount );
237     hr = IDirect3DDevice8_CreatePixelShader( pDevice, simple_ps, &dPixelShader );
238     CHECK_CALL( hr, "CreatePixelShader", pDevice, refcount );
239     /* Textures */
240     hr = IDirect3DDevice8_CreateTexture( pDevice, 32, 32, 3, 0, D3DFMT_X8R8G8B8, D3DPOOL_DEFAULT, &pTexture );
241     CHECK_CALL( hr, "CreateTexture", pDevice, ++refcount );
242     if (pTexture)
243     {
244         tmp = get_refcount( (IUnknown *)pTexture );
245         /* This should not increment device refcount */
246         hr = IDirect3DTexture8_GetSurfaceLevel( pTexture, 1, &pTextureLevel );
247         CHECK_CALL( hr, "GetSurfaceLevel", pDevice, refcount );
248         /* But should increment texture's refcount */
249         CHECK_CALL( hr, "GetSurfaceLevel", pTexture, tmp+1 );
250     }
251     hr = IDirect3DDevice8_CreateCubeTexture( pDevice, 32, 0, 0, D3DFMT_X8R8G8B8, D3DPOOL_DEFAULT, &pCubeTexture );
252     CHECK_CALL( hr, "CreateCubeTexture", pDevice, ++refcount );
253     hr = IDirect3DDevice8_CreateVolumeTexture( pDevice, 32, 32, 2, 0, 0, D3DFMT_X8R8G8B8, D3DPOOL_DEFAULT, &pVolumeTexture );
254     CHECK_CALL( hr, "CreateVolumeTexture", pDevice, ++refcount );
255     /* Surfaces */
256     hr = IDirect3DDevice8_CreateDepthStencilSurface( pDevice, 32, 32, D3DFMT_D24S8, D3DMULTISAMPLE_NONE, &pStencilSurface );
257     CHECK_CALL( hr, "CreateDepthStencilSurface", pDevice, ++refcount );
258     hr = IDirect3DDevice8_CreateImageSurface( pDevice, 32, 32, D3DFMT_X8R8G8B8, &pImageSurface );
259     CHECK_CALL( hr, "CreateImageSurface", pDevice, ++refcount );
260     hr = IDirect3DDevice8_CreateRenderTarget( pDevice, 32, 32, D3DFMT_X8R8G8B8, D3DMULTISAMPLE_NONE, TRUE, &pRenderTarget );
261     CHECK_CALL( hr, "CreateRenderTarget", pDevice, ++refcount );
262     /* Misc */
263     hr = IDirect3DDevice8_CreateStateBlock( pDevice, D3DSBT_ALL, &dStateBlock );
264     CHECK_CALL( hr, "CreateStateBlock", pDevice, refcount );
265     hr = IDirect3DDevice8_CreateAdditionalSwapChain( pDevice, &d3dpp, &pSwapChain );
266     CHECK_CALL( hr, "CreateAdditionalSwapChain", pDevice, ++refcount );
267
268     if(pVertexBuffer)
269     {
270         BYTE *data;
271         /* Vertex buffers can be locked multiple times */
272         hr = IDirect3DVertexBuffer8_Lock(pVertexBuffer, 0, 0, &data, 0);
273         ok(hr == D3D_OK, "IDirect3DVertexBuffer8::Lock failed with %08lx\n", hr);
274         hr = IDirect3DVertexBuffer8_Lock(pVertexBuffer, 0, 0, &data, 0);
275         ok(hr == D3D_OK, "IDirect3DVertexBuffer8::Lock failed with %08lx\n", hr);
276         hr = IDirect3DVertexBuffer8_Unlock(pVertexBuffer);
277         ok(hr == D3D_OK, "IDirect3DVertexBuffer8::Unlock failed with %08lx\n", hr);
278         hr = IDirect3DVertexBuffer8_Unlock(pVertexBuffer);
279         ok(hr == D3D_OK, "IDirect3DVertexBuffer8::Unlock failed with %08lx\n", hr);
280     }
281
282 cleanup:
283     CHECK_RELEASE(pDevice,              pDevice, --refcount);
284
285     /* Buffers */
286     CHECK_RELEASE(pVertexBuffer,        pDevice, --refcount);
287     CHECK_RELEASE(pIndexBuffer,         pDevice, --refcount);
288     /* Shaders */
289     if (dVertexShader != -1)  IDirect3DDevice8_DeleteVertexShader( pDevice, dVertexShader );
290     if (dPixelShader != -1)   IDirect3DDevice8_DeletePixelShader( pDevice, dPixelShader );
291     /* Textures */
292     /* pTextureLevel is holding a reference to the pTexture */
293     CHECK_RELEASE(pTexture,             pDevice,   refcount);
294     CHECK_RELEASE(pTextureLevel,        pDevice, --refcount);
295     CHECK_RELEASE(pCubeTexture,         pDevice, --refcount);
296     CHECK_RELEASE(pVolumeTexture,       pDevice, --refcount);
297     /* Surfaces */
298     CHECK_RELEASE(pStencilSurface,      pDevice, --refcount);
299     CHECK_RELEASE(pImageSurface,        pDevice, --refcount);
300     CHECK_RELEASE(pRenderTarget,        pDevice, --refcount);
301     /* Misc */
302     if (dStateBlock != -1)    IDirect3DDevice8_DeleteStateBlock( pDevice, dStateBlock );
303     /* This will destroy device - cannot check the refcount here */
304     if (pSwapChain)           IUnknown_Release( pSwapChain );
305
306     if (pD3d)                 IUnknown_Release( pD3d );
307
308     DestroyWindow( hwnd );
309 }
310
311 START_TEST(device)
312 {
313     HMODULE d3d8_handle = LoadLibraryA( "d3d8.dll" );
314
315     pDirect3DCreate8 = (void *)GetProcAddress( d3d8_handle, "Direct3DCreate8" );
316     if (pDirect3DCreate8)
317     {
318         test_refcount();
319         test_swapchain();
320     }
321 }