wine
11 years agoriched20: Move undo handling to a different set of structs as the display item struct...
Huw Davies [Tue, 29 Jan 2013 13:41:48 +0000 (13:41 +0000)] 
riched20: Move undo handling to a different set of structs as the display item structs are not a good fit.

11 years agocscript: Correct forming cmd for forwarding to wscript.
Putin Evgeny [Mon, 28 Jan 2013 07:45:02 +0000 (11:45 +0400)] 
cscript: Correct forming cmd for forwarding to wscript.

11 years agowininet: Moved WORKREQ_FTPREMOVEDIRECTORYW out of WORKREQUEST.
Jacek Caban [Tue, 29 Jan 2013 11:05:13 +0000 (12:05 +0100)] 
wininet: Moved WORKREQ_FTPREMOVEDIRECTORYW out of WORKREQUEST.

11 years agowininet: Moved WORKREQ_FTPCREATEDIRECTORYW out of WORKREQUEST.
Jacek Caban [Tue, 29 Jan 2013 11:05:03 +0000 (12:05 +0100)] 
wininet: Moved WORKREQ_FTPCREATEDIRECTORYW out of WORKREQUEST.

11 years agowininet: Moved WORKREQ_FTPSETCURRENTDIRECTORYW out of WORKREQUEST.
Jacek Caban [Tue, 29 Jan 2013 11:04:55 +0000 (12:04 +0100)] 
wininet: Moved WORKREQ_FTPSETCURRENTDIRECTORYW out of WORKREQUEST.

11 years agowininet: Moved WORKREQ_FTPPUTFILEW out of WORKREQUEST.
Jacek Caban [Tue, 29 Jan 2013 11:04:40 +0000 (12:04 +0100)] 
wininet: Moved WORKREQ_FTPPUTFILEW out of WORKREQUEST.

11 years agowininet: Moved WORKREQ_SENDCALLBACK out of WORKREQUEST.
Jacek Caban [Tue, 29 Jan 2013 11:04:28 +0000 (12:04 +0100)] 
wininet: Moved WORKREQ_SENDCALLBACK out of WORKREQUEST.

11 years agowininet: Moved WORKREQ_HTTPENDREQUESTW out of WORKREQUEST.
Jacek Caban [Tue, 29 Jan 2013 11:04:16 +0000 (12:04 +0100)] 
wininet: Moved WORKREQ_HTTPENDREQUESTW out of WORKREQUEST.

11 years agokernel32: We no longer need the server start time in kernel32.
Alexandre Julliard [Tue, 29 Jan 2013 10:50:21 +0000 (11:50 +0100)] 
kernel32: We no longer need the server start time in kernel32.

11 years agoAssorted spelling fixes.
Francois Gouget [Tue, 29 Jan 2013 06:06:07 +0000 (07:06 +0100)] 
Assorted spelling fixes.

11 years agowined3d: debug_{d3dbasis, d3ddegree}() are not used anymore so remove them.
Francois Gouget [Tue, 29 Jan 2013 06:04:54 +0000 (07:04 +0100)] 
wined3d: debug_{d3dbasis, d3ddegree}() are not used anymore so remove them.

11 years agowined3d: Make device_stream_info_from_declaration() static.
Francois Gouget [Tue, 29 Jan 2013 06:04:44 +0000 (07:04 +0100)] 
wined3d: Make device_stream_info_from_declaration() static.

11 years agowined3d: Rebind texture before checking for its content in check_fbo_compat().
Matteo Bruni [Sat, 26 Jan 2013 22:48:54 +0000 (23:48 +0100)] 
wined3d: Rebind texture before checking for its content in check_fbo_compat().

11 years agoddraw/tests: Add viewport handling tests.
Stefan Dösinger [Sat, 26 Jan 2013 12:39:49 +0000 (13:39 +0100)] 
ddraw/tests: Add viewport handling tests.

11 years agoddraw: Don't check for NULL in GetCurrentViewport.
Stefan Dösinger [Sat, 26 Jan 2013 12:39:48 +0000 (13:39 +0100)] 
ddraw: Don't check for NULL in GetCurrentViewport.

11 years agoddraw: Unset the viewport if the current vp is deleted.
Stefan Dösinger [Sat, 26 Jan 2013 12:39:47 +0000 (13:39 +0100)] 
ddraw: Unset the viewport if the current vp is deleted.

11 years agoddraw: AddViewport holds a reference to the viewport.
Stefan Dösinger [Sat, 26 Jan 2013 12:39:46 +0000 (13:39 +0100)] 
ddraw: AddViewport holds a reference to the viewport.

11 years agoddraw: Check for NULL pointers in SetCurrentViewport.
Stefan Dösinger [Sat, 26 Jan 2013 12:39:45 +0000 (13:39 +0100)] 
ddraw: Check for NULL pointers in SetCurrentViewport.

11 years agoddraw: Check for NULL pointers in DeleteViewport.
Stefan Dösinger [Sat, 26 Jan 2013 12:39:44 +0000 (13:39 +0100)] 
ddraw: Check for NULL pointers in DeleteViewport.

11 years agoddraw: Delete viewports when destroying the device.
Stefan Dösinger [Sat, 26 Jan 2013 12:39:43 +0000 (13:39 +0100)] 
ddraw: Delete viewports when destroying the device.

11 years agoddraw: device::GetCurrentViewport returns an error if no viewport is set.
Stefan Dösinger [Sat, 26 Jan 2013 12:39:42 +0000 (13:39 +0100)] 
ddraw: device::GetCurrentViewport returns an error if no viewport is set.

11 years agowbemprox: Return an empty object if the path is NULL or empty.
Hans Leidekker [Mon, 28 Jan 2013 14:56:40 +0000 (15:56 +0100)] 
wbemprox: Return an empty object if the path is NULL or empty.

11 years agowineoss.drv: Set reasonable defaults if driver reports invalid values.
Andrew Eikum [Mon, 28 Jan 2013 14:52:55 +0000 (08:52 -0600)] 
wineoss.drv: Set reasonable defaults if driver reports invalid values.

11 years agowininet: Don't depend on user settings.
Detlef Riekenberg [Fri, 25 Jan 2013 16:23:49 +0000 (17:23 +0100)] 
wininet: Don't depend on user settings.

11 years agowininet: Remove most GetLastError tests for IsDomainLegalCookieDomainW.
Detlef Riekenberg [Fri, 25 Jan 2013 13:26:20 +0000 (14:26 +0100)] 
wininet: Remove most GetLastError tests for IsDomainLegalCookieDomainW.

11 years agowininet: Fix a test failure on w2k.
Detlef Riekenberg [Fri, 25 Jan 2013 13:26:18 +0000 (14:26 +0100)] 
wininet: Fix a test failure on w2k.

11 years agokernel32: Use the monotonic counter in GetTickCount64.
Alexandre Julliard [Fri, 25 Jan 2013 16:28:48 +0000 (17:28 +0100)] 
kernel32: Use the monotonic counter in GetTickCount64.

11 years agontdll: Use the monotonic counter for NtGetTickCount.
Alexandre Julliard [Fri, 25 Jan 2013 16:28:28 +0000 (17:28 +0100)] 
ntdll: Use the monotonic counter for NtGetTickCount.

11 years agontdll: Add support for the monotonic time counter on Mac OS X.
Alexandre Julliard [Mon, 28 Jan 2013 16:11:25 +0000 (17:11 +0100)] 
ntdll: Add support for the monotonic time counter on Mac OS X.

11 years agontdll: Use a monotonic time counter to implement NtQueryPerformanceCounter.
Alexandre Julliard [Fri, 25 Jan 2013 16:27:52 +0000 (17:27 +0100)] 
ntdll: Use a monotonic time counter to implement NtQueryPerformanceCounter.

11 years agoinclude: Add remaining checks for ARM64.
André Hentschel [Sat, 26 Jan 2013 11:10:23 +0000 (12:10 +0100)] 
include: Add remaining checks for ARM64.

11 years agowinex11: Push down variable attrib down in create_gl_drawable.
Gerald Pfeifer [Sat, 26 Jan 2013 01:07:13 +0000 (02:07 +0100)] 
winex11: Push down variable attrib down in create_gl_drawable.

11 years agotextstor.idl: Added TS_ATTR_FIND_* constants.
Jacek Caban [Mon, 28 Jan 2013 12:13:16 +0000 (13:13 +0100)] 
textstor.idl: Added TS_ATTR_FIND_* constants.

11 years agomsvcrt: Don't call invalid parameter handler in str{n,i}cmp functions.
Piotr Caban [Mon, 28 Jan 2013 10:40:36 +0000 (11:40 +0100)] 
msvcrt: Don't call invalid parameter handler in str{n,i}cmp functions.

11 years agowininet: Moved WORKREQ_HTTPREADFILEEX out of WORKREQUEST.
Jacek Caban [Mon, 28 Jan 2013 10:23:58 +0000 (11:23 +0100)] 
wininet: Moved WORKREQ_HTTPREADFILEEX out of WORKREQUEST.

11 years agowininet: Moved WORKREQ_INTERNETOPENURLW out of WORKREQUEST.
Jacek Caban [Mon, 28 Jan 2013 10:23:45 +0000 (11:23 +0100)] 
wininet: Moved WORKREQ_INTERNETOPENURLW out of WORKREQUEST.

11 years agowininet: Moved WORKREQ_HTTPSENDREQUESTW out of WORKREQUEST.
Jacek Caban [Mon, 28 Jan 2013 10:23:19 +0000 (11:23 +0100)] 
wininet: Moved WORKREQ_HTTPSENDREQUESTW out of WORKREQUEST.

11 years agowininet: Moved WORKREQUEST allocation to INTERNET_AsyncCall callers.
Jacek Caban [Mon, 28 Jan 2013 10:23:03 +0000 (11:23 +0100)] 
wininet: Moved WORKREQUEST allocation to INTERNET_AsyncCall callers.

11 years agowined3d: Get rid of CheckBumpMapCapability().
Henri Verbeet [Mon, 28 Jan 2013 10:15:40 +0000 (11:15 +0100)] 
wined3d: Get rid of CheckBumpMapCapability().

The color fixup being supported is implied by WINED3DFMT_FLAG_TEXTURE.

11 years agowined3d: Get rid of CheckTextureCapability().
Henri Verbeet [Mon, 28 Jan 2013 10:15:39 +0000 (11:15 +0100)] 
wined3d: Get rid of CheckTextureCapability().

11 years agowined3d: Introduce a format flag for texturing.
Henri Verbeet [Mon, 28 Jan 2013 10:15:38 +0000 (11:15 +0100)] 
wined3d: Introduce a format flag for texturing.

11 years agod3drm: Avoid LPD3DRMMATERIALOVERRIDE.
Henri Verbeet [Mon, 28 Jan 2013 10:15:37 +0000 (11:15 +0100)] 
d3drm: Avoid LPD3DRMMATERIALOVERRIDE.

11 years agod3drm: Avoid LPD3DRMIMAGE.
Henri Verbeet [Mon, 28 Jan 2013 10:15:36 +0000 (11:15 +0100)] 
d3drm: Avoid LPD3DRMIMAGE.

11 years agodwrite: Avoid triggering an exception on DLL_PROCESS_DETACH.
Dmitry Timoshkov [Mon, 28 Jan 2013 06:37:36 +0000 (14:37 +0800)] 
dwrite: Avoid triggering an exception on DLL_PROCESS_DETACH.

11 years agocomctl32/listview: Implement dragging with right button with a message loop.
Nikolay Sivov [Mon, 28 Jan 2013 03:56:01 +0000 (07:56 +0400)] 
comctl32/listview: Implement dragging with right button with a message loop.

11 years agoxmllite: Fail to set input for external IXmlReaderInput.
Nikolay Sivov [Sun, 27 Jan 2013 07:54:58 +0000 (11:54 +0400)] 
xmllite: Fail to set input for external IXmlReaderInput.

11 years agoxmllite: Handle E_PENDING from stream for comment nodes.
Nikolay Sivov [Sun, 27 Jan 2013 07:17:27 +0000 (11:17 +0400)] 
xmllite: Handle E_PENDING from stream for comment nodes.

11 years agowinemac: Implement an APP_DEACTIVATED event.
Ken Thomases [Sun, 27 Jan 2013 22:19:56 +0000 (16:19 -0600)] 
winemac: Implement an APP_DEACTIVATED event.

11 years agowinemac: Implement a WINDOW_LOST_FOCUS event.
Ken Thomases [Sun, 27 Jan 2013 22:19:53 +0000 (16:19 -0600)] 
winemac: Implement a WINDOW_LOST_FOCUS event.

11 years agowinemac: Implement a WINDOW_GOT_FOCUS event for when Cocoa tries to focus a window.
Ken Thomases [Sun, 27 Jan 2013 22:19:48 +0000 (16:19 -0600)] 
winemac: Implement a WINDOW_GOT_FOCUS event for when Cocoa tries to focus a window.

11 years agowinemac: Maintain a list of which windows have been "key" (focused) recently.
Ken Thomases [Sun, 27 Jan 2013 22:19:45 +0000 (16:19 -0600)] 
winemac: Maintain a list of which windows have been "key" (focused) recently.

11 years agowinemac: Take control over when a window can become focused away from Cocoa.
Ken Thomases [Sun, 27 Jan 2013 22:19:41 +0000 (16:19 -0600)] 
winemac: Take control over when a window can become focused away from Cocoa.

11 years agowinemac: Implement a MOUSE_BUTTON event for mouse clicks.
Ken Thomases [Sun, 27 Jan 2013 22:19:37 +0000 (16:19 -0600)] 
winemac: Implement a MOUSE_BUTTON event for mouse clicks.

11 years agowinemac: Add infrastructure to convert from Cocoa event time to Wine tick count.
Ken Thomases [Sun, 27 Jan 2013 22:19:33 +0000 (16:19 -0600)] 
winemac: Add infrastructure to convert from Cocoa event time to Wine tick count.

11 years agowinemac: Implement WINDOW_FRAME_CHANGED event to tell Wine when window is moved or...
Ken Thomases [Sun, 27 Jan 2013 22:19:29 +0000 (16:19 -0600)] 
winemac: Implement WINDOW_FRAME_CHANGED event to tell Wine when window is moved or resized.

11 years agowined3d: Use assignment instead of memcpy to copy structs.
Michael Stefaniuc [Sun, 27 Jan 2013 21:57:20 +0000 (22:57 +0100)] 
wined3d: Use assignment instead of memcpy to copy structs.

11 years agod3dcompiler_43: Use assignment instead of memcpy to copy structs.
Michael Stefaniuc [Sun, 27 Jan 2013 21:55:33 +0000 (22:55 +0100)] 
d3dcompiler_43: Use assignment instead of memcpy to copy structs.

11 years agojscript: Update buffer size in do_regexp_match_next.
Piotr Caban [Sat, 26 Jan 2013 14:51:24 +0000 (15:51 +0100)] 
jscript: Update buffer size in do_regexp_match_next.

11 years agomsvcp71: Fixed basic_filebuf class layout.
Piotr Caban [Sat, 26 Jan 2013 13:38:03 +0000 (14:38 +0100)] 
msvcp71: Fixed basic_filebuf class layout.

11 years agowbemprox: Implement IWbemQualifierSet::Get.
Hans Leidekker [Fri, 25 Jan 2013 16:34:00 +0000 (17:34 +0100)] 
wbemprox: Implement IWbemQualifierSet::Get.

11 years agowbemprox: Check the result count instead of the result pointer in get_propval.
Hans Leidekker [Fri, 25 Jan 2013 16:33:24 +0000 (17:33 +0100)] 
wbemprox: Check the result count instead of the result pointer in get_propval.

11 years agojscript: Fixed a leak in regexp_match function.
Piotr Caban [Fri, 25 Jan 2013 15:48:07 +0000 (16:48 +0100)] 
jscript: Fixed a leak in regexp_match function.

11 years agojscript: Fixed a leak in do_regexp_match_next function.
Piotr Caban [Fri, 25 Jan 2013 15:47:57 +0000 (16:47 +0100)] 
jscript: Fixed a leak in do_regexp_match_next function.

11 years agousp10: Do not apply SSA_LINK to right to left text.
Aric Stewart [Fri, 25 Jan 2013 15:12:05 +0000 (09:12 -0600)] 
usp10: Do not apply SSA_LINK to right to left text.

11 years agomsvcrt: Fixed _Gettnames test on Win8.
Piotr Caban [Fri, 25 Jan 2013 14:07:37 +0000 (15:07 +0100)] 
msvcrt: Fixed _Gettnames test on Win8.

11 years agomsvcrt: Fixed setlocale tests on Win8.
Piotr Caban [Fri, 25 Jan 2013 14:07:16 +0000 (15:07 +0100)] 
msvcrt: Fixed setlocale tests on Win8.

11 years agoriched20: Simplify adding the undo items when joining paragraphs.
Huw Davies [Fri, 25 Jan 2013 13:56:29 +0000 (13:56 +0000)] 
riched20: Simplify adding the undo items when joining paragraphs.

11 years agoatl100: Added AtlGetPerUserRegistration stub implementation.
Jacek Caban [Fri, 25 Jan 2013 12:12:02 +0000 (13:12 +0100)] 
atl100: Added AtlGetPerUserRegistration stub implementation.

11 years agomsvcrt: Added N flag support to fopen.
Piotr Caban [Fri, 25 Jan 2013 10:39:05 +0000 (11:39 +0100)] 
msvcrt: Added N flag support to fopen.

11 years agomsvcrt: Ignore S and R flags in fopen.
Piotr Caban [Fri, 25 Jan 2013 10:38:48 +0000 (11:38 +0100)] 
msvcrt: Ignore S and R flags in fopen.

11 years agod3dcompiler.h: Added D3DCOMPILER_DLL macro.
Jacek Caban [Fri, 25 Jan 2013 10:25:03 +0000 (11:25 +0100)] 
d3dcompiler.h: Added D3DCOMPILER_DLL macro.

11 years agod3d9/tests: Add simple DrawRectPatch tests.
Stefan Dösinger [Tue, 22 Jan 2013 22:01:31 +0000 (23:01 +0100)] 
d3d9/tests: Add simple DrawRectPatch tests.

11 years agod3d8/tests: Add simple DrawRectPatch tests.
Stefan Dösinger [Tue, 22 Jan 2013 22:01:31 +0000 (23:01 +0100)] 
d3d8/tests: Add simple DrawRectPatch tests.

11 years agowined3d: Remove draw_primitive_strided.
Stefan Dösinger [Wed, 23 Jan 2013 23:39:13 +0000 (00:39 +0100)] 
wined3d: Remove draw_primitive_strided.

11 years agod3d: Remove high level patch support.
Stefan Dösinger [Wed, 23 Jan 2013 23:39:12 +0000 (00:39 +0100)] 
d3d: Remove high level patch support.

No Windows driver ever exposed this, and no game uses this. The
only application that used this feature is a DirectX 8 SDK sample.

11 years agoddraw: Implement DrawIndexedPrimitiveStrided with regular draws.
Stefan Dösinger [Wed, 23 Jan 2013 23:39:11 +0000 (00:39 +0100)] 
ddraw: Implement DrawIndexedPrimitiveStrided with regular draws.

11 years agoddraw: Implement DrawPrimitiveStrided with regular draws.
Stefan Dösinger [Wed, 23 Jan 2013 23:39:10 +0000 (00:39 +0100)] 
ddraw: Implement DrawPrimitiveStrided with regular draws.

11 years agomsvcp: Sync implementations.
Piotr Caban [Fri, 25 Jan 2013 09:38:07 +0000 (10:38 +0100)] 
msvcp: Sync implementations.

11 years agomsvcp90: Added std::sqrt(complex) tests.
Piotr Caban [Fri, 25 Jan 2013 09:37:53 +0000 (10:37 +0100)] 
msvcp90: Added std::sqrt(complex) tests.

11 years agomsvcp90: Added std::pow(complex) and std::sqrt(complex) implementation.
Piotr Caban [Fri, 25 Jan 2013 09:37:39 +0000 (10:37 +0100)] 
msvcp90: Added std::pow(complex) and std::sqrt(complex) implementation.

11 years agomsvcp90: Added std::norm(complex) and std::polar(complex) implementation.
Piotr Caban [Fri, 25 Jan 2013 09:37:24 +0000 (10:37 +0100)] 
msvcp90: Added std::norm(complex) and std::polar(complex) implementation.

11 years agomsvcp90: Added std::log10(complex) tests.
Piotr Caban [Fri, 25 Jan 2013 09:37:10 +0000 (10:37 +0100)] 
msvcp90: Added std::log10(complex) tests.

11 years agomsvcp90: Added std::log(complex) and std::exp(complex) implementation.
Piotr Caban [Fri, 25 Jan 2013 09:36:51 +0000 (10:36 +0100)] 
msvcp90: Added std::log(complex) and std::exp(complex) implementation.

11 years agowined3d: Get rid of a superfluous texture copy in check_fbo_compat().
Henri Verbeet [Fri, 25 Jan 2013 09:57:20 +0000 (10:57 +0100)] 
wined3d: Get rid of a superfluous texture copy in check_fbo_compat().

11 years agowined3d: Replace "VertexShaderMode" and "PixelShaderMode" with shader model limits.
Henri Verbeet [Fri, 25 Jan 2013 09:57:19 +0000 (10:57 +0100)] 
wined3d: Replace "VertexShaderMode" and "PixelShaderMode" with shader model limits.

11 years agowined3d: Support all fixups in shader_none_color_fixup_supported().
Henri Verbeet [Fri, 25 Jan 2013 09:57:18 +0000 (10:57 +0100)] 
wined3d: Support all fixups in shader_none_color_fixup_supported().

11 years agod3drm: Avoid LPD3DRMRENDERQUALITY.
Henri Verbeet [Fri, 25 Jan 2013 09:57:17 +0000 (10:57 +0100)] 
d3drm: Avoid LPD3DRMRENDERQUALITY.

11 years agod3drm: Avoid LPD3DRMBOX.
Henri Verbeet [Fri, 25 Jan 2013 09:57:16 +0000 (10:57 +0100)] 
d3drm: Avoid LPD3DRMBOX.

11 years agomscoree: Use assignment instead of memcpy to copy a struct.
Michael Stefaniuc [Fri, 25 Jan 2013 09:02:38 +0000 (10:02 +0100)] 
mscoree: Use assignment instead of memcpy to copy a struct.

11 years agogphoto2.ds: Avoid signed-unsigned integer comparisons.
Andrew Talbot [Thu, 24 Jan 2013 22:10:35 +0000 (22:10 +0000)] 
gphoto2.ds: Avoid signed-unsigned integer comparisons.

11 years agohhctrl.ocx: Avoid signed-unsigned integer comparisons.
Andrew Talbot [Thu, 24 Jan 2013 22:10:41 +0000 (22:10 +0000)] 
hhctrl.ocx: Avoid signed-unsigned integer comparisons.

11 years agousp10: Add ShapeCharGlyphProp and ContextualShape for Control characters.
Aric Stewart [Thu, 24 Jan 2013 19:42:26 +0000 (13:42 -0600)] 
usp10: Add ShapeCharGlyphProp and ContextualShape for Control characters.

11 years agousp10: Add ShapeCharGlyphProp_Latin to properly handle zero width character propertie...
Aric Stewart [Thu, 24 Jan 2013 19:42:18 +0000 (13:42 -0600)] 
usp10: Add ShapeCharGlyphProp_Latin to properly handle zero width character properties for Latin.

11 years agoieframe/tests: Don't convert to long path name until the file exists.
Andrew Eikum [Thu, 24 Jan 2013 16:35:00 +0000 (10:35 -0600)] 
ieframe/tests: Don't convert to long path name until the file exists.

11 years agoieframe/tests: Fixed a race in tests.
Jacek Caban [Thu, 24 Jan 2013 12:28:09 +0000 (13:28 +0100)] 
ieframe/tests: Fixed a race in tests.

11 years agouser32: Init standard scrollbars during WM_NCCREATE.
Sergey Guralnik [Wed, 23 Jan 2013 06:28:36 +0000 (08:28 +0200)] 
user32: Init standard scrollbars during WM_NCCREATE.

11 years agoinclude: Flesh out d3d11.idl.
Austin English [Wed, 23 Jan 2013 02:59:18 +0000 (18:59 -0800)] 
include: Flesh out d3d11.idl.

11 years agoadvapi32/tests: Fix another test failure.
Alexandre Julliard [Thu, 24 Jan 2013 16:00:06 +0000 (17:00 +0100)] 
advapi32/tests: Fix another test failure.

11 years agoadvapi32: Fix intermittent 64-bit test failure.
Erich Hoover [Fri, 18 Jan 2013 18:00:58 +0000 (11:00 -0700)] 
advapi32: Fix intermittent 64-bit test failure.

11 years agoitss: Use assignment instead of memcpy to copy a struct.
Michael Stefaniuc [Thu, 24 Jan 2013 14:30:53 +0000 (15:30 +0100)] 
itss: Use assignment instead of memcpy to copy a struct.